Re: [RFC PATCH v12 0/5] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-12-26 Thread Rafael J. Wysocki
On Tuesday, December 26, 2017 3:36:41 AM CET Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v13: > Fix compiler error reported by kbuild test robot

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

2017-12-26 Thread Bjorn Andersson
On Tue 19 Dec 09:04 PST 2017, Colin King wrote: > From: Colin Ian King > > msg_body.min_ch_time is being assigned twice; remove the redundant > first assignment. > > Detected by CoverityScan, CID#1463042 ("Unused Value") > Happy to see Coverity working for us :)

Re: [PATCH] wl1251: check return from call to wl1251_acx_arp_ip_filter

2017-12-26 Thread Pavel Machek
On Tue 2017-12-26 17:33:18, Colin King wrote: > From: Colin Ian King > > Currently the less than zero error check on ret is incorrect > as it is checking a far earlier ret assignment rather than the > return from the call to wl1251_acx_arp_ip_filter. Fix this by >

[PATCH] wl1251: check return from call to wl1251_acx_arp_ip_filter

2017-12-26 Thread Colin King
From: Colin Ian King Currently the less than zero error check on ret is incorrect as it is checking a far earlier ret assignment rather than the return from the call to wl1251_acx_arp_ip_filter. Fix this by adding in the missing assginment. Detected by CoverityScan,

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2017-12-26 Thread Enrico Mioso
Ok, observing a stall. Unfortunately, it still happens. Ufh... dmesg: may I do something else? Linux version 4.9.70 (mrkiko@gatosaldo) (gcc version 5.5.0 (OpenWrt GCC 5.5.0 r5616-67c1c145f0) ) #0 Sun Dec 24 16:06:16 2017 SoC Type: Ralink RT3350 id:1 rev:2 bootconsole [early0] enabled CPU0

Re: [PATCH 2/2] rt2x00: do not pause queue unconditionally on error path

2017-12-26 Thread Enrico Mioso
On a WL-330N3G device, these patches seems to make the situation much better. In other words, I wasn't able to reproduce the stall on this chipset. On MT7620 a stall was never seen directly, but tests with these patches revealed no stall. So I think it's good to have these merged. Tested-by:

Re: [PATCH 1/2] rt2x00: pause almost full queue early

2017-12-26 Thread Enrico Mioso
Oops, sorry, wrong tag Tested-by: Enrico Mioso On Tue, 19 Dec 2017, Stanislaw Gruszka wrote: Date: Tue, 19 Dec 2017 12:33:55 From: Stanislaw Gruszka To: linux-wireless@vger.kernel.org Cc: Helmut Schaa , Enrico Mioso

Re: [PATCH 1/2] rt2x00: pause almost full queue early

2017-12-26 Thread Enrico Mioso
On a WL-330N3G device, these patches seems to make the situation much better. In other words, I wasn't able to reproduce the stall on this chipset. On MT7620 a stall was never seen directly, but tests with these patches revealed no stall. So I think it's good to have these merged. Tested-by: