Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds wrote: > Should the array access in entry_SYSCALL_64_fastpath be made to use > the masking approach? That one has a bounds check for an inline constant. cmpq$__NR_syscall_max, %rax so should be safe. The

Re: [PATCH v2 15/19] carl9170: prevent bounds-check bypass via speculative execution

On Fri, Jan 12, 2018 at 12:01 PM, Christian Lamparter wrote: > On Friday, January 12, 2018 7:39:50 PM CET Dan Williams wrote: >> On Fri, Jan 12, 2018 at 6:42 AM, Christian Lamparter >> wrote: >> > On Friday, January 12, 2018 1:47:46 AM CET Dan Williams

[PATCH 1/2] Revert "mwifiex: cancel pcie/sdio work in remove/shutdown handler"

This reverts commit b713bbf1471b56b572ce26bd02b81a85c2b007f4. The "fix" in question does not actually fix all related problems, and it also introduces new deadlock possibilities. Since commit b014e96d1abb ("PCI: Protect pci_error_handlers->reset_notify() usage with device_lock()"), the race in

[PATCH 2/2] mwifiex: resolve reset vs. remove()/shutdown() deadlocks

Commit b014e96d1abb ("PCI: Protect pci_error_handlers->reset_notify() usage with device_lock()") resolves races between driver reset and removal, but it introduces some new deadlock problems. If we see a timeout while we've already started suspending, removing, or shutting down the driver, we

Re: brcmfmac4329-sdio firmware load failed.

Thank you Arend. I updated to master again, v4.15-rc7+, and applied your patch. All log snips are grabbed with dmesg|grep -E 'mmc0|brcm', as the sdio device is on mmc0. Without patch [1], for reference... [0.00] Kernel command line: console=tty0 selinux=0 video=1280x800

Re: [PATCH v2 15/19] carl9170: prevent bounds-check bypass via speculative execution

On Friday, January 12, 2018 7:39:50 PM CET Dan Williams wrote: > On Fri, Jan 12, 2018 at 6:42 AM, Christian Lamparter > wrote: > > On Friday, January 12, 2018 1:47:46 AM CET Dan Williams wrote: > >> Static analysis reports that 'queue' may be a user controlled value that > >>

Re: [PATCH v2 01/10] rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS

On 01/11/2018 01:09 AM, pks...@realtek.com wrote: From: Ping-Ke Shih Enter/leavel IPS and LPS are large critical section, and they can't use sleep function because running in atomic-context, which own a spin_lock. In commit ba9f93f82aba ("rtlwifi: Fix enter/exit

Re: Re: Re: [PATCH] mwifiex: cancel pcie/sdio work in remove/shutdown handler

On Thu, Jan 11, 2018 at 06:25:09PM -0800, Brian Norris wrote: > Anyway, I'll do my own testing and then submit my patch properly. OK, so I definitely confirmed: if your patch does anything, it introduces a new deadlock possibility. Just trigger a Wifi timeout or reset from within remove(), and

Re: [PATCH v2 15/19] carl9170: prevent bounds-check bypass via speculative execution

On Fri, Jan 12, 2018 at 6:42 AM, Christian Lamparter wrote: > On Friday, January 12, 2018 1:47:46 AM CET Dan Williams wrote: >> Static analysis reports that 'queue' may be a user controlled value that >> is used as a data dependency to read from the 'ar9170_qmap' array. In >>

[PATCH] ath10k: remove redundant -ve check against u32 integer size

From: Colin Ian King Variable section_table.size is a u32 and so cannot be less than zero, hence the less than zero check is redundant and can be removed. Detected by CoverityScan, CID#1463855 ("Unsigned compared against 0") Signed-off-by: Colin Ian King

Re: [PATCH v2 15/19] carl9170: prevent bounds-check bypass via speculative execution

On Friday, January 12, 2018 1:47:46 AM CET Dan Williams wrote: > Static analysis reports that 'queue' may be a user controlled value that > is used as a data dependency to read from the 'ar9170_qmap' array. In > order to avoid potential leaks of kernel memory values, block > speculative execution

[PATCH] ssb: Prevent build of PCI host features in module

Attempting to build ssb.ko with CONFIG_SSB_DRIVER_PCICORE=y results in a build error due to use of symbols not exported from vmlinux: ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined! ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined! make[1]: ***

[PATCH] bcma: Prevent build of PCI host features in module

Attempting to build bcma.ko with BCMA_DRIVER_PCI_HOSTMODE=y results in a build error due to use of symbols not exported from vmlinux: ERROR: "pcibios_enable_device" [drivers/bcma/bcma.ko] undefined! ERROR: "register_pci_controller" [drivers/bcma/bcma.ko] undefined! make[1]: ***

Re: [PATCH 0/5] iwlwifi: updates intended for v4.16 2017-12-23

+ emmanuel Luca Coelho writes: > From: Luca Coelho > > Hi, > > Here's the fourth and probably last batch of patches intended for > 4.16. Nothing major, just continued development, some cleanups and > small fixes here and there. > > * Fix a UBSAN

Re: [PATCH 02/10] qtnfmac: pass complete channel data between driver and firmware

Sergey Matyukevich writes: >> > +/** >> > * struct qlink_chandef - qlink channel definition >> > * >> > + * @chan: primary channel definition >> > * @center_freq1: center frequency of first segment >> > * @center_freq2: center frequency of second

Re: [PATCH v2] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

Arend van Spriel writes: > On 1/12/2018 8:44 AM, Wright Feng wrote: >> For legacy chips without CLM blob files, kernel with user helper function >> returns -EAGAIN when we request_firmware() for blob file. _Why_ is the -EAGAIN returned? Is it because of user space,

Re: [PATCH v2] brcmfmac: fix CLM load error for legacy chips when user helper is enabled

On 1/12/2018 8:44 AM, Wright Feng wrote: For legacy chips without CLM blob files, kernel with user helper function returns -EAGAIN when we request_firmware() for blob file. In this case, brcmf_bus_started gets error and failed to bring up legacy chips. Because of that, we should continue with

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

Do you think that the appropriate patches could be copied to the appropriate people please? On Thu, Jan 11, 2018 at 04:46:24PM -0800, Dan Williams wrote: > Changes since v1 [1]: > * fixup the ifence definition to use alternative_2 per recent AMD > changes in tip/x86/pti (Tom) > > * drop

[PATCH][next] ath10k: fix spelling mistake: "addrress" -> "address"

From: Colin Ian King Trivial fix to spelling mistake in warning message text. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

Hi Christophe ， On 2018/1/4 16:05, Christophe LEROY wrote: > > > Le 25/12/2017 à 02:34, Yisheng Xie a écrit : >> >> >> On 2017/12/24 17:05, christophe leroy wrote: >>> >>> >>> Le 23/12/2017 à 14:48, Greg KH a écrit : On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote: > Hi