Re: [PATCH] cfg80211/nl80211: add DFS offload flag

2018-02-21 Thread Kalle Valo
Arend van Spriel writes: > Friendly advice: you may want to avoid using this footer in emails on > the kernel.org mailing lists. Indeed. Most of the time I don't even reply to mails with such disclaimers and patches containing that will be automatically dropped.

Re: [PATCH 3/4] staging: wilc1000: refactor wilc_spi_clear_int_ext() by using GENMASK macro

2018-02-21 Thread Dan Carpenter
Please check all these again, right? I've glanced at this and it seems wrong, but I'm too stupid to sure immediately and too lazy to be thourough. regards, dan caprenter

[PATCHv3 1/3] cfg80211: enable setting cqm rssi config for AP mode

2018-02-21 Thread Tamizh chelvam
From: Tamizh chelvam This patch extend cqm rssi config and notifier feature to AP mode by introducing NL80211_EXT_FEATURE_AP_STA_CQM_RSSI_CONFIG ext feature bit. And this patch introduces NL80211_MCGRP_AP_STA_CQM for notifying station's low/high rssi event to userspace

[PATCHv3 2/3] mac80211: enable setting cqm rssi config for AP mode

2018-02-21 Thread Tamizh chelvam
From: Pradeep Kumar Chitrapu Enable connection monitoring for AP mode which makes it possible to track signal strength of connected stations. Co-Developed-by: Tamizh Chelvam Signed-off-by: Tamizh chelvam Signed-off-by:

[PATCHv3 0/3] cfg80211/mac80211: cqm rssi config for AP mode

2018-02-21 Thread Tamizh chelvam
From: Tamizh chelvam Currently station mode has the support of rssi based cqm. This patchsets extended the support for AP mode as well. Already netlink accepts mac address in cqm notification event. We can use that to pass mac address of the station to specify its rssi

[PATCHv3 3/3] mac80211: implement cqm rssi check using rx data signal

2018-02-21 Thread Tamizh chelvam
From: Tamizh chelvam Triggers cfg80211_ap_sta_cqm_rssi_notify with the corresponding event when station signal goes lower than the configured rssi threshold. And notify back to user space once the station signal becomes greater than the configured value. It uses rx data

Re: [PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

2018-02-21 Thread Dan Carpenter
On Wed, Feb 21, 2018 at 09:42:10PM +0530, Ajay Singh wrote: > Use existing macro GENMASK to get the bitmask value. Moved the code to > get the bitmask value outside the loop, as its only required one time. > > Signed-off-by: Ajay Singh > --- >

Re: [PATCH 1/4] staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int()

2018-02-21 Thread Dan Carpenter
On Wed, Feb 21, 2018 at 09:42:09PM +0530, Ajay Singh wrote: > Modified wilc_spi_read_int() by removing unnecessary use of "happened" > variable. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_spi.c | 8 +++- > 1 file changed, 3 insertions(+),

Re: [PATCH] ath10k: debugfs support to get final TPC stats for 10.4 variants

2018-02-21 Thread kbuild test robot
Hi Maharaja, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ath6kl/ath-next] [also build test WARNING on v4.16-rc2 next-20180221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH 2/3] mwifiex: support sysfs initiated device coredump

2018-02-21 Thread Brian Norris
On Wed, Feb 21, 2018 at 11:50:19AM +0100, Arend van Spriel wrote: > Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") > it is possible to initiate a device coredump from user-space. This > patch adds support for it adding the .coredump() driver callback. > As there is no longer

Re: [PATCH] cfg80211/nl80211: add DFS offload flag

2018-02-21 Thread Arend van Spriel
On 2/21/2018 12:25 PM, Dmitrii Lebed wrote: On 21.02.2018 14:03, Arend van Spriel wrote: On 2/21/2018 11:56 AM, Sergey Matyukevich wrote: From: Dmitry Lebed Add wiphy flag to indicate that HW does all DFS actions by itself. User-space functionality already implemented

information required

2018-02-21 Thread info
Thanks for your last email response to me. The information required should include the following-: Your full names Your address Telephone number Your private email Occupation Age This is to enable my further discussion with you in confidence. Best regards and wishes to you. Mohammad Amir Khadov

Re: [PATCH 0/3] Export TXQ parameters and statistics via nl80211

2018-02-21 Thread Arend van Spriel
On 2/21/2018 12:00 PM, Toke Høiland-Jørgensen wrote: Arend van Spriel writes: On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote: This series adds TXQ parameters and statistics that were previously only available through debugfs to the nl80211 userspace

Marvell STA getting hanged during BA neg

2018-02-21 Thread Neelansh Mittal
Hello, Observing that Marvell STA is getting hanged after association, during ADDBA req/response exchange. Logs Feb 19 20:53:23 debian kernel: wlan_interrupt: sdio_ireg = 0x1 Feb 19 20:53:23 debian kernel: UPLD: rd_bitmap=0x0001 Feb 19 20:53:23 debian kernel: mlan0:

Re: [PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext()

2018-02-21 Thread Claudiu Beznea
Hi Ajay, Sure, I will take a look. Thank you, Claudiu On 21.02.2018 18:25, Ajay Singh wrote: > Hi Claudiu, > > On Mon, 19 Feb 2018 15:33:09 +0200 > Claudiu Beznea wrote: > >> Since you re-factor this, as I suggested in patch: >> "[PATCH 6/6] staging: wilc1000:

Re: [PATCH 02/12] staging: wilc1000: fix too many leading tabs warning in sdio_clear_int_ext()

2018-02-21 Thread Ajay Singh
Hi Claudiu, On Mon, 19 Feb 2018 15:33:09 +0200 Claudiu Beznea wrote: > Since you re-factor this, as I suggested in patch: > "[PATCH 6/6] staging: wilc1000: fix line over 80 chars in > wilc_spi_clear_int_ext()" form your previous series: > "fix line over 80 char &

[PATCH 3/4] staging: wilc1000: refactor wilc_spi_clear_int_ext() by using GENMASK macro

2018-02-21 Thread Ajay Singh
Use available macro GENMASK to get the bitmask value of specific value. Simplified the logic by adding expected_irqs & unexpected_irqs to check the interrupt bits. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 46

[PATCH 4/4] staging: wilc1000: refactor sdio_clear_int_ext() by using GENMASK macro

2018-02-21 Thread Ajay Singh
Use GENMASK macro in sdio_clear_int_ext function to get the required bitmask value. Simplified the logic by making use of GENMASK macro. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_sdio.c | 74 +++- 1 file changed, 31

[PATCH 0/4] staging: wilc1000: modify functions by making use of GENMASK macro

2018-02-21 Thread Ajay Singh
This patch series contains changes to refactor functions by making use of GENMASK macro and also removed unnecessary variable from wilc_spi_read_int(). Ajay Singh (4): staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int() staging: wilc1000: modified

[PATCH 2/4] staging: wilc1000: modified wilc_spi_read_int() by using GENMASK macro

2018-02-21 Thread Ajay Singh
Use existing macro GENMASK to get the bitmask value. Moved the code to get the bitmask value outside the loop, as its only required one time. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH 1/4] staging: wilc1000: remove use of 'happened' variable in wilc_spi_read_int()

2018-02-21 Thread Ajay Singh
Modified wilc_spi_read_int() by removing unnecessary use of "happened" variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_spi.c

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-21 Thread Jeremy Cline
On 02/20/2018 04:34 PM, Carlo Caione wrote: > On Tue, Feb 20, 2018 at 9:18 PM, Jeremy Cline wrote: > >> Great, thanks for all the info! I'll definitely keep you CC'ed on my >> progress. I'm still very new to kernel development so I expect it'll >> take me quite a while, but I

Re: [PATCHv2 1/3] cfg80211: enable setting cqm rssi config for AP mode

2018-02-21 Thread Tamizh chelvam
On 2018-02-19 18:44, Johannes Berg wrote: On Tue, 2018-02-13 at 14:50 +0530, Tamizh chelvam wrote: @@ -9903,8 +9906,10 @@ static int nl80211_set_cqm_rssi(struct genl_info *info, prev = thresholds[i]; } - if (wdev->iftype != NL80211_IFTYPE_STATION && -

[PATCH] ath10k: debugfs support to get final TPC stats for 10.4 variants

2018-02-21 Thread mkenna
From: Maharaja Kennadyrajan Export the final Transmit Power Control (TPC) value, which is the minimum of control power and existing TPC value to user space via a new debugfs file "tpc_stats_final" to help with debugging. It works with the new wmi cmd and event introduced

Re: [PATCH] cfg80211/nl80211: add DFS offload flag

2018-02-21 Thread Dmitrii Lebed
On 21.02.2018 14:03, Arend van Spriel wrote: On 2/21/2018 11:56 AM, Sergey Matyukevich wrote: From: Dmitry Lebed Add wiphy flag to indicate that HW does all DFS actions by itself. User-space functionality already implemented in hostapd using vendor-specific (QCA) OUI to

Re: brcmfmac signal/interference issues

2018-02-21 Thread Arend van Spriel
On 2/21/2018 10:39 AM, Daniel Drake wrote: Hi Arend, On Wed, Feb 21, 2018 at 12:07 PM, Arend van Spriel wrote: On 2/21/2018 9:14 AM, Daniel Drake wrote: Hi, We're working with the Weibu F3C MiniPC which includes BCM43455 SDIO wifi chip 0x004345(17221) rev

Re: [PATCH] cfg80211/nl80211: add DFS offload flag

2018-02-21 Thread Arend van Spriel
On 2/21/2018 11:56 AM, Sergey Matyukevich wrote: From: Dmitry Lebed Add wiphy flag to indicate that HW does all DFS actions by itself. User-space functionality already implemented in hostapd using vendor-specific (QCA) OUI to advertise HW support. Need to introduce

Re: [PATCH 0/3] Export TXQ parameters and statistics via nl80211

2018-02-21 Thread Toke Høiland-Jørgensen
Arend van Spriel writes: > On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote: >> This series adds TXQ parameters and statistics that were previously only >> available through debugfs to the nl80211 userspace interface and the >> cfg80211 kernel interface. Patches

[PATCH] cfg80211/nl80211: add DFS offload flag

2018-02-21 Thread Sergey Matyukevich
From: Dmitry Lebed Add wiphy flag to indicate that HW does all DFS actions by itself. User-space functionality already implemented in hostapd using vendor-specific (QCA) OUI to advertise HW support. Need to introduce generic flag to inform about DFS offload support. For

[PATCH 2/3] mwifiex: support sysfs initiated device coredump

2018-02-21 Thread Arend van Spriel
Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it adding the .coredump() driver callback. As there is no longer a need to initiate it through debugfs remove that code. Signed-off-by:

[PATCH 3/3] btmrvl: support sysfs initiated firmware coredump

2018-02-21 Thread Arend van Spriel
Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is possible to initiate a device coredump from user-space. This patch adds support for it in btmrvl_sdio adding the .coredump() driver callback. This makes dump through debugfs obsolete so removing it. Signed-off-by: Arend

[PATCH 0/3] drivers: support for sysfs initiated coredump

2018-02-21 Thread Arend van Spriel
This series is intended for 4.17 adding support for sysfs initiated coredump. This uses new functionality that was added in drivers base. Device drivers can now implement a .coredump() callback upon which a sysfs entry is created when the device is bound to the driver. From user-space a device

[PATCH 1/3] brcmfmac: add support for sysfs initiated coredump

2018-02-21 Thread Arend van Spriel
The driver already supports device coredump initiated by firmware event. Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") it is also possible to initiate it from user-space through sysfs. This patch adds support for SDIO and PCIe devices. Reviewed-by: Hante Meuleman

Re: brcmfmac signal/interference issues

2018-02-21 Thread Daniel Drake
Hi Arend, On Wed, Feb 21, 2018 at 12:07 PM, Arend van Spriel wrote: > > On 2/21/2018 9:14 AM, Daniel Drake wrote: >> >> Hi, >> >> We're working with the Weibu F3C MiniPC which includes BCM43455 SDIO >> wifi chip 0x004345(17221) rev 0x06 (AP6255 module). >> >> We

Re: brcmfmac signal/interference issues

2018-02-21 Thread Arend van Spriel
On 2/21/2018 9:14 AM, Daniel Drake wrote: Hi, We're working with the Weibu F3C MiniPC which includes BCM43455 SDIO wifi chip 0x004345(17221) rev 0x06 (AP6255 module). We are seeing a strange issue where usually within an hour of usage, the wifi connection becomes so unstable and lossy that

Re: [PATCH 0/3] Export TXQ parameters and statistics via nl80211

2018-02-21 Thread Arend van Spriel
On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote: This series adds TXQ parameters and statistics that were previously only available through debugfs to the nl80211 userspace interface and the cfg80211 kernel interface. Patches for iw to print the statistics and change the settings are

Re: [PATCH] brcmfmac: reject too long PSK

2018-02-21 Thread Arend van Spriel
On 2/19/2018 1:30 PM, Johannes Berg wrote: From: Johannes Berg nl80211 already allows specifying 48 bytes, but brcmfmac only supports 32. Reject keys that are too long. Hah. Recent discussion about the key length made you look ;-) Thanks! Acked-by: Arend van Spriel

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-21 Thread Marcel Holtmann
Hi Carlo, >> Great, thanks for all the info! I'll definitely keep you CC'ed on my >> progress. I'm still very new to kernel development so I expect it'll >> take me quite a while, but I do have a fair bit of time to devote to >> this. > > Welcome to this crazy world ;) > Keep me on CC also, I

Re: [RFC PATCH 0/2] net: rfkill: gpio: Fix and support SerDev

2018-02-21 Thread Marcel Holtmann
Hi Martin, Is this for devices with a RTL8723BS chip? If so then they still will not work after this since there also no longer is a /dev/ttyS4 created for the UART for the bluetooth, instead you probably want:

brcmfmac signal/interference issues

2018-02-21 Thread Daniel Drake
Hi, We're working with the Weibu F3C MiniPC which includes BCM43455 SDIO wifi chip 0x004345(17221) rev 0x06 (AP6255 module). We are seeing a strange issue where usually within an hour of usage, the wifi connection becomes so unstable and lossy that it is unusable. While investigating this my