Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

taken a look at the specific code, and from my point of view the code that sets up the LED (including callback) is so trivial that it's simply not worth dealing with adding the leds-gpio driver to the mix. It adds extra complexity and an extra dependency for no reason at all. There's no extra

Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

Hi Felix, On Fri, Mar 9, 2018 at 2:46 AM, Felix Fietkau wrote: > On 2018-03-08 15:05, Pavel Machek wrote: >> On Thu 2018-03-08 13:33:29, Sebastian Gottschall wrote: >>> Am 08.03.2018 um 10:02 schrieb Pavel Machek: >>> >On Wed 2018-03-07 18:54:41, Sebastian Gottschall wrote: >>>

Dependency required for wil6210 kernel module

Hi, Currently I am working to minimize the filesystem for one of my project. In my project I only want to add support for USB & Wireless (wil6210). To minimize the filesystem I disabled the unwanted things like Iptables, VLAN, VPN, Ethernet support etc from .config and brought my image size from

Re: iwlwifi still randomly fails to restore from S3 sleep (4.15.6 now): 0010:iwl_trans_pcie_grab_nic_access+0xc3/0xd8

Any suggestions or other place/list I should report this bug? Thanks, Marc On Sun, Mar 04, 2018 at 10:22:44PM -0800, Marc MERLIN wrote: > Howdy, > > Info on my card: > [ 14.583443] iwlwifi :04:00.0: runtime IRQ mapping not provided by arch > [ 14.583755] pcieport :00:1c.2: enabling

[PATCH 1/3] Revert "mwifiex: fix incorrect ht capability problem"

This reverts commit bcc920e8f08336cbbdcdba7c4449c27137e6b4b9. Drivers gets hardware info and updates ht_cap field of wiphy->bands during initialization. Once updated during init, ht_cap must not be modified as it reflects the capability supported by hardwawre. Above patch tries to modify the

[PATCH 3/3] mwifiex: get_channel from firmware

At present driver gets chan_type by referring to IEEE80211_HT_PARAM_CHA_SEC_OFFSET, in ASSOC response. Sometimes AP shows IEEE80211_HT_PARAM_CHA_SEC_OFFSET as above/below in assoc response, even if the association is done on HT20 channel only. So, it will be accurate to get econdary channel offset

[PATCH 2/3] mwifiex: fix incorrect ht capability problem

IEEE80211_CHAN_NO_HT40PLUS and IEEE80211_CHAN_NO_HT40PLUS channel flags tell if HT40 operation is allowed on a channel or not. This patch ensures ht_capability information is modified accordingly so that we don't end up creating a HT40 connection when it's not allowed for current regulatory

[PATCH 0/3] Fix issues with connect and get_channel implementation

First change reverts one of our earlier patch, which did change the hardware info stored in driver. Second patch improves the first(reverted) patch. Third change adds a new command, which fixes an issue with get_channel implementation. Three patches needed to make sure the driver association are

ath9k: rx trigger issue

Hi, I am facing an issue with ath9k. I noticed that the rx_tasklet is not being triggered right after reception of a packet. Instead, it is triggered much later (up to few milliseconds) and forwards up more than one packets (all packets received during this time interval). How can I get a

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

On Fri, Mar 9, 2018 at 5:29 AM, Joe Perches wrote: > On Fri, 2018-03-09 at 15:23 +0200, Andreas Christoforou wrote: >> The kernel would like to have all stack VLA usage removed. >> This is the correct patch. > [] >> diff --git a/drivers/net/wireless/ath/ath9k/dfs.c >>

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

Andreas Christoforou writes: > The kernel would like to have all stack VLA usage removed. > > This is the correct patch. > > Signed-off-by: Andreas Christoforou Please use versioning in the patches:

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

Himanshu Jha writes: > On Fri, Mar 09, 2018 at 02:30:12PM +0200, Andreas Christoforou wrote: >> The kernel would like to have all stack VLA usage removed. >> >> Signed-off-by: Andreas Christoforou >> --- >>

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

On 03/09/2018 05:23 AM, Andreas Christoforou wrote: The kernel would like to have all stack VLA usage removed. This is the correct patch. Signed-off-by: Andreas Christoforou This is a lazy changelog really. 'This is the correct patch' has no technical value.

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

On Fri, 2018-03-09 at 15:23 +0200, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed. > This is the correct patch. [] > diff --git a/drivers/net/wireless/ath/ath9k/dfs.c > b/drivers/net/wireless/ath/ath9k/dfs.c [] > @@ -101,7 +101,7 @@ static bool

[PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

The kernel would like to have all stack VLA usage removed. This is the correct patch. Signed-off-by: Andreas Christoforou --- drivers/net/wireless/ath/ath9k/dfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

On Fri, Mar 09, 2018 at 02:30:12PM +0200, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed. > > Signed-off-by: Andreas Christoforou > --- > drivers/net/wireless/ath/ath9k/dfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [Regression] brcmfmac: brcmf_cfg80211_reg_notifier: not an ISO3166 code

Hi, > Stefan Wahren hat am 4. März 2018 um 18:26 > geschrieben: > > > Hi, > > the commit "regulatory: add NUL to request alpha2" in linux-next-20180302 > causes a regression with brcmfmac (Platform: Raspberry Pi 3 B). During driver > probe i will get this error: >

[PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

The kernel would like to have all stack VLA usage removed. Signed-off-by: Andreas Christoforou --- drivers/net/wireless/ath/ath9k/dfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/dfs.c

Re: Variable-length arrays considered bad

Amitkumar Karwar writes: > On Thu, Mar 8, 2018 at 2:10 PM, Kalle Valo wrote: >> Hi, >> >> in an lkml discussion[1] it was mentioned that variable-length arrays >> should not be used. Few warnings were found[2] from wireless: >> >>

[PATCH] mt7601u: let mac80211 validate rx CCMP PN

Apparently the hardware does not perform CCMP PN validation so let mac80211 take care of possible replay attacks in sw. Moreover indicate ICV and MIC had been stripped setting corresponding bits in ieee80211_rx_status. The fix has been validated using 4.2.1 and 4.1.3 tests from the WiFi Alliance

Re: brcmfmac signal/interference issues

On 3/8/2018 4:54 PM, Steve deRosier wrote: On Thu, Mar 8, 2018 at 2:47 AM, Arend van Spriel wrote: On 2/23/2018 2:49 PM, Daniel Drake wrote: On Fri, Feb 23, 2018 at 12:54 PM, Arend van Spriel wrote: Yup. Windows firmware talks

Re: [PATCH 00/10] staging: wilc1000: fixes for checkpatch issues & coding style related

Reviewed-by: Claudiu Beznea On 07.03.2018 04:13, Ajay Singh wrote: > This patch series contains modification to remove the checkpatch warnings > and changes to follow linux coding style. > > Ajay Singh (10): > staging: wilc1000: rename pstrHostIFconnectAttr to

Re: debugfs entries in cfg80211

Hi Arend, Sorry for the late reply - just returning from Israel now (in fact I'm on the plane, but it has wifi). While reworking brcmfmac I stumbled on debugfs code in cfg80211, which creates the debugfs dir for the wiphy instance. It also creates a couple of entries, ie. rts and

Re: [PATCH 00/10] staging: wilc1000: fixes related to camelCase & line over 80 chars

Reviewed-by: Claudiu Beznea On 07.03.2018 03:32, Ajay Singh wrote: > Patch series contains fixes to remove checkpatch reported warnings. > > Ajay Singh (10): > staging: wilc1000: rename strHiddenNetwork to avoid camelCase > staging: wilc1000: rename

Re: [PATCH 10/10] staging: wilc1000: fix line over 80 char in cfg_scan_result()

On 07.03.2018 03:32, Ajay Singh wrote: > Refactor cfg_scan_result() API to avoid 'line over 80 chars' issue > reported by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 148 > +++--- >