On Mon, 26 Mar 2018 18:16:29 +0100
Colin King wrote:
> From: Colin Ian King
>
> Replace several allocation and memcpys with kmemdup and add in some
> missing memory allocation failure checks. Also fix an incorrect
> -EFAULT return with
> so far i see no regressions with 9984 with that patch
>
> except that 9984 has a rekeying problem at all. with wds ap -> wds sta
> mode rekeying will fail and it will reauthenticate at each interval. (it
> disconnects and reconnects)
> but this is a long term issue qca never fixed for years.
Add QMI client driver for Q6 integrated WLAN connectivity subsystem.
Can you give an example which chipset series is Q6 integrated WLAN ?
Thanks,
Peter
From: Fengguang Wu
drivers/staging/wilc1000/host_interface.c:946:32-39: WARNING opportunity for
kmemdup
drivers/staging/wilc1000/host_interface.c:970:30-37: WARNING opportunity for
kmemdup
Use kmemdup rather than duplicating its implementation
Generated by:
Hi,
I am working on wil6210 sector control. Now I think I can successfully
call these 4 functions( set_cfg, get_cfg, set_selected and get
selected index) but it looks like it does not work well because, in
the next Beacon Interval, TXSS will set a new TX sector again. My
question is how I can
Signed-off-by: Denis Kenzior
---
include/uapi/linux/nl80211.h | 2 ++
net/wireless/ibss.c | 1 +
net/wireless/nl80211.c | 6 ++
3 files changed, 9 insertions(+)
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index
Signed-off-by: Denis Kenzior
---
include/net/cfg80211.h | 3 +++
include/uapi/linux/nl80211.h | 14 +-
net/wireless/nl80211.c | 26 ++
3 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/include/net/cfg80211.h
Signed-off-by: Denis Kenzior
---
net/mac80211/cfg.c | 1 +
net/mac80211/ieee80211_i.h | 3 +++
net/mac80211/tx.c | 46 ++
3 files changed, 50 insertions(+)
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
Signed-off-by: Denis Kenzior
---
include/net/cfg80211.h | 3 +++
net/wireless/nl80211.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 2e7f30c66913..2a28f446648e 100644
--- a/include/net/cfg80211.h
+++
This commit implements the TX side of NL80211_CMD_CONTROL_PORT_FRAME.
Userspace provides the raw EAPoL frame using NL80211_ATTR_FRAME.
Userspace should also provide the destination address and the protocol
type to use when sending the frame. This is used to implement TX of
Pre-authentication
Currently autodisconnect_wk assumes that only interface types of
P2P_CLIENT and STATION use conn_owner_nlportid. Change this so all
interface types are supported.
Signed-off-by: Denis Kenzior
---
net/wireless/sme.c | 43 ---
1 file
This patchset adds support for running 802.11 authentication mechanisms (e.g.
802.1X, 4-Way Handshake, etc) over NL80211 instead of putting them onto the
network device. This has the advantage of fixing several long-standing race
conditions that result from userspace operating on multiple
This commit also adds cfg80211_rx_control_port function. This is used
to generate a CMD_CONTROL_PORT_FRAME event out to userspace. The
conn_owner_nlportid is used as the unicast destination. This means that
userspace must specify NL80211_ATTR_SOCKET_OWNER flag if control port
over nl80211
Signed-off-by: Denis Kenzior
---
include/uapi/linux/nl80211.h | 2 ++
net/wireless/mesh.c | 1 +
net/wireless/nl80211.c | 10 +-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
Signed-off-by: Denis Kenzior
---
include/uapi/linux/nl80211.h | 2 ++
net/wireless/ap.c| 1 +
net/wireless/nl80211.c | 4
3 files changed, 7 insertions(+)
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index
Signed-off-by: Denis Kenzior
---
include/net/cfg80211.h | 3 +++
net/wireless/nl80211.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 2a28f446648e..bdb1a3c2661e 100644
--- a/include/net/cfg80211.h
+++
If userspace requested control port frames to go over 80211, then do so.
The control packets are intercepted just prior to delivery of the packet
to the underlying network device.
Pre-authentication type frames (protocol: 0x88c7) are also forwarded
over nl80211.
Signed-off-by: Denis Kenzior
Le 26/03/2018 à 19:16, Colin King a écrit :
From: Colin Ian King
Replace several allocation and memcpys with kmemdup and add in some
missing memory allocation failure checks. Also fix an incorrect
-EFAULT return with -ENOMEM.
Signed-off-by: Colin Ian King
From: Colin Ian King
Replace several allocation and memcpys with kmemdup and add in some
missing memory allocation failure checks. Also fix an incorrect
-EFAULT return with -ENOMEM.
Signed-off-by: Colin Ian King
---
Signed-off-by: Denis Kenzior
---
include/uapi/linux/nl80211.h | 2 ++
net/wireless/mesh.c | 1 +
net/wireless/nl80211.c | 10 +-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
This patchset adds support for running 802.11 authentication mechanisms (e.g.
802.1X, 4-Way Handshake, etc) over NL80211 instead of putting them onto the
network device. This has the advantage of fixing several long-standing race
conditions that result from userspace operating on multiple
This commit implements the TX side of NL80211_CMD_CONTROL_PORT_FRAME.
Userspace provides the raw EAPoL frame using NL80211_ATTR_FRAME.
Userspace should also provide the destination address and the protocol
type to use when sending the frame. This is used to implement TX of
Pre-authentication
If userspace requested control port frames to go over 80211, then do so.
The control packets are intercepted just prior to delivery of the packet
to the underlying network device.
Pre-authentication type frames (protocol: 0x88c7) are also forwarded
over nl80211.
Signed-off-by: Denis Kenzior
Signed-off-by: Denis Kenzior
---
include/net/cfg80211.h | 3 +++
net/wireless/nl80211.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 2a28f446648e..bdb1a3c2661e 100644
--- a/include/net/cfg80211.h
+++
Signed-off-by: Denis Kenzior
---
include/net/cfg80211.h | 3 +++
include/uapi/linux/nl80211.h | 14 +-
net/wireless/nl80211.c | 26 ++
3 files changed, 42 insertions(+), 1 deletion(-)
diff --git a/include/net/cfg80211.h
Signed-off-by: Denis Kenzior
---
net/mac80211/cfg.c | 1 +
net/mac80211/ieee80211_i.h | 3 +++
net/mac80211/tx.c | 46 ++
3 files changed, 50 insertions(+)
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
Signed-off-by: Denis Kenzior
---
include/net/cfg80211.h | 3 +++
net/wireless/nl80211.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 2e7f30c66913..2a28f446648e 100644
--- a/include/net/cfg80211.h
+++
Signed-off-by: Denis Kenzior
---
include/uapi/linux/nl80211.h | 2 ++
net/wireless/ap.c| 1 +
net/wireless/nl80211.c | 4
3 files changed, 7 insertions(+)
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index
Currently autodisconnect_wk assumes that only interface types of
P2P_CLIENT and STATION use conn_owner_nlportid. Change this so all
interface types are supported.
Signed-off-by: Denis Kenzior
---
net/wireless/sme.c | 43 ---
1 file
Signed-off-by: Denis Kenzior
---
include/uapi/linux/nl80211.h | 2 ++
net/wireless/ibss.c | 1 +
net/wireless/nl80211.c | 6 ++
3 files changed, 9 insertions(+)
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index
This commit also adds cfg80211_rx_control_port function. This is used
to generate a CMD_CONTROL_PORT_FRAME event out to userspace. The
conn_owner_nlportid is used as the unicast destination. This means that
userspace must specify NL80211_ATTR_SOCKET_OWNER flag if control port
over nl80211
On 26/03/18 16:35, Ajay Singh wrote:
> Thanks for submitting the patch.
>
> On Wed, 21 Mar 2018 13:03:18 -0700
> Joe Perches wrote:
>
>> On Wed, 2018-03-21 at 19:19 +, Colin King wrote:
>>> From: Colin Ian King
>>>
>>> There are three kmalloc
Applied.
Tamizh chelvam writes:
> When attempt to read tpc_stats for the chipsets which support
> more than 3 tx chain will trigger kernel panic(kernel stack is corrupted)
> due to writing values on rate_code array out of range.
> This patch changes the array size depends on the
Thanks for submitting the patch.
On Wed, 21 Mar 2018 13:03:18 -0700
Joe Perches wrote:
> On Wed, 2018-03-21 at 19:19 +, Colin King wrote:
> > From: Colin Ian King
> >
> > There are three kmalloc allocations that are not null checked which
> >
Ramon Fried wrote:
> IRQ reason was not cheked for errors.
> Although error handing is not currently supported, it
> will be nice to output an error value to the log if the
> DMA operation failed.
>
> Signed-off-by: Ramon Fried
> Signed-off-by:
Ramon Fried wrote:
> DXE channel defaults used hardcoded magic values.
> Added bit definitions of the control register and
> calculate this values in compilation for clarity.
>
> Signed-off-by: Ramon Fried
> Signed-off-by: Kalle Valo
Ramon Fried wrote:
> DXE descriptor control registers used hardcoded magic values. Added bit
> definitions of the control register and calculate this values in compilation
> for clarity. No functional changes.
>
> Signed-off-by: Ramon Fried
>
Peter Große wrote:
> Signed-off-by: Peter Große
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
1fb148f51e6c ath9k: spelling s/premble/preamble/
--
https://patchwork.kernel.org/patch/10262081/
Karthikeyan Periyasamy wrote:
> When attempt to run worker (ath10k_sta_rc_update_wk) after the station object
> (ieee80211_sta) delete will trigger the kernel panic.
>
> This problem arise in AP + Mesh configuration, Where the current node AP VAP
> and neighbor node
Carl Huang wrote:
> The skb may be freed in tx completion context before
> trace_ath10k_wmi_cmd is called. This can be easily captured when
> KASAN(Kernel Address Sanitizer) is enabled. The fix is to move
> trace_ath10k_wmi_cmd before the send operation. As the ret has no
Ramon Fried wrote:
> Whenever the WLAN interface is started the FW
> version and caps are printed.
> The caps now will be displayed only in debug mode.
> Firmware version will be displayed only once on first
> startup of the interface.
>
> Change-Id:
srirr...@codeaurora.org wrote:
> This fixes false radar detection (of radar type 7)
> in Japan region by correcting the radar pulse type
> to Chirp as per specification.
>
> Signed-off-by: Sriram R
> Signed-off-by: Kalle Valo
Patch applied to
mke...@codeaurora.org wrote:
> Export the final Transmit Power Control (TPC) value, which is the
> minimum of control power and existing TPC value to user space via
> a new debugfs file "tpc_stats_final" to help with debugging.
> It works with the new wmi cmd and event introduced in 10.4 firmware
Vasanthakumar Thiagarajan wrote:
> Added per tid sta counters for the following
>
> - Total number MSDUs received from firmware
> - Number of MSDUs received with errors like decryption, crc, mic ,etc.
> - Number of MSDUs dropped in the driver
> - A-MPDU/A-MSDU subframe
Ramon Fried writes:
> Kind reminder. Is the patch ok ?
First of all, please don't top most as it makes using patchwork
annoying. I wish it would detect these top posts somehow.
And for checking the state of patch I have a written instructions to the
wiki:
From: Dmitry Lebed
Exclude CAC_STARTED event from !wdev->cac_started check,
since cac_started will be set later in the same function.
Signed-off-by: Dmitry Lebed
---
net/wireless/mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Dmitry Lebed
DFS offload support implemented:
- DFS_OFFLOAD feature is advertised depending on HW capabilities
- CAC_STARTED event forwarding from HW implemented
- start_radar_detection() callback now returning -ENOTSUPP
if DFS_OFFLOAD is enabled
Signed-off-by:
From: Dmitry Lebed
Currently channel switch/start_ap to DFS channel cannot be done to
non-CAC-cleared channel even if DFS offload if enabled.
Make non-cleared DFS channels available if DFS offload is enabled.
CAC will be started by HW after channel change, start_ap call,
Hello Johannes and all,
Here is a patch set with minor cleanups/updates needed to enable
DFS offload in cfg80211.
Note that the third patch enables DFS offload for qtnfmac driver.
We assume that it should go through wireless-drivers tree after
all cfg80211/nl80211 changes are reviewed and
On Seg, 2018-03-26 at 09:24 -0300, Vanessa Maegima wrote:
> Hi Arend,
>
> >
> > Here's the hexdump: http://code.bulix.org/trv3o7-306254
> >
> The link above provides the hexdump from the html nvram, which makes
> wifi work on pico-imx7d.
>
> I also got the hexdump of the nvram file provided by
From: HariPrasath Elango
In this function,removed the unused integer variable as it is not
actually used to return function success or failure. Return is a pointer
to net_device structure.
Signed-off-by: HariPrasath Elango
---
Apparently, some APs are buggy enough to send a zeroed
WMM IE. Don't WARN on this since this is not caused by a bug
on the client's system.
This aligns the condition of the WARNING in drv_conf_tx
with the validity check in ieee80211_sta_wmm_params.
We will now pick the default values whenever we
Hi Kalle.
Kind reminder. Is the patch ok ?
Thanks,
Ramon
On 2/27/2018 4:05 PM, Ramon Fried wrote:
> Whenever the WLAN interface is started the FW
> version and caps are printed.
> The caps now will be displayed only in debug mode.
> Firmware version will be displayed only once on first
>
Hi Arend,
> Here's the hexdump: http://code.bulix.org/trv3o7-306254
>
The link above provides the hexdump from the html nvram, which makes
wifi work on pico-imx7d.
I also got the hexdump of the nvram file provided by TechNexion for
comparison, which returns the error "brcmfmac:
On Mon, Mar 26, 2018 at 05:01:50PM +0530, Ajay Singh wrote:
> On Mon, 26 Mar 2018 11:32:41 +0300
> Dan Carpenter wrote:
>
> > What happened to patch 8/9? Anyway, I can't apply this patch and it
> > could be my fault or it could be the missing patch. I don't know...
>
so far i see no regressions with 9984 with that patch
except that 9984 has a rekeying problem at all. with wds ap -> wds sta
mode rekeying will fail and it will reauthenticate at each interval. (it
disconnects and reconnects)
but this is a long term issue qca never fixed for years. 988x doesnt
Am Wes ze Stanów Zjednoczonych, ale obecnie przebywa w Syrii na misji
pokojowej. Obecnie szukam przyjaźni, która doprowadzi do związku, w którym
znowu czuję się kochana ...
Chcę cię lepiej poznać, jeśli mogę być odważny. Uważam się za łatwego człowieka
..
Proszę wybaczyć moje
Free allocated memory in wilc_add_ptk() when it fails to enqueue the
command.
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
drivers/staging/wilc1000/host_interface.c | 13 +++--
1 file changed, 7 insertions(+), 6
Free memory allocated for wep key when command enqueue is failed.
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
drivers/staging/wilc1000/host_interface.c | 24 ++--
1 file changed, 14 insertions(+), 10
Free allocated memory for failure scenario while processing the
information message received from the firmware. Added NULL check and used
kmemdup in the flow of handling information message.
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
Fix 'Too many leading tabs' issue found by checkpatch.pl script in
handle_rcvd_gnrl_async_info().
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
drivers/staging/wilc1000/host_interface.c | 286 --
1
Free memory allocated in wilc_add_rx_gtk() before returing from the
function.
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
drivers/staging/wilc1000/host_interface.c | 17 +++--
1 file changed, 11 insertions(+), 6
Added fix to free the allocated memory in case of failure to enqueue
the command.
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
drivers/staging/wilc1000/host_interface.c | 8 ++--
1 file changed, 6 insertions(+), 2
Free allocated memory after completing wilc_send_config_pkt() function.
Remove unncessary use of 'stamac' pointer in handle_get_inactive_time().
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
Cleanup patch to remove the unused global variables defined for p2p.
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
drivers/staging/wilc1000/host_interface.c | 59 ---
1 file changed, 59
Added 'NULL' check before accessing the allocated memory. Free up the
memory incase of failure to enqueue the command. Used kmemdup instead of
kmalloc & memcpy.
Signed-off-by: Ajay Singh
Reviewed-by: Claudiu Beznea
---
This patch series contains changes to fix memory leaks, avoid NULL pointer
exceptions and checkpatch reported issue fixes.
V2:
Modified patch #4, #6, #7 as per review comments.
Added 'Reviewed-by' tags in commit description.
Ajay Singh (9):
staging: wilc1000: remove unused global variables
On Mon, 26 Mar 2018 11:32:41 +0300
Dan Carpenter wrote:
> What happened to patch 8/9? Anyway, I can't apply this patch and it
> could be my fault or it could be the missing patch. I don't know...
I rechecked by applying the patches in order and didn't face any
Hi Dan,
On Mon, 26 Mar 2018 11:17:48 +0300
Dan Carpenter wrote:
> On Fri, Mar 23, 2018 at 08:38:53PM +0530, Ajay Singh wrote:
> We should "return result;" here otherwise we'll hang when we
> wait_for_completion(). This is the sort of bug why I always encourage
>
Hi Mathias
> sorry for the delayed testing. I had to create a new test setup
> first, fought with buggy hardware and was busy with other stuff.
Thanks for doing it.
> The two attached patches are causing a performance regression for me again:
>
> OpenWrt head (forced HT40, 100Mbit wired
The modified file includes 'linux/ieee80211.h', but redefines many
constants that already exist in the header. This will create a conflict
if the values are ever changed in the kernel.
Signed-off-by: Quytelda Kahja
---
drivers/staging/rtl8723bs/include/ieee80211.h | 12
This is a problem with the rtl8723bs driver in staging; it's source
tree has a custom IEEE80211 header which imports 'linux/ieee80211.h',
but redefines many of the #define's from the original header.
Functionally, they are the same, but I will submit a patch in reply to
this email which removes
From: Anilkumar Kolli
QCA9984/QCA99X0/QCA4019 chipsets have 8 memory regions, dump all of them to the
firmware coredump file. Some of the regions need to be read using ioread() so
add new region types for them.
Signed-off-by: Anilkumar Kolli
As QCA9984 needs two region types refactor the code to make it easier add the
new types. No functional changes.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 55 +++
1 file changed, 36 insertions(+), 19 deletions(-)
Reviewed-by: Claudiu Beznea
On 23.03.2018 17:08, Ajay Singh wrote:
> This patch series contains changes to fix memory leaks, avoid NULL pointer
> exceptions and checkpatch reported issue fixes.
>
> Ajay Singh (9):
> staging: wilc1000: remove unused global
What happened to patch 8/9? Anyway, I can't apply this patch and it
could be my fault or it could be the missing patch. I don't know...
Anwyway, seems like a nice patchset.
regards,
dan carpenter
On Fri, Mar 23, 2018 at 08:38:53PM +0530, Ajay Singh wrote:
> Free memory allocated for wep key when command enqueue is failed.
>
> Signed-off-by: Ajay Singh
> ---
> drivers/staging/wilc1000/host_interface.c | 10 +++---
> 1 file changed, 7 insertions(+), 3
So I really don't know enough to properly review
your patch. Just be aware that ath10k is weird about sw-crypt, maybe
make
sure your patch is tested on it to make sure it doesn't out-right
break something.
i will test it today in sta and ap mode. lets see whats the result after
some hours
Hi Govind,
On Mon, Mar 26, 2018 at 11:11:26AM +0530, Govind Singh wrote:
> Add support for bdf download and cold boot
> calibration trigger qmi message support.
>
> Signed-off-by: Govind Singh
> ---
> drivers/net/wireless/ath/ath10k/qmi.c | 195
>
FW has Smart Logging feature enabled by default for detecting failures
and processing FATAL_CONDITION_EVENTID (36925 - 0x903D) back to host.
Since ath10k doesn't implement the Smart Logging and FATAL CONDITION
EVENT processing yet, suppressing the unknown event ID warning by moving
this under
On Freitag, 23. März 2018 19:37:14 CEST Anilkumar Kolli wrote:
> +static u32 ath10k_get_expected_throughput(struct ieee80211_hw *hw,
> + struct ieee80211_sta *sta)
> +{
> + struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv;
> +
> +
82 matches
Mail list logo