Re: [RFC 3/4] mac80211: Apply per-peer NoAck tid bitmap configuration

On 2018-03-27 14:12, Vasanthakumar Thiagarajan wrote: Use per-peer noack tid bitmap, if it is configured, when setting up the qos header. If no per-peer configuration is set, use the existing nedev wide noack policy configuration. Also modifies callback set_noack_tid_bitmap() with the provision

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

Hello! Thank you very much for your work. I tested your patch on the ASUS WL-330N3G; it allows the device to continue operating even when the error verifies. Here's the logs from dmesg: triggered with an iPhone SE, latest iOS as now should that matter. openwrt head at commit

Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check

me...@codeaurora.org writes: > On 2018-03-28 20:40, Colin King wrote: >> From: Colin Ian King >> >> The pointer ndev is being dereferenced before it is being null checked, >> hence there is a potential null pointer deference. Fix this by only >> dereferencing ndev after

how to disable DIFS and Backoff in 802.11 ath9k or ath5k driver

Dear All, I am a researcher on 802.11 network security. I am doing a project where the first two stations are communicating and the third station tries to inject an forged 802.11 ACK if the last data frame is lost. The ACK must be arrived to the data sender before the ACK timer expires. Therefore

[PATCH] ath10k: avoid possible string overflow

The way that 'strncat' is used here raised a warning in gcc-8: drivers/net/wireless/ath/ath10k/wmi.c: In function 'ath10k_wmi_tpc_stats_final_disp_tables': drivers/net/wireless/ath/ath10k/wmi.c:4649:4: error: 'strncat' output truncated before terminating nul copying as many bytes from a string

Re: Intel Corporation Wireless 8260 [8086:24f3] (rev 3a) - Hardware error in PCI passthrough

On Wed, 2018-03-21 at 19:43 -0600, Mohamed Khalfella wrote: > Hi, Hi Mohamed, > I am working in pci passthrough for qemu under SmartOS. My test > machine is Intel NUC Kit NUC6i3SYH BOXNUC6I3SYH which comes with > Intel > Wireless 8260 [8086:24f3]. So far the guest OS recognize the PCI > device

pull-request: iwlwifi-next 2018-03-28

Hi Kalle, This is a batch of patches intended for v4.17. Nothing major here, just the usual continued development, bugfixes, new FW APIs and some minor features. More details about the contents in the tag description. The commit messages you commented on have been fixed, as you can see in v2

[PATCH v2 14/14] iwlwifi: wrt: add fw force restart via triggers

From: Shahar S Matityahu We can set triggers that cause a debug data collection when something of interest happens (e.g. when too many probes are lost conscutively). Normally, this triggers don't cause the FW to be restarted, but in some cases that may be desired,

[PATCH v2 07/14] iwlwifi: mvm: add support for oce

From: "Zamir, Roee" Add support for Optimized Connectivity Experience (OCE). Get capabilities from the fw, expose them with nl80211, and enable them in UMAC scan if the relevant nl80211 flags are set by the userspace. Signed-off-by: Roee Zamir

[PATCH v2 06/14] iwlwifi: mvm: add adaptive dwell support

From: "Zamir, Roee" Update the scan command API with support for adaptive dwell. Adaptive dwell is a type of scan that dynamically changes the time it remains on each channel listening for beacons or probe responses. Signed-off-by: Roee Zamir

Re: [PATCH 14/14] iwlwifi: wrt: add fw force restart via triggers

On Wed, 2018-03-28 at 19:23 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: Shahar S Matityahu > > > > Add support to wrt force restart capability. > > > > Signed-off-by: Shahar S Matityahu > >

Re: [PATCH 07/14] iwlwifi: mvm: add support for oce

On Wed, 2018-03-28 at 19:20 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: "Zamir, Roee" > > > > Get capabilities from the fw, expose them with nl80211, and enable > > them > > in UMAC scan if the relevant nl80211 flags are set by the > >

Re: [PATCH 06/14] iwlwifi: mvm: add adaptive dwell support

On Wed, 2018-03-28 at 19:18 +0300, Kalle Valo wrote: > Luca Coelho writes: > > > From: "Zamir, Roee" > > > > Update the scan command API with support for adaptive dwell > > and add a debugfs entry to configure max budget parameter. > > > > Signed-off-by:

Re: brcmfmac signal/interference issues

On Thu, Mar 8, 2018 at 4:47 AM, Arend van Spriel wrote: >> 43455c0-roml/sdio-ag-ndis-vista-pktfilter-d0c-pno-aoe-p2p-dhdoid-ndoe-gtkoe-mfp-proptxstatus-dmatxrc-keepalive-ap-ampduretry-pclose-txbf >> >> Yes, ndis. So no easy way to run the same firmware on the 2 OSes.

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

Hi On Tue, Mar 27, 2018 at 07:43:04PM +0200, Daniel Golle wrote: > That's great news! Are you running OpenWrt or some self-baked > vanilla Linux with some of the OpenWrt patchery on top? Just what OpenWRT/LEDE provides, but self compiled form git tree to allow test patches. > Also note that

Re: brcmfmac signal/interference issues

On Thu, Mar 8, 2018 at 9:54 AM, Steve deRosier wrote: > Did you check the Bluetooth? I don't know if this chip has it or if > it's an independent chip on this board, but if Linux is leaving it > powered up but not properly configured you could have issues. I had already

Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check

On 2018-03-28 20:40, Colin King wrote: From: Colin Ian King The pointer ndev is being dereferenced before it is being null checked, hence there is a potential null pointer deference. Fix this by only dereferencing ndev after it has been null checked Detected by

[PATCH][next] wil6210: fix potential null dereference of ndev before null check

From: Colin Ian King The pointer ndev is being dereferenced before it is being null checked, hence there is a potential null pointer deference. Fix this by only dereferencing ndev after it has been null checked Detected by CoverityScan, CID#1467010 ("Dereference before

Re: [PATCH v3 2/3] mac80211: limit wmm params to comply with ETSI requirements

+ if (sdata->vif.type == NL80211_IFTYPE_AP) + wmm_ac = >wmm_rule->ap[ac]; + else + wmm_ac = >wmm_rule->client[ac]; + qparam->cw_min = max_t(u16, qparam->cw_min, wmm_ac->cw_min); + qparam->cw_max = max_t(u16, qparam->cw_max, wmm_ac->cw_max);

Re: [PATCH 14/14] iwlwifi: wrt: add fw force restart via triggers

Luca Coelho writes: > From: Shahar S Matityahu > > Add support to wrt force restart capability. > > Signed-off-by: Shahar S Matityahu > Signed-off-by: Luca Coelho The commit log is not

Re: [PATCH 07/14] iwlwifi: mvm: add support for oce

Luca Coelho writes: > From: "Zamir, Roee" > > Get capabilities from the fw, expose them with nl80211, and enable them > in UMAC scan if the relevant nl80211 flags are set by the userspace. > > Signed-off-by: Roee Zamir >

Re: [PATCH 06/14] iwlwifi: mvm: add adaptive dwell support

Luca Coelho writes: > From: "Zamir, Roee" > > Update the scan command API with support for adaptive dwell > and add a debugfs entry to configure max budget parameter. > > Signed-off-by: Roee Zamir > Signed-off-by: Beni Lev

Re: [PATCHv2] ath10k: Add tx ack signal support for management frames

Venkateswara Naralasetty wrote: > This patch add support to get RSSI from acknowledgment > frames for transmitted management frames. > > hardware_used: QCA4019, QCA9984. > firmware version: 10.4-3.5.3-00052. > > Signed-off-by: Venkateswara Naralasetty

Re: [v7,3/5] ath10k: Enable TDLS peer inactivity detection

yint...@qti.qualcomm.com wrote: > Enable TDLS peer inactivity detetion feature. > QCA6174 firmware(version: WLAN.RM.4.4) support TDLS link inactivity detecting. > Set related parameters in TDLS WMI command to enable this feature. > > Signed-off-by: Yingying Tang >

Re: [07/12] ath10k: Add MSA handshake QMI mgs support

Govind Singh wrote: > HOST allocates 2mb of region for modem and WCN3990 > secure access and provides the address and access > control to target for secure access. > Add MSA handshake request/response messages. > > Signed-off-by: Govind Singh >

Re: [01/12] ath10k: Add qmi service for wlan qmi client

Govind Singh wrote: > WLAN qmi server running in Q6 dsp exposes host > to target cold boot qmi handshake. > Add WLAN QMI service helpers for WLAN serivice. > > Signed-off-by: Govind Singh > Signed-off-by: Kalle Valo This

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

On Tue, Mar 27, 2018 at 11:09 PM, wrote: > On 2018-03-27 22:18, Steve deRosier wrote: >> >> Hi Vasanthakumar, >> >> On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan >> wrote: >>> >>> Adds infrastructure for driver to offload NoAck

Re: [PATCH 7/9] rtlwifi: btcoex: Add modifier const to version related variables

writes: > From: Ping-Ke Shih > > The variables declared as 'static' look a little weird. Since they are > version of btcoex and only used to display in debug message, this patch > changes them to 'static const' to make it clear. > > Signed-off-by: Ping-Ke

[PATCH 14/14] iwlwifi: wrt: add fw force restart via triggers

From: Shahar S Matityahu Add support to wrt force restart capability. Signed-off-by: Shahar S Matityahu Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 6 ++

[PATCH 13/14] iwlwifi: mvm: save low latency causes in an enum

From: Sara Sharon Currently we have a boolean variable for each cause. This costs space, and requires to check each separately when determining low latency. Since we have another cause incoming, convert it to an enum. While at it, move the retrieval of the prev value

[PATCH 12/14] iwlwifi: bump the max API version for 9000 and 22000 devices

From: Emmanuel Grumbach We are now ready to load 38.ucode Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/cfg/22000.c | 4 +++-

[PATCH 10/14] iwlwifi: add a bunch of new 9000 PCI IDs

From: Luca Coelho A lot of new PCI IDs were added for the 9000 series. Add them to the list of supported PCI IDs. Cc: sta...@vger.kernel.org # 4.13+ Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 157

[PATCH 11/14] iwlwifi: api: Add geographic profile information to MCC_UPDATE_CMD

From: Haim Dreyfuss Some geographic profiles require specific handling. For example ETSI profile requires special channel access handling. Add geographic profile information to MCC_UPDATE response to allow it. Signed-off-by: Haim Dreyfuss

[PATCH 09/14] iwlwifi: fw api: support the new scan request FW API version

From: Ayala Beker Remove fragmented_dwell_time and add num_of_fragments to support the new API version. Signed-off-by: Ayala Beker Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/fw/api/scan.h | 67

[PATCH 08/14] iwlwifi: mvm: Allow iwl_mvm_mac_mgd_prepare_tx() when associated

From: Ilan Peer The FW does not allocate quota air time for the binding of a station MAC before iwlmvm indicates that it is associated. Currently iwlmvm indicates that the MAC is associated only after hearing a beacon from the AP. In case a deauthentication frame is sent

[PATCH 06/14] iwlwifi: mvm: add adaptive dwell support

From: "Zamir, Roee" Update the scan command API with support for adaptive dwell and add a debugfs entry to configure max budget parameter. Signed-off-by: Roee Zamir Signed-off-by: Beni Lev Signed-off-by: Luca Coelho

[PATCH 07/14] iwlwifi: mvm: add support for oce

From: "Zamir, Roee" Get capabilities from the fw, expose them with nl80211, and enable them in UMAC scan if the relevant nl80211 flags are set by the userspace. Signed-off-by: Roee Zamir Signed-off-by: Luca Coelho ---

[PATCH 03/14] iwlwifi: mvm: move TSO segment to a separate function

From: Sara Sharon This makes future bail-outs from transmitting an AMSDU more readable. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 158

[PATCH 05/14] iwlwifi: mvm: check if mac80211_queue is valid in iwl_mvm_disable_txq

From: Luca Coelho Sometimes iwl_mvm_disable_txq() may be called with mac80211_queue == IEEE80211_INVAL_HW_QUEUE, and this would cause us to use BIT(0xFF) which is way too large for the u16 we used to store it in hw_queue_to_mac820211. If this happens the following

[PATCH 04/14] iwlwifi: set default timstamp marker cmd

From: Mordechay Goodstein In case debug configuration is started with LDBG cmd also start timestamp marker for syncing logs witn the FW. Signed-off-by: Mordechay Goodstein Signed-off-by: Luca Coelho ---

[PATCH 01/14] iwlwifi: mvm: flip AMSDU addresses only for 9000 family

From: Sara Sharon Hardware bug was fixed in later generation. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 25 +++-- 1 file changed, 15

[PATCH 02/14] iwlwifi: mvm: take RCU lock before dereferencing

From: Sara Sharon RCU isn't properly locked. Fixes: 46d372af9935 ("iwlwifi: mvm: rs: new rate scale API - add FW notifications") Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho ---

[PATCH 00/14] iwlwifi: updates intended for v4.17 2018-03-28

From: Luca Coelho Hi, Here's the last batch of patches intended for 4.17. I'm also including the 5 patches I sent out last year and were still pending, since they were rebased and some have changed slightly. The old series contains these: * Fix a UBSAN warning; *

[PATCH] mac80211: allow AP_VLAN operation on crypto controlled devices

From: Manikanta Pubbisetty In the current implementation, mac80211 advertises the support of AP_VLANs based on the driver's support for AP mode; it also blocks encrypted AP_VLAN operation on devices advertising SW_CRYPTO_CONTROL. The implementation seems weird in it's

Re: [PATCH v3] ath9k: fix crash in spectral scan

Am 28.03.2018 um 13:21 schrieb Kalle Valo: Sebastian Gottschall writes: Apparently the automatic email was not sent, no idea why. But this was applied to ath-next few days ago: 221b6ec69ed9 ath9k: fix crash in spectral scan i have seen it. thx any idea about my led

Re: [PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup

On Mon, Mar 26, 2018 at 06:16:29PM +0100, Colin King wrote: > From: Colin Ian King > > Replace several allocation and memcpys with kmemdup and add in some > missing memory allocation failure checks. Also fix an incorrect > -EFAULT return with -ENOMEM. > >

Re: [PATCH v2 1/9] staging: wilc1000: remove unused global variables related to p2p

On Mon, Mar 26, 2018 at 05:15:55PM +0530, Ajay Singh wrote: > Cleanup patch to remove the unused global variables defined for p2p. > > Signed-off-by: Ajay Singh > Reviewed-by: Claudiu Beznea > --- >

Re: [PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly

On Tue, Mar 27, 2018 at 12:52:13PM +0530, Ajay Singh wrote: > > Please let me know, in case I have to rework and resubmit this patch > series to make them into staging branch. You already sent a v2 series for this, right? Why respond to the v1 set? confused, greg k-h

Re: [PATCH v3] ath9k: fix crash in spectral scan

Sebastian Gottschall writes: >> Apparently the automatic email was not sent, no idea why. But this was >> applied to ath-next few days ago: >> >> 221b6ec69ed9 ath9k: fix crash in spectral scan > > i have seen it. thx > > any idea about my led code for ath10k? I should

Passing uninitialised local variable

Hello everyone, I recently found that a local variable in passed uninitialised to the function at drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:2950 u32 var; err = brcmf_fil_iovar_int_get(ifp, "dtim_assoc", ); if (err) {

Re: [PATCH v3] ath9k: fix crash in spectral scan

Apparently the automatic email was not sent, no idea why. But this was applied to ath-next few days ago: 221b6ec69ed9 ath9k: fix crash in spectral scan i have seen it. thx any idea about my led code for ath10k? Sebastian -- Mit freundlichen Grüssen / Regards Sebastian Gottschall / CTO

[PATCH v3 3/3] cfg80211: Add API to allow querying regdb for wmm_rule

From: Haim Dreyfuss In general regulatory self managed devices maintain their own regulatory profiles thus it doesn't have to query the regulatory database on country change. ETSI has recently introduced a new channel access mechanism for 5GHz that all wlan devices need

[PATCH v3 2/3] mac80211: limit wmm params to comply with ETSI requirements

From: Haim Dreyfuss ETSI has recently added new requirements that restrict the WMM parameter values for 5GHz frequencies. We need to take care of the following scenarios in order to comply with these new requirements: 1. When using mac80211 default values; 2. When the

[PATCH v3 0/3] cfg80211/mac80211: ETSI requirements patches

From: Luca Coelho Hi, Here are Haim's 3 patches for the new ETSI requirements that have been pending due to fixes we had in our internl tree. All the fixes have been squased. Please review and let me know if there are any issues. Cheers, Luca. Haim Dreyfuss (3):

[PATCH v3 1/3] cfg80211: read wmm rules from regulatory database

From: Haim Dreyfuss ETSI EN 301 893 v211 (2017-05) standard defines a new channel access mechanism that all devices (WLAN and LAA) need to comply with. The regulatory database can now be loaded into the kernel and also has the option to load optional data. In order to be

Re: [PATCH v3] ath9k: fix crash in spectral scan

s.gottsch...@dd-wrt.com writes: > From: Sebastian Gottschall > > fixes crash seen on arm smp systems (gateworks ventana imx6) > > Signed-off-by: Sebastian Gottschall > > v2: fix wrong field and add signed-off-by > v3: forgot to include correct

Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

On Wed, 2018-03-28 at 14:20 +0530, vthia...@codeaurora.org wrote: > > > Btw, we should probably also have a way to *delete* the per-station > > configuration, so it uses the default again? > > Sure. How about setting it to default when the command is received with > no NL80211_ATTR_NOACK_MAP

Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

On 2018-03-28 13:36, Johannes Berg wrote: On Wed, 2018-03-28 at 10:24 +0530, vthia...@codeaurora.org wrote: > The question is how that interacts with having enough space - are you > sure this is a concern? This will not be an issue at lest for ath10k. This is mainly for a (new)driver which

Re: [RFC 2/4] nl80211/mac80211: Extend NoAck policy command with peer MAC address

On Wed, 2018-03-28 at 10:24 +0530, vthia...@codeaurora.org wrote: > > The question is how that interacts with having enough space - are you > > sure this is a concern? > > This will not be an issue at lest for ath10k. This is mainly for a > (new)driver > which implements the offload but has

Re: [RFC 3/4] mac80211: Apply per-peer NoAck tid bitmap configuration

> I think 0 as the Noack configuration from user can also be a valid one > in the case > where user does not want any NoAck policy to be used for a particular > station even > when a non-zero NoAck configuration is set for ndev level. In this case, > the logic > may need to be modified so that

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

On Wed, 2018-03-28 at 13:29 +0530, vthia...@codeaurora.org wrote: > On 2018-03-28 13:07, Arend van Spriel wrote: > > On 3/28/2018 8:09 AM, vthia...@codeaurora.org wrote: > > > On 2018-03-27 22:18, Steve deRosier wrote: > > > > Hi Vasanthakumar, > > > > > > > > On Tue, Mar 27, 2018 at 1:42 AM,

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

On 2018-03-28 13:07, Arend van Spriel wrote: On 3/28/2018 8:09 AM, vthia...@codeaurora.org wrote: On 2018-03-27 22:18, Steve deRosier wrote: Hi Vasanthakumar, On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan wrote: Adds infrastructure for driver to offload

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

On 3/28/2018 8:09 AM, vthia...@codeaurora.org wrote: On 2018-03-27 22:18, Steve deRosier wrote: Hi Vasanthakumar, On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan wrote: Adds infrastructure for driver to offload NoAck functionality, driver like ath10k could

[PATCH 8/9] rtlwifi: btcoex: Add struct members to replace global varaibles

From: Ping-Ke Shih Chip specific context plays as global variables that will not support multiple devices simultaneously. This patch adds 'union' fields to hold the variables, and next patch will remove all of them. To use the declaration of fields in halbtcoutsrc.h, I move

[PATCH 5/9] rtlwifi: btcoex: Add 8822b to Makefile

From: Ping-Ke Shih Add btcoex of 8822b to Makefile. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/Makefile

[PATCH 9/9] rtlwifi: btcoex: Remove global variables of chip specific context

From: Ping-Ke Shih Remove the global varaibles, and use local varialbes that point the fields defined in 'struct btc_coexist' instead, so it is possible to support multiple devices. Signed-off-by: Ping-Ke Shih ---

[PATCH 3/9] rtlwifi: btcoex: Add 8822b header files to precomp.h

From: Ping-Ke Shih Add 8822b header files to precomp.h for routing functions. Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtlwifi/btcoexist/halbt_precomp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 7/9] rtlwifi: btcoex: Add modifier const to version related variables

From: Ping-Ke Shih The variables declared as 'static' look a little weird. Since they are version of btcoex and only used to display in debug message, this patch changes them to 'static const' to make it clear. Signed-off-by: Ping-Ke Shih ---

[PATCH 6/9] rtlwifi: btcoex: remove comments that are not meaningful

From: Ping-Ke Shih The comments aren't meaningful and the use of '***...***' isn't upstream style, so remove them. This patch doesn't change any code. Signed-off-by: Ping-Ke Shih --- .../realtek/rtlwifi/btcoexist/halbtc8192e2ant.c| 22

Re: [PATCH v2] ath10k: Implement get_expected_throughput callback

On Mittwoch, 28. März 2018 11:41:51 CEST ako...@codeaurora.org wrote: [...] > The rate average and throughput are relative. no? In the sense that rate has a tendency to affect the expected throughput - yes. But it is not like the expected throughput perfectly correlates with the rate and you

Re: [PATCH v2] ath10k: Implement get_expected_throughput callback

On 2018-03-26 12:52, Sven Eckelmann wrote: On Freitag, 23. März 2018 19:37:14 CEST Anilkumar Kolli wrote: +static u32 ath10k_get_expected_throughput(struct ieee80211_hw *hw, + struct ieee80211_sta *sta) +{ + struct ath10k_sta *arsta = (struct

Re: [RFC 0/4] wireless: Per-sta NoAck and offload support

On 2018-03-27 22:18, Steve deRosier wrote: Hi Vasanthakumar, On Tue, Mar 27, 2018 at 1:42 AM, Vasanthakumar Thiagarajan wrote: Adds infrastructure for driver to offload NoAck functionality, driver like ath10k could make use of it. Also extends the current ndev wide