Re: [rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

On Thu, 2018-04-05 at 01:25 +, Gustavo A. R. Silva wrote: > Hi all, > > While doing some static analysis I came across the following piece of code at > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: > > 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct

[rtlwifi-btcoex] Suspicious code in halbtc8821a1ant driver

Hi all, While doing some static analysis I came across the following piece of code at drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_coexist *btcoexist, 1582

[PATCH] brcm80211: brcmsmac: phy_lcn: remove duplicate code

Remove and refactor some code in order to avoid having identical code for different branches. Notice that this piece of code hasn't been modified since 2011. Addresses-Coverity-ID: 1226756 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH] mac80211: Fix bad line warning

From: Masanari Iida Date: Wed, 4 Apr 2018 20:53:33 +0900 > After 03fe2debbb2771fb90881e merged during 4.17 marge window, > I start to see following warning during "make xmldocs" > > ./include/net/mac80211.h:2083: warning: bad line: > > > Replace ">" with "*" fix the

Re: RTL8723BE performance regression

On Tue, Apr 3, 2018 at 6:51 PM, João Paulo Rechi Vita wrote: > > This are the results (testing with speedtest.net) I got at some key points: > > VersionCommitPingDownUp > > v4.11a351e9b1225.445.99 > v4.11

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

On 4/4/2018 12:36 PM, Johannes Berg wrote: Hi, Started working on this and actually the "weird flags thing" is done for a reason. Maybe the reason was because it is done like that in the CMD_CONNECT case, but the better reason is that we need to return -EINVAL for "no-fils-offload-support,

Re: [PATCH 1/9] rtlwifi: btcoex: Add 8822b1ant coex files

On Wed, 2018-04-04 at 20:41 +0800, Pkshih wrote: > On Wed, 2018-04-04 at 02:43 +, Larry Finger wrote: > > On 03/28/2018 02:27 AM, pks...@realtek.com wrote: > > > From: Ping-Ke Shih > > >  > > > This file supports 8822be WiFi module with two physical antenna that > > >

Re: [PATCH 1/9] rtlwifi: btcoex: Add 8822b1ant coex files

On Wed, 2018-04-04 at 02:43 +, Larry Finger wrote: > On 03/28/2018 02:27 AM, pks...@realtek.com wrote: > > From: Ping-Ke Shih > >  > > This file supports 8822be WiFi module with two physical antenna that > > means one antenna will share with BT. > >  > > Signed-off-by:

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

Hi, > Started working on this and actually the "weird flags thing" is done for > a reason. Maybe the reason was because it is done like that in the > CMD_CONNECT case, but the better reason is that we need to return > -EINVAL for "no-fils-offload-support, any-fils-param" *and* >

Re: [PATCH] nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS

On 3/29/2018 1:31 PM, Arend van Spriel wrote: So yeah, I'd argue that what the patch needed was somebody taking a critical look at my review ;-) And perhaps fixing the weird flags thing I pointed out. Yup. That made sense. Hi Johannes, Started working on this and actually the "weird flags

[PATCH] mt76x2: set default values in TX_ALC_CFG_{1,2} for tempetaure compensation

Initialize default values for temperature compensation in TX_ALC_CFG_{1,2} if tssi has been enabled Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2_phy.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH] mt76x2: fix tx_alc_enabled check

Fix mt76x2_temp_tx_alc_enabled routine since in order to enable tx_alc temperature compensation it necessary to take into account BIT(15) of MT_EE_TX_POWER_EXT_PA_5G eeprom info Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") Signed-off-by: Lorenzo Bianconi

Re: Request for brcmfmac4366c-pcie.bin

On 4/4/2018 4:12 AM, Hubert Wiedeke wrote: On Mon, 19 Feb 2018 12:51:07 +0100 Arend van Spriel wrote: On 2/17/2018 9:19 AM, Hubert Wiedeke wrote: Hi, I'd like to ask about the current status of 4366c firmware preparation for linux-firmware.git . Is it close to

Re: [PATCH 3/3] wcn36xx: don't delete invalid bss indices

On Wednesday, April 04, 2018 07:40 AM, Ramon Fried wrote: > On 4/3/2018 7:51 PM, Daniel Mack wrote: >> The firmware code cannot cope with requests to remove BSS indices that have >> not previously been added. This primarily happens when the device is >> suspended and then resumed.

[PATCH] iwlwifi: mvm: query regdb for wmm rule if needed

From: Haim Dreyfuss Since our device is regulatory self managed it maintains its regulatory rules by its own. However the wmm_rules values can't be set by the device itself but only the indication about the need to set it. In case the device set wmm indication,

Re: Wi-Fi Disconnection on Suspend for no wowlan triggers

Steve deRosier writes: > On Tue, Apr 3, 2018 at 5:39 AM, Sunil Dutt Undekari > wrote: >> Hi All , >> >> I would like to discuss on the commit >> 8125696991194aacb1173b6e8196d19098b44e17 (cfg80211/mac80211: >> disconnect on suspend) which triggers the