Re: iwlwifi 4.18rc1 SYNC TIME_QUOTA_CMD with fw 31

On Wed, 2018-04-18 at 11:31 +0300, Emmanuel Grumbach wrote: > On Wed, Apr 18, 2018 at 5:47 AM, Scott Register wrote: > > > > Hello, > > > > After upgrading to 4.18rc1 iwlwifi is printing a FW error. There > > was a > > previous thread with a similar > > issue but they seemed to

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

On 2018-04-18 18:46, Kalle Valo wrote: (fixing top posting) govi...@codeaurora.org writes: On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

On 04/18/2018 02:26 PM, Johannes Berg wrote: On Tue, 2018-04-17 at 18:49 -0700, gree...@candelatech.com wrote: + * @get_ethtool_stats2: Return extended statistics about the device. + * This is only useful if the device maintains statistics not + * included in rtnl_link_stats64. + *

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

On Tue, 2018-04-17 at 18:49 -0700, gree...@candelatech.com wrote: > > + * @get_ethtool_stats2: Return extended statistics about the device. > + * This is only useful if the device maintains statistics not > + * included in rtnl_link_stats64. > + * Takes a flags argument: 0 means all

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

On 04/17/2018 06:49 PM, gree...@candelatech.com wrote: > From: Ben Greear > > This is similar to ETHTOOL_GSTATS, but it allows you to specify > flags. These flags can be used by the driver to decrease the > amount of stats refreshed. In particular, this helps with

Re: ath confusing log message "country IE"

On Wed, 2018-04-18 at 16:55 +0200, Toke Høiland-Jørgensen wrote: > > Heh, that is a good point, I think. The patch below should fix it; but I > worry that the log lines become quite long, then? Maybe better to use > "country-IE", but that could also be confused. "country inf.elem" > perhaps?

Re: wil6210: low level sector API

Hi, I updated the firmware and tried to call some low level functions, like WMI_PRIO_TX_SECTORS_NUMBER_CMDID and WMI_SET_RF_SECTOR_ON_CMDID . The previous errors have gone but it still has errors: wil6210 :03:00.0 wlp3s0: wmi_event_handle: Unhandled event 0x19a5 wil6210 :03:00.0 wlp3s0:

Re: ath confusing log message "country IE"

On Wed, Apr 18, 2018 at 7:55 AM, Toke Høiland-Jørgensen wrote: > Bernhard Gabler writes: > >> Dear all, >> >> would it be possible to re-write the log message from >> "regdomain ... dynamically updated by country IE" >> in a less ambiguous way, e.g. to:

Re: ath confusing log message "country IE"

Bernhard Gabler writes: > Dear all, > > would it be possible to re-write the log message from >    "regdomain ... dynamically updated by country IE" > in a less ambiguous way, e.g. to: >    "regdomain ... dynamically updated by country-IE" >    "regdomain ...

ath confusing log message "country IE"

Dear all, would it be possible to re-write the log message from    "regdomain ... dynamically updated by country IE" in a less ambiguous way, e.g. to:    "regdomain ... dynamically updated by country-IE"    "regdomain ... dynamically updated by country information element" , please? To the

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

On 4/18/2018 3:16 PM, Kalle Valo wrote: (fixing top posting) govi...@codeaurora.org writes: On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

(fixing top posting) govi...@codeaurora.org writes: > On 2018-04-18 12:36, Sebastian Gottschall wrote: >> from my point of view powersave should be optional and not forced. >> >> consider : >> iw dev set power_save on/off >> >> so there is already a config option made for that purpose, > >

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

On 2018-04-18 12:36, Sebastian Gottschall wrote: from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made for that purpose, Sebastian Am 17.04.2018 um 14:07 schrieb pill...@codeaurora.org: From:

Re: [PATCH] rt2x00: fix spelling mistake in various macros, UKNOWN -> UNKNOWN

On Wed, Apr 18, 2018 at 12:47:50PM +0100, Colin King wrote: > From: Colin Ian King > > Rename several macros that contain mispellings of UNKNOWN > > Signed-off-by: Colin Ian King Acked-by: Stanislaw Gruszka

[PATCH] rt2x00: fix spelling mistake in various macros, UKNOWN -> UNKNOWN

From: Colin Ian King Rename several macros that contain mispellings of UNKNOWN Signed-off-by: Colin Ian King --- drivers/net/wireless/ralink/rt2x00/rt2800.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 05/22] staging: wilc1000: refactor add_key() to avoid duplicated code

Cleanup fixes by removing the duplicated code in actor add_key(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 64 --- 1 file changed, 23 insertions(+), 41 deletions(-) diff --git

[PATCH 06/22] staging: wilc1000: handle error condition in add_key() and remove auth_type variable

Added the code to return correct error code in add_key() and also removed 'auth_type' variable. Now passing diretly to function instead of using the 'auth_type' variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 52

[PATCH 22/22] staging: wilc1000: rename pu32InactiveTime to avoid camelCase issue

Avoid camelCase issues found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.h

[PATCH 20/22] staging: wilc1000: rename goto labels starting with '_' in wilc1000_wlan_init()

Rename goto labels starting with '_' in wilc1000_wlan_init() to follow linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH 12/22] staging: wilc1000: remove multiple define used for MAX_SSID_LEN

Cleanup patch to have commonly used macro in common header file to avoid same defination in mulitple file. Removed MAX_SSID_LEN macro from coreconfigurator.h header as its already defined in wilc_wlan_if.h. Signed-off-by: Ajay Singh ---

[PATCH 18/22] staging: wilc1000: remove the use of goto label in wilc_init()

Added direct return in wilc_init() instead of goto label. Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff

[PATCH 19/22] staging: wilc1000: rename goto label '_fail_' linux naming convension

Rename '_fail_' goto label to have name as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/linux_wlan.c | 92 +-- drivers/staging/wilc1000/wilc_sdio.c | 84

[PATCH 16/22] staging: wilc1000: remove the use of goto label in wilc_spi_read_int()

In wilc_spi_read_int() remove the use of goto label '_fail_'. Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 21/22] staging: wilc1000: remove the use of goto label in wilc_spi_clear_int_ext()

Remove goto label '_fail_' used in wilc_spi_clear_int_ext(), to avoid the label name starting with '_'. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 03/22] staging: wilc1000: split add_key() to avoid line over 80 chars

Cleanup changes to fix 'line over 80 chars' issue found by checkpatch.pl script by spliting the function. Also make use of kzalloc() instead of kmalloc(). Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 108 +- 1

[PATCH 09/22] staging: wilc1000: rename WID_LOGTerminal_Switch to avoid camelCase

Fix 'Avoid camelCase' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h

[PATCH 10/22] staging: wilc1000: added identifiers name in function definations

Fix identifier names required for functions definition issues reported by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wlan.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH 07/22] staging: wilc1000: use sizeof(variable) for memory allocated to store key info

Changes to fix below checkpatch reported issues. CHECK: Prefer kmalloc(sizeof(*priv->wilc_gtk[idx])...) over kmalloc(sizeof(struct wilc_wfi_key)...) CHECK: Prefer kmalloc(sizeof(*priv->wilc_ptk[idx])...) over kmalloc(sizeof(struct wilc_wfi_key)...) Signed-off-by: Ajay Singh

[PATCH 17/22] staging: wilc1000: remove goto label '_done_' in handle_listen_state_expired()

Remove the use of goto label '_done_' in handle_listen_state_expired(). Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 11/22] staging: wilc1000: remove unused macros in wilc module

Cleanup patch to remove the macros which are defined by not used. Below mentioned macros are removed: SCAN_DONE SCAN_EVENT_DONE_ABORTED WILC_WFI_RX_INTR WILC_WFI_TX_INTR WILC_WFI_TIMEOUT WILC_WFI_DWELL_PASSIVE WILC_WFI_DWELL_ACTIVE MAX_SURVEY_RESULT_FRAG_SIZE SURVEY_RESULT_LENGTH

[PATCH 04/22] staging: wilc1000: remove inner block {} and resetting of mode variable

Cleanup fixes to remove the uncessary inner block { /* */ } and setting of 'mode' variable. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 43 +++ 1 file changed, 20 insertions(+), 23 deletions(-) diff --git

[PATCH 14/22] staging: wilc1000: remove the use of goto label in spi_cmd_complete()

In spi_cmd_complete() remove the use of goto label '_error_'. Changes were done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 13/22] staging: wilc1000: remove multiple define for mac connect and disconnect

Cleanup patch to have commonly used macro in common header file to avoid same defination in mulitple file. Removed MAC_CONNECTED & MAC_DISCONNECTED macro from coreconfigurator.h header. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/coreconfigurator.h | 3 ---

[PATCH 15/22] staging: wilc1000: remove the use of goto label in wilc_spi_read_size()

In wilc_spi_read_size() remove the use of goto label '_fail_'. Changes are done to avoid the use of '_' in label name. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 08/22] staging: wilc1000: fix line over 80 chars in change_station()

Fix 'line over 80 chars' issue found by checkpatch.pl script. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c

[PATCH 01/22] staging: wilc1000: rename WILC_WFI_wep_key & WILC_WFI_wep_key_len

Cleanup patch to use lower case for variable name as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 30 +++ drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 +-- 2 files changed, 17

[PATCH 02/22] staging: wilc1000: rename variable using datatype in their name in add_key()

Cleanup changes to use variable name as per linux coding style. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 32 +++ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH 00/22] staging: wilc1000: cleanup patches to follow linux coding style

This patch series is based on top of "[PATCH 00/11] staging: wilc1000: fix for checkpatch and handled malloc memory properly" and its not applied yet.[1] In this series contains fixes to avoid the checkpatch reported issue. Also remove the multiple #define for same macros and changes to follow

Re: [PATCH] mt76x2: fix is_mt7612 routine

On 2018-04-18 00:27, Lorenzo Bianconi wrote: > Fix is_mt7612 routine since asic version is set in mt76_dev revision > field and not in mt76x2_dev one. > Moreover remove mt76x2_dev rev field since it is never used in the > driver > > Fixes: 7bc04215a66b ('mt76: add driver code for MT76x2e') >

[RESEND][PATCH 1/4] NFC: st21nfca: Fix out of bounds kernel access when handling ATR_REQ

From: Suren Baghdasaryan Out of bounds kernel accesses in st21nfca's NFC HCI layer might happen when handling ATR_REQ events if user-specified atr_req->length is bigger than the buffer size. In that case memcpy() inside st21nfca_tm_send_atr_res() will read extra bytes

[RESEND][PATCH 3/4] NFC: Fix possible memory corruption when handling SHDLC I-Frame commands

From: Suren Baghdasaryan When handling SHDLC I-Frame commands "pipe" field used for indexing into an array should be checked before usage. If left unchecked it might access memory outside of the array of size NFC_HCI_MAX_PIPES(127). Signed-off-by: Suren Baghdasaryan

[RESEND][PATCH 4/4] NFC: fdp: Fix possible buffer overflow in WCS4000 NFC driver

From: Suren Baghdasaryan Possible buffer overflow when reading next_read_size bytes into tmp buffer after next_read_size was extracted from a previous packet. Signed-off-by: Suren Baghdasaryan Signed-off-by: Amit Pundir ---

[RESEND][PATCH 2/4] NFC: st21nfca: Fix memory OOB and leak issues in connectivity events handler

From: Suren Baghdasaryan Overflow on memcpy is possible in kernel driver for st21nfca's NFC HCI layer when handling connectivity events if aid_len or params_len are bigger than the buffer size. Memory leak is possible when parameter tag is invalid. Signed-off-by: Suren

[RESEND][PATCH 0/4] Few NFC fixes from android-4.14 tree

Hi, Resending few NFC fixes I picked up from android-4.14 tree[1] for review and comments. They seem reasonable upstream candidates. My last attempt was not timed properly and it got lost between Christmas-New Year break and then Meltdown-Spectre happened. Also like to point out that I have not

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

> > > Is there a problem with the "supported commands" list? > > My understanding is that in general the "supported commands" list is not > well-maintained. Not every nl80211 command is represented in the list so > user-space can not know whether it is missing or not supported. > For this

Re: iwlwifi 4.18rc1 SYNC TIME_QUOTA_CMD with fw 31

On Wed, Apr 18, 2018 at 5:47 AM, Scott Register wrote: > > Hello, > > After upgrading to 4.18rc1 iwlwifi is printing a FW error. There was a > previous thread with a similar > issue but they seemed to resolve it with a ucode update. I think I'm > running a newer FW and > am still

Re: [PATCH 2/2] ath10k: support MAC address randomization in scan

+ Johannes (to confirm/correct my understanding regarding "supported commands") On 4/18/2018 4:35 AM, Dan Williams wrote: On Tue, 2018-04-17 at 15:26 -0700, Brian Norris wrote: On Tue, Apr 17, 2018 at 2:49 PM, Arend van Spriel wrote: On 4/17/2018 6:07 PM, Brian

Re: [PATCH v2 4/4] ath10k: Enable sta idle power save

from my point of view powersave should be optional and not forced. consider : iw dev set power_save on/off so there is already a config option made for that purpose, Sebastian Am 17.04.2018 um 14:07 schrieb pill...@codeaurora.org: From: Govind Singh Enable sta