Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On 2018-05-01 05:14, Sriram R wrote: On 2018-05-01 00:39, Greg KH wrote: On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote: Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done on host (mac80211) rather than firmware.

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On 2018-05-01 00:39, Greg KH wrote: On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote: Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done on host (mac80211) rather than firmware. Rebuild cipher header in every received

Re: [PATCH v7] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

+    /* only 4x4 configuration do support 2x2 for VHT160, everything else must use 1x1 */ +    if (ar->cfg_rx_chainmask == 15) +    nss160 = arg->peer_num_spatial_streams <= 2 ? arg->peer_num_spatial_streams : 2; If peer nss == 3, then nss160 must be 1x1.  That is why I previously

Possible Regression in Wireless Driver Affecting Intel Corporation Wireless 7265 (rev 59)

Two recent kernel upgrades seem to have both affected the Intel Corporation Wireless 7265 (rev 59) adapters on our systems in a manner which causes their network transfer rates to be reduced dramatically. File transfers which normally require a few minutes are now taking several hours. These

Re: [PATCH 2/2] cfg80211: Modify wiphy registration semantics for self managed hints

hi Johannes, replies inline: On 2018-04-19 08:07, Johannes Berg wrote: On Fri, 2018-04-13 at 13:32 -0700, asing...@codeaurora.org wrote: hi Johannes, please fine some replies inline: On 2018-03-21 03:15, Johannes Berg wrote: > So I really think this should just be one

Re: [PATCH v7] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

On 04/30/2018 02:30 PM, s.gottsch...@dd-wrt.com wrote: From: Sebastian Gottschall current handling of peer_bw_rxnss_override parameter is based on guessing the VHT160/8080 capability by rx rate. this is wrong and may lead to a non initialized peer_bw_rxnss_override

[PATCH v7] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter

From: Sebastian Gottschall current handling of peer_bw_rxnss_override parameter is based on guessing the VHT160/8080 capability by rx rate. this is wrong and may lead to a non initialized peer_bw_rxnss_override parameter which is required since VHT160 operation mode

Proposal

Hello Greetings to you today i asked before but i did't get a response please i know this might come to you as a surprise because you do not know me personally i have a business proposal for our mutual benefit please let me know if you are interested. Best Regards, Esentepe Mahallesi

Re: [PATCH 2/2] ath10k: DFS Host Confirmation

On 04/30/2018 10:45 AM, Sriram R wrote: In the 10.4-3.6 firmware branch there's a new DFS Host confirmation feature which is advertised using WMI_SERVICE_HOST_DFS_CHECK_SUPPORT flag. This new features enables the ath10k host to send information to the firmware on the specifications of

Re: [PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On Mon, Apr 30, 2018 at 11:56:27AM +0530, Sriram R wrote: > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > on host (mac80211) rather than firmware. Rebuild cipher header > in every received data frames (that are notified

Re: [PATCH 1/2] ath: Add support to get the detected radar specifications

On 04/30/2018 10:45 AM, Sriram R wrote: This enables ath10k/ath9k drivers to collect the specifications of the radar type once it is detected by the dfs pattern detector unit. Usage of the collected info is specific to driver implementation. For example, collected radar info could be used by

Re: [PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

On Mon, Apr 30, 2018 at 11:56:25AM +0530, Sriram R wrote: > ath10k has a replay detection issue which was fixed in v4.14 and we would > like to get this security fix also to linux-stable-4.4.But for that it > depends on 3 mac80211 patches so the below mac80211 commits needs to be > picked first in

[PATCH 2/2] ath10k: DFS Host Confirmation

In the 10.4-3.6 firmware branch there's a new DFS Host confirmation feature which is advertised using WMI_SERVICE_HOST_DFS_CHECK_SUPPORT flag. This new features enables the ath10k host to send information to the firmware on the specifications of detected radar type. This allows the firmware to

[PATCH 0/2] ath/ath10k: DFS Host Confirmation

This feature adds support for the ath10k host to send information about the specifications of the detected radar to the firmware for validation. A New WMI interface is added for enabling this communication of this information between the host and the firmware. Sriram R (2): ath: Add support to

[PATCH 1/2] ath: Add support to get the detected radar specifications

This enables ath10k/ath9k drivers to collect the specifications of the radar type once it is detected by the dfs pattern detector unit. Usage of the collected info is specific to driver implementation. For example, collected radar info could be used by the host driver to send to co-processors for

Re: [PATCH] staging: wilc1000: fix infinite loop and out-of-bounds access

On Mon, Apr 30, 2018 at 07:59:16PM +0530, Ajay Singh wrote: > Reviewed-by: Ajay Singh > > On Mon, 30 Apr 2018 07:50:40 -0500 > "Gustavo A. R. Silva" wrote: > > > If i < slot_id is initially true then it will remain true. Also, > > as i is

Re: [PATCH] staging: wilc1000: fix infinite loop and out-of-bounds access

Reviewed-by: Ajay Singh On Mon, 30 Apr 2018 07:50:40 -0500 "Gustavo A. R. Silva" wrote: > If i < slot_id is initially true then it will remain true. Also, > as i is being decremented it will end up accessing memory out of > bounds. > > Fix

[RFC 10/18] mt76: introduce mt76x2-common module

In order to remove usb dependency from pcie code, add mt76x2-common as a container of shared code between mt76x2 and mt76x2u. Add eeprom code to mt76x2-common module Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Kconfig | 4

[RFC 15/18] mt76: add mt76x2_phy_common to mt76x2-common module

Move phy related code shared between mt76x2 and mt76x2u in mt76x2-common module Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile| 2 +- drivers/net/wireless/mediatek/mt76/mt76x2.h| 8 +

[RFC 05/18] mt76x2: move currently mt76x2u unsupported features to mt76x2_init

Move currently mt76x2u hw unsupported features to mt76x2_init in order to reuse mt76_register_device routine supporting mt76x2u based chipsets Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mac80211.c| 15 ---

[RFC 16/18] mt76: move mt76x2_debugfs in mt76-common module

Move mt76x2_debugfs code in mt76-common module since it is shared between mt76x2 and mt76x2u Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile | 5 +++-- drivers/net/wireless/mediatek/mt76/mt76x2_debugfs.c | 1 + 2 files

[RFC 18/18] mt76: add driver code for MT76x2u based devices

MT76x2u is a 2x2 USB 802.11ac chipset by MediaTek. This driver currently support station mode. Frequency calibration is currently not supported Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Kconfig| 9 +

[RFC 17/18] mt76: add usb suppor to mt76 layer

This will be used by drivers for MT76x2u based devices Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile | 3 +- drivers/net/wireless/mediatek/mt76/dma.h| 5 + drivers/net/wireless/mediatek/mt76/mt76.h | 114 +-

[RFC 04/18] mt76x2: introduce mt76x2_init_device routine

Add mt76x2_init_device routine in order to reuse common pcie/usb mac80211 initialization code supporting mt76x2u based device Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2.h | 1 +

[RFC 01/18] mt76x2: use completion instead of wait_queue for mcu rx queue

In order to reuse mcu related code supporting mt76x2u based devices, use completion instead of wait_queue for mcu responses queue Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2.h | 2 +-

[RFC 00/18] add mt76x2u support to mt76 driver

Add usb layer to mt76 driver in order to support mt76x2u based devices. Move common code between pci and usb in mt76x2-common module in order to remove pci dependency from usb driver Lorenzo Bianconi (18): mt76x2: use completion instead of wait_queue for mcu rx queue mt76x2: move

[RFC 07/18] mt76x2: add napi struct to mt76_rx_poll_complete/mt76_rx_complete signatures

in order to reuse mt76_rx_complete routine supporting mt76x2u based devices add napi struct to mt76_rx_poll_complete and mt76_rx_complete routine signatures and do not fetch it according to the rx queue index Signed-off-by: Lorenzo Bianconi ---

[RFC 12/18] mt76: add mt76x2_mac_common to mt76x2-common module

Move mac related code shared between mt76x2 and mt76x2u in mt76x2-common module Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile| 2 +- drivers/net/wireless/mediatek/mt76/mt76x2.h| 6 +-

[RFC 09/18] mt76: introduce tx_queue_skb function pointer in mt76_bus_ops

Add tx_queue_skb function pointer in mt76_bus_ops since mt76x2u based devices do not map mt76x2_txwi on dma buffers and it is not possible to reuse mt76_tx_queue_skb() routine to enqueue tx frames to hw buffers Signed-off-by: Lorenzo Bianconi ---

[RFC 11/18] mt76: add mt76x2_tx_common to mt76x2-common module

Move tx related code shared between mt76x2 and mt76x2u in mt76x2-common module Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile| 2 +- drivers/net/wireless/mediatek/mt76/mt76x2.h| 2 +

[RFC 14/18] mt76: add mt76x2_common to mt76x2-common module

Move core related code shared between mt76x2 and mt76x2u in mt76x2-common module Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile| 2 +- drivers/net/wireless/mediatek/mt76/mt76x2.h| 21 ++

[RFC 02/18] mt76x2: move mt76x2_fw_header and mt76x2_patch_header definitions in mcu.h

move mt76x2_fw_header and mt76x2_patch_header definitions in mcu.h in order to reuse them in mt76x2u mcu related code Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2_mcu.c | 17 -

[RFC 13/18] mt76: add mt76x2_init_common to mt76x2-common module

Move init related code shared between mt76x2 and mt76x2u in mt76x2-common module Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/Makefile| 3 +- drivers/net/wireless/mediatek/mt76/mt76x2.h| 6 +

[RFC 03/18] mt76x2: move utility routines in mt76x2.h

In order to reuse them supporting mt76x2u based devices, move mt76x2_wait_for_mac, wait_for_wpdma and mt76x2_channel_silent in mt76x2.h Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2.h | 40

[RFC 06/18] mt76x2: introduce mt76x2_mac_load_tx_status routine

Add mt76x2_mac_load_tx_status routine since tx stats register map is shared between usb and pci based devices but usb devices do not have a tx stat irq line as pcie ones and it is necessary to load tx statistics using a workqueue Signed-off-by: Lorenzo Bianconi ---

[RFC 08/18] mt76x2: add buffer len to mt76x2_mac_write_txwi signature

Add frame length to mt76x2_mac_write_txwi routine signature and do not fetch it from skb since txwi data structure is added at the beginning of the skb for usb based devices and mt76x2_mac_write_txwi will be shared between pci and usb related code Signed-off-by: Lorenzo Bianconi

[PATCH] rtlwifi: fix spelling mistake: "dismatch" -> "mismatch"

From: Colin Ian King Trivial fix to spelling mistake in RT_TRACE message text. Signed-off-by: Colin Ian King --- .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8192e2ant.c| 2 +-

[PATCH 1/2] rt2x00: call sta_add/remove directly in rt2800

Only rt2800 subdriver of rt2x00 implement sta_add() and sta_remove(), we do not need generic version of those. Signed-off-by: Stanislaw Gruszka --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 11 +++ drivers/net/wireless/ralink/rt2x00/rt2800lib.h | 5 +++--

[PATCH 2/2] rt2x00: check against flushing empty queue

We have check if queue is not empty when start flushing queues on by mac80211 callback, but we also can start flushing queues by internal driver calls. So move check into rt2x00queue_flush_queue() to assure we do not flush empty queue anytime. Additionally add warning if we start to kick empty

[PATCH] staging: wilc1000: fix infinite loop and out-of-bounds access

If i < slot_id is initially true then it will remain true. Also, as i is being decremented it will end up accessing memory out of bounds. Fix this by incrementing *i* instead of decrementing it. Addresses-Coverity-ID: 1468454 ("Infinite loop") Fixes: faa657641081 ("staging: wilc1000: refactor

Re: [wireless-drivers-next:master 62/66] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:2740:49: sparse: Using plain integer as NULL pointer

(adding linux-wireless) kbuild test robot writes: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git > master > head: f56324baf329bc9362a52ad77a4a1a0f3356d1bc > commit: 7742fce4c007141617dab9bcb90034b3c0fe2347 [62/66] brcmfmac:

Re: [3/6] brcmfmac: use nl80211_band directly to get ieee80211 channel

Arend Van Spriel wrote: > From: Franky Lin > > The enum nl80211_band used to retrieve wiphy->bands is the same as > wiphy->bands->band which is checked by wiphy_register(). So it can be used > directly as parameter of

Re: [2/6] brcmfmac: reports boottime_ns while informing bss

Arend Van Spriel wrote: > From: Franky Lin > > Provides a timestamp in bss information so user space can see when the > bss info was updated. Since tsf is not available from the dongle events > boottime is reported instead. > >

Re: [1/6] brcmfmac: check p2pdev mac address uniqueness

Arend Van Spriel wrote: > The mac address for p2pdev must be different from the primary interface > due to firmware requirement. Add an explicit check for this requirement > if user-space provides a mac address. > > Reviewed-by: Hante Meuleman

Re: [PATCH v4 1/2] dma-mapping: move dma configuration to bus infrastructure

On Sat, Apr 28, 2018 at 08:21:58AM +0530, Nipun Gupta wrote: [...] > diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c > index 88a3558..a9ec99d 100644 > --- a/drivers/gpu/host1x/bus.c > +++ b/drivers/gpu/host1x/bus.c > @@ -314,6 +314,13 @@ static int host1x_device_match(struct

Re: ipw2100: fix spelling mistake: "decsribed" -> "described"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in comment and in the ord_data text > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks.

Re: rt2x00: fix spelling mistake in various macros, UKNOWN -> UNKNOWN

Colin Ian King wrote: > From: Colin Ian King > > Rename several macros that contain mispellings of UNKNOWN > > Signed-off-by: Colin Ian King > Acked-by: Stanislaw Gruszka Patch applied to

Re: rsi_91x: fix uninitialized variable

"Gustavo A. R. Silva" wrote: > There is a potential execution path in which variable ret is returned > without being properly initialized previously. > > Fix this by storing the value returned by function > rsi_usb_master_reg_write into _ret_. > > Addresses-Coverity-ID:

Re: rsi_91x: fix structurally dead code

"Gustavo A. R. Silva" wrote: > Function rsi_hal_key_config returns before reaching code at line > 922 if (status), hence this code is structurally dead. > > Fix this by storing the value returned by rsi_hal_load_key > into _status_ for its further evaluation and use. >

Re: [v2] wlcore: sdio: allow pm to handle sdio power

Eyal Reizer wrote: > pm_runtime handles sdio power on and power off transitions. > An old workaround for trying to control the power explicitly from the > driver was in fact causing failures on suspend/resume as the mmc layer > already power the module on resume. > > In

Re: qtnfmac: fix qtnf_netdev_hard_start_xmit()'s return type

Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

Jia-Ju Bai wrote: > dma_tx_fragment() is never called in atomic context. > > dma_tx_fragment() is only called by b43legacy_dma_tx(), which is > only called by b43legacy_tx_work(). > b43legacy_tx_work() is only set a parameter of INIT_WORK() in >

Re: mwifiex: fix spelling mistake: "capabilties" -> "capabilities"

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in function names and text strings > > Signed-off-by: Colin Ian King Failed to apply: error: patch failed:

Re: [1/3] mwifiex: make firmware mac address consistent with host configuration

Xinming Hu wrote: > For user configurated mac address, directly set to firmware with no change. > > Signed-off-by: Xinming Hu 3 patches applied to wireless-drivers-next.git, thanks. 307857db47eb mwifiex: make firmware mac address consistent with host

Re: mwifiex: fix mwifiex_hard_start_xmit()'s return type

Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > >

Re: [1/4] mt76: fix concurrent rx calls on A-MPDU release

Felix Fietkau wrote: > Add a spinlock in mt76_rx_complete. Without this, multiple stats updates > could happen in parallel, which can lead to deadlocks. There are > probably more corner cases fixed by this change. > > Signed-off-by: Felix Fietkau 4 patches

Re: mt76x2: fix is_mt7612 routine

Lorenzo Bianconi wrote: > Fix is_mt7612 routine since asic version is set in mt76_dev revision > field and not in mt76x2_dev one. > Moreover remove mt76x2_dev rev field since it is never used in the > driver > > Fixes: 7bc04215a66b ('mt76: add driver code for

Re: pull-request: iwlwifi-next 2018-04-26

Luca Coelho writes: > This is the second batch of patches intended for v4.18. Nothing major > here, just the usual continued development, bugfixes, new FW APIs and > some new features. More details about the contents in the tag > description. > > I have sent this out before and

Re: [PATCH v3 00/19] rtlwifi: halmac: Add new module halmac

On Mon, Apr 30, 2018 at 8:10 AM, Pkshih wrote: > > > > -Original Message- > > From: Barry Day [mailto:brise...@gmail.com] > > Sent: Saturday, April 28, 2018 6:42 AM > > To: Pkshih > > Cc: Kalle Valo; larry.fin...@lwfinger.net; linux-wireless@vger.kernel.org > >

[PATCH 2/2 - linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done on host (mac80211) rather than firmware. Rebuild cipher header in every received data frames (that are notified through those HTT interfaces) from the rx_hdr_status tlv available

[PATCH 0/2 linux-stable-4.4] ath10k: rebuild crypto header in rx data frames

ath10k has a replay detection issue which was fixed in v4.14 and we would like to get this security fix also to linux-stable-4.4.But for that it depends on 3 mac80211 patches so the below mac80211 commits needs to be picked first in the same order and then apply this patchset. f980ebc058c2 :

[PATCH 1/2 linux-stable-4.4] ath10k: Add new hw param to identify alignment for different chipsets

Chipset QCA99X0 doesnot have rx_hdr_status padded to align in 4-byte boundary.Hence define a new hw_params field to handle different alignment behaviour between different chipsets. [Upstream commit : 2f38c3c01de945234d23dd163e3528ccb413066d] Signed-off-by: Vasanthkumar Thiagarajan