Re: [v3] b43: fix transmit failure when VT is switched

2018-05-14 Thread Kalle Valo
k...@sra-tohoku.co.jp wrote: > From: Taketo Kabe > > Setup: > Using BCM4306 rev.03 chip based CardBus wireless card. > IRQ is shared with yenta (cardbus bridge) and i915 (display) driver. > For firmware, installed latest but dated openfwwf 5.2 > (http://netweb.ing.unibs.it/~openfwwf/) > > How-t

Re: [1/3] rsi: Add null check for virtual interfaces in wowlan config

2018-05-14 Thread Kalle Valo
Sushant Kumar Mishra wrote: > From: Sanjay Kumar Konduri > > When the "poweroff" command is executed after wowlan enabled, we have > observed a system crash. In the system "poweroff" sequence, network-manager > is sent to inactive state by cleaning up the network interfaces, using > rsi_mac8021

Re: brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag

2018-05-14 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > brcmfmac is a FullMAC driver and it implements/uses cfg80211 interface > for stations management. At the same time it doesn't receive or pass up > management frames. > > This flag indicates that authenticator doesn't have to subscribe to or > handl

[RFC 2/2] mac80211: Add support for per-rate rx statistics

2018-05-14 Thread Sriram R
This patch adds support for the mac80211 to collect rx statistics (Packet count and total bytes received) per-rate, per-station when enabled by a user space application. Note that the rate field passed on to the userspace from mac80211 is an encoded value where different rate attributes such as ty

[RFC 1/2] nl80211: Add support for collection of per rate rx statistics

2018-05-14 Thread Sriram R
RX Statistics per rate, per station can be useful in understanding the quality of communication with our peers and can be helpful in evaluating the consistency at which a specific peer has been communicating in different MCS/BW/NSS after association at different time periods and in varied environme

[RFC 0/2] nl80211/mac80211 Add support for per-rate rx statistics

2018-05-14 Thread Sriram R
This patchset adds support for the collection and propagating of per-rate, per-station rx statistics when enabled by a userspace application. These statistics can be useful in understanding the quality of communication with our peers and in evaluating how different peers are communicating in diff

Re: [PATCH 2/2] ath10k: DFS Host Confirmation

2018-05-14 Thread Kalle Valo
Adrian Chadd writes: > On Mon, 14 May 2018 at 11:25, Kalle Valo wrote: > >> Adrian Chadd writes: > >> > May we have a little more information about how this is supposed to > work? >> > >> > It looks like we're supposed to send the information about the matched >> > radar pattern back to the fir

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-14 Thread Luis R. Rodriguez
On Mon, May 14, 2018 at 10:02:31PM -0400, Mimi Zohar wrote: > On Mon, 2018-05-14 at 19:28 +, Luis R. Rodriguez wrote: > > > - CONFIG_IMA_APPRAISE is not fine enough grained. > > > > > > The CONFIG_IMA_APPRAISE_FIRMWARE will be a Kconfig option.  Similar > > > Kconfig options will require kerne

[PATCH] cfg80211: further limit wiphy names to 64 bytes

2018-05-14 Thread Eric Biggers
From: Eric Biggers wiphy names were recently limited to 128 bytes by commit a7cfebcb7594 ("cfg80211: limit wiphy names to 128 bytes"). As it turns out though, this isn't sufficient because dev_vprintk_emit() needs the syslog header string "SUBSYSTEM=ieee80211\0DEVICE=+ieee80211:$devname" to fit

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-14 Thread Mimi Zohar
On Mon, 2018-05-14 at 19:28 +, Luis R. Rodriguez wrote: [...] > > At runtime, in the case > > that regdb is enabled and a custom policy requires IMA-appraisal > > firmware signature verification, then both signature verification > > methods will verify the signatures.  If either fails, then

[PATCH] mac80211: TX aggregation stop race can break TX

2018-05-14 Thread Alexander Wetzel
The mac80211 tear down code is not waiting for the driver call back. This can bring down the the TX path (TID) till the user manually reconnects. (Observed with iwldvm and enabled TX aggregation.) The race can be prevented when the ampdu_mlme worker handles the tear down. The race: * ieee80211_s

Re: [PATCH 2/2] ath10k: DFS Host Confirmation

2018-05-14 Thread Adrian Chadd
On Mon, 14 May 2018 at 11:25, Kalle Valo wrote: > Adrian Chadd writes: > > May we have a little more information about how this is supposed to work? > > > > It looks like we're supposed to send the information about the matched > > radar pattern back to the firmware for confirmation? What's the

Re: [PATCH 2/2] ath10k: DFS Host Confirmation

2018-05-14 Thread Peter Oh
Which regulatory enforcement are you talking to? Are you talking about such "prevent users from changing regulatory domain" or "don't provide a manner to change regulatory domain or channel list" ? If not, can you share the section of document? Sorry, I don't have any references about that. Th

Linux Plumbers Networking Track CFP

2018-05-14 Thread David Miller
Linux Plumbers Networking Track CFP This is a call for proposals for the networking track at the 2018 edition of the Linux Plumbers Conference which will be held in Vancouver on November 13th and November 14th. The LPC Networking Track is a community event, open to everyone, and does not require

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-14 Thread Luis R. Rodriguez
On Mon, May 14, 2018 at 08:58:12AM -0400, Mimi Zohar wrote: > On Fri, 2018-05-11 at 21:52 +, Luis R. Rodriguez wrote: > > diff --git a/drivers/base/firmware_loader/main.c > > b/drivers/base/firmware_loader/main.c > > index eb34089e4299..d7cdf04a8681 100644 > > --- a/drivers/base/firmware_loade

Re: Regression: bcm4312 lp-phy device not working in 4.17-rc5 kernel

2018-05-14 Thread Chris Vine
On Mon, 14 May 2018 20:02:05 +0200 Michael Büsch wrote: > On Mon, 14 May 2018 19:55:39 +0200 > Michael Büsch wrote: > > > On Mon, 14 May 2018 18:49:53 +0100 > > Chris Vine wrote: > > > > > I have an old netbook with a Broadcom bcm4312 802.11b/g lp-phy > > > [14e4:4315] (rev 01) wifi device. T

Re: [PATCH 2/2] ath10k: DFS Host Confirmation

2018-05-14 Thread Kalle Valo
Adrian Chadd writes: > May we have a little more information about how this is supposed to work? > > It looks like we're supposed to send the information about the matched > radar pattern back to the firmware for confirmation? What's the intended > behaviour from the firmware? Will the firmware h

Re: [PATCH 2/2] ath10k: DFS Host Confirmation

2018-05-14 Thread Kalle Valo
Peter Oh writes: > On 05/02/2018 04:27 AM, Kalle Valo wrote: >> Peter Oh writes: >> >>> On 04/30/2018 10:45 AM, Sriram R wrote: In the 10.4-3.6 firmware branch there's a new DFS Host confirmation feature which is advertised using WMI_SERVICE_HOST_DFS_CHECK_SUPPORT flag. This

Re: Regression: bcm4312 lp-phy device not working in 4.17-rc5 kernel

2018-05-14 Thread Michael Büsch
On Mon, 14 May 2018 19:55:39 +0200 Michael Büsch wrote: > On Mon, 14 May 2018 18:49:53 +0100 > Chris Vine wrote: > > > I have an old netbook with a Broadcom bcm4312 802.11b/g lp-phy > > [14e4:4315] (rev 01) wifi device. This works up to and including the > > 4.16 kernel, but not with 4.17-rc5.

Re: Regression: bcm4312 lp-phy device not working in 4.17-rc5 kernel

2018-05-14 Thread Michael Büsch
On Mon, 14 May 2018 18:49:53 +0100 Chris Vine wrote: > I have an old netbook with a Broadcom bcm4312 802.11b/g lp-phy > [14e4:4315] (rev 01) wifi device. This works up to and including the > 4.16 kernel, but not with 4.17-rc5. > > The b43, mac80211, cfg80211, ssb and mmc_core modules are loaded

Regression: bcm4312 lp-phy device not working in 4.17-rc5 kernel

2018-05-14 Thread Chris Vine
I have an old netbook with a Broadcom bcm4312 802.11b/g lp-phy [14e4:4315] (rev 01) wifi device. This works up to and including the 4.16 kernel, but not with 4.17-rc5. The b43, mac80211, cfg80211, ssb and mmc_core modules are loaded OK, as is the firmware, and the wlan0 interface will come up, bu

[PATCH v2 3/3] ath10k: Support survey dump for ath10k-ct 10.1 firmware.

2018-05-14 Thread greearb
From: Ben Greear Recent ath10k-ct 10.1 firmware supports survey results, and advertises the appropriate service flags. This confuses the ath10k driver because the 10.1 wmi commands are not set up for survey information. So, this patch adds support for handling survey information. Example outpu

[PATCH v2 1/3] ath10k: Add ath10k-ct firmware feature flags and descriptions.

2018-05-14 Thread greearb
From: Ben Greear These feature flags are used by ath10k-ct firmware. Add these so we can use them in future patches and so there are no warnings about feature flags on loading ath10k-ct firmware. Signed-off-by: Ben Greear --- v2: Fix warings typo in description. drivers/net/wireless/ath/ath

[PATCH v2 2/3] ath10k: Don't try un-supported idle_ps_config command.

2018-05-14 Thread greearb
From: Ben Greear The warning the the logs does not give user a clue as to what command is failing, so it is worth it to check for un-supported command before trying the call. And add return-code to survey error message. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 14

Re: [PATCH 1/2] ath: Add support to get the detected radar specifications

2018-05-14 Thread Kalle Valo
Peter Oh writes: > On 04/30/2018 10:45 AM, Sriram R wrote: >> This enables ath10k/ath9k drivers to collect the specifications of the >> radar type once it is detected by the dfs pattern detector unit. >> Usage of the collected info is specific to driver implementation. >> For example, collected r

Re: [PATCH 07/12] ath10k: Add MSA handshake QMI mgs support

2018-05-14 Thread Govind Singh
Hi Bjorn, Thanks for the review. On 2018-05-12 00:13, Bjorn Andersson wrote: On Sun 25 Mar 22:40 PDT 2018, Govind Singh wrote: HOST allocates 2mb of region for modem and WCN3990 secure access and provides the address and access control to target for secure access. Add MSA handshake request/re

Re: [wireless-drivers-next:master] BUILD REGRESSION b41c393676696c20456d5fd8cbe71453560ee06e

2018-05-14 Thread Kalle Valo
kbuild test robot writes: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git > master > branch HEAD: b41c393676696c20456d5fd8cbe71453560ee06e rsi: fix > spelling mistake: "thead" -> "thread" > > Regressions in current branch: > > drivers/net/wireless/

Re: [PATCH v3 00/12] *** Add support for wifi QMI client driver ***

2018-05-14 Thread Kalle Valo
Govind Singh writes: > Add QMI client driver for Q6 integrated WLAN connectivity subsystem. > This module is responsible for communicating WLAN control messages to FW > over QMI interface. > > “QUALCOMM Messaging Interface”(QMI) provides the control interface between > components running b/w remo

Re: [PATCH 04/12] ath10k: add support to start and stop qmi service

2018-05-14 Thread Govind Singh
On 2018-05-11 23:13, Bjorn Andersson wrote: On Sun 25 Mar 22:39 PDT 2018, Govind Singh wrote: Add support to start qmi service to configure the wlan firmware component and register event notifier to communicate with the WLAN firmware over qmi communication interface. Signed-off-by: Govind Sing

Re: [PATCH 01/12] ath10k: Add qmi service for wlan qmi client

2018-05-14 Thread Kalle Valo
Bjorn Andersson writes: >> new file mode 100644 >> index 000..5857c0c >> --- /dev/null >> +++ b/drivers/net/wireless/ath/ath10k/qmi_svc_v01.c >> @@ -0,0 +1,2323 @@ >> +/* >> + * Copyright (c) 2018 The Linux Foundation. All rights reserved. >> + * >> + * Permission to use, copy, modify, and/or

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

2018-05-14 Thread Mimi Zohar
On Fri, 2018-05-11 at 21:52 +, Luis R. Rodriguez wrote: > On Fri, May 11, 2018 at 01:00:26AM -0400, Mimi Zohar wrote: > > On Thu, 2018-05-10 at 23:26 +, Luis R. Rodriguez wrote: > > > On Wed, May 09, 2018 at 10:00:58PM -0400, Mimi Zohar wrote: > > > > On Wed, 2018-05-09 at 23:48 +, Luis

Re: WARNING in dev_vprintk_emit

2018-05-14 Thread Johannes Berg
On Sun, 2018-05-13 at 11:47 -0700, Eric Biggers wrote: > The bug is that mac80211_hwsim allows creating device names that are too long, > via HWSIM_CMD_NEW_RADIO. Commit a7cfebcb7594a2 ("cfg80211: limit wiphy names > to > 128 bytes") limited them to 128 bytes, but it's not enough because > dev_v

Re: [PATCH V3 0/5] Update brcm firmware files

2018-05-14 Thread Josh Boyer
n Mon, May 14, 2018 at 6:11 AM Arend van Spriel < arend.vanspr...@broadcom.com> wrote: > On 3/16/2018 3:08 PM, Chi-Hsien Lin wrote: > > Update brcm firmware files and WHENCE accordingly. > Hi firmware-maintainers, > It seems this series somehow got lost. Can these still be applied. They > can be

Re: [PATCH 03/12] ath10k: Add ath10k QMI client driver

2018-05-14 Thread Govind Singh
Hi Bjorn, Thanks for the review. On 2018-05-11 22:55, Bjorn Andersson wrote: On Sun 25 Mar 22:39 PDT 2018, Govind Singh wrote: Add QMI client driver for Q6 integrated WLAN connectivity subsystem. This module is responsible for communicating WLAN control messages to FW over QUALCOMM MSM Interfa

Re: brcmfmac: Updating Broadcom/Cypress Wifi/BT firmware

2018-05-14 Thread James Hughes
On 14 May 2018 at 10:52, Stefan Wahren wrote: > Hi Arend, > > Am 14.05.2018 um 10:15 schrieb Arend van Spriel: >> >> On 5/2/2018 8:05 PM, Stefan Wahren wrote: >>> >>> Hi, >>> i wanted to know, if there are any plans to update the Broadcom/Cypress >>> firmware under: >>> >>> >>> https://git.kernel.

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

2018-05-14 Thread Ajay Singh
Hi Claudiu, On Mon, 14 May 2018 11:57:24 +0300 Claudiu Beznea wrote: > Hi Ajay, > > On 10.05.2018 08:27, Claudiu Beznea wrote: > > > > > > On 09.05.2018 21:42, Ajay Singh wrote: > >> On Wed, 9 May 2018 16:43:14 +0300 > >> Claudiu Beznea wrote: > >> > >>> On 07.05.2018 11:43, Ajay Singh w

Re: [PATCH V3 0/5] Update brcm firmware files

2018-05-14 Thread Arend van Spriel
On 3/16/2018 3:08 PM, Chi-Hsien Lin wrote: Update brcm firmware files and WHENCE accordingly. Hi firmware-maintainers, It seems this series somehow got lost. Can these still be applied. They can be found in the linux-wireless patchwork database. I provided links below. Regards, Arend ---

Re: brcmfmac: Updating Broadcom/Cypress Wifi/BT firmware

2018-05-14 Thread Stefan Wahren
Hi Arend, Am 14.05.2018 um 10:15 schrieb Arend van Spriel: On 5/2/2018 8:05 PM, Stefan Wahren wrote: Hi, i wanted to know, if there are any plans to update the Broadcom/Cypress firmware under: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git As BCM2835 maintain

Re: [PATCH 14/30] staging: wilc1000: fix line over 80 chars in add_network_to_shadow()

2018-05-14 Thread Claudiu Beznea
Hi Ajay, On 10.05.2018 08:27, Claudiu Beznea wrote: > > > On 09.05.2018 21:42, Ajay Singh wrote: >> On Wed, 9 May 2018 16:43:14 +0300 >> Claudiu Beznea wrote: >> >>> On 07.05.2018 11:43, Ajay Singh wrote: Fix line over 80 characters issue reported by checkpatch in add_network_to_shado

Re: brcmfmac: Updating Broadcom/Cypress Wifi/BT firmware

2018-05-14 Thread Arend van Spriel
On 5/2/2018 8:05 PM, Stefan Wahren wrote: Hi, i wanted to know, if there are any plans to update the Broadcom/Cypress firmware under: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git As BCM2835 maintainer i'm interested in the following files: brcm/brcmfmac43430-sdi

Re: rtl8188eu: link is not ready error on lm816

2018-05-14 Thread Mylène Josserand
Hello Larry, Sorry about the delay, I was on holiday last week. On Sat, 5 May 2018 16:11:13 -0500 Larry Finger wrote: > On 05/04/2018 02:20 PM, Mylène Josserand wrote: > > Hello everyone, > > > > I am currently testing a USB Wifi dongle LM816 [1] on a custom platform > > based on an IMX6. > >

Re: [PATCH] brcmfmac: add debugfs entry for reading firmware capabilities

2018-05-14 Thread Arend van Spriel
On 5/14/2018 7:11 AM, Rafał Miłecki wrote: +/** + * brcmf_cap_read() - expose firmware capabilities to debugfs. Please stick to naming convention brcmf__foo(), ie. brcmf_feat_cap_read(). Will do, thanks! I missed that naming convention because of brcmf_debugfs_fws_stats_read() / brcmf_debugfs