Re: [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro

writes: > From: Ping-Ke Shih > > The format of C2H data is ID(1 byte) + Length(1 byte) + value, and it is > more readable to use macros to access C2H data. > > Signed-off-by: Ping-Ke Shih [...] > --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h > +++

[PATCH 2/2] mwifiex: reserve passive scan time for radar channel

Active scan is not allowed on radar channel, instead using passvie scan with more time. Signed-off-by: Xinming Hu --- drivers/net/wireless/marvell/mwifiex/scan.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c

[PATCH 1/2] mwifiex: increase log level for internal scan fail result

Signed-off-by: Xinming Hu --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index 54a2297..6eba0b2 100644 ---

Re: [PATCH v1] ath10k: fix band_center_freq handling for VHT160 in recent firmwares

On 05/28/2018 10:54 AM, Sebastian Gottschall wrote: Am 28.05.2018 um 16:43 schrieb Ben Greear: On 05/27/2018 03:25 PM, Sebastian Gottschall wrote: Am 25.05.2018 um 16:52 schrieb Ben Greear: On 05/25/2018 07:44 AM, Kalle Valo wrote: Sebastian Gottschall writes: Am 26.04.2018 um

Re: [PATCH 1/2] NFC: st95hf: initialize semaphore and mutex earlier

On Monday, May 28, 2018 04:50 PM, Samuel Ortiz wrote: Hi Daniel, On Mon, May 28, 2018 at 04:35:15PM +0200, Daniel Mack wrote: On Wednesday, May 16, 2018 03:32 PM, Daniel Mack wrote: 'rm_lock' and 'exchange_lock' need to be ready before the IRQ handler has a chance to fire. This fixes the

Re: [PATCH] Revert "rt2800: use TXOP_BACKOFF for probe frames"

Stanislaw Gruszka writes: > This reverts commit fb47ada8dc3c30c8e7b415da155742b49536c61e. > > In some situations when we set TXOP_BACKOFF, the probe frame is > not sent at all. What it worse then sending probe frame as part > of AMPDU and can degrade 11n performance to 11g

Re: [PATCH 3/7] wil6210: initialize TX and RX enhanced DMA rings

On 2018-05-25 15:14, Kalle Valo wrote: Kalle Valo writes: Maya Erez writes: From: Gidon Studinski Enhanced DMA design includes the following rings: - Single RX descriptor ring is used for all VIFs - Multiple RX status

Re: [PATCH] brcmfmac: stop watchdog before detach and free everything

Hi Andy The problem seems really easy to solve: diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index 412a05b..ba60b151 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++

Re: [PATCH] brcmfmac: stop watchdog before detach and free everything

Hi On Mon, May 28, 2018 at 5:25 PM, Andy Shevchenko wrote: > On Mon, May 28, 2018 at 12:54 PM, Michael Nazzareno Trimarchi > wrote: >> Hi Arend >> >> On Mon, May 28, 2018 at 11:51 AM, Arend van Spriel >>

Re: [PATCH] brcmfmac: stop watchdog before detach and free everything

On Mon, May 28, 2018 at 12:54 PM, Michael Nazzareno Trimarchi wrote: > Hi Arend > > On Mon, May 28, 2018 at 11:51 AM, Arend van Spriel > wrote: >> On 5/28/2018 9:50 AM, Michael Trimarchi wrote: >>> >>> Watchdog need to be stopped in

Re: [PATCH 1/2] NFC: st95hf: initialize semaphore and mutex earlier

Hi Daniel, On Mon, May 28, 2018 at 04:35:15PM +0200, Daniel Mack wrote: > On Wednesday, May 16, 2018 03:32 PM, Daniel Mack wrote: > > 'rm_lock' and 'exchange_lock' need to be ready before the IRQ handler has a > > chance to fire. > > > > This fixes the oops below. > > Nobody seems to be

Re: [PATCH 1/2] NFC: st95hf: initialize semaphore and mutex earlier

Hi Daniel, On Mon, May 28, 2018 at 04:35:15PM +0200, Daniel Mack wrote: > On Wednesday, May 16, 2018 03:32 PM, Daniel Mack wrote: > > 'rm_lock' and 'exchange_lock' need to be ready before the IRQ handler has a > > chance to fire. > > > > This fixes the oops below. > > Nobody seems to be

Re: [PATCH v1] ath10k: fix band_center_freq handling for VHT160 in recent firmwares

On 05/27/2018 03:25 PM, Sebastian Gottschall wrote: Am 25.05.2018 um 16:52 schrieb Ben Greear: On 05/25/2018 07:44 AM, Kalle Valo wrote: Sebastian Gottschall writes: Am 26.04.2018 um 15:44 schrieb Ben Greear: On 04/26/2018 02:43 AM, s.gottsch...@dd-wrt.com

Re: [PATCH 1/2] NFC: st95hf: initialize semaphore and mutex earlier

On Wednesday, May 16, 2018 03:32 PM, Daniel Mack wrote: 'rm_lock' and 'exchange_lock' need to be ready before the IRQ handler has a chance to fire. This fixes the oops below. Nobody seems to be interested in these. Davem, can you take them through your tree or is there anyone else I can

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

Hi! On Mon, May 28, 2018 at 02:50:40PM +0200, Stanislaw Gruszka wrote: > I have some updates here. > > ... > Another issue is that sometimes we do not sent rate probe frames, > I posted fix for that (revert of my older change): > https://marc.info/?l=linux-wireless=152750671715369=2 > This

[PATCH 2/5] mac80211: add probe request building flags

From: Johannes Berg Add flags to pass through to probe request building and change the "bool directed" to be one of them. Signed-off-by: Johannes Berg --- net/mac80211/ieee80211_i.h | 12 +--- net/mac80211/mlme.c| 5 +++--

[PATCH 3/5] mac80211: split ieee80211_send_probe_req()

From: Johannes Berg This function is passed many more parameters in the scan case than in the MLME case, and differentiates the two cases inside. Split it up and make both versions static to simplify things. Signed-off-by: Johannes Berg ---

[PATCH 0/5] improved scan privacy

After the random MAC address, we all expected the next level of escalation in the "tracking war". This comes in form of the APs being able to track clients using their sequence numbers and to some extent HT/VHT information which tends to be pretty unique, as evidenced by the fingerprinting the

[PATCH 5/5] mac80211: support scan features for improved scan privacy

From: Johannes Berg Support the new random SN and minimal probe request contents scan flags for the case of software scan - for hardware scan the drivers need to opt in, but may need to do only that, depending on their implementation. Signed-off-by: Johannes Berg

[PATCH 4/5] nl80211: add scan features for improved scan privacy

From: Johannes Berg Add the scan flags for randomized SN and minimized probe request content for improved scan privacy. Signed-off-by: Johannes Berg --- include/uapi/linux/nl80211.h | 15 +++ net/wireless/nl80211.c | 8

[PATCH 1/5] nl80211: refactor common code in scan flags checks

From: Johannes Berg There's a very common pattern to check for a scan flag and then reject it if an extended feature flag isn't set, factor this out into a helper function. Signed-off-by: Johannes Berg --- net/wireless/nl80211.c | 60

[RFCv2 2/2] mac80211: Add support for per-rate rx statistics

This patch adds support for the mac80211 to collect rx statistics (Packet count and total bytes received) per-rate, per-station when subscribed by user space clients. Note that the rate field passed on to the userspace from mac80211 is an encoded value where different rate attributes such as

[RFCv2 0/2] nl80211/mac80211 Add support for per-rate rx statistics

This patchset adds support for the collection and propagating of per-rate, per-station rx statistics when subscribed by userspace applications. These statistics can be useful in understanding the quality of communication with our peers and in evaluating how different peers are communicating in

[RFCv2 1/2] nl80211: support per-rate/per-station statistics

Per-rate/per-station statistics can be desirable to have but they're quite expensive (keeping the four counters for each rate would take close to 4k of memory per station only for VHT MCSes for a moderately capable VHT chip (with 2 spatial streams and 80MHz support) so it's not a good idea to keep

RE: hostapd.config file for ACS Configuration

> -Message d'origine- > De : linux-wireless-ow...@vger.kernel.org > [mailto:linux-wireless-ow...@vger.kernel.org] De la part de > Ahmad Zainudin > Envoyé : lundi 28 mai 2018 04:32 > À : linux-wireless@vger.kernel.org > Objet : hostapd.config file for ACS Configuration > > Hello all, > >

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

I have some updates here. First thing is that printing messages by printk can cause few seconds of cpu hang on my mt7620 hardware, what result on wifi disconnects. I realized that when added debug patch like this: diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index

[PATCH 3/3] wcn36xx: Fix WEP encryption

In case of WEP encryption, driver has to configure shared key for associated station(s). Note that sta pointer is NULL in case of non pairwise key, causing NULL pointer dereference with existing code (sta_priv->is_data_encrypted). Fix this by using associated sta list instead. Signed-off-by: Loic

[PATCH 2/3] wcn36xx: Track associated stations

Add list of associated stations(STA, AP, peer...) per vif. Signed-off-by: Loic Poulain --- drivers/net/wireless/ath/wcn36xx/main.c| 5 + drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 3 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH 1/3] wcn36xx: Fix WEP104 encryption type

Signed-off-by: Loic Poulain --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index aeb5e6e..4648a78 100644 ---

[PATCH] Revert "rt2800: use TXOP_BACKOFF for probe frames"

This reverts commit fb47ada8dc3c30c8e7b415da155742b49536c61e. In some situations when we set TXOP_BACKOFF, the probe frame is not sent at all. What it worse then sending probe frame as part of AMPDU and can degrade 11n performance to 11g rates. Cc: sta...@vger.kernel.org Signed-off-by: Stanislaw

Re: [PATCH 5/7] wil6210: add support for enhanced DMA RX data flows

On 2018-05-25 15:31, Kalle Valo wrote: Maya Erez writes: From: Gidon Studinski Enhanced DMA RX data path is handled using a single RX descriptor ring for all VIFs. Multiple RX status rings are supported, to allow RSS and multi MSI support. The

Re: [PATCH] brcmfmac: stop watchdog before detach and free everything

Hi Arend On Mon, May 28, 2018 at 11:51 AM, Arend van Spriel wrote: > On 5/28/2018 9:50 AM, Michael Trimarchi wrote: >> >> Watchdog need to be stopped in brcmf_sdio_remove to avoid >> i >> The system is going down NOW! >> [ 1348.110759] Unable to handle kernel NULL

Re: [PATCH] brcmfmac: stop watchdog before detach and free everything

On 5/28/2018 9:50 AM, Michael Trimarchi wrote: Watchdog need to be stopped in brcmf_sdio_remove to avoid i The system is going down NOW! [ 1348.110759] Unable to handle kernel NULL pointer dereference at virtual address 02f8 Sent SIGTERM to all processes [ 1348.121412] Mem abort info: [

Re: [RFC 1/3] cfg80211: Add support for HE

On 5/25/2018 9:51 PM, Luca Coelho wrote: Arend, On Fri, 2018-05-25 at 13:11 +0300, Luca Coelho wrote: On Mon, 2018-05-21 at 21:47 +0200, Arend van Spriel wrote: On 5/18/2018 4:05 PM, Luca Coelho wrote: @@ -781,6 +783,23 @@ int wiphy_register(struct wiphy *wiphy)

[PATCH v2] wlcore: sdio: check for valid platform device data before suspend

the wl pointer can be null In case only wlcore_sdio is probed while no WiLink module is successfully probed, as in the case of mounting a wl12xx module while using a device tree file configured with wl18xx related settings. In this case the system was crashing in wl1271_suspend() as platform

RE: [EXTERNAL] Re: [PATCH] wlcore: sdio: check for valid platform device data before suspend

> > the wl pointer can be null In case only wlcore_sdio is probed while > > no WiLink module is successfully probed, as in the case of mounting a > > wl12xx module while using a device tree file configured with wl18xx > > related settings. > > In this case the system was crashing in

Re: [RFC] mac80211: add stop/start logic for software TXQs

On Mon, 2018-05-28 at 12:49 +0530, Manikanta Pubbisetty wrote: > > > > This doesn't seem right, all the logic that clears the TXQ_STOP etc. > > still needs to be invoked, otherwise your TXQ will get stuck completely > > since you'll never run this code again. > > If the queues are blocked more

[PATCH] brcmfmac: stop watchdog before detach and free everything

Watchdog need to be stopped in brcmf_sdio_remove to avoid i The system is going down NOW! [ 1348.110759] Unable to handle kernel NULL pointer dereference at virtual address 02f8 Sent SIGTERM to all processes [ 1348.121412] Mem abort info: [ 1348.126962] ESR = 0x9604 [ 1348.130023]

Re: [RFC] mac80211: add stop/start logic for software TXQs

+++ b/net/mac80211/agg-tx.c @@ -213,11 +213,15 @@ static void ieee80211_agg_start_txq(struct sta_info *sta, int tid, bool enable) { struct ieee80211_txq *txq = sta->sta.txq[tid]; + struct ieee80211_local *local = sta->local; struct txq_info *txqi; if (!txq)