Re: [PATCH] staging: wilc1000: fix compilation warning for ARCH PowerPC

2018-08-02 Thread Ajay Singh
Hi Greg, On Thu, 2 Aug 2018 21:31:16 +0200 Greg KH wrote: > On Thu, Aug 02, 2018 at 04:57:02PM +0530, Ajay Singh wrote: > > Fix below warning reported for PowerPC arch compilation > > > > include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing > > argument 1 of '__swab32s' makes

Re: use-after free bug in hacked 4.16 kernel, related to fq_flow_dequeue

2018-08-02 Thread Toke Høiland-Jørgensen
Ben Greear writes: > On 08/02/2018 12:45 PM, Toke Høiland-Jørgensen wrote: >> Ben Greear writes: >> >>> This is from my hacked kernel, could be my fault. I thought the fq >>> guys might want to know however... >> >> Hmm, nothing obvious comes to mind; fq_flow_dequeue() just dequeues a >> packet

Re: use-after free bug in hacked 4.16 kernel, related to fq_flow_dequeue

2018-08-02 Thread Ben Greear
On 08/02/2018 12:45 PM, Toke Høiland-Jørgensen wrote: Ben Greear writes: This is from my hacked kernel, could be my fault. I thought the fq guys might want to know however... Hmm, nothing obvious comes to mind; fq_flow_dequeue() just dequeues a packet from the queue; it only has two memory

Re: use-after free bug in hacked 4.16 kernel, related to fq_flow_dequeue

2018-08-02 Thread Toke Høiland-Jørgensen
Ben Greear writes: > This is from my hacked kernel, could be my fault. I thought the fq > guys might want to know however... Hmm, nothing obvious comes to mind; fq_flow_dequeue() just dequeues a packet from the queue; it only has two memory derefs, to fq->lock and flow->queue. Don't see why

Re: [PATCH v4 3/3] mac80211: Fix PTK rekey freezes and cleartext leaks

2018-08-02 Thread Alexander Wetzel
>> Rekeying a pairwise key with encryption offload and only keyid 0 had >> multiple races. Two of them could freeze the wlan connection till >> rekeyed again and the third could send out packets in clear which >> should >> have been encrypted. >> >>  1) Freeze caused by

Re: [PATCH] staging: wilc1000: fix compilation warning for ARCH PowerPC

2018-08-02 Thread Greg KH
On Thu, Aug 02, 2018 at 04:57:02PM +0530, Ajay Singh wrote: > Fix below warning reported for PowerPC arch compilation > > include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing > argument 1 of '__swab32s' makes pointer from integer without a cast > [-Wint-conversion] > > Fixes:

Re: [PATCH v2] qtnfmac: implement basic WoWLAN support

2018-08-02 Thread Kalle Valo
Sergey Matyukevich wrote: > This patch implements basic WoWLAN support in qtnfmac driver, including > processing of WoWLAN features reported by firmware and implementation > of cfg80211 suspend/resume/wakeup callbacks. Currently the following > WoWLAN triggers are supported: disconnect, magic

Re: [PATCH v3 01/14] mt76x0: core files

2018-08-02 Thread Kalle Valo
Stanislaw Gruszka wrote: > Core files of mt76x0 driver. > > mt76x0 driver adds support for Mediatek MT7610U based > USB Wi-Fi dongles. > > Signed-off-by: Stanislaw Gruszka 14 patches applied to wireless-drivers-next.git, thanks. 7b4859026ccd mt76x0: core files a77443498137 mt76x0: mac files

Re: [PATCH v2 01/19] mt76: move MT_TXD_INFO, MT_MCU_MSG and MT_RX_FCE_INFO defs in dma.h

2018-08-02 Thread Kalle Valo
Lorenzo Bianconi wrote: > Since MT_TXD_INFO, MT_MCU_MSG and MT_RX_FCE_INFO definitions are in > common between mt76x2u, mt76x2 and mt76x0u move them in dma.h in order > to reuse usb code supporting mt76x2u and mt76x0u based devices > > Signed-off-by: Lorenzo Bianconi 19 patches applied to

Re: pull-request: iwlwifi-next 2018-08-02

2018-08-02 Thread Kalle Valo
Luca Coelho writes: > Hi Kalle, > > This is another batch of patches intended for v4.19. Usual development > work, mostly focused on the new 22560, and some other small fixes and > improvements. More details about the contents in the tag description. > > I have sent this out before and

Re: [PATCH v3 00/14] Add mt76x0 driver

2018-08-02 Thread Kalle Valo
Lorenzo Bianconi writes: > On Aug 01, Stanislaw Gruszka wrote: >> On Wed, Aug 01, 2018 at 10:39:58AM +0300, Kalle Valo wrote: >> > Stanislaw Gruszka writes: >> > >> > > Add mt76x0 driver for MT7610U based USB dongles. Currently driver >> > > support only STA mode. >> > > >> > > mt76x0 is based

Re: [PATCH v3 12/14] mt76: Kconfig and Makefile for mt76x0 driver

2018-08-02 Thread Kalle Valo
Stanislaw Gruszka writes: > On Wed, Aug 01, 2018 at 11:41:33AM +0300, Kalle Valo wrote: >> Stanislaw Gruszka writes: >> >> > On Wed, Aug 01, 2018 at 10:32:12AM +0300, Kalle Valo wrote: >> >> Stanislaw Gruszka writes: >> >> >> >> > Add Kconfig and Makefiles for mt76x0 driver. Now the driver

[PATCH] staging: wilc1000: fix compilation warning for ARCH PowerPC

2018-08-02 Thread Ajay Singh
Fix below warning reported for PowerPC arch compilation include/uapi/linux/byteorder/big_endian.h:95:37: warning: passing argument 1 of '__swab32s' makes pointer from integer without a cast [-Wint-conversion] Fixes: 02211edc9a1f ("staging: wilc1000: fix endianness warnings reported by sparse")

[PATCH v2] qtnfmac: implement basic WoWLAN support

2018-08-02 Thread Sergey Matyukevich
This patch implements basic WoWLAN support in qtnfmac driver, including processing of WoWLAN features reported by firmware and implementation of cfg80211 suspend/resume/wakeup callbacks. Currently the following WoWLAN triggers are supported: disconnect, magic packet, custom pattern packet.

Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

2018-08-02 Thread Ajay Singh
Hi Greg, On Thu, 2 Aug 2018 09:34:54 +0200 Greg KH wrote: > On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote: > > Cleanup patch to fix below checkpatch reported issue: > > -#define ISWILC1000(id) ((id & 0xf000) > > == 0x10 ? 1 : 0) +#define ISWILC1000(id)

Re: [PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file

2018-08-02 Thread Ajay Singh
Hi Greg, On Thu, 2 Aug 2018 09:33:17 +0200 Greg KH wrote: > On Sun, Jul 29, 2018 at 11:36:52AM +0530, Ajay Singh wrote: > > Cleanup patch to remove the unnecessary copyright information in > > the file, as it already has SPDX License Identifier. > > > > diff --git

pull-request: iwlwifi-next 2018-08-02

2018-08-02 Thread Luca Coelho
Hi Kalle, This is another batch of patches intended for v4.19. Usual development work, mostly focused on the new 22560, and some other small fixes and improvements. More details about the contents in the tag description. I have sent this out before and kbuildbot this morning, but I didn't get

Re: [PATCH 8/8] staging: wilc1000: added parentheses in macro to avoid checkpatch issue

2018-08-02 Thread Greg KH
On Sun, Jul 29, 2018 at 11:36:57AM +0530, Ajay Singh wrote: > Cleanup patch to fix below checkpatch reported issue: > > Macro argument 'id' may be better as '(id)' to avoid precedence issues > > Also updated the TODO file to remove the below item > 'rework comments and function headers(also

Re: [PATCH 7/8] staging: wilc1000: replace udelay with usleep_range

2018-08-02 Thread Greg KH
On Sun, Jul 29, 2018 at 11:36:56AM +0530, Ajay Singh wrote: > Cleanup patch to avoid the below checkpatch reported issue. > > "usleep_range is preferred over udelay; see > Documentation/timers/timers-howto.txt". > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 2 +-

Re: [PATCH 3/8] staging: wilc1000: remove unnecessary copyright information in file

2018-08-02 Thread Greg KH
On Sun, Jul 29, 2018 at 11:36:52AM +0530, Ajay Singh wrote: > Cleanup patch to remove the unnecessary copyright information in > the file, as it already has SPDX License Identifier. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_debugfs.c | 10 -- >