Re: feedback on mainlining wilc1000 staging driver

2018-08-16 Thread Ajay Singh
On Thu, 16 Aug 2018 13:53:50 +0300 Kalle Valo wrote: > Kalle Valo writes: > > > Ajay Singh writes: > > > >> Hi Greg, > >> > >> We all are working on submitting and reviewing patches for > >> wilc1000 in staging driver for quite some time. > >> > >> We would like to have feedback on the next

Re: [PATCH v6 2/3] mac80211: Define new driver callback replace_key

2018-08-16 Thread Denis Kenzior
Hi Alexander, Just minor nitpicks: + * @replace_key: Replace an exiting in use key with a new one while guaranteeing + * to not leak clear text packets. Implementing this callback will enable + * mac80211 to announce NL80211_EXT_FEATURE_ATOMIC_KEY_REPLACE. + * Packets already queue

Re: [PATCH v6 1/3] nl80211: Add ATOMIC_KEY_REPLACE API

2018-08-16 Thread Denis Kenzior
Hi Alexander, On 08/14/2018 05:42 AM, Alexander Wetzel wrote: Drivers able to correctly replace a in-use key should set NL80211_EXT_FEATURE_ATOMIC_KEY_REPLACE to allow the userspace (e.g. hostapd or wpa_supplicant) to rekey PTK keys. The userspace must detect a PTK rekey attempt and only go ahe

[PATCH] mac80211: WFA Multi-AP backhaul STA Rx requirement

2018-08-16 Thread Sathishkumar Muruganandam
The current mac80211 WDS (4-address mode) can be used to cover most of the Multi-AP requirements for Data frames per the WFA Multi-AP Specification v1.0. When configuring AP/STA interfaces in 4-address mode, they are able to function as fronthaul AP/backhaul STA of Multi-AP device complying below

Re: [DEBUG PATCH] brcmfmac: add firmware watchdog running on host machine

2018-08-16 Thread Arend van Spriel
On 8/15/2018 8:01 PM, Rafał Miłecki wrote: From: Rafał Miłecki It may happen for FullMAC firmware to crash. It should be detected and ideally somehow handled by a driver. Since commit ff4445a8502c ("brcmfmac: expose device memory to devcoredump subsystem") brcmfmac has BRCMF_E_PSM_WATCHDOG eve

Re: wireless dongle causing entire machine to hang

2018-08-16 Thread Stanislaw Gruszka
On Thu, Aug 16, 2018 at 12:31:07PM +0200, Stanislaw Gruszka wrote: > I prepared a patch that count EPROTO errors and if it's bigger > than 10 mark device as gone. It should not make a problem > when we will get one time random error. I'm attaching it, > please test. Forgot to compile the patch, h

Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...?

2018-08-16 Thread Stanislaw Gruszka
Hello On Thu, Aug 16, 2018 at 12:35:29AM +0200, Daniel Golle wrote: > Clone the master branch of > https://git.openwrt.org/openwrt/staging/dangole.git > and give it shot and let us know the results. Thanks! > > Please also remove: > > 600-23-rt2x00-rt2800mmio-add-a-workaround-for-spurious-TX_F.p

Re: feedback on mainlining wilc1000 staging driver

2018-08-16 Thread Kalle Valo
Kalle Valo writes: > Ajay Singh writes: > >> Hi Greg, >> >> We all are working on submitting and reviewing patches for wilc1000 in >> staging driver for quite some time. >> >> We would like to have feedback on the next steps to bring wilc1000 >> driver closer to move into the wireless subsystem

Re: feedback on mainlining wilc1000 staging driver

2018-08-16 Thread Kalle Valo
Ajay Singh writes: > Hi Greg, > > We all are working on submitting and reviewing patches for wilc1000 in > staging driver for quite some time. > > We would like to have feedback on the next steps to bring wilc1000 > driver closer to move into the wireless subsystem tree. > > In summary, the fol

Re: [DEBUG PATCH] brcmfmac: add firmware watchdog running on host machine

2018-08-16 Thread Kalle Valo
Rafał Miłecki writes: > From: Rafał Miłecki > > It may happen for FullMAC firmware to crash. It should be detected and > ideally somehow handled by a driver. > > Since commit ff4445a8502c ("brcmfmac: expose device memory to > devcoredump subsystem") brcmfmac has BRCMF_E_PSM_WATCHDOG event handle

Re: wireless dongle causing entire machine to hang

2018-08-16 Thread Stanislaw Gruszka
On Wed, Aug 15, 2018 at 10:25:48PM -0600, Randy Oostdyk wrote: > Sorry about the mangled log file! Here's the txt file as an > attachment, hope it's useful. We loop infinitely in rt2x00_rxdone because we can not submit urb. We always get EPROTO error. I think usb host driver should give ENODEV at

Re: feedback on mainlining wilc1000 staging driver

2018-08-16 Thread Ajay Singh
Hi Greg, On Thu, 16 Aug 2018 08:43:54 +0200 Greg KH wrote: > On Thu, Aug 16, 2018 at 01:52:43AM +0530, Ajay Singh wrote: > > Hi Greg, > > > > We all are working on submitting and reviewing patches for wilc1000 > > in staging driver for quite some time. > > > > We would like to have feedback o