On Fri, 24 Aug 2018 11:47:14 +0300
Claudiu Beznea wrote:
>
>
> On 23.08.2018 13:00, Ajay Singh wrote:
> > Unless ndo_set_rx_mode() gets called quickly I don't think there is any
> > issue here.
>
> I don't agree with this.
It would be safer that the mcast list be passed to
On Thu, 23 Aug 2018 11:09:56 +0300
Claudiu Beznea wrote:
>
>
> On 14.08.2018 09:50, Ajay Singh wrote:
> > Avoid use of static variable 'clients_count' and move it part of 'wilc'
> > structure.
> >
> > Signed-off-by: Ajay Singh
> > ---
> > drivers/staging/wilc1000/host_interface.c | 9
Saw this when trying to connect to an 8021x network:
[ 118.464038] wlp2s0: authenticate with a4:2b:8c:82:6b:55
[ 118.466982] wlp2s0: send auth to a4:2b:8c:82:6b:55 (try 1/3)
[ 118.468168] wlp2s0: authenticated
[ 118.469041] wlp2s0: associate with a4:2b:8c:82:6b:55 (try 1/3)
[ 118.476118]
> This is the begin work of integration between mt76x0 and mt76x2.
>
> Further development can be seen here:
> https://github.com/sgruszka/wireless-drivers-next/commits/mt76x0-draft-v2
>
> Stanislaw Gruszka (17):
> mt76: unify wait_for_mac
> mt76: rename mt76x2_regs.h
> mt76: merge
Hello
On Mon, Aug 20, 2018 at 02:20:41PM +0200, Stanislaw Gruszka wrote:
> On Sat, Aug 18, 2018 at 06:08:40PM +0200, Daniel Golle wrote:
> > Still seeing a lot of those
> >
> > Sat Aug 18 16:05:51 2018 kern.err kernel: [ 8364.972151] ieee80211 phy0:
> > rt2x00queue_write_tx_frame: Error -
>
> Lorenzo Bianconi writes:
>
> > Verify if evt field is set to EVT_CMD_DONE in usb mcu
> > response messages
> >
> > Signed-off-by: Lorenzo Bianconi
>
> Does this fix a real bug or is it just a cleanup? To which tree it
> should go?
Ops sorry, I forgot to mention that is a preliminary patch
Lorenzo Bianconi writes:
> Verify if evt field is set to EVT_CMD_DONE in usb mcu
> response messages
>
> Signed-off-by: Lorenzo Bianconi
Does this fix a real bug or is it just a cleanup? To which tree it
should go?
--
Kalle Valo
On Fri, Aug 24, 2018 at 01:15:04PM +0200, Stanislaw Gruszka wrote:
> This is the begin work of integration between mt76x0 and mt76x2.
Forgot to mention this is on top of not yet applied Geert patch:
https://marc.info/?l=linux-kernel=153506589931390=2
Use common mt76xx_sta and mt76xx_tx_status structures in mt76x0 sub-driver.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/init.c | 2 +-
drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 14 +++---
drivers/net/wireless/mediatek/mt76/mt76x0/mac.h
Add helpers for register access from common code.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h
b/drivers/net/wireless/mediatek/mt76/mt76.h
index
Second part of unifying mt76xx_sta structure between mt76x0 and mt76x2.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x2.h | 20 +++-
drivers/net/wireless/mediatek/mt76/mt76x2_common.c | 12 ++--
Merge mt76x{0,2}_mac_wcid_set_key into common code.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76.h | 3 ++
drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 41 --
drivers/net/wireless/mediatek/mt76/mt76x0/mac.h| 2 --
First part of unifying mt76xx_sta structure between mt76x0 and mt76x2.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x2_common.c | 26 +-
drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 2 +-
Move mt76xx_mac_wcid_set_drop to common code and use it in mt76x0.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 3 ++-
drivers/net/wireless/mediatek/mt76/mt76x2_common.c | 4 ++--
drivers/net/wireless/mediatek/mt76/mt76x2_mac.h| 1
Move rxfilter and mutex to common structure. Create mt76xx-lib.ko
for mt76x0 and mt76x2 common functions and create new unified
mt76xx_configure_filter() function there.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/Kconfig | 6 ++
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/main.c
b/drivers/net/wireless/mediatek/mt76/mt76x0/main.c
index 2d655e715ee8..36ab4fc8432c 100644
---
Use helper from util instead of custom code.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/main.c
Merge mt76x{0,2}_mac_wcid_setup into common code.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 17
drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 6 +++---
drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 2 --
Private vif structures definitions are the same for mt76x2 and mt76x0.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/init.c| 2 +-
drivers/net/wireless/mediatek/mt76/mt76x0/main.c| 8
drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h
Merge mt76x{0,2} mac_shared_key_setup into common code.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 24 --
drivers/net/wireless/mediatek/mt76/mt76x0/mac.h| 2 --
drivers/net/wireless/mediatek/mt76/mt76x0/main.c | 2 +-
Merge mt76x{0,2} mac_get_key_info into new mt76xx_mac.c file.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/Makefile| 2 +-
drivers/net/wireless/mediatek/mt76/mt76x0/mac.c| 30 +-
.../net/wireless/mediatek/mt76/mt76x2_mac_common.c | 30
Add missed definitions for mt76x0 into mt76xx_regs.h. Remove
mt76x0/regs.h and fixup mt76x0 code to adjust to some diffrent
registers/fields names.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/init.c | 16 +-
drivers/net/wireless/mediatek/mt76/mt76x0/mac.c
MAC registers are the same for mt76x0 and mt76x2. Rename mt76x2_regs.h
file to reflect that.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x2.h | 2 +-
drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 619 ---
This is the begin work of integration between mt76x0 and mt76x2.
Further development can be seen here:
https://github.com/sgruszka/wireless-drivers-next/commits/mt76x0-draft-v2
Stanislaw Gruszka (17):
mt76: unify wait_for_mac
mt76: rename mt76x2_regs.h
mt76: merge mt76x0/regs.h into
Create new mt76xx_mac.h for common mac functions of mt76x0 and mt76x2
and unity wait_for_mac for both drivers.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76x0/init.c | 11 +++---
drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0.h | 3 +-
Add module license.
Signed-off-by: Stanislaw Gruszka
---
drivers/net/wireless/mediatek/mt76/mt76xx_util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76xx_util.c
b/drivers/net/wireless/mediatek/mt76/mt76xx_util.c
index 3b0f9006eaa2..82a647d8398b
Verify if evt field is set to EVT_CMD_DONE in usb mcu
response messages
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/dma.h | 10 ++
drivers/net/wireless/mediatek/mt76/usb_mcu.c | 3 ++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git
From: Naftali Goldstein
In the HE phy capabilities IE there are 2 bits to signal support for
STBC in bandwidths of 80Mhz or less, and of 160Mhz.
Use these bits to determine STBC support if this IE exists.
Signed-off-by: Naftali Goldstein
Signed-off-by: Luca Coelho
---
From: Johannes Berg
This reverts the addition of memory type in the memory debug TLV
as the firmware never ended up implementing it, and now the PRPH
dump is added as a different TLV.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/fw/dbg.c |
From: Johannes Berg
Decode the HE TB PPDU data that we get in sniffer mode
and use it to populate the HE radiotap information.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
.../net/wireless/intel/iwlwifi/fw/api/rx.h| 21 ++
From: Naftali Goldstein
Add flags to the tlc_cfg_cmd for signaling peer support for receiving
Dual Carrier Modulation at BPSK (MCS 0), and set them according to peer
capabilities.
Signed-off-by: Naftali Goldstein
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/fw/api/rs.h |
From: Ayala Beker
In case of fragmented scan on the HB channels, configure EBS to be
fragmented as well.
Signed-off-by: Ayala Beker
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/fw/api/scan.h | 1 +
drivers/net/wireless/intel/iwlwifi/mvm/scan.c| 12 +++-
2
From: Golan Ben Ami
Support more txq_alloc command types by moving the command declaration
to the gen specific area. While at it, move some of the code segments
to a common place for re-use.
Signed-off-by: Golan Ben Ami
Signed-off-by: Luca Coelho
---
From: Shahar S Matityahu
Make all FW debug data stop recording flows to use
iwl_fw_dbg_stop_recording function instead of writing to FW
registers directly.
Signed-off-by: Shahar S Matityahu
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 4 ++--
From: Emmanuel Grumbach
Probe responses were sent to the multicast station while
they should be routed to the broadcast station.
This has no negative effect since the frame was still
routed to the right queue, but it looked very fishy
to send a frame to a (queue, station) tuple where
'queue' is
From: Naftali Goldstein
As with the non-offloaded rs case, during assoc on the ap side the phy
context is set to 20MHz until authorization of a client that supports
wider channel-widths. Support this by sending the initial
tlc_config_cmd with max supported channel width of 20MHz until
From: Johannes Berg
The GI duration depends on the frame type in some cases,
take that into account when decoding for radiotap.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 22 ++-
1 file changed, 16
From: Johannes Berg
This is the same as for SU PPDUs, so it's easy to do.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Shahar S Matityahu
Allow access to the memory by the host and the device simultaneously.
This will be needed in some future patches.
Signed-off-by: Shahar S Matityahu
Signed-off-by: Luca Coelho
---
.../wireless/intel/iwlwifi/pcie/internal.h| 4 +-
From: Johannes Berg
I evidently completely confused "number of LTF symbols" and "LTF size".
Radiotap was reporting the former, while I thought it was the latter,
and we really need both.
Add the LTF symbol size into the newly defined field in radiotap.
Signed-off-by: Johannes Berg
From: Johannes Berg
Implement the extended HE-MU info type decoding to show the HE-SIG-B
common contents in the HE-MU radiotap field.
The DW4 data is partially overwritten by the hardware in all cases, so
only the higher 16 bits can be used. To be able to use it for the HE
SIG-B common data
From: Ido Yariv
In the new method of parsing the NVM the disable_11n module parameter
isn't consulted when setting up HT capabilities. Fix this.
Signed-off-by: Ido Yariv
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c | 4 +++-
1 file changed, 3
From: Johannes Berg
If the bandwidth is only 20 MHz, then the second channel doesn't
exist, but the hardware reports the CRC was OK. Suppress the data
of the second channel in the HE radiotap in this case, by marking
it as not known.
Signed-off-by: Johannes Berg
Signed-off-by: Luca Coelho
---
From: Luca Coelho
Hi,
Here's the third set of patches intended for v4.20. It's the usual
development, with some small new feauters, cleanups and bugfixes.
The changes are:
* Enable a new scanning feature;
* Continued work on HE (mostly radiotap);
* Some fixes in the FW rate-scaling
On 23.08.2018 13:33, Ajay Singh wrote:
> On Thu, 23 Aug 2018 11:12:08 +0300
> Claudiu Beznea wrote:
>
>> On 14.08.2018 09:50, Ajay Singh wrote:
>>> Cleanup patch to avoid line over 80 chars issue reported by
>>> checkpatch.pl script.
>>>
>>> Signed-off-by: Ajay Singh
>>> ---
>>>
On 23.08.2018 12:43, Ajay Singh wrote:
> The idea was to keep private data related to 'wiphy priv'
> in 'wilc_priv' struct and 'netdev priv' related data in 'wilc_vif'
> struct.
OK, I see, agree!
On 23.08.2018 13:00, Ajay Singh wrote:
> Unless ndo_set_rx_mode() gets called quickly I don't think there is any
> issue here.
I don't agree with this.
On 23.08.2018 13:09, Ajay Singh wrote:
> On Thu, 23 Aug 2018 11:11:09 +0300
> Claudiu Beznea wrote:
>
>> On 14.08.2018 09:50, Ajay Singh wrote:
>>> Avoid use of static variable and move it in 'wilc' structure
>>> related to hif and added NULL before accessing hif_workqueue in
>>>
On 23.08.2018 17:36, Ajay Singh wrote:
> On Thu, 23 Aug 2018 11:11:18 +0300
> Claudiu Beznea wrote:
>
>> On 14.08.2018 09:50, Ajay Singh wrote:
>>> Remove the use of static variable 'terminated_handle' and instead
>>> move in wilc_vif struct.
>>> After moving this variable to wilc_vif struct
Cleanup {tx,rx} and mcu queues if resume operation fails
Fixes: ee676cd5017c ("mt76: add driver code for MT76x2u based devices")
Signed-off-by: Lorenzo Bianconi
---
drivers/net/wireless/mediatek/mt76/mt76x2_usb.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git
From: Luca Coelho
The Free Software Foundation address is superfluous and causes
checkpatch to issue a warning when present. Remove all paragraphs
with FSF's address to prevent that.
Signed-off-by: Luca Coelho
---
drivers/net/wireless/intel/iwlwifi/cfg/1000.c | 4
51 matches
Mail list logo