Re: [PATCH RFC v3 0/4] Move TXQ scheduling into mac80211

2018-09-09 Thread Kan Yan
Hi Toke, It is great to see finally there will be a general airtime fairness support in mac80211. I feel this patch set could still use some improvements to make it works better with 11ac drivers like ath10k. I did a version of airtime fairness in the ath10k driver that used in Google Wifi and

[PATCH 11/11] mt76x0: remove mt76x0_burst_write_regs()

2018-09-09 Thread Lorenzo Bianconi
From: Stanislaw Gruszka We don't need to use custom burst write regs via MCU, we can use generic mt76_wr_copy() for the same purpose. Signed-off-by: Stanislaw Gruszka Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/init.c | 25 ++--

[PATCH 05/11] mt76: usb: use common helpers for mcu_alloc_msg()/mcu_send_msg()

2018-09-09 Thread Lorenzo Bianconi
Use mcu common helpers instead of usb specific routines. Add static qualifier to the following functions: - mt76u_mcu_msg_alloc - __mt76u_mcu_send_msg - mt76u_mcu_send_msg - mt76u_mcu_wr_rp - mt76u_mcu_rd_rp - mt76u_wr_rp - mt76u_rd_rp This is a preliminary patch to move mt76x02 usb mcu code in

[PATCH 09/11] mt76x02: add static qualifier to mt76x02_remove_dma_hdr

2018-09-09 Thread Lorenzo Bianconi
Add static qualifier to mt76x02_remove_dma_hdr routine and do not export the symbol since it is only used in mt76x02_util.c Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x02_util.c | 3 +-- drivers/net/wireless/mediatek/mt76/mt76x02_util.h | 1 - 2 files changed, 1

[PATCH 07/11] mt76: usb: move mt76u_skb_dma_info in mt76x02_usb_core.c

2018-09-09 Thread Lorenzo Bianconi
Move mt76u_skb_dma_info routine in mt76x02-usb module and rename it in mt76x02u_skb_dma_info. Moreover move mt76x02u_set_txinfo in mt76x02_usb_core.c. This is a preliminary patch to move MT_TXD_INFO, MT_MCU_MSG and MT_RX_FCE_INFO defs in mt76x02-lib module since other chipsets (e.g. mt7603) use

[PATCH 08/11] mt76x02: move TXD/RXD/MCU definitions in mt76x02_dma.h

2018-09-09 Thread Lorenzo Bianconi
Introduce mt76x02_dma.h header file to contain mt76x02 dma related definitions Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/dma.h | 38 .../net/wireless/mediatek/mt76/mt76x02_dma.h | 60 +++

[PATCH 06/11] mt76: usb: move mt76x02 mcu code in mt76x02-usb module

2018-09-09 Thread Lorenzo Bianconi
Introduce mt76x02_usb_mcu.c in order to contain mt76x02u mcu related code. Add mt76x02-usb module as a container for mt76x02 usb code. This is a preliminary patch to move MT_TXD_INFO, MT_MCU_MSG and MT_RX_FCE_INFO defs in mt76x02-lib module since other chipsets (e.g. mt7603) use different dma

[PATCH 10/11] mt76x0: remove unused mt76x0_burst_read_regs

2018-09-09 Thread Lorenzo Bianconi
From: Stanislaw Gruszka mt76x0_burst_read_regs is not used, but keep it for eventual use. Since we have this function now in the driver git history, we can remove it and eventually revert this commit it the function will be needed. Signed-off-by: Stanislaw Gruszka Signed-off-by: Lorenzo

[PATCH 03/11] mt76: add usb implementation of {wr,rd}_rp

2018-09-09 Thread Lorenzo Bianconi
From: Stanislaw Gruszka Add USB implementation for read and write reg pair routines. The actual implementation can use mcu related routines according to MCU state Signed-off-by: Stanislaw Gruszka Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76.h | 8 ++

[PATCH 04/11] mt76: add rd_rp and wr_rp to bus_ops/mcu_ops

2018-09-09 Thread Lorenzo Bianconi
From: Stanislaw Gruszka Add callbacks for reading and writing reg pairs tables. Signed-off-by: Stanislaw Gruszka Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76.h| 20 +++- drivers/net/wireless/mediatek/mt76/usb.c | 2 ++

[PATCH 02/11] mt76: add mt76_mcu_ops data structure for mcu related pointers

2018-09-09 Thread Lorenzo Bianconi
Introduce mt76_mcu_ops data structure to contain mcu related function pointers. This is a preliminary patch to move mt76x02 usb mcu code in mt76x02-usb module Acked-by: Stanislaw Gruszka Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76.h| 11 +++

[PATCH 01/11] mt76: move mt76x0 and mt76x2 mcu shared defs in mt76x02_mcu.h

2018-09-09 Thread Lorenzo Bianconi
Move mt76x0 and mt76x2 mcu shared definition in mt76x02_mcu.h and remove duplicated code Signed-off-by: Lorenzo Bianconi --- .../net/wireless/mediatek/mt76/mt76x0/mcu.c | 8 +-- .../net/wireless/mediatek/mt76/mt76x0/mcu.h | 51 + .../net/wireless/mediatek/mt76/mt76x02_mcu.h |

[PATCH 00/11] move mcu usb code in mt76x02-lib module

2018-09-09 Thread Lorenzo Bianconi
This is the first of two series that unify mcu code between pci and usb drivers. That patchset will be used to properly support mt76x0e chipsets without duplicating the code. Moreover this patchset moves MT_TXD_INFO, MT_MCU_MSG and MT_RX_FCE_INFO definitions in mt76x02-lib module since other

Re: Troubleshooting compilation of hostapd

2018-09-09 Thread Rami Rosen
HI Pavlin, Please try from scratch cloning the tree from scratch, then cp defconfig .config, then uncomment the following entry in .config: CONFIG_LIBNL32=y and then run "make", and post here the results. Regards, Rami Rosen http://ramirose.wixsite.com/ramirosen On Sun, 9 Sep 2018 at 16:57,

Troubleshooting compilation of hostapd

2018-09-09 Thread pavlin
Hi, I work as a software tester who has general understanding of C++ language. I experiment with simulated Wi-Fi access point and a station. My Linux distribution is Fedora 27. I try to compile hostap by following the steps from:

Testing simulated Wi-Fi with hostap

2018-09-09 Thread Pavlin Georgiev
Hi, I am a software tester who decided to experiment with hostap. I am not a C++ programmer, but I have general understanding of that language. My Linux distro is Fedora 27. My goal is to test network connections with various authentication methods between a simulated Wi-Fi access point and

[PATCH 15/16] iwlwifi: fix LED command capability bit

2018-09-09 Thread Luca Coelho
From: Johannes Berg The capability bit was added to the driver and had been negotiated with the firmware, but then got forgotten in the firmware and later reused for a different capability. Now the firmware added it in a new bit. Fixes: 2eabc84d2f8e ("iwlwifi: mvm: only send LEDS_CMD when the

[PATCH 10/16] iwlwifi: mvm: TLC support for Coex Schema 2

2018-09-09 Thread Luca Coelho
From: Erel Geron The new coex schema requires setting the non-shared antenna for the single_stream_ant_msk field in the TLC command. Signed-off-by: Erel Geron Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/coex.c | 9 +

[PATCH 11/16] iwlwifi: mvm: remove support for adjacent channel compensation

2018-09-09 Thread Luca Coelho
From: Emmanuel Grumbach We no longer want to consider the RSSI if the beacon / probe has been heard on an adjacent channel. This was based on a firmware capability that is now unavailable. Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho ---

[PATCH 14/16] iwlwifi: configure power scheme to balanced for 22560 devices

2018-09-09 Thread Luca Coelho
From: Golan Ben Ami As a temporary stage in the 22560 devices bring up, we disabled power save, to avoid bugs related to that domain. Now we would like to use power save so enable the balanced mode, and allow configuring the mode via module parameter. Signed-off-by: Golan Ben Ami

[PATCH 13/16] iwlwifi: pcie: add infrastructure for multiple debug buffers

2018-09-09 Thread Luca Coelho
From: Sara Sharon In future devices we will have more than one debug buffer. Prepare the infrastructure for allocation and release of multiple debug buffers by grouping the variables in an array of structures and moving it to trans section, where they will be visible to opmode and FW.

[PATCH 16/16] iwlwifi: mvm: Allow TKIP for AP mode

2018-09-09 Thread Luca Coelho
From: Ilan Peer Support for setting keys for TKIP cipher suite was mistakenly removed for AP mode. Fix this. Fixes: 85aeb58cec1a ("iwlwifi: mvm: Enable security on new TX API") Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 4 1

[PATCH 12/16] iwlwifi: pcie: support transmitting SKBs with fraglist

2018-09-09 Thread Luca Coelho
From: Johannes Berg We want to be able to build A-MSDUs in higher layers, e.g. by xmit_more, so support transmitting SKBs with fraglist to use it for such. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 8 1 file changed, 8

[PATCH 08/16] iwlwifi: mvm: use correct FIFO length

2018-09-09 Thread Luca Coelho
From: Sara Sharon Current FIFO size calculation is wrong for two reasons: - We access lmac 0 by default - We don't take 11ax into consideration. Fix both. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- .../net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 4 ++

[PATCH 09/16] iwlwifi: mvm: set wep key for all stations in soft ap mode

2018-09-09 Thread Luca Coelho
From: Avraham Stern When operating as a soft ap with wep security, the key was not configured to the fw for the stations, based on the fact that the key will be specified in the tx command. However, in the new tx api the tx command does not include the key, which resulted in all data frames

[PATCH 06/16] iwlwifi: mvm: do not override amsdu size user settings

2018-09-09 Thread Luca Coelho
From: Shaul Triebitz Since AMSDUs are not de-aggregated by HW in monitor mode, we still need the option for setting large RBs (up to 12K). Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 20 1 file changed, 12

[PATCH 04/16] iwlwifi: pcie: Fail fast if HW is inaccessible at probe

2018-09-09 Thread Luca Coelho
From: Rajat Jain If the HW is not responding at probe time, fail immediately complaining about it. Without this, we see that the kernel spends > 100ms trying to load firmware (even gives an incorrect impression that it actually loaded a firmware) and do unnecesary processing before concluding

[PATCH 07/16] iwlwifi: pcie: set RB size according to user settings

2018-09-09 Thread Luca Coelho
From: Shaul Triebitz RB size can be configured by user to be greater than 4K. That's needed for monitor to capture big AMSDUs. The firmware now enables different RB sizes configuration via context info. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho ---

[PATCH 03/16] iwlwifi: pcie: tx: pull tracing out of iwl_fill_data_tbs()

2018-09-09 Thread Luca Coelho
From: Johannes Berg This will allow us to reuse the function later for adding fraglist SKBs to the TFD. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 41 ++-- 1 file changed, 21 insertions(+), 20 deletions(-) diff

[PATCH 01/16] iwlwifi: pcie: gen2: build A-MSDU only for GSO

2018-09-09 Thread Luca Coelho
From: Johannes Berg If the incoming frame should be an A-MSDU, it may already be one, for example in the case of NAN multicast being encapsulated in an A-MSDU. Thus, use the GSO algorithm to build A-MSDU only if the skb actually contains GSO data. Fixes: 6ffe5de35b05 ("iwlwifi: pcie: add AMSDU

[PATCH 02/16] iwlwifi: pcie: tx: unify TFD unmapping

2018-09-09 Thread Luca Coelho
From: Johannes Berg When anything fails, we unmap the whole TFD in three different places scattered throughout the code. Unify this to a single place. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 28 +--- 1 file

[PATCH 05/16] iwlwifi: pcie: fit reclaim msg to MAX_MSG_LEN

2018-09-09 Thread Luca Coelho
From: Golan Ben Ami Today, the length of a debug message in iwl_trans_pcie_reclaim may pass the MAX_MSG_LEN, which is 110. An example for this kind of message is: 'iwl_trans_pcie_reclaim: Read index for DMA queue txq id (2), last_to_free 65535 is out of range [0-65536] 2 2.' Cut the message a

[PATCH 00/16] iwlwifi: updates intended for v4.20 2018-09-09

2018-09-09 Thread Luca Coelho
From: Luca Coelho Hi, Here's the fifth set of patches intended for v4.20. It's the usual development, with some small new features, cleanups and bugfixes. The changes are: * Fix one FW feature TLV that had a conflict with another value; * A couple of fixes for SoftAP mode; * Work continues