Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Joe Perches
On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote: > Joe Perches writes: > > > On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > > > From: Yan-Hsuan Chuang > > [] > > > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > > > b/drivers/net/wireless/realtek/rtw88/debug.c >

Re: [RFC v3 01/12] rtw88: main files

2018-10-13 Thread Kalle Valo
Tony Chuang writes: >> > +static void rtw_watch_dog_work(struct work_struct *work) >> > +{ >> > + struct rtw_dev *rtwdev = container_of(work, struct rtw_dev, >> > +watch_dog_work.work); >> > + struct rtw_vif *rtwvif; >> > + >> > + if

Re: [PATCH 1/5] qtnfmac: use 'help' in Kconfig

2018-10-13 Thread Kalle Valo
Sergey Matyukevich wrote: > Fix checkpatch warning: use preferred 'help' option in Kconfig. > > Signed-off-by: Sergey Matyukevich 3 patches applied to wireless-drivers-next.git, thanks. db62abe51853 qtnfmac: use 'help' in Kconfig b458a033ca2f qtnfmac: use SPDX identifier for pcie bus layer

Re: [PATCH v4] brcmsmac: AP mode: update beacon when TIM changes

2018-10-13 Thread Kalle Valo
Ali MJ Al-Nasrawy wrote: > Beacons are not updated to reflect TIM changes. This is not compliant with > power-saving client stations as the beacons do not have valid TIM and can > cause the network to stall at random occasions and to have highly variable > latencies. > Fix it by updating beacon

pull request: mt76 2018-10-13 v2

2018-10-13 Thread Felix Fietkau
Hi Kalle, Here's another large batch of mt76 code cleanup / deduplication / fixes v2: add missing S-o-b. - Felix The following changes since commit c894696188d5c2af1e636e458190e80c53fb893d: rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic version (2018-10-13 15:00:37

Re: pull request: mt76 2018-10-13

2018-10-13 Thread Kalle Valo
Felix Fietkau writes: > Hi Kalle, > > Here's another batch of mt76 code cleanup / deduplication / fixes > > - Felix > > The following changes since commit c894696188d5c2af1e636e458190e80c53fb893d: > > rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic > version

Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Kalle Valo
Joe Perches writes: > On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: >> From: Yan-Hsuan Chuang > [] >> diff --git a/drivers/net/wireless/realtek/rtw88/debug.c >> b/drivers/net/wireless/realtek/rtw88/debug.c > [] >> +#ifdef CONFIG_RTW88_DEBUG >> + >> +void __rtw_dbg(struct

pull request: mt76 2018-10-13

2018-10-13 Thread Felix Fietkau
Hi Kalle, Here's another batch of mt76 code cleanup / deduplication / fixes - Felix The following changes since commit c894696188d5c2af1e636e458190e80c53fb893d: rtlwifi: rtl8821ae: replace _rtl8821ae_mrate_idx_to_arfr_id with generic version (2018-10-13 15:00:37 +0300) are available in the

Re: [RFC v4 08/13] rtw88: debug files

2018-10-13 Thread Joe Perches
On Sat, 2018-10-13 at 17:00 +0800, yhchu...@realtek.com wrote: > From: Yan-Hsuan Chuang [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.c > b/drivers/net/wireless/realtek/rtw88/debug.c [] > +#ifdef CONFIG_RTW88_DEBUG > + > +void __rtw_dbg(struct rtw_dev *rtwdev, const char *fmt, ...)

Re: [PATCH 5/5] qtnfmac: add support for Topaz chipsets

2018-10-13 Thread Kalle Valo
Sergey Matyukevich writes: > This patch adds support for QSR1000/QSR2000 family of chipsets > to qtnfmac_pcie platform driver. > > QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2, > 4x4/2x4/2x2 chips, including single and dual band devices. > Depending on specific chip model and

Re: [PATCH] iwlwifi: mvm: check return value of rs_rate_from_ucode_rate()

2018-10-13 Thread Kalle Valo
Luca Coelho wrote: > From: Luca Coelho > > The rs_rate_from_ucode_rate() function may return -EINVAL if the rate > is invalid, but none of the callsites check for the error, potentially > making us access arrays with index IWL_RATE_INVALID, which is larger > than the arrays, causing an

Re: pull-request: iwlwifi-next 2018-10-12

2018-10-13 Thread Kalle Valo
Luca Coelho writes: > Hi Kalle, > > This is the fourth batch of patches intended for v4.20. This includes > only the last patchset I sent. Usual development work, mostly queue > handling cleanups. More details about the contents in the tag > description. > > I have sent this out before and

Re: [RFC v3] cfg80211: add peer measurement with FTM API

2018-10-13 Thread Kalle Valo
Johannes Berg writes: > From: Johannes Berg > > Add a new "peer measurement" API, that can be used to measure > certain things related to a peer. Right now, only implement > FTM (flight time measurement) over it, but the idea is that > it'll be extensible to also support measuring the necessary

Re: [PATCH v4 4/8] rt2800: fix registers init for MT7620

2018-10-13 Thread Kalle Valo
Stanislaw Gruszka writes: > There is duplicated 'if (rt2x00_rt(rt2x00dev, RT6352))' entry that > causes we do not perform register initialization for RT6352 (MT7620 > SOCs) in correct branch. Fix this and disable registers initialization > that is specific to particular MT7620 revision. > >

[PATCH] linux-firmware: add firmware for mt7610e

2018-10-13 Thread Lorenzo Bianconi
Add binary firmware for mt7610e based devices Signed-off-by: Lorenzo Bianconi --- WHENCE | 3 ++- mediatek/mt7610e.bin | Bin 0 -> 80680 bytes 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 mediatek/mt7610e.bin diff --git a/WHENCE b/WHENCE index

[RFC v4 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang This is a new mac80211 driver for Realtek 802.11ac wireless network chips. rtw88 supports 8822BE and 8822CE chips, and will be able to support multi-vif combinations in run-time. For now, only PCI bus is supported, but rtw88 was originally designed to optionally support

[RFC v4 13/13] rtw88: add support for Realtek 802.11ac wireless chips

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang Signed-off-by: Yan-Hsuan Chuang --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ad052a..138515b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12546,6 +12546,14 @@ T: git

[RFC v4 05/13] rtw88: mac files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang mac files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac.c | 1045 ++ drivers/net/wireless/realtek/rtw88/mac.h | 35 + 2 files changed, 1080 insertions(+) create mode

[RFC v4 06/13] rtw88: fw and efuse files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang fw and efuse files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/efuse.c | 150 +++ drivers/net/wireless/realtek/rtw88/efuse.h | 53 +++ drivers/net/wireless/realtek/rtw88/fw.c| 655

[RFC v4 01/13] rtw88: main files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang main files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/mac80211.c | 478 ++ drivers/net/wireless/realtek/rtw88/main.c | 1168 +

[RFC v4 03/13] rtw88: hci files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang hci files for Realtek 802.11ac wireless network chips For now there is only PCI bus supported by rtwlan, in the future it will also have USB/SDIO Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/hci.h | 211 ++

[RFC v4 08/13] rtw88: debug files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang debug files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/debug.c | 652 + drivers/net/wireless/realtek/rtw88/debug.h | 43 ++ 2 files changed, 695 insertions(+) create

[RFC v4 11/13] rtw88: 8822C init table

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang 8822C init table for chip files Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- .../net/wireless/realtek/rtw88/rtw8822c_table.c| 4150 1 file changed, 4150 insertions(+) create mode 100644

[RFC v4 07/13] rtw88: phy files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang phy files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/phy.c | 1679 ++ drivers/net/wireless/realtek/rtw88/phy.h | 125 +++ 2 files changed, 1804 insertions(+) create

[RFC v4 09/13] rtw88: chip files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang chip files Realtek 802.11ac wireless network chips 8822B & 8822C series files Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 1588 drivers/net/wireless/realtek/rtw88/rtw8822b.h | 155 ++

[RFC v4 04/13] rtw88: trx files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang trx files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/rx.c | 153 ++ drivers/net/wireless/realtek/rtw88/rx.h | 41 + drivers/net/wireless/realtek/rtw88/tx.c | 273

[RFC v4 12/13] rtw88: Kconfig & Makefile

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang Kconfig & Makefile for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/Kconfig| 1 + drivers/net/wireless/realtek/Makefile | 1 + drivers/net/wireless/realtek/rtw88/Kconfig | 55

[RFC v4 02/13] rtw88: core files

2018-10-13 Thread yhchuang
From: Yan-Hsuan Chuang core files for Realtek 802.11ac wireless network chips Signed-off-by: Yan-Hsuan Chuang --- drivers/net/wireless/realtek/rtw88/ps.c | 168 +++ drivers/net/wireless/realtek/rtw88/ps.h | 20 ++ drivers/net/wireless/realtek/rtw88/regd.c | 328

Re: [Make-wifi-fast] [PATCH RFC v5 3/4] mac80211: Add airtime accounting and scheduling to TXQs

2018-10-13 Thread Dave Taht
On Fri, Oct 12, 2018 at 12:38 AM Rajkumar Manoharan wrote: > > On 2018-10-11 03:38, Toke Høiland-Jørgensen wrote: > > Rajkumar Manoharan writes: > > > >> Hmm... mine is bit different. txqs are refilled only once for all > >> txqs. > >> It will give more opportunity for non-served txqs.

Re: [PATCH] iwlwifi: mvm: check return value of rs_rate_from_ucode_rate()

2018-10-13 Thread Luciano Coelho
On Sat, 2018-10-13 at 09:46 +0300, Luca Coelho wrote: > From: Luca Coelho > > The rs_rate_from_ucode_rate() function may return -EINVAL if the rate > is invalid, but none of the callsites check for the error, > potentially > making us access arrays with index IWL_RATE_INVALID, which is larger >

[PATCH] iwlwifi: mvm: check return value of rs_rate_from_ucode_rate()

2018-10-13 Thread Luca Coelho
From: Luca Coelho The rs_rate_from_ucode_rate() function may return -EINVAL if the rate is invalid, but none of the callsites check for the error, potentially making us access arrays with index IWL_RATE_INVALID, which is larger than the arrays, causing an out-of-bounds access. This will trigger