Re: Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming)

On 11-03-16 16:23, Michael Trimarchi wrote: > Hi > > I have a kernel panic on the brcmf_sdiod_sgtable_alloc just because > the function is called before brcmf_sdio_probe. > > I think that > nents = max_t(uint, BRCMF_DEFAULT_RXGLOM_SIZE, >

Re: BCM4350 not working properly under Debian 9 RC3, Dell XPS 13 9350

+ linux-wireless On 27-05-17 11:33, Graziano D'Innocenzo wrote: > Hello, > > I found this email address on: > https://wireless.wiki.kernel.org/en/users/Drivers/brcm80211 > > We have a laptop "Dell XPS 13 9350" and we have been unable to make > its wireless work properly: signal is extremely

Re: [PATCH 4.12 REGRESSION fix] brcmfmac: Use ALIGNMENT rather then hardcoded "4" for bus:txglomalign

On 26-05-17 13:18, Hans de Goede wrote: > Hi, > > On 26-05-17 13:15, Kalle Valo wrote: >> Hans de Goede <hdego...@redhat.com> writes: >> >>> From: Arend Van Spriel <arend.vanspr...@broadcom.com> > > Ah I see I set the Author to Arend when I ad

Re: brcmfmac: brcm43430 Invalid mailbox value issue

On 24-05-17 14:50, James Hughes wrote: > We are seeing an issue on Raspberry Pi which uses the bcm43430 chip. It's > been tested up to 4.9 which still shows the issue (it's been there for some > time, > 1yr). I'm trying to find someone who can test on 4.11 as I cannot > replicate (The latest

[PATCH] cfg80211: make cfg80211_sched_scan_results() work from atomic context

ed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- net/wireless/scan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index 14d5f0c..9f0901f 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -322,9

Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi

On 23-5-2017 9:22, Johannes Berg wrote: > On Tue, 2017-05-23 at 09:19 +0200, Arend Van Spriel wrote: >> >>> WARN_ON_ONCE(!rcu_read_lock_held() && !lockdep_rtnl_is_held()); >> >> Thought about something like this after sending the email. So there >>

Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi

On 22-5-2017 23:04, Johannes Berg wrote: > Hi Arend, > > Sorry, I forgot that the original message wasn't Cc'ed to the wireless > list, only netdev. That explains. Not subscribed to that. >> +++ b/net/wireless/scan.c >> @@ -322,9 +322,7 @@ static void cfg80211_del_sched_scan_req(struct >>

Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi

On 22-5-2017 14:09, Arend van Spriel wrote: > On 5/22/2017 12:57 PM, Johannes Berg wrote: >> On Mon, 2017-05-22 at 12:36 +0200, Sander Eikelenboom wrote: >>> Hi, >>> >>> I encountered this splat with 4.12-RC2. >> >> Ugh, yeah, I should've seen tha

Re: 4.12-RC2 BUG: scheduling while atomic: irq/47-iwlwifi

On 5/22/2017 12:57 PM, Johannes Berg wrote: On Mon, 2017-05-22 at 12:36 +0200, Sander Eikelenboom wrote: Hi, I encountered this splat with 4.12-RC2. Ugh, yeah, I should've seen that in the review. Arend, please take a look at this. cfg80211_sched_scan_results() cannot sleep, so you can't

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

On 5/19/2017 12:21 PM, Johannes Berg wrote: On Thu, 2017-05-18 at 14:48 +0200, Arend Van Spriel wrote: True. However, we touched this topic a while ago in generic context, ie. preference for ext_features over supported_commands. Right now wpa_supplicant does not check NEW_KEY support so we can

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

On 5/21/2017 4:19 PM, Andreas Färber wrote: Hi, Am 16.05.2017 um 21:56 schrieb Martin Blumenstingl: On Tue, May 16, 2017 at 12:05 AM, Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: On 15-5-2017 22:13, Martin Blumenstingl wrote: The example in the BCM43xx documentation uses

Re: [PATCH] nl80211: Add association id to station response

On 5/22/2017 8:17 AM, Johannes Berg wrote: Hi Kirill, First of all, please read https://www.kernel.org/doc/html/latest/process/submitting-patches.html particularly https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin is

Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8

On 14-5-2017 13:45, Hans de Goede wrote: > Hi, > > On 14-05-17 10:21, Arend Van Spriel wrote: >> On 13-5-2017 16:55, Hans de Goede wrote: >>> Hi, >>> >>> On 13-05-17 15:39, Heiner Kallweit wrote: >>>> Am 13.05.2017 um 14:35 schrieb Hans de Go

[PATCH V4 2/3] brcmfmac: add mutex to protect pno requests

From: Arend Van Spriel <arend.vanspr...@broadcom.com> The request references kept in pno are accessed in user-space context and in firmware event handler context. As such we need to protect it with a lock. As both context allow sleep a mutex seems appropriate. Reviewed-by: Hante Me

[PATCH V4 1/3] brcmfmac: add support multi-scheduled scan

From: Arend Van Spriel <arend.vanspr...@broadcom.com> This change adds support for multi-scheduled scan in the driver. It currently relies on g-scan support in firmware and will set struct wiphy::max_sched_scan_reqs accordingly. This is limited to 16 concurrent requests. The firmware cur

[PATCH V4 3/3] brcmfmac: add scheduled scan support for specified BSSIDs

From: Arend Van Spriel <arend.vanspr...@broadcom.com> Add support to handle scheduled scan request containing BSSID in the matchsets. The firmware can send event upon finding BSSIDs and SSIDs. To get these in one event the bit REPORT_SEPARATELY needed to be removed from the

Re: [PATCH] brcmfmac: remove setting IBSS mode when stopping AP

On 5/19/2017 6:49 AM, Kalle Valo wrote: Wright Feng writes: From: Chi-hsien Lin Setting IBSS mode when stopping AP may affect functionality of INFRA mode on another interface. For instance, if user creates and stops hostap daemon on

Re: [V3, 5/9] brcmfmac: add firmware feature detection for gscan feature

On 18-5-2017 17:47, Kalle Valo wrote: > Kalle Valo <kv...@codeaurora.org> writes: > >> Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: >>> From: Arend van Spriel <ar...@broadcom.com> >>> >>> Detect gscan support in firmw

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

On 18-5-2017 12:40, Johannes Berg wrote: > On Thu, 2017-05-18 at 12:29 +0200, Arend Van Spriel wrote: >> On 18-5-2017 11:22, Johannes Berg wrote: >>> On Thu, 2017-05-18 at 10:18 +0200, Arend Van Spriel wrote: >>>> >>>>> We should ther

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

On 18-5-2017 11:22, Johannes Berg wrote: > On Thu, 2017-05-18 at 10:18 +0200, Arend Van Spriel wrote: >> >>> We should therefore probably set the expectation that wpa_s - if >>> it's new enough - always uses the offloaded functionality and >>> always sets t

Re: [PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

+ hostap list On 17-5-2017 16:19, Johannes Berg wrote: > Hi, > > I think this looks really good. One thing though: > >> Another change is the >> addition of the flag ATTR_WANT_1X_4WAY_HS that user-space has to pass >> in CONNECT request. Some drivers may need to be aware before the PMK >> is

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On 16-5-2017 1:13, Luis R. Rodriguez wrote: > On Fri, May 12, 2017 at 11:02:26PM +0200, Arend Van Spriel wrote: >> try again.. replacing email address from Michał >> On 12-5-2017 22:55, Arend Van Spriel wrote: >>> Let me explain the idea to refresh your memory (and mine)

Re: [PATCH 1/1] dt-binding: net: wireless: fix node name in the BCM43xx example

d specific bits). Please feel free to add my... Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com> > --- > Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 2 +- > 1

Re: [PATCH] iwlegacy: warn when enabling power save

On 5/15/2017 11:20 AM, Stanislaw Gruszka wrote: On Mon, May 15, 2017 at 11:41:05AM +0300, Kalle Valo wrote: Stanislaw Gruszka writes: iwlegacy firmware can crash when power save is configured. PS was allowed in "dbdac2b iwlegacy: properly enable power saving" with belive

Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8

On Sun, May 14, 2017 at 1:45 PM, Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > > On 14-05-17 10:21, Arend Van Spriel wrote: >> >> On 13-5-2017 16:55, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 13-05-17 15:39, Heiner Kall

Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8

On 13-5-2017 16:55, Hans de Goede wrote: > Hi, > > On 13-05-17 15:39, Heiner Kallweit wrote: >> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>> >>> >>> Hi, >>> >>> On 13-05-17 14:19, Hans de Goede wrote: Hi, I've just rebased my personal kernel tree to what will soon be 4.12-rc1

Re: [v2,1/3] ath9k: Support channels in licensed bands

On 12-5-2017 21:21, Steve deRosier wrote: > Hi Ben, > > On Fri, May 12, 2017 at 7:12 AM, Ben Greear wrote: >> >> >> On 05/11/2017 04:38 AM, Kalle Valo wrote: >>> [snip] >>> o I don't know about other countries, but in Finland applying for any >>> type of license

Re: Participation in common kernel API recommendation?

On 12-5-2017 23:28, Eric Schultz wrote: > Hey all, > > My name’s Eric Schultz, I’m the Community Manager at prpl Foundation > (https://prpl.works ). prpl Foundation has an > effort, called the Low-Level Common API subcommittee, led by Felix > Fietkau of OpenWrt/LEDE and

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On 4-5-2017 4:28, Luis R. Rodriguez wrote: > On Wed, May 03, 2017 at 09:02:20PM +0200, Arend Van Spriel wrote: >> On 3-1-2017 18:59, Luis R. Rodriguez wrote: >>> On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: >>>> >>>> Right question is &

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

On 5/12/2017 10:54 AM, Kalle Valo wrote: Arend van Spriel <arend.vanspr...@broadcom.com> writes: On 5/12/2017 10:19 AM, Kalle Valo wrote: Xie Qirong <cheerx1...@gmail.com> writes: The combination of init_timer and setting up the data and function field manually is equivalen

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

On 5/12/2017 10:19 AM, Kalle Valo wrote: Xie Qirong <cheerx1...@gmail.com> writes: The combination of init_timer and setting up the data and function field manually is equivalent to calling setup_timer(). This is an api consolidation only and improves readability. Acked-by: Arend van

Re: [v2 05/11] rsi: Remove unnecessary buffer allocation

On 5/11/2017 8:28 PM, Kalle Valo wrote: Amitkumar Karwar writes: From: Prameela Rani Garnepudi In functions usb read register and usb write register, dynamic allocation of 4 bytes is used. This is removed as it is unncessary for local variable

Re: [PATCH] ath10k: Fix reported HT MCS rates with NSS > 1

On 11-5-2017 11:09, Sven Eckelmann wrote: > The QCA4019 firmware 10.4-3.2.1-00050 reports only HT MCS rates between > 0-9. But 802.11n MCS rates can be larger than that. For example a 2x2 > device can send with up to MCS 15. > > The firmware encodes the higher MCS rates using the NSS field. The

Re: [PATCH] wcn36xx: Close SMD channel on device removal

On 5/10/2017 1:03 AM, Bjorn Andersson wrote: On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote: Bjorn Andersson writes: The SMD channel is not the primary WCNSS channel and must explicitly be closed as the device is removed, or the channel will already by open on a

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

On 9-5-2017 7:33, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> The name of an array used by itself will always return the array's address. >> So these tests will always evaluate as false and therefore the _return_ >> will never be executed. >> >> Signed-off-by:

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On 3-1-2017 18:59, Luis R. Rodriguez wrote: > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: >> >> Right question is "should we solve it without user-space help"? >> >> Answer is no, too. Way too complex. Yes, it would be nice if hardware >> was designed in such a way that getting

Re: [PATCH 2/6] mwifiex: usb: urb->context sanity check in complete handler

On 3-5-2017 13:48, Xinming Hu wrote: > From: Xinming Hu > > urb/context might be freed in cornel case, add sanity check to avoid > use-after-free. > > Signed-off-by: Xinming Hu > --- > drivers/net/wireless/marvell/mwifiex/usb.c | 10 ++ > 1 file

[PATCH V2 8/9] brcmfmac: switch to using cfg80211_connect_done()

ule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 20 +++-

[PATCH V2 7/9] brcmfmac: support 4-way handshake offloading for 802.1X

Adding callbacks for PMK provisioning. If firmware supports offloading it is indicated to user-space that 802.1X offload is supported. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 61 -- .../br

[PATCH V2 9/9] brcmfmac: provide port authorized state in CONNECT event

Fill struct cfg80211_connection_params::authorized field according the supplicant state received from the device. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 27 +- 1 file changed, 16 inse

[PATCH V2 3/9] nl80211: add authorized flag to CONNECT event

-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/net/cfg80211.h | 3 +++ include/uapi/linux/nl80211.h | 4 net/wireless/nl80211.c | 2 ++ net/wireless/sme.c | 1 + 4 files changed, 10 insertions(+) diff --git a/include/net/cfg80211.h b/inclu

[PATCH V2 2/9] cfg80211: support 4-way handshake offloading for 802.1X

Stern <avraham.st...@intel.com> Signed-off-by: Johannes Berg <johannes.b...@intel.com> [arend.vanspr...@broadcom.com: add WANT_1X_4WAY_HS attribute] Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- V2: - rename ATTR_WANT_1X_OFFLOAD to ATTR_WANT_1X_4WAY_HS. -

[PATCH V2 1/9] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

..@broadcom.com rebase dealing with existing ATTR_PMK] Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/linux/ieee80211.h| 1 + include/net/cfg80211.h | 2 ++ include/uapi/linux/nl80211.h | 10 -- net/wireless/nl80211.c | 9 + 4 files ch

[PATCH V2 5/9] nl80211: remove desciption about request from NL80211_CMD_ROAM

to assume it will not be added any time soon and thus remove it. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/uapi/linux/nl80211.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux

[PATCH V2 4/9] nl80211: add authorized flag to ROAM event

ed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> [arend.vanspr...@broadcom.com reuse NL80211_ATTR_PORT_AUTHORIZED] Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/net/cfg80211.h | 4 in

[PATCH V2 0/9] nl80211: add support for PTK/GTK handshake offload

. This series also comes with driver implementation in brcmfmac although it does not use the authorized flag in the ROAM event (yet). The series applies to the master branch of the mac80211-next repository. V2: - changed patch 2/9 addressing comments from Johannes. Arend van Spriel (6): nl80211

when to use wdev_lock()

Hi Johannes, I bumped into use of wdev_lock() again with 802.1X 4-way-hs offload stuff. So for .set_pmk() and .del_pmk() it takes wdev_lock(). Is there a rule of thumb when this lock is needed. What is it protecting in general and in the case of pmk configuration. Regards, Arend

Re: [PATCH 0/9] nl80211: add support for PTK/GTK handshake offload

On 5/3/2017 10:15 AM, Johannes Berg wrote: On Wed, 2017-05-03 at 10:10 +0200, Arend van Spriel wrote: I was asking because we do it for the keys: correction: the *temporal* keys :) /* * Delete all the keys ... pairwise keys can't really * exist any more anyway

Re: [PATCH 0/9] nl80211: add support for PTK/GTK handshake offload

On 5/3/2017 7:49 AM, Johannes Berg wrote: On Tue, 2017-05-02 at 13:42 +0100, Arend van Spriel wrote: Another change is the addition of the flag ATTR_WANT_1X_OFFLOAD that user-space has to pass in CONNECT request. Some drivers may need to be aware before the PMK is programmed through SET_PMK

Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer

above before your sign-off so it will end up in the git commit message. When done you may also add my acknowledgement, ie.: Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Regards, Arend

Re: [PATCH] cfg80211: fix multi scheduled scan kernel-doc

ame up with if you want to reuse it. cfg80211: fix documentation warnings in struct cfg80211_sched_scan_request The documentation for cfg80211_sched_scan_request was not properly updated with changes related to multi-scheduled scan support. Regardless your decision here is my ... A

[PATCH 1/9] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK

..@broadcom.com rebase dealing with existing ATTR_PMK] Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/linux/ieee80211.h| 1 + include/net/cfg80211.h | 2 ++ include/uapi/linux/nl80211.h | 10 -- net/wireless/nl80211.c | 9 + 4 files ch

[PATCH 6/9] brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK

From: Arend van Spriel <ar...@broadcom.com> The firmware may have supplicant code built-in. This is detected by the driver and indicated in the wiphy features flags. User-space can use this flag to determine whether or not to provide the pre-shared key material in the nl80211 CONNECT c

[PATCH 2/9] cfg80211: support 4-way handshake offloading for 802.1X

Stern <avraham.st...@intel.com> Signed-off-by: Johannes Berg <johannes.b...@intel.com> [arend.vanspr...@broadcom.com: add WANT_1X_OFFLOAD attribute] Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/linux/ieee80211.h| 3 ++ include/ne

[PATCH 9/9] brcmfmac: provide port authorized state in CONNECT event

Fill struct cfg80211_connection_params::authorized field according the supplicant state received from the device. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 27 +- 1 file changed, 16 inse

[PATCH 0/9] nl80211: add support for PTK/GTK handshake offload

list do not use it and the .del_pmk() is also not used within cfg80211. Should it be called in __cfg80211_disconnected() just to be sure? Arend van Spriel (6): nl80211: add authorized flag to CONNECT event nl80211: remove desciption about request from NL80211_CMD_ROAM brcmfmac: support 4-way

[PATCH 8/9] brcmfmac: switch to using cfg80211_connect_done()

ule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 20 +++-

[PATCH 7/9] brcmfmac: support 4-way handshake offloading for 802.1X

Adding callbacks for PMK provisioning. If firmware supports offloading it is indicated to user-space that 802.1X offload is supported. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/cfg80211.c | 61 -- .../br

[PATCH 5/9] nl80211: remove description about request from NL80211_CMD_ROAM

to assume it will not be added any time soon and thus remove it. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/uapi/linux/nl80211.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux

[PATCH 3/9] nl80211: add authorized flag to CONNECT event

-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- include/net/cfg80211.h | 3 +++ include/uapi/linux/nl80211.h | 4 net/wireless/nl80211.c | 2 ++ net/wireless/sme.c | 1 + 4 files changed, 10 insertions(+) diff --git a/include/net/cfg80211.h b/inclu

Re: [PATCH 5/9] cfg80211/nl80211: add authorized flag to roaming event

On 4/28/2017 11:02 PM, Johannes Berg wrote: On Wed, 2017-04-26 at 12:05 +0200, Arend van Spriel wrote: the mobility domain does not require new 802.1X authentication, but roaming to another mobility domain does. Not sure about the terminology here. Is "mobility domain" the sam

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

On 28-4-2017 14:02, Johannes Berg wrote: > >> I tested the 4-way-hs (both Personal and 802.1X) with boolean >> parameter similar to what is proposed in the patch for roaming >> "cfg80211/nl80211: add authorized flag to roaming event" and it works >> fine. So I can extend it for use in connect

[PATCH V4] cfg80211: add request id to cfg80211_sched_scan_*() api

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- Hi Johannes, Able to give it a spin on my test equipment and it passed so here it is. Did not see the pull-request so Regards, Arend changed since:

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

On 26-4-2017 9:20, Johannes Berg wrote: > On Tue, 2017-04-25 at 20:56 +0200, Arend Van Spriel wrote: >> >> You might, but not about this ;-) The other approach I had in mind is >> to only pass the flag for drivers with 4-way-hs support. In that case >> wpa_supp also has

Re: [PATCH 5/9] cfg80211/nl80211: add authorized flag to roaming event

+ Jouni On 26-4-2017 12:05, Arend van Spriel wrote: > Almost overlooked this one. Thanks for the hint, Johannes. > > On 4/26/2017 9:58 AM, Luca Coelho wrote: >> From: Avraham Stern <avraham.st...@intel.com> >> >> Drivers that initiate roaming while being co

Re: [PATCH V3 4/9] cfg80211: add request id to cfg80211_sched_scan_*() api

On 26-4-2017 9:16, Johannes Berg wrote: > On Fri, 2017-04-21 at 13:05 +0100, Arend van Spriel wrote: >> Have proper request id filled in the SCHED_SCAN_RESULTS and >> SCHED_SCAN_STOPPED notifications toward user-space by having the >> driver provide it through the api. >

Fwd: Question on drivers using skb_unclone

Hi Steve, Here the email which hopefully provides enough context. Regards, Arend Forwarded Message Subject:Question on drivers using skb_unclone Date: Fri, 14 Apr 2017 10:03:01 +0100 From: James Hughes To: net...@vger.kernel.org

Re: ath6kl: assure headroom of skbuff is writable in .start_xmit()

On 26-4-2017 17:44, Steve deRosier wrote: > On Wed, Apr 26, 2017 at 1:53 AM, Kalle Valo <kv...@codeaurora.org> wrote: >> Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: >>> An issue was found brcmfmac driver in which a skbuff in .start_xmit() >>> c

Re: [PATCH V3 1/9] nl80211: allow multiple active scheduled scan requests

On 4/26/2017 11:08 AM, Johannes Berg wrote: On Wed, 2017-04-26 at 11:05 +0200, Arend van Spriel wrote: I guess it could be done, but I'm tending towards doing that less again, I have no strong preference in this case. If it was something that seems likely to get abused, perhaps, but here

Re: [PATCH 5/9] cfg80211/nl80211: add authorized flag to roaming event

Almost overlooked this one. Thanks for the hint, Johannes. On 4/26/2017 9:58 AM, Luca Coelho wrote: From: Avraham Stern Drivers that initiate roaming while being connected to a network that uses 802.1X authentication need to inform user space if 802.1X authentication

Re: [PATCH V3 1/9] nl80211: allow multiple active scheduled scan requests

On 4/26/2017 10:49 AM, Johannes Berg wrote: FWIW: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/commit/?id=978812b3f43dda86e20588cfe0a4a244c4fab141 On Wed, 2017-04-26 at 10:46 +0200, Arend van Spriel wrote: Sure. In the worker we are already iterating so I guess

Re: ath6kl: assure headroom of skbuff is writable in .start_xmit()

On 4/26/2017 10:53 AM, Kalle Valo wrote: Arend Van Spriel <arend.vanspr...@broadcom.com> wrote: An issue was found brcmfmac driver in which a skbuff in .start_xmit() callback was actually cloned. So instead of checking for sufficient headroom it should also be writable. Hence use skb_co

Re: [PATCH 4/9] cfg80211: unify cfg80211_roamed() and cfg80211_roamed_bss()

On 4/26/2017 9:58 AM, Luca Coelho wrote: From: Avraham Stern cfg80211_roamed() and cfg80211_roamed_bss() take the same arguments except that cfg80211_roamed() requires the BSSID and cfg80211_roamed_bss() requires the bss entry. Unify the two functions by using a

Re: [PATCH V3 1/9] nl80211: allow multiple active scheduled scan requests

On 4/25/2017 9:49 PM, Johannes Berg wrote: if (schedule_destroy_work) { - struct cfg80211_iface_destroy *destroy; + struct cfg80211_nlport_release *destroy; destroy = kzalloc(sizeof(*destroy), GFP_ATOMIC); I was never

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

On 25-4-2017 20:36, Johannes Berg wrote: > On Tue, 2017-04-25 at 20:34 +0200, Arend Van Spriel wrote: > >>>> + (cr->port_state != CONTROL_PORT_STATE_UNAUTHORIZED >>>> && >>>> + nla_put_flag(msg, NL80211_ATTR_PORT_AUTHORIZED)) ||

Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

On 25-4-2017 16:40, Johannes Berg wrote: > On Fri, 2017-04-21 at 22:01 +0100, Arend van Spriel wrote: > >> I have been working on 4-way handshake offloading and one of the >> things discussed was the addition of PORT_AUTHORIZED flag. So >> this is what I came up with, but

Re: [PATCH] ath6kl: assure headroom of skbuff is writable in .start_xmit()

On 25-4-2017 11:36, James Hughes wrote: > On 25 April 2017 at 10:10, Arend van Spriel > <arend.vanspr...@broadcom.com> wrote: >> An issue was found brcmfmac driver in which a skbuff in .start_xmit() >> callback was actually cloned. So instead of checking for sufficient &g

[PATCH] ath6kl: assure headroom of skbuff is writable in .start_xmit()

An issue was found brcmfmac driver in which a skbuff in .start_xmit() callback was actually cloned. So instead of checking for sufficient headroom it should also be writable. Hence use skb_cow_head() to check and expand the headroom appropriately. Signed-off-by: Arend van Spriel <arend.van

Re: [PATCH v2] brcmfmac: Ensure pointer correctly set if skb data location changes

s. Hi Kalle, This one should go on 4.12 queue as well. Thanks, Arend > Signed-off-by: James Hughes <james.hug...@raspberrypi.org> > > Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > ---

Re: [PATCH v2] brcmfmac: Make skb header writable before use

On 25-4-2017 9:38, Arend Van Spriel wrote: > On 24-4-2017 15:03, James Hughes wrote: >> The driver was making changes to the skb_header without >> ensuring it was writable (i.e. uncloned). >> This patch also removes some boiler plate header size >> checking/adjustment c

Re: [PATCH v2] brcmfmac: Make skb header writable before use

On 24-4-2017 15:03, James Hughes wrote: > The driver was making changes to the skb_header without > ensuring it was writable (i.e. uncloned). > This patch also removes some boiler plate header size > checking/adjustment code as that is also handled by the > skb_cow_header function used to make

Re: [PATCH v2] brcmfmac: Make skb header writable before use

comments but apart from that: Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: James Hughes <james.hug...@raspberrypi.org> > --- > Changes in v2 > Makes the _cow_ call at the entry point of the skb in to the > stack, means only needs to be don

Re: [PATCH v2] brcmfmac: Make skb header writable before use

On 24-4-2017 20:09, Eric Dumazet wrote: > On Mon, 2017-04-24 at 14:03 +0100, James Hughes wrote: >> The driver was making changes to the skb_header without >> ensuring it was writable (i.e. uncloned). >> This patch also removes some boiler plate header size >> checking/adjustment code as that is

Re: [PATCH] brcmfmac: Ensure pointer correctly set if skb data location changes

Minor nit below... You may add my acknowledgement: Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Signed-off-by: James Hughes <james.hug...@raspberrypi.org> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

On 21-4-2017 11:22, James Hughes wrote: > On 20 April 2017 at 20:48, Arend van Spriel > <arend.vanspr...@broadcom.com> wrote: >> + linux-wireless >> >> On 4/20/2017 1:16 PM, James Hughes wrote: >>> >>> The driver was adding header informati

[RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params

in the NL80211_CMD_CONNECT notification. Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- Hi Johannes, Jouni, et al I have been working on 4-way handshake offloading and one of the things discussed was the addition of PORT_AUTHORIZED flag. So this is what I came up with, but I s

[PATCH V3 3/9] cfg80211: add request id parameter to .sched_scan_stop() signature

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c| 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 6 +++--- drivers/net/wireless/ma

[PATCH V3 2/9] nl80211: add support for BSSIDs in scheduled scan matchsets

This patch allows for the scheduled scan request to specify matchsets for specific BSSIDs. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed

[PATCH V3 4/9] cfg80211: add request id to cfg80211_sched_scan_*() api

adcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- .../broadcom/brcm80211/brcmfmac/cfg80211.c

[PATCH V3 0/9] cfg80211: support multiple scheduled scans

req. --- Arend van Spriel (9): nl80211: allow multiple active scheduled scan requests nl80211: add support for BSSIDs in scheduled scan matchsets cfg80211: add request id parameter to .sched_scan_stop() signature cfg80211: add request id to cfg80211_sched_scan_*() api brcmfmac: add firmw

[PATCH V3 1/9] nl80211: allow multiple active scheduled scan requests

ule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- .../broadcom/brc

[PATCH V3 6/9] brcmfmac: move scheduled scan wiphy param setting to pno module

Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c| 18 +- .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.h| 2 ++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 10

[PATCH V3 9/9] brcmfmac: add scheduled scan support for specified BSSIDs

ule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../broadcom/brcm80211/brcmfmac/fwil_types.h | 11 .../net/wir

[PATCH V3 5/9] brcmfmac: add firmware feature detection for gscan feature

From: Arend van Spriel <ar...@broadcom.com> Detect gscan support in firmware by doing pfn_gscan_cfg iovar with invalid version. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by:

[PATCH V3 7/9] brcmfmac: add support multi-scheduled scan

rather easy for dual-band devices. Reviewed-by: Hante Meuleman <hante.meule...@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.c

[PATCH V3 8/9] brcmfmac: add mutex to protect pno requests

r-Paul Giesberts <pieter-paul.giesbe...@broadcom.com> Reviewed-by: Franky Lin <franky@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspr...@broadcom.com> --- .../net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 33 -- 1 file changed, 25 insertions(+), 8

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

+ linux-wireless On 4/20/2017 1:16 PM, James Hughes wrote: The driver was adding header information to incoming skb without ensuring the head was uncloned and hence writable. skb_cow_head has been used to ensure they are writable, however, this required some changes to error handling to ensure

Re: [PATCH] brcm80211: brcmfmac: Ensure header writes are on writable skb

On 4/20/2017 5:47 PM, James Hughes wrote: Driver was writing to skb header area without ensuring it was writable i.e. uncloned. Used skb_cow_header to ensure that header buffer is large enough and is uncloned. Detected when, in combination with the smsc85xx driver, both drivers attempted to

Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable

On 4/20/2017 2:09 PM, James Hughes wrote: On 20 April 2017 at 12:31, Kalle Valo wrote: + linux-wireless James Hughes writes: The driver was adding header information to incoming skb without ensuring the head was uncloned and hence

Re: [PATCH V2 02/10] nl80211: allow multiple active scheduled scan requests

On 4/18/2017 10:55 AM, Johannes Berg wrote: On Tue, 2017-04-18 at 10:53 +0200, Johannes Berg wrote: Hi Arend, Overall this looks good, and I've almost applied it - but I have a question on this patch. You have this list: + struct list_head sched_scan_req_list; struct

<    3   4   5   6   7   8   9   10   11   12   >