[PATCH v2 07/15] wcn36xx: Fetch private sta data from sta entry instead of from vif

From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 06/15] wcn36xx: Add helper macros to cast sta to priv

; Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 14 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 6 ++ 3 files changed, 18 insertions(+), 14 deleti

[PATCH v2 04/15] wcn36xx: Use consistent name for private vif

From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v2 09/15] wcn36xx: Parse trigger_ba response properly

From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH v2 11/15] wcn36xx: Use allocated self sta index instead of hard coded

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v2 03/15] wcn36xx: Add helper macros to cast vif to private vif and vice versa

From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 7 +-- driver

[PATCH v2 10/15] wcn36xx: Copy all members in config_sta v1 conversion

From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH v2 05/15] wcn36xx: Use define for invalid index and fix typo

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH v2 02/15] wcn36xx: Pad TIM PVM if needed

d-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Jason Mobarak <j...@cozybit.com> [bjorn: squashed in Jason's fixup] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 3 +++ drivers/net/wireless/ath/wcn36xx/smd.c |

[PATCH v2 08/15] wcn36xx: Remove sta pointer in private vif struct

From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH v2 14/15] wcn36xx: Implement multicast filtering

OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wireless/ath/wcn36xx/smd.c | 51

[PATCH v2 13/15] wcn36xx: Track association state

From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[PATCH v2 12/15] wcn36xx: Clear encrypt_type when deleting bss key

From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH v2 15/15] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

Re: [RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

On Tue 29 Mar 14:41 PDT 2016, Bjorn Andersson wrote: > From: Jason Mobarak <j...@cozybit.com> > > Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh > beaconing. The field tim_off is always 0 for mesh mode, and thus > pvm_len (referring t

[RESEND PATCH 15/16] wcn36xx: don't pad beacons for mesh

dy.beacon_length is incorrectly calculated for mesh mode. Fix this. Fixes: 8ad99a4e3ee5 ("wcn36xx: Pad TIM PVM if needed") Signed-off-by: Jason Mobarak <j...@cozybit.com> Signed-off-by: Chun-Yeow Yeoh <yeohchuny...@cozybit.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

e system] > > url: > https://github.com/0day-ci/linux/commits/Bjorn-Andersson/Misc-wcn36xx-fixes/20160329-141847 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git > master > config: sparc64-allyesconfig (attached as .config) > reproduce

[PATCH 03/16] wcn36xx: Add helper macros to cast vif to private vif and vice versa

From: Pontus Fuchs <pontus.fu...@gmail.com> Makes the code a little easier to read. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/debug.c | 12 +++- drivers/net/wi

[PATCH 04/16] wcn36xx: Use consistent name for private vif

From: Pontus Fuchs <pontus.fu...@gmail.com> Some code used priv_vif and some used vif_priv. Convert all to vif_priv for consistency. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH 05/16] wcn36xx: Use define for invalid index and fix typo

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 2 +- drivers/net/wireless/ath/wcn36xx/main.c | 4 ++-- drivers/net/wi

[PATCH 01/16] wcn36xx: Clean up wcn36xx_smd_send_beacon

From: Pontus Fuchs <pontus.fu...@gmail.com> Needed for coming improvements. No functional changes. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 7 +-- driver

[PATCH 00/16] Misc wcn36xx fixes

As I was debugging some issues with the wcn36xx driver I found a series of patches that exists in Eugene's github tree but not in mainline. Noteworthy is the long requested feature of having working ARP support. Please apply these rebased and relocated patches. Jason Mobarak (1): wcn36xx:

[PATCH 11/16] wcn36xx: Use allocated self sta index instead of hard coded

From: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH 08/16] wcn36xx: Remove sta pointer in private vif struct

From: Pontus Fuchs <pontus.fu...@gmail.com> This does not work with multiple sta's in a vif. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 3 --- drivers/net/wi

[PATCH 09/16] wcn36xx: Parse trigger_ba response properly

From: Pontus Fuchs <pontus.fu...@gmail.com> This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/

[PATCH 12/16] wcn36xx: Clear encrypt_type when deleting bss key

From: Pontus Fuchs <pontus.fu...@gmail.com> This fixes a problem connecting to an open network after being connected to an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wi

[PATCH 10/16] wcn36xx: Copy all members in config_sta v1 conversion

From: Pontus Fuchs <pontus.fu...@gmail.com> When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames not being delivered on an encrypted network. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-o

[PATCH 14/16] wcn36xx: Implement multicast filtering

OMISC_IN_BSS usage] Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/hal.h | 6 ++-- drivers/net/wireless/ath/wcn36xx/main.c | 50 ++-- drivers/net/wi

[PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

From: Pontus Fuchs <pontus.fu...@gmail.com> For consistency with other code. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 16/16] wcn36xx: Use correct command struct for EXIT_BMPS_REQ

From: Pontus Fuchs <pontus.fu...@gmail.com> EXIT_BMPS_REQ was using the command struct for ENTER_BMPS_REQ. I spotted this when looking at command dumps. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- driver

[PATCH 15/16] wcn36xx: don't pad beacons for mesh

dy.beacon_length is incorrectly calculated for mesh mode. Fix this. Signed-off-by: Jason Mobarak <j...@cozybit.com> Signed-off-by: Chun-Yeow Yeoh <yeohchuny...@cozybit.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 5 +

[PATCH 13/16] wcn36xx: Track association state

From: Pontus Fuchs <pontus.fu...@gmail.com> Knowing the association state is needed for mc filtering. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 2 ++ driver

[PATCH 02/16] wcn36xx: Pad TIM PVM if needed

From: Pontus Fuchs <pontus.fu...@gmail.com> The wcn36xx FW expects a fixed size TIM PVM in the beacon template. If supplied with a shorter than expected PVM it will overwrite the IE following the TIM. Signed-off-by: Pontus Fuchs <pontus.fu...@gmail.com> Signed-off-by: Bjo

[PATCH 07/16] wcn36xx: Add helper macros to cast sta to priv

; Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 14 ++ drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 6 ++ 3 files changed, 18 insertions(+), 14 deleti

Re: [PATCH 3/4] wcn36xx: Transition driver to SMD client

this depends on changes to the wcnss_ctrl driver, which are being reviewed right now. Regards, Bjorn > 2015-12-28 1:34 GMT+00:00 Bjorn Andersson <bj...@kryo.se>: >> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD >> channel, as such it should be a SMD client. Th

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

On Tue, Dec 29, 2015 at 11:03 AM, Bjorn Andersson <bj...@kryo.se> wrote: > On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > >> On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: >> > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. >>

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > > HI Bjorn, > > On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson <bj...@kryo.se> wrote: > > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > > clients from h

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

On Wed, Dec 30, 2015 at 10:30 AM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson <bj...@kryo.se> wrote: >> On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> >> wrote: >>> >>

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > > Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> > > --- > >

Re: [PATCH 2/4] wcn36xx: Change indication list lock to spinlock

On Mon 28 Dec 15:06 PST 2015, Stephen Hemminger wrote: > On Sun, 27 Dec 2015 17:34:25 -0800 > Bjorn Andersson <bj...@kryo.se> wrote: > > > In preparation for handling incoming messages from IRQ context, change > > the indication list lock to a spinlock > > &

[PATCH 2/4] wcn36xx: Change indication list lock to spinlock

In preparation for handling incoming messages from IRQ context, change the indication list lock to a spinlock Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 2

[PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

Add binding representing the Qualcomm wcn3620/60/80 WiFi block. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- .../bindings/net/wireless/qcom,wcn36xx-wifi.txt| 76 ++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devi

[PATCH 1/4] wcn36xx: Fold indication payload into message header

Merge the two allocation instead of separately allocating room for the indication payload. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wireless/ath/wcn36xx/smd.c | 15 ++- drivers/net/wireless/ath/wcn36xx/smd.h | 2 +- 2 files chan

[PATCH 3/4] wcn36xx: Transition driver to SMD client

The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> --- drivers/net/wirele

[PATCH 0/4] WCN36xx convert to mainline SMD interface

during boot of the WCNSS core. This is being worked on separately. [1] https://lkml.org/lkml/2015/12/27/185 Bjorn Andersson (4): wcn36xx: Fold indication payload into message header wcn36xx: Change indication list lock to spinlock wcn36xx: Transition driver to SMD client dt: binding: Add

Re: [PATCH v2] wcn36xx: handle rx skb allocation failure to avoid system crash

On Mon 14 Dec 02:06 PST 2015, Fengwei Yin wrote: > Lawrence reported that git clone could make system crash on a > Qualcomm ARM soc based device (DragonBoard, 1G memory without > swap) running 64bit Debian. > > It's turned out the crash is related with rx skb allocation > failure. git could

Re: [PATCH 4/5] wcn3620: use new response format for wcn3620 trigger_ba

On Mon, Nov 9, 2015 at 7:40 AM, Bob Copeland wrote: > On Mon, Nov 09, 2015 at 05:02:41AM -0500, Yin, Fengwei wrote: >> From: Andy Green >> >> From: Andy Green >> >> On wcn3620, firmware response to trigger_ba uses the new,

Re: [PATCH] wcn36xx: Remove warning message when dev is NULL for arm64 dma_alloc.

[] ieee80211_do_open+0x1b0/0x9a4 > [] ieee80211_open+0x58/0x68 > [] __dev_open+0xb0/0x120 > [] __dev_change_flags+0x88/0x150 > [] dev_change_flags+0x1c/0x5c > [] devinet_ioctl+0x644/0x6f0 > > Signed-off-by: Yin, Fengwei <fengwei@linaro.org> Acked-by: Bjorn Andersson <bj

Re: [PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

On Thu, Oct 22, 2015 at 11:57 AM, Punit Vara wrote: Hi Punit, > Remove empty line suggested by Sergei > A commit message is here to, in the future, help us all understand what and why this change was made, so you should not include comments about what you changed since a

Re: [PATCH 1/2] net wireless wcn36xx add wcnss platform code

On Sat, Jan 17, 2015 at 9:16 PM, Andy Green andy.gr...@linaro.org wrote: From: Eugene Krasnikov k.eugen...@gmail.com AG modified to remove regulator handling not needed on msm8916-qrd Signed-off-by: Eugene Krasnikov k.eugen...@gmail.com Signed-off-by: Andy Green andy.gr...@linaro.org ---

Re: [PATCH 6/7] net: wireless: wcn36xx: remove powersaving for wcn3620

On Sat, Jan 17, 2015 at 9:11 PM, Andy Green andy.gr...@linaro.org wrote: WCN3620 powersaving mode is not stable. Disable it if we're on a wcn3620 chip type. Signed-off-by: Andy Green andy.gr...@linaro.org --- drivers/net/wireless/ath/wcn36xx/main.c |4 1 file changed, 4

Re: [PATCH 6/7] net: wireless: wcn36xx: remove powersaving for wcn3620

On Mon, Feb 9, 2015 at 1:28 PM, Andy Green andy.gr...@linaro.org wrote: On 10 February 2015 at 05:11, Bjorn Andersson bj...@kryo.se wrote: On Feb 9, 2015 1:07 PM, Andy Green andy.gr...@linaro.org wrote: On 10 February 2015 at 01:54, Bjorn Andersson bj...@kryo.se wrote: On Sat, Jan 17, 2015

<    1   2