Re: [PATCH] staging: wilc1000: check for kmalloc allocation failures

On 26/03/18 16:35, Ajay Singh wrote: > Thanks for submitting the patch. > > On Wed, 21 Mar 2018 13:03:18 -0700 > Joe Perches <j...@perches.com> wrote: > >> On Wed, 2018-03-21 at 19:19 +, Colin King wrote: >>> From: Colin Ian King <colin.k...@canonic

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

On 29/12/17 07:44, Loic Poulain wrote: > Hi Colin, Bjorn, > > On 26 December 2017 at 21:13, Bjorn Andersson > <bjorn.anders...@linaro.org> wrote: >> On Tue 19 Dec 09:04 PST 2017, Colin King wrote: >> >>> From: Colin Ian King <colin.k...@canonical.

Re: [PATCH] mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

annel >= 484) > + else if (channel >= 184) > delta_idx = 3; > else if (channel < 44) > delta_idx = 3; > any possibility of adding: Reported-by: Colin Ian King <colin.k...@canonical.com>

Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

On 22/09/17 11:03, Joe Perches wrote: > On Fri, 2017-09-22 at 09:23 +0200, Julia Lawall wrote: >> >> On Thu, 21 Sep 2017, Colin King wrote: >> >>> From: Colin Ian King <colin.k...@canonical.com> >>> >>> Don't populate const array ac_to_fifo

re: mac80211: avoid allocating TXQs that won't be used

Johannes, Static analysis with CoverityScan on linux-next today detected a null pointer dereference issue on commit: >From 0fc4b3403d215ecd3c05505ec1f0028a227ed319 Mon Sep 17 00:00:00 2001 From: Johannes Berg Date: Thu, 22 Jun 2017 12:20:29 +0200 Subject: [PATCH]

NACK: [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

On 12/08/17 23:00, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > The function btc8723b2ant_dac_swing is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'btc8723b2ant_

Re: [PATCH] rt2x00: make const array glrt_table static

On 12/07/17 07:49, Stanislaw Gruszka wrote: > On Tue, Jul 11, 2017 at 12:47:33PM +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> Don't populate array glrt_table on the stack but make it static. >> Makes the object code a smalle

Re: [PATCH][net-next] qtnfmac: fix uninitialized return code in ret

ed to be setup correctly. >> >> Detected by CoverityScan, CID#1437563 ("Unitialized scalar variable") >> >> Signed-off-by: Colin Ian King <colin.k...@canonical.com> >> --- >> drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +- >> 1 f

Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'

On 03/04/17 10:20, Joe Perches wrote: > On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> trivial fix to spelling mistake in wl1271_warning error message >> >> Signed-off-by: Colin Ian King <co

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

On 26/02/17 18:52, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/

Re: [PATCH] [media] gp8psk: fix spelling mistake: "firmare" -> "firmware"

On 29/12/16 21:23, VDR User wrote: >> - err("firmare chunk size bigger than 64 bytes."); >> + err("firmware chunk size bigger than 64 bytes."); > > Yup. > >> -"HW don't support CMAC encrypiton, use software >> CMAC

Re: [PATCH] mwifiex: fix memory leak on regd when chan is zero

On 15/09/16 18:10, Kalle Valo wrote: > Colin King <colin.k...@canonical.com> writes: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> When chan is zero mwifiex_create_custom_regdomain does not kfree >> regd and we have a memory leak. Fix

Re: [PATCH] ath10k: fix memory leak on caldata on error exit path

On 02/09/16 16:45, Valo, Kalle wrote: > Colin King <colin.k...@canonical.com> writes: > >> From: Colin Ian King <colin.k...@canonical.com> >> >> caldata is not being free'd on the error exit path, causing >> a memory leak. kfree it to fix the leak. &g

NACK: [PATCH] nfp: check idx is -ENOSPC before using it is an index

Ignore this, got some other fix included by mistake. Will resend. On 11/07/16 16:46, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > idx can be returned as -ENOSPC, so we should check for this first > before using it as an index into nn->vxlan_usecn

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

On 22/02/16 06:51, Alexander Stein wrote: > On Saturday 20 February 2016 22:10:27, Colin King wrote: >> From: Colin Ian King <colin.k...@canonical.com> >> >> passing rtl_stats by value is inefficient; the structure is over 300 >> bytes in size and generally j

Re: [PATCH] rtlwifi: ratelimit skb allocation failure message

On 10/02/15 13:48, Kalle Valo wrote: Eric Dumazet eric.duma...@gmail.com writes: On Tue, 2015-02-10 at 08:54 +, Colin King wrote: From: Colin Ian King colin.k...@canonical.com when running low on memory I noticed rtlwifi was producing a large quantity of repeated skb allocation