Re: WARNING in kernfs_add_one

2018-05-07 Thread Dmitry Vyukov
On Mon, May 7, 2018 at 10:43 AM, Johannes Berg wrote: > On Sat, 2018-05-05 at 15:07 -0700, Greg KH wrote: > >> > > > syzbot found the following crash on: > > Maybe it should learn to differentiate warnings, if it's going to set > panic_on_warn :-) How? Note that this is not specific to syzbot. If

Re: INFO: rcu detected stall in vprintk_default

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 12:50 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) > Merge branch 'perf-urgent-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > syzbot dashb

Re: INFO: rcu detected stall in vprintk_func

2018-04-01 Thread Dmitry Vyukov
On Sun, Apr 1, 2018 at 12:49 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 3eb2ce825ea1ad89d20f7a3b5780df850e4be274 (Sun Mar 25 22:44:30 2018 +) > Linux 4.16-rc7 > syzbot dashboard link: > https://syzkaller.appspot.com/bug?extid=3f28bd18291266ec826b > > Unf

Re: WARNING in check_flush_dependency

2018-02-19 Thread Dmitry Vyukov
On Wed, Jan 24, 2018 at 8:39 AM, Johannes Berg wrote: > On Mon, 2018-01-22 at 23:39 -0800, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on upstream commit >> 0d665e7b109d512b7cae3ccef6e8654714887844 (Fri Jan 19 12:49:24 2018 +) >> mm, page_vma_mapped: Drop faulty pointer arithm

Re: WARNING in sysfs_warn_dup

2018-01-22 Thread Dmitry Vyukov
On Mon, Jan 22, 2018 at 3:45 PM, Greg KH wrote: > On Mon, Jan 22, 2018 at 03:30:12PM +0100, Dmitry Vyukov wrote: >> On Mon, Jan 22, 2018 at 3:00 PM, Greg KH wrote: >> > On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: >> >> On Tue, Dec 19, 2

Re: [PATCH] sysfs: turn WARN() into pr_warn()

2018-01-22 Thread Dmitry Vyukov
he automated testing > tools a lot harder to find the real bugs in the kernel. > > So just print a warning out and dump the stack to get the attention of > the developer that they did something foolish. Then keep on trucking, > as this should not be a fatal error at all. > > Re

Re: WARNING in sysfs_warn_dup

2018-01-22 Thread Dmitry Vyukov
On Mon, Jan 22, 2018 at 3:00 PM, Greg KH wrote: > On Mon, Jan 22, 2018 at 02:47:33PM +0100, Dmitry Vyukov wrote: >> On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov wrote: >> > On Tue, Dec 19, 2017 at 10:03 AM, Dmitry Vyukov wrote: >> >> >> >>

Re: WARNING in sysfs_warn_dup

2018-01-22 Thread Dmitry Vyukov
On Tue, Dec 19, 2017 at 10:06 AM, Dmitry Vyukov wrote: > On Tue, Dec 19, 2017 at 10:03 AM, Dmitry Vyukov wrote: >> >> On Tue, Dec 19, 2017 at 10:01 AM, Greg KH wrote: >>> >>> On Mon, Dec 18, 2017 at 08:57:01AM -0800, syzbot wrote: >>> > Hello, >

Re: WARNING in rfkill_alloc

2018-01-15 Thread Dmitry Vyukov
On Mon, Jan 15, 2018 at 1:01 PM, Johannes Berg wrote: > On Mon, 2018-01-15 at 10:12 +0100, Dmitry Vyukov wrote: > >> However, there can be some surprising things, for example, executing >> one ioctl/setsockopt with data meant for another one, or these >> 0x

Re: WARNING in rfkill_alloc

2018-01-15 Thread Dmitry Vyukov
On Mon, Jan 15, 2018 at 9:57 AM, Johannes Berg wrote: > Hi, > >> RIP: 0010:rfkill_alloc+0x2c0/0x380 net/rfkill/core.c:930 > > This seems pretty obvious - there's no name given. > >> wiphy_new_nm+0x159c/0x21d0 net/wireless/core.c:487 >> ieee80211_alloc_hw_nm+0x4b4/0x2140 net/mac80211/main.c:531

Re: WARNING in wiphy_register

2018-01-15 Thread Dmitry Vyukov
On Mon, Jan 15, 2018 at 9:22 AM, Johannes Berg wrote: > Hi syzbot maintainers, > > Thanks for the report. > >> hwsim_new_radio_nl+0x5b7/0x7c0 drivers/net/wireless/mac80211_hwsim.c:3152 >> genl_family_rcv_msg+0x7b7/0xfb0 net/netlink/genetlink.c:599 >> genl_rcv_msg+0xb2/0x140 net/netlink/genet

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-19 Thread Dmitry Vyukov
On Mon, Oct 16, 2017 at 2:19 PM, Dmitry Vyukov wrote: > On Mon, Oct 16, 2017 at 11:40 AM, Stanislaw Gruszka > wrote: >> Hi Dmitry >> >> On Sat, Oct 14, 2017 at 04:38:03PM +0200, Dmitry Vyukov wrote: >>> On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka >&

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-16 Thread Dmitry Vyukov
On Mon, Oct 16, 2017 at 12:27 PM, Kalle Valo wrote: > Dmitry Vyukov writes: > >> On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka >> wrote: >>> Hi >>> >>> On Mon, Oct 09, 2017 at 07:50:53PM +0200, Andrey Konovalov wrote: >>>> I&

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-16 Thread Dmitry Vyukov
On Mon, Oct 16, 2017 at 11:40 AM, Stanislaw Gruszka wrote: > Hi Dmitry > > On Sat, Oct 14, 2017 at 04:38:03PM +0200, Dmitry Vyukov wrote: >> On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka >> wrote: >> > Hi >> > >> > On Mon, Oct 09,

Re: usb/net/rt2x00: warning in rt2800_eeprom_word_index

2017-10-14 Thread Dmitry Vyukov
On Thu, Oct 12, 2017 at 9:25 AM, Stanislaw Gruszka wrote: > Hi > > On Mon, Oct 09, 2017 at 07:50:53PM +0200, Andrey Konovalov wrote: >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f (4.14-rc4). >> >> I'm not sure whe

net/rfkill: WARNING in rfkill_fop_read

2016-01-26 Thread Dmitry Vyukov
Hello, The following program triggers WARNING message in rfkill_fop_read: [ cut here ] WARNING: CPU: 2 PID: 6975 at kernel/sched/core.c:7663 __might_sleep+0x138/0x1a0() do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait_event+0x141/0x410 kernel/

Re: [Patch net] nfc: check sock state in llcp_sock_getname()

2016-01-02 Thread Dmitry Vyukov
o play lock-free then you also need proper memory barriers. Stores to sk_state need to be smp_store_release, while the load needs to be smp_load_acquire. Otherwise getname still can see partially initialized socket. > Reported-by: Dmitry Vyukov > Cc: Lauro Ramos Venancio > Cc: Aloi

net/nfc: GPF in llcp_sock_getname

2016-01-01 Thread Dmitry Vyukov
Hello, The following program triggers GPF in llcp_sock_getname: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include #include #include int fd; void *thr(void *arg) { struct sockaddr_nfc_llcp sa; sa.sa_fa

net/nfc: user-controllable kmalloc size in nfc_llcp_send_ui_frame

2015-12-30 Thread Dmitry Vyukov
Hello, The following program triggers WARNING In kmalloc: [ cut here ] WARNING: CPU: 2 PID: 6754 at mm/page_alloc.c:2989 __alloc_pages_nodemask+0x771/0x15f0() Modules linked in: CPU: 2 PID: 6754 Comm: a.out Not tainted 4.4.0-rc7+ #181 Hardware name: QEMU Standard PC (i440

Re: Information leak in llcp_sock_bind/llcp_raw_sock_bind

2015-12-16 Thread Dmitry Vyukov
On Tue, Dec 15, 2015 at 9:58 PM, David Miller wrote: > From: Dmitry Vyukov > Date: Tue, 15 Dec 2015 21:55:37 +0100 > >> I've seen a kernel address at least in pptp_bind, > > We're not talking about pptp_bind. > > We're talking about llcp_{,raw}_sock_bi

Re: Information leak in llcp_sock_bind/llcp_raw_sock_bind

2015-12-15 Thread Dmitry Vyukov
On Tue, Dec 15, 2015 at 9:48 PM, David Miller wrote: > From: Dmitry Vyukov > Date: Tue, 15 Dec 2015 21:45:16 +0100 > >> On Tue, Dec 15, 2015 at 9:36 PM, David Miller wrote: >>> From: Dmitry Vyukov >>> Date: Tue, 15 Dec 2015 21:00:20 +0100 >>&g

Re: Information leak in llcp_sock_bind/llcp_raw_sock_bind

2015-12-15 Thread Dmitry Vyukov
On Tue, Dec 15, 2015 at 9:36 PM, David Miller wrote: > From: Dmitry Vyukov > Date: Tue, 15 Dec 2015 21:00:20 +0100 > >> The problem is that llcp_sock_bind/llcp_raw_sock_bind do not check >> sockaddr_len passed in, so they copy stack garbage from stack into the >> s

Information leak in llcp_sock_bind/llcp_raw_sock_bind

2015-12-15 Thread Dmitry Vyukov
Hello, The following program leads to leak of unint bytes from kernel stack: #include #include #include #include #include #include #include #include #include #include #include #include #define NFC_SOCKPROTO_LLCP 1 int main(void) { struct sockaddr sa; unsigned len, i,