Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

ing functionality. >> Oh, I didn't realise it had that many patches. But the driver is >> orphaned and doesn't have a maintainer so could I then have an ack from >> one of the active contributors that this ok? > > Fine by me. > > $ ./scripts/get_maintainer.pl -f --git dri

[PATCH v2 2/2] wlcore/wl18xx: add radar_debug_mode handling

for it when initializing ap vif. Signed-off-by: Eliad Peller <el...@wizery.com> --- drivers/net/wireless/ti/wl18xx/debugfs.c | 66 drivers/net/wireless/ti/wl18xx/event.c | 3 +- drivers/net/wireless/ti/wlcore/init.c| 5 +++ drivers/net/wireless/ti/

[PATCH v2 1/2] wlcore: don't WARN_ON in case of existing ROC

When working with AP + P2P, it's possible to get into a state when the AP is in ROC (due to assiciating station) while trying to ROC on the P2P interface. Replace the WARN_ON with wl1271_error to avoid warnings in this case. Signed-off-by: Eliad Peller <el...@wizery.com> --- v2: fix

[PATCH 2/2] wlcore/wl18xx: add radar_debug_mode handling

for it when initializing ap vif. Signed-off-by: Eliad Peller <el...@wizery.com> --- drivers/net/wireless/ti/wl18xx/debugfs.c | 66 drivers/net/wireless/ti/wl18xx/event.c | 3 +- drivers/net/wireless/ti/wlcore/init.c| 5 +++ drivers/net/wireless/ti/

[PATCH 1/2] wlcore: don't WARN_ON in case of existing ROC

When working with AP + P2P, it's possible to get into a state when the AP is in ROC (due to assiciating station) while trying to ROC on the P2P interface. Replace the WARN_ON with wl1271_error to avoid warnings in this case. Signed-off-by: Eliad Peller <el...@wizery.com> --- drive

Re: [PATCH V10 1/2] nl80211: add feature for BSS selection support

On Mon, Feb 29, 2016 at 11:44 AM, Arend van Spriel wrote: > Introducing a new feature that the driver can use to > indicate the driver/firmware supports configuration of BSS > selection criteria upon CONNECT command. This can be useful > when multiple BSS-es are found

Re: [PATCH V9 1/2] nl80211: add feature for BSS selection support

hi Arend, On Fri, Feb 26, 2016 at 10:59 PM, Arend van Spriel wrote: > Introducing a new feature that the driver can use to > indicate the driver/firmware supports configuration of BSS > selection criteria upon CONNECT command. This can be useful > when multiple BSS-es are

Re: [PATCH 2/3] iwlwifi: mvm: move TX PN assignment for TKIP to the driver

On Mon, Feb 15, 2016 at 11:16 AM, Grumbach, Emmanuel <emmanuel.grumb...@intel.com> wrote: > > > On 02/15/2016 11:06 AM, Eliad Peller wrote: >> On Sun, Feb 14, 2016 at 9:37 PM, Grumbach, Emmanuel >> <emmanuel.grumb...@intel.com> wrote: >>> >&

Re: [PATCH 2/3] iwlwifi: mvm: move TX PN assignment for TKIP to the driver

On Sun, Feb 14, 2016 at 9:37 PM, Grumbach, Emmanuel wrote: > > > On 02/14/2016 09:33 PM, Johannes Berg wrote: >> On Sun, 2016-02-14 at 19:34 +0200, Emmanuel Grumbach wrote: >>> >>> Since the 3rd patch needs to be dropped anyway, let's route this one >>> through my

Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

On Wed, Oct 21, 2015 at 10:07 PM, Punit Vara wrote: > Remove int ret suggested by kbuild test robot > > This patch is to the wlcore/acx.c file that fixes up warning > reported by coccicheck: > > WARNING: end returns can be simplified if negative or 0 value > > Prefer direct

Re: new regdb file format

On Mon, Oct 19, 2015 at 2:31 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Mon, 2015-10-19 at 14:28 +0300, Eliad Peller wrote: > >> while at it - is there any way to indicate exclusion of some >> channels? >> e.g. channels 38/42 in US (the current rule is

Re: new regdb file format

On Mon, Oct 19, 2015 at 2:53 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Mon, 2015-10-19 at 14:52 +0300, Eliad Peller wrote: >> >> > Hm? Why would you want to do that, if you are allowed to use that >> > band? >> > >> The spec se

Re: new regdb file format

On Thu, Oct 15, 2015 at 12:01 AM, Johannes Berg wrote: > Err. Let's try that again. > > I spent a bit of time thinking about a file format that would be more > extensible, yet still be loadable into the kernel without having to > parse it into new data structures in the

Re: Association race when acting as AP?

On Thu, Jul 2, 2015 at 1:39 PM, Michal Kazior michal.kaz...@tieto.com wrote: On 2 July 2015 at 10:43, Eliad Peller el...@wizery.com wrote: On Thu, Jul 2, 2015 at 11:38 AM, Johannes Berg johan...@sipsolutions.net wrote: [please try to send w/o html if you're CC'ing the linux-wireless list

Re: [PATCH 01/11] mac80211: add TX fastpath

On Mon, Apr 20, 2015 at 11:47 AM, Johannes Berg johan...@sipsolutions.net wrote: Hey, somebody is reviewing my patches :-) i didn't delve into them too much, but generally they look good :) + build.key = rcu_access_pointer(sta-ptk[sta-ptk_idx]); + if (!build.key) +

Re: [PATCH 01/11] mac80211: add TX fastpath

On Fri, Apr 17, 2015 at 6:15 PM, Johannes Berg johan...@sipsolutions.net wrote: From: Johannes Berg johannes.b...@intel.com In order to speed up mac80211's TX path, add the fast-xmit cache that will cache the data frame 802.11 header and other data to be able to build the frame more quickly.

Re: [PATCH v7 0/6] wlcore: add device-tree support

hi Nikita, On Tue, Mar 24, 2015 at 1:37 PM, Nikita Kiryanov nik...@compulab.co.il wrote: Hi Eliad, On 03/18/2015 06:38 PM, Eliad Peller wrote: Add device-tree support to the wlcore (wl12xx/wl18xx) driver. Update the current users to use the bindings instead of pdata-quirks. Finally

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

On Mon, Mar 23, 2015 at 10:21 AM, Sekhar Nori nsek...@ti.com wrote: On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its members

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

hi Sekhar, On Mon, Mar 23, 2015 at 9:51 AM, Sekhar Nori nsek...@ti.com wrote: + Ido On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its

Re: [PATCH] mac80211: stop scan before connection

On Tue, Mar 17, 2015 at 7:58 PM, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: From: David Spinadel david.spina...@intel.com Stop scan before authentication or association to make sure that nothing interferes with connection flow. this makes sense Currently mac80211 defers RX auth

Re: [PATCH] mac80211: stop scan before connection

On Wed, Mar 18, 2015 at 11:46 AM, Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2015-03-18 at 11:36 +0200, Eliad Peller wrote: On Tue, Mar 17, 2015 at 7:58 PM, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: From: David Spinadel david.spina...@intel.com Stop scan before

[PATCH v7 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

Coelho l...@coelho.fi [Eliad - small fixes, update board file changes] Signed-off-by: Eliad Peller el...@wizery.com --- v7: rebase arch/arm/mach-davinci/board-da850-evm.c | 3 +- arch/arm/mach-omap2/pdata-quirks.c | 29 drivers/net/wireless/ti/wl12xx/main.c | 60

[PATCH v7 4/6] wlcore: add device-tree support

When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad Peller el...@wizery.com Tested-by: Sébastien Szymanski sebastien.szyman...@armadeus.com

[PATCH v7 3/6] dt: bindings: add TI's wilink wireless device

Add device tree binding documentation for TI's wilink (wl12xx and wl18xx) wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- .../devicetree/bindings/net/wireless/ti,wlcore.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v7 6/6] wlcore: remove wl12xx_platform_data

...@coelho.fi Signed-off-by: Eliad Peller el...@wizery.com --- v7: * fix spi compilation (Tony) * remove irq/irq_trigger from wlcore_platdev_data (they are being passed separately) arch/arm/mach-davinci/Kconfig | 11 --- arch/arm/mach-davinci/board-da850-evm.c| 113

Re: [PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

+Kalle On Fri, Mar 13, 2015 at 5:00 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150312 05:09]: From: Luciano Coelho l...@coelho.fi Instead of defining an enumeration with the FW specific values for the different clock rates, use the actual frequency instead

Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data

On Fri, Mar 13, 2015 at 5:13 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150312 05:10]: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its members into the platform

Re: wl18xx: Bad format for rx_frames_per_rates in debugfs?

On Thu, Mar 12, 2015 at 2:39 PM, Nicolas Iooss nicolas.iooss_li...@m4x.org wrote: Hello, While adding __printf attributes to several functions in the kernel, I got a surprising gcc warning in drivers/net/wireless/ti/wl18xx/debugfs.c about format '%u' expects argument of type 'unsigned int',

[PATCH v6 4/6] wlcore: add device-tree support

When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad Peller el...@wizery.com --- v6: parse frequency properties, add wl12xx compatible strings

[PATCH v6 6/6] wlcore: remove wl12xx_platform_data

(and doesn't have DT bindings), so remove the relevant code/Kconfig option from the board file (as suggested by Sekhar Nori) Signed-off-by: Luciano Coelho l...@coelho.fi Signed-off-by: Eliad Peller el...@wizery.com --- arch/arm/mach-davinci/Kconfig | 11 --- arch/arm/mach-davinci

[PATCH v6 0/6] wlcore: add device-tree support

-tested only. I'm looking for some wl12xx card (that i should have somewhere) to test the wl12xx changes (wrt. clocks), but haven't found it yet. v6: * Add Luca's patches to pass irq_trigger/freq * Support wl12xx as well * Update all relevant platforms Eliad Peller (4): dt: bindings: add TI's

[PATCH v6 1/6] wlcore: set irq_trigger in board files instead of hiding behind a quirk

the quirk, have the board files set the irq_trigger explicitly. This will allow us to use standard irq DT definitions later on. Signed-off-by: Luciano Coelho l...@coelho.fi [Eliad - rebase, add irq_trigger field and pass it, update board file changes] Signed-off-by: Eliad Peller el...@wizery.com

[PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

Coelho l...@coelho.fi [Eliad - small fixes, update board file changes] Signed-off-by: Eliad Peller el...@wizery.com --- arch/arm/mach-davinci/board-da850-evm.c | 3 +- arch/arm/mach-omap2/pdata-quirks.c | 29 drivers/net/wireless/ti/wl12xx/main.c | 60

[PATCH v6 5/6] ARM: dts: add wl12xx/wl18xx bindings

Replace all the pdata-quirks for setting wl12xx/wl18xx platform data with proper DT definitions. The patch was compile-tested only. Signed-off-by: Eliad Peller el...@wizery.com --- v6: add wl12xx definitions as well arch/arm/boot/dts/am335x-evmsk.dts | 11 arch/arm/boot/dts

[PATCH v6 3/6] dt: bindings: add TI's wilink wireless device

Add device tree binding documentation for TI's wilink (wl12xx and wl18xx) wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- v6: add wl12xx, use IRQ_TYPE_LEVEL_HIGH .../devicetree/bindings/net/wireless/ti,wlcore.txt | 47 ++ 1 file changed, 47 insertions(+) create

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Wed, Mar 11, 2015 at 3:21 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: Right now it seems that all boards in mainline with a WiLink6 part are

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

hi Javier, On Wed, Mar 11, 2015 at 2:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Eliad, On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and omap3-igep0020-rev-f dts files, instead of defining

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

hi Javier, On Wed, Mar 11, 2015 at 3:19 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Eliad, On Wed, Mar 11, 2015 at 1:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: --- a/arch/arm/boot/dts

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

On Wed, Mar 11, 2015 at 11:51 AM, Arnd Bergmann a...@arndb.de wrote: +static void wlcore_del_platform_data(struct wl12xx_platform_data *pdata) +{ + kfree(pdata); +} + This function seems to be an unnecessary, why not just call kfree() directly? Or better, maybe the

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Wed, Mar 11, 2015 at 1:34 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: I think that patch [0] should not be needed since for external clocks, the IP providing the clocks should have its own clock driver and for internal clocks, a property should be used instead as you said. If

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150309 14:03]: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: I was expecting you to remove all calls to legacy_init_wl12xx from this file, including

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Tue, Mar 10, 2015 at 6:18 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150310 09:11]: On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren

[PATCH] mac80211: handle hw roc cancel vs. expiration race

-by: Eliad Peller el...@wizery.com --- net/mac80211/cfg.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index dd4ff36..a80f7b3 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -2782,7 +2782,22 @@ static int ieee80211_cancel_roc

Re: [PATCH] mac80211: handle hw roc cancel vs. expiration race

On Mon, Mar 9, 2015 at 2:52 PM, Johannes Berg johan...@sipsolutions.net wrote: On Mon, 2015-03-09 at 13:53 +0200, Eliad Peller wrote: Fix it by cancelling hw_roc_done on roc cancel. Since hw_roc_done takes local-mtx, temporarily release it (before re-acquiring it and starting the next roc

Re: [PATCH v3 2/2] wl18xx: add basic device-tree support

On Mon, Mar 9, 2015 at 10:50 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 09:18:46 Eliad Peller wrote: On Sun, Mar 8, 2015 at 11:53 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 08 March 2015 13:13:13 Eliad Peller wrote: I've looked up the what boards actually use

[PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and omap3-igep0020-rev-f dts files, instead of defining the platform data through the pdata-quirks. The patch was compile-tested only. Signed-off-by: Eliad Peller el...@wizery.com --- arch/arm/boot/dts/omap3-igep0020-rev-f.dts | 9

[PATCH v5 1/3] dt: bindings: add wl18xx wireless device

Add device tree binding documentation for TI's wl18xx wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- .../devicetree/bindings/net/wireless/ti,wl18xx.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/ti

[PATCH v5 2/3] wl18xx: add basic device-tree support

When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts @@ -64,4 +64,13 @@ vmmc-supply = lbep5clwmc_wlen; bus

Re: [PATCH v3 2/2] wl18xx: add basic device-tree support

On Sun, Mar 8, 2015 at 11:53 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 08 March 2015 13:13:13 Eliad Peller wrote: I've looked up the what boards actually use this data and found that all of them already support booting from DT: some omap2 boards using arch/arm/mach-omap2/pdata

[PATCH v4 2/2] wl18xx: add basic device-tree support

When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

[PATCH v4 1/2] dt: bindings: add wl18xx wireless device

Add device tree binding documentation for TI's wl18xx wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- v4: use specific wl18xx model numbers (Arnd) .../devicetree/bindings/net/wireless/ti,wl18xx.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644

Re: [PATCH v3 1/2] dt: bindings: add wl18xx wireless device

On Fri, Feb 27, 2015 at 10:14 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 19 February 2015 18:13:20 Eliad Peller wrote: +Required properties: + - compatible : Should be ti,wl18xx. Do not use wildcards in the compatible string, use specific model numbers. ok. i'll change it to ti

Re: [PATCH v2] wlcore: add basic device-tree support

hi Luca, On Fri, Feb 27, 2015 at 9:31 AM, Luca Coelho l...@coelho.fi wrote: Hi, On Sun, 2015-02-15 at 13:09 +0200, Eliad Peller wrote: When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now

Re: [PATCH v3 2/2] wl18xx: add basic device-tree support

On Fri, Feb 27, 2015 at 10:26 AM, Arnd Bergmann a...@arndb.de wrote: On Thursday 19 February 2015 18:13:21 Eliad Peller wrote: + +static struct wl12xx_platform_data *wlcore_probe_of(struct device *dev) +{ + struct device_node *np = dev-of_node; + struct wl12xx_platform_data

[PATCH v3 2/2] wl18xx: add basic device-tree support

When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

[PATCH v3 1/2] dt: bindings: add wl18xx wireless device

Add device tree binding documentation for TI's wl18xx wlan chip. Signed-off-by: Eliad Peller el...@wizery.com --- v3: * make the bindings device-specific (wl18xx) (Arnd, Mark) * split bindings and driver changes (Arnd) * make interrupt-parent optional (Arnd) * make unit-address same as reg

Re: [PATCH v2] wlcore: add basic device-tree support

On Tue, Feb 17, 2015 at 5:45 PM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Feb 17, 2015 at 03:39:03PM +, Eliad Peller wrote: On Mon, Feb 16, 2015 at 12:06 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 15 February 2015 13:09:10 Eliad Peller wrote: s + +This node provides

Re: [PATCH v2] wlcore: add basic device-tree support

On Mon, Feb 16, 2015 at 12:06 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 15 February 2015 13:09:10 Eliad Peller wrote: s + +This node provides properties for controlling the wilink wireless device. The +node is expected to be specified as a child node to the SDIO controller

[PATCH v2] wlcore: add basic device-tree support

When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties can be added later on. Signed-off-by: Ido Yariv i...@wizery.com Signed-off-by: Eliad

Re: [PATCH v2 3/3] mac80211: don't defer scans in case of radar detection

On Sun, Feb 8, 2015 at 5:56 PM, Jouni Malinen j...@w1.fi wrote: I don't see why returning EBUSY is wrong, though. Actually, it just make the test fail immediately, instead of waiting indefinitely until a timeout occurs (i guess, didn't actually test it with the reverted patch). This was

[PATCH] mac80211: clear sdata-radar_required

If ieee80211_vif_use_channel() fails, we have to clear sdata-radar_required (which we might have just set). Failing to do it results in stale radar_required field which prevents starting new scan requests. Reported-by: Jouni Malinen j...@w1.fi Signed-off-by: Eliad Peller el...@wizery.com

Re: [PATCH v2 3/3] mac80211: don't defer scans in case of radar detection

On Sun, Feb 8, 2015 at 3:17 PM, Janusz Dziedzic janusz.dzied...@tieto.com wrote: On 8 February 2015 at 11:57, Eliad Peller el...@wizery.com wrote: On Sat, Feb 7, 2015 at 9:17 PM, Janusz Dziedzic janusz.dzied...@tieto.com wrote: BTW, what in case we will start AP on first interface (DFS channel

Re: [PATCH v2 3/3] mac80211: don't defer scans in case of radar detection

Hi Jouni, On Sat, Feb 7, 2015 at 1:57 PM, Jouni Malinen j...@w1.fi wrote: On Wed, Jan 07, 2015 at 05:50:11PM +0200, Eliad Peller wrote: Radar detection can last indefinite time. There is no point in deferring a scan request in this case - simply return -EBUSY. diff --git a/net/mac80211

Re: [PATCH v2 3/3] mac80211: don't defer scans in case of radar detection

On Sat, Feb 7, 2015 at 9:17 PM, Janusz Dziedzic janusz.dzied...@tieto.com wrote: BTW, what in case we will start AP on first interface (DFS channel), on second one we will try to connect to other AP. As I understand this correctly, second iface (STA iface) will not allow to scan (connect) ...?

Re: [patch] wlcore: unlock on error in wl1271_op_suspend()

On Thu, Jan 15, 2015 at 1:43 PM, Dan Carpenter dan.carpen...@oracle.com wrote: We recently introduced a new error path which needs an unlock. Fixes: 6d5a748d4836 ('wlcore: add ability to reduce FW interrupts during suspend') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Static

Re: [PATCH RESEND 2/2] wlcore: align member-assigns in a structure-copy block

On Fri, Jan 9, 2015 at 7:03 PM, Kalle Valo kv...@codeaurora.org wrote: Giel van Schijndel m...@mortis.eu writes: This highlights the differences (e.g. the bug fixed in the previous commit). Signed-off-by: Giel van Schijndel m...@mortis.eu --- drivers/net/wireless/ti/wlcore/acx.c | 22

[PATCH v2 3/3] mac80211: don't defer scans in case of radar detection

Radar detection can last indefinite time. There is no point in deferring a scan request in this case - simply return -EBUSY. Signed-off-by: Eliad Peller el...@wizery.com --- v1-v2: use the newly introduced funcion net/mac80211/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 1/3] mac80211: remove local-radar_detect_enabled

cases (e.g. channel switch), simply check whether radar detection is enabled only when needed, instead of caching the result. Signed-off-by: Eliad Peller el...@wizery.com --- net/mac80211/cfg.c | 2 +- net/mac80211/chan.c| 5 ++--- net/mac80211/ieee80211_i.h | 3 +-- net/mac80211

[PATCH v2 2/3] mac80211: consider only relevant vifs for radar_required calculation

ctx-conf.radar_enabled should reflect whether radar detection is enabled for the channel context. When calculating it, make it consider only the vifs that have this context assigned (instead of all the vifs). Signed-off-by: Eliad Peller el...@wizery.com --- v1-v2: * add a new function (instead

Re: [PATCH 1/3] mac80211: consider only relevant vifs for radar_required calculation

On Tue, Jan 6, 2015 at 9:36 PM, Eliad Peller el...@wizery.com wrote: On Tue, Jan 6, 2015 at 9:02 PM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2015-01-06 at 20:57 +0200, Eliad Peller wrote: On Tue, Jan 6, 2015 at 4:14 PM, Johannes Berg johan...@sipsolutions.net wrote: On Tue

Re: [PATCH 1/3] mac80211: consider only relevant vifs for radar_required calculation

On Wed, Jan 7, 2015 at 6:32 PM, Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2015-01-07 at 17:58 +0200, Eliad Peller wrote: ap_ht_40mhz_intolerant_ap still seems to fail here, but it fails even when running only this test, without any of my patches applied. now i get the same error

Re: [PATCH 1/3] mac80211: consider only relevant vifs for radar_required calculation

On Tue, Jan 6, 2015 at 9:02 PM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2015-01-06 at 20:57 +0200, Eliad Peller wrote: On Tue, Jan 6, 2015 at 4:14 PM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2015-01-06 at 15:05 +0100, Johannes Berg wrote: On Tue, 2015-01-06

Re: [PATCH 1/3] mac80211: consider only relevant vifs for radar_required calculation

On Tue, Jan 6, 2015 at 4:14 PM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2015-01-06 at 15:05 +0100, Johannes Berg wrote: On Tue, 2015-01-06 at 12:04 +0100, Johannes Berg wrote: all three applied. Nope, dropped patch 2 again And dropped the other two also - with them the

[PATCH 1/3] mac80211: consider only relevant vifs for radar_required calculation

no need to consider all the vifs, but only the ones that have this context assigned. Signed-off-by: Eliad Peller el...@wizery.com --- This patch was already sent previously as part of a different patchset (in which the other patch was later dropped). However, i don't see it in patchwork, so

[PATCH 2/3] mac80211: don't defer scans in case of radar detection

Radar detection can last indefinite time. There is no point in deferring a scan request in this case - simply return -EBUSY. Signed-off-by: Eliad Peller el...@wizery.com --- net/mac80211/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/scan.c b/net/mac80211

[PATCH 3/3] mac80211: always recalc_radar on chanctx changes

). Signed-off-by: Eliad Peller el...@wizery.com --- net/mac80211/chan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/mac80211/chan.c b/net/mac80211/chan.c index 7f83451..9261cc0 100644 --- a/net/mac80211/chan.c +++ b/net/mac80211/chan.c @@ -629,10 +629,12 @@ out

[PATCH 09/13] wlcore: add support for ap csa

Support ap csa support by implementing the channel_switch_beacon() mac80211 op. Signed-off-by: Eliad Peller el...@wizery.com --- drivers/net/wireless/ti/wl18xx/cmd.c | 11 +++-- drivers/net/wireless/ti/wlcore/event.c | 10 +++-- drivers/net/wireless/ti/wlcore/main.c | 81

[PATCH 06/13] wlcore: enable sleep during AP mode operation

Leibovitch kobi.lev...@gmail.com Signed-off-by: Arik Nemtsov a...@wizery.com Signed-off-by: Eliad Peller el...@wizery.com --- drivers/net/wireless/ti/wl12xx/main.c | 1 + drivers/net/wireless/ti/wl18xx/acx.c| 32 drivers/net/wireless/ti/wl18xx/acx.h| 25

[PATCH 07/13] wl18xx: add radar detection implementation

Add support for CAC start/stop commands, and pass radar detection events from the fw to mac80211. Bump fw name (to wl18xx-fw-4.bin) and min fw version (to 8.9.*.*.11), and align event mailbox accordingly. Signed-off-by: Guy Mishol g...@ti.com Signed-off-by: Eliad Peller el...@wizery.com

[PATCH 01/13] wlcore: fix WLCORE_VENDOR_ATTR_GROUP_KEY policy

The attribute type is binary data (with max length). Signed-off-by: Eliad Peller el...@wizery.com --- drivers/net/wireless/ti/wlcore/vendor_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/vendor_cmd.c b/drivers/net/wireless/ti/wlcore

[PATCH 05/13] wlcore: enable AP wowlan

configure wowlan when host is suspended in AP mode, since the FW can now wake the host up on Rx. Signed-off-by: Kobi Leibovitch kobi.lev...@gmail.com Signed-off-by: Arik Nemtsov a...@wizery.com Signed-off-by: Eliad Peller el...@wizery.com --- drivers/net/wireless/ti/wlcore/main.c | 18

[PATCH 03/13] wlcore/wl18xx: handle rc updates in a separate work

sta_rc_update runs in atomic context. thus, a new work should be scheduled in order to configure the fw with the required configuration. Signed-off-by: Eliad Peller el...@wizery.com --- drivers/net/wireless/ti/wl18xx/main.c | 18 drivers/net/wireless/ti/wlcore/hw_ops.h

[PATCH 13/13] wl18xx: declare radar_detect_widths support for ap interfaces

After having all the dfs infrastructure in place, declare radar_detect_widths support for the ap interfaces combination. Signed-off-by: Eliad Peller el...@wizery.com --- drivers/net/wireless/ti/wl18xx/main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ti/wl18xx

[PATCH] mac80211: fix dot11MulticastTransmittedFrameCount tested address

dot11MulticastTransmittedFrameCount should be updated according to the DA, which might be different from hdr1. (Checking hdr1 results in the counter being 0 in case of station, as TODS data frames use hdr1 for the bssid address) Signed-off-by: Eliad Peller el...@wizery.com --- net/mac80211

Re: [PATCH] mac80211: fix dot11MulticastTransmittedFrameCount tested address

On Sun, Dec 21, 2014 at 4:19 PM, Fred Chou fred.chou...@gmail.com wrote: On 21/12/2014 9:25 PM, Eliad Peller wrote: dot11MulticastTransmittedFrameCount should be updated according to the DA, which might be different from hdr1. Shouldn't address 1 be used to determine whether the MPDU

[PATCH 1/2] mac80211: consider only relevant vifs for radar_required calculation

no need to consider all the vifs, but only the ones that have this context assigned. Signed-off-by: Eliad Peller el...@wizery.com --- net/mac80211/chan.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/net/mac80211/chan.c b/net/mac80211/chan.c index

[PATCH 2/2] mac80211: allow some multi-channel combinations with DFS master

() to consider this case, and look specifically for the chanctx with radar_enabled. Signed-off-by: Eliad Peller el...@wizery.com --- net/mac80211/main.c | 11 --- net/mac80211/util.c | 3 +++ net/wireless/core.c | 23 +-- 3 files changed, 20 insertions(+), 17 deletions(-) diff

Re: [PATCH] mac80211: fix dot11MulticastTransmittedFrameCount tested address

On Sun, Dec 21, 2014 at 6:25 PM, Johannes Berg johan...@sipsolutions.net wrote: On Sun, 2014-12-21 at 17:27 +0200, Eliad Peller wrote: On Sun, Dec 21, 2014 at 4:19 PM, Fred Chou fred.chou...@gmail.com wrote: On 21/12/2014 9:25 PM, Eliad Peller wrote: dot11MulticastTransmittedFrameCount

Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

hi, On Thu, Dec 18, 2014 at 2:51 PM, Arend van Spriel ar...@broadcom.com wrote: From: Gautam Kumar Shukla gaut...@broadcom.com The new feature flag allows the driver to indicate that it can offload the 4-way handshake for WPA/RSN-PSK. With the wiphy::features flag being used up this patch

Re: [RFC] cfg80211: Add feature flag for 4-way handshake offload

hi Arend, On Thu, Dec 18, 2014 at 5:21 PM, Arend van Spriel ar...@broadcom.com wrote: On 12/18/14 14:44, Eliad Peller wrote: On Thu, Dec 18, 2014 at 2:51 PM, Arend van Sprielar...@broadcom.com wrote: From: Gautam Kumar Shuklagaut...@broadcom.com The new feature flag allows the driver

Re: [PATCH] cfg80211: Warn once for delayed scan completion

On Tue, Oct 21, 2014 at 9:42 AM, Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2014-10-21 at 09:26 +0530, Sujith Manoharan wrote: Johannes Berg wrote: Maybe we need something like this: diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c index af0d094b2f2f..45b74ab1c59d

Re: SMPS for AP mode confoguration

hi, On Sun, Oct 19, 2014 at 2:50 PM, Krishna Chaitanya chaitanya.m...@gmail.com wrote: We are testing SMPS functionality for AP mode. The driver conveys its capabilities through setting the HT capability which can be set to 0-3. I wanted to convey support for both Dynamic and Static Powersave