Re: [PATCH v2] ath10k: transmit queued frames after waking queues

On 05/22/2018 11:15 PM, Niklas Cassel wrote: Earlier we observed performance issues in calling push_pending from each tx completion. IMHO this change may introduce the same problem again. I prefer functional TX over performance issues, but I agree that it is unfortunate that SDIO doesn't

Re: ath10k wake_tx_queue issues

Hello Niklas Quick question: Are you using my patch: "ath10k: add htt_tx num_pending window"? I assume (from your logs below) that you are not... See more comments below. I guess the best way to describe this is to show my ftrace buffer: ksoftirqd/2-21[002] .ns474.711744:

[PATCH] ath10k: fix return value check in wake_tx_q op

f this fix is that we will iterate the queue until ath10k_mac_tx_push_txq returns -ENOENT. This will make sure the queue is not added back to ar->txqs when it is empty. This could potentially improve performance somewhat (I have seen a small improvement with SDIO devices). Signed-off-by: E

[PATCH 0/2] ath10k: HTT ops wrappers

These two patches were included in the High latency v4 RFC submitted a few months ago. I think it would be appropriate to add them separately since they are not really related to the HL patches. This will make the next HL patch set somewhat smaller. Erik Stromdahl (2): ath10k: add inlined

[PATCH 1/2] ath10k: add inlined wrappers for htt tx ops

These wrappers makes the HTT ops align better with the HIF ops (where similar wrappers are used). It also makes it easier for a target to have unsupported ops (by letting the corresponding function pointer be NULL). Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drive

[PATCH 2/2] ath10k: add inlined wrappers for htt rx ops

Added for the same reason as the TX wrappers. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h| 37 drivers/net/wireless/ath/ath10k/htt_rx.c | 14 - 2 files changed, 44 insertions(+), 7 deletions(-)

[RFC v4 04/18] ath10k: high_latency detection

Add is_high_latency parameter to struct ath10k_bus_params. The setup of high latency chips is sometimes different than for chips using low latency interfaces. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/ahb.c | 1 + drivers/net/wirele

[RFC v4 16/18] ath10k: remove htt pending TX count for high latency

High latency chipsets does not seem to send any HTT_T2H_MSG_TYPE_TX_COMPL_IND for outgoing frames. This means that htt->num_pending_tx will never be decremented and we will eventually hit the maximum limit. All outgoing packets will then be discarded. Signed-off-by: Erik Stromdahl <erik.

[RFC v4 06/18] ath10k: per target config of max_num_peers

This patch makes sure the value of max_num_peers matches num_peers in hw_params (if set to a non zero value). Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c| 17 - drivers/net/wireless/ath/ath10k/hw.h | 3 +++ d

[RFC v4 07/18] ath10k: DMA related fixes for high latency devices

Several DMA related functions (such as the dma_map_xxx functions) are not used with high latency devices and don't need to be invoked in this case. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htc.c| 19 --- drivers/net/wi

[RFC v4 02/18] ath10k: add inlined wrappers for htt rx ops

Added for the same reason as the TX wrappers. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h| 38 drivers/net/wireless/ath/ath10k/htt_rx.c | 14 ++-- 2 files changed, 45 insertions(+), 7 del

[RFC v4 08/18] ath10k: various fixes for high latency devices

A few execution paths are not applicable for high latency devices and can be skipped. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt_rx.c | 3 ++- drivers/net/wireless/ath/ath10k/txrx.c | 2 +- 2 files changed, 3 insertions(+), 2 del

[RFC v4 12/18] ath10k: htt: RX ring config HL support

Special HTT RX ring config message used by high latency devices. The main difference between HL and LL is that HL devices do not use shared memory between device and host and thus, no host paddr's are added to the RX config message. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.

[RFC v4 13/18] ath10k: htt: High latency TX support

Add HTT TX function for HL interfaces. Intended for SDIO and USB. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt_tx.c | 92 1 file changed, 92 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/ht

[RFC v4 18/18] ath10k: add QCA9377 sdio hw_param item

Hardware parameters for QCA9377 sdio devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 26 ++ drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 27 insertions(+) diff --git a/drivers/net/wi

[RFC v4 11/18] ath10k: add HTT RX HL ops

Initial (empty) HTT RX ops for high latency devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt_rx.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wi

[RFC v4 14/18] ath10k: htt: High latency RX support

me control field. The chipset seems to do hw decryption but the frame_control protected bit is still set. This is necessary for mac80211 not to drop the frame. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h | 47 +++ drivers/

[RFC v4 03/18] ath10k: add struct ath10k_bus_params

This struct is used as argument to ath10k_core_register in order to make it easier to add more bus parameters in the future. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/ahb.c | 8 drivers/net/wireless/ath/ath10k/core.

[RFC v4 05/18] ath10k: add bus type check in ath10k_init_hw_params

. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 16 +++- drivers/net/wireless/ath/ath10k/core.h | 8 drivers/net/wireless/ath/ath10k/hw.h | 9 + 3 files changed, 24 insertions(+), 9 deletions(-) diff

[RFC v4 09/18] ath10k: add start_once support

to rerun the BMI phase (fw upload) without power-cycling the device. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 19 +++ drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wireless/ath/ath10k/hw.h | 6 +++

[RFC v4 15/18] ath10k: wmi: disable softirq's while calling ieee80211_rx

This is done in order not to trig the below warning in ieee80211_rx_napi: WARN_ON_ONCE(softirq_count() == 0); ieee80211_rx_napi requires that softirq's are disabled during execution. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 3

[RFC v4 17/18] ath10k: add QCA9377 usb hw_param item

Hardware parameters for QCA9377 usb devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 24 drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/wirele

[RFC v4 10/18] ath10k: add HTT TX HL ops

Initial HTT TX ops for high latency devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt_tx.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wirele

[RFC v4 00/18] ath10k high latency

emoves the pending TX counter), but since I don't know how to configure the device to generate HTT_T2H_MSG_TYPE_TX_COMPL_IND's the sw flow control had to be disabled. Since I no longer have access to any SDIO hardware I have not been able to try the SDIO stuff, so it might be broken. Erik Stromda

[RFC v4 01/18] ath10k: add inlined wrappers for htt tx ops

These wrappers makes the HTT ops align better with the HIF ops (where similar wrappers are used). It also makes it easier for a target to have unsupported ops (by letting the corresponding function pointer be NULL). Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drive

[PATCH 0/3] ath10k: a few minor fixes

71e9c29fbd28ec14bb8f920c7afd515a75c00234 The other two are just cleanups. Erik Stromdahl (3): ath10k: fix spelling error ath10k: remove unused prototype ath10k: bugfix: add USB case in ath10k_core_probe_fw drivers/net/wireless/ath/ath10k/core.c | 1 + drivers/net/wireless/ath/ath10k/htt.h | 1 - drivers/net

[PATCH 1/3] ath10k: fix spelling error

Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index b0ed38c05bf8..c7b30ed9015d

[PATCH 2/3] ath10k: remove unused prototype

The function does not exist and thus, the prototype can be removed. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k

[PATCH 3/3] ath10k: bugfix: add USB case in ath10k_core_probe_fw

Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 51444d34a06c..fe9341c97f31 100644 --- a/drive

Re: [RFC v3 03/11] ath10k: per target configurablity of various items

On 2017-12-22 16:19, Kalle Valo wrote: Erik Stromdahl <erik.stromd...@gmail.com> writes: Added ability to set bus type and configure the max number of peers in the ath10k_hw_params struct. With this functionality it is possible to have a different hw configuration depending on bu

Re: [PATCH 09/11] ath10k_sdio: virtual scatter gather for receive

On 2017-09-30 19:37, silexcom...@gmail.com wrote: From: Alagu Sankar The existing implementation of initiating multiple sdio transfers for receive bundling is slowing down the receive speed. Combining the transfers using a scatter gather method would be ideal.

Re: [PATCH 00/11] SDIO support for ath10k

with the WUSB6100M without any problems. On 02-10-2017 14:32, Erik Stromdahl wrote: Hi Alagu, It is great to see that we are finally about have fully working mainline support for QCA9377 SDIO chipsets! Great job! On 2017-09-30 19:37, silexcom...@gmail.com wrote: From: Alagu Sankar <alagusan...@si

Re: [PATCH 02/11] ath10k_sdio: wb396 reference card fix

Hi Alagu, On 2017-10-02 09:02, Alagu Sankar wrote: Hi Steve, On 2017-10-02 04:17, Steve deRosier wrote: Hi Alagu, On Sat, Sep 30, 2017 at 10:37 AM, wrote: From: Alagu Sankar The QCA9377-3 WB396 sdio reference card does not get

Re: [PATCH 00/11] SDIO support for ath10k

Hi Alagu, It is great to see that we are finally about have fully working mainline support for QCA9377 SDIO chipsets! Great job! On 2017-09-30 19:37, silexcom...@gmail.com wrote: From: Alagu Sankar This patchset, generated against master-pending branch, enables

[RFC v3 10/11] ath10k: wmi: disable softirq's while calling ieee80211_rx

Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 38a97086708b..10bb5be6ab00 100644 --- a/drive

[RFC v3 02/11] ath10k: htt: RX ring config HL support

Special HTT RX ring config message used by high latency devices. The main difference between HL and LL is that HL devices do not use shared memory between device and host and thus, no host paddr's are added to the RX config message. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.

[RFC v3 11/11] ath10k: remove htt pending TX count for high latency

High latency chipsest does not seem to send any HTT_T2H_MSG_TYPE_TX_COMPL_IND for outgoing frames. This means that htt->num_pending_tx will never be decremented and we will eventually hit the maximum limit. All outgoing packets will then be discarded. Signed-off-by: Erik Stromdahl <erik.

[RFC v3 08/11] ath10k: add QCA9377 usb hw_param item

Hardware parameters for QCA9377 usb devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 23 +++ drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/wirele

[RFC v3 00/11] ath10k high latency

onnection. Changes since v2: - Disabled htt num_pending_tx counter for HL. - Fixed transmit flags for HL HTT TX. - Proper marking of aggregated frames in the HL HTT RX handler. - A few other minor fixes Erik Stromdahl (11): ath10k: high_latency detection ath10k: htt: RX ring config HL support at

[RFC v3 04/11] ath10k: add start_once support

to rerun the BMI phase (fw upload) without power-cycling the device. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 19 +++ drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wireless/ath/ath10k/hw.h | 6 +++

[RFC v3 03/11] ath10k: per target configurablity of various items

device in order to prevent the target fw to crash after HTT RX ring cfg is issued. Apparently, the QCA9377 HL device does not seem to handle the same amount of peers as the LL devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c

[RFC v3 01/11] ath10k: high_latency detection

The setup of high latency chips (USB and SDIO) is sometimes different than for chips using low latency interfaces. The bus type is used to determine if the interface is a high latency interface. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/

[RFC v3 07/11] ath10k: various fixes for high latency devices

Several DMA related functions (such as the dma_map_xxx functions) are not used with high latency devices and don't need to be invoked in this case. A few other execution paths are not applicable for high latency devices and can be skipped. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.

[RFC v3 06/11] ath10k: htt: High latency RX support

me control field. The chipset seems to do hw decryption but the frame_control protected bit is still set. This is necessary for mac80211 not to drop the frame. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c| 27 --- drivers/net/wir

[RFC v3 09/11] ath10k: add QCA9377 sdio hw_param item

Hardware parameters for QCA9377 sdio devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 25 + drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/net/wi

[RFC v3 05/11] ath10k: htt: High latency TX support

Add HTT TX function for HL interfaces. Intended for SDIO and USB. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h| 9 ++-- drivers/net/wireless/ath/ath10k/htt_tx.c | 91 +++- drivers/net/wireless/ath/ath10k

[PATCH v2] ath10k: sdio: remove unused struct member

irq_wq in struct ath10k_sdio is a remnant from an earlier version of the sdio patchset. Its use was removed as a result of Kalle's review, but somehow the struct member survived. It is not used and can therefore safely be removed. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com>

[PATCH] ath10k: sdio: remove unused struct member

irq_wq in struct ath10k_sdio is a remnant from an earlier version of the sdio patchset. It's use was removed as a result of Kalle's review, but somehow the struct member survived. It is not used and can therefore safely be removed. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.

[PATCH] ath10k: sdio: fix compile warning

ss/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used uninitialized in this function ... drivers/net/wireless/ath/ath10k/sdio.c: In function ‘ath10k_sdio_irq_handler’: drivers/net/wireless/ath/ath10k/sdio.c:1331: warning: ‘ret’ may be used uninitialized in this function Signed-off-by: Erik St

Re: [RFC v2 05/10] ath10k: htt: High latency TX support

On 2017-06-13 19:38, Peter Oh wrote: On 06/12/2017 08:03 AM, Erik Stromdahl wrote: Add HTT TX function for HL interfaces. Intended for SDIO and USB. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wirele

[RFC v2 04/10] ath10k: add start_once support

to rerun the BMI phase (fw upload) without power-cycling the device. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 19 +++ drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wireless/ath/ath10k/hw.h | 6 +++

[RFC v2 09/10] ath10k: add QCA9377 sdio hw_param item

Hardware parameters for QCA9377 sdio devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 25 + drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/net/wi

[RFC v2 03/10] ath10k: per target configurablity of various items

device in order to prevent the target fw to crash after HTT RX ring cfg is issued. Apparently, the QCA9377 HL device does not seem to handle the same amount of peers as the LL devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c

[RFC v2 07/10] ath10k: dma fixes for high latency devices

Several DMA related functions (such as the dma_map_xxx functions) are not used with high latency devices and don't need to be invoked in this case. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htc.c| 13 - drivers/net/wirele

[RFC v2 05/10] ath10k: htt: High latency TX support

Add HTT TX function for HL interfaces. Intended for SDIO and USB. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h| 9 ++-- drivers/net/wireless/ath/ath10k/htt_tx.c | 72 +++- drivers/net/wireless/ath/ath10k

[RFC v2 01/10] ath10k: high_latency detection

The setup of high latency chips (USB and SDIO) is sometimes different than for chips using low latency interfaces. The bus type is used to determine if the interface is a high latency interface. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/

[RFC v2 08/10] ath10k: add QCA9377 usb hw_param item

Hardware parameters for QCA9377 usb devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 23 +++ drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/wirele

[RFC v2 10/10] ath10k: wmi: disable softirq's while calling ieee80211_rx

Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 472b42b..d5d0d5c 100644 --- a/drivers/net/wirele

[RFC v2 02/10] ath10k: htt: RX ring config HL support

Special HTT RX ring config message used by high latency devices. The main difference between HL and LL is that HL devices do not use shared memory between device and host and thus, no host paddr's are added to the RX config message. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.

[RFC v2 06/10] ath10k: htt: High latency RX support

me control field. The chipset seems to do hw decryption but the frame_control protected bit is still set. This is necessary for mac80211 not to drop the frame. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c| 38 +++- drivers/

[RFC v2 00/10] ath10k high latency

these calls removes a warning generated by mac80211. The previous RFC mentioned a problem related to this warning. >From Linux 4.12, the warning was not handled correctly and the warning was turned into an oops (I still don't know the reason for this). This version fixes this. Erik Stromdahl

Re: [PATCH 1/1] mac80211: ieee80211_rx_napi: remove warning

On 2017-06-07 23:57, Johannes Berg wrote: On Sun, 2017-06-04 at 15:11 +0200, Erik Stromdahl wrote: The softirq count is not always incremented during driver operation. This is the case for usb and sdio network drivers. I'm pretty sure the warning is correct, and we do rely on having

[PATCH 0/1] mac80211: removal of warning in RX path

4 15 66 85 ff 74 10 a8 04 ba 01 00 00 00 75 26 83 c8 04 <66> 89 41 0 a 66 85 ff 74 49 0f b6 49 0b 4c 89 e2 45 31 c9 49 89 [ 58.457842] RIP: report_bug+0x94/0x120 RSP: c9213a68 [ 58.458458] CR2: a00818ee [ 58.458826] ---[ end trace 1d0941df07be82c5 ]--- When mac80211 is built into the kernel everything is working as expected! I understand that this is really not an issue with mac80211, but perhaps you have experienced similar issues before. Perhaps it is a kernel config issue? I have used the default ARCH config (as I have always done), and it has never before caused any problems. Any ideas are welcome... Erik Stromdahl (1): mac80211: ieee80211_rx_napi: remove warning net/mac80211/rx.c | 2 -- 1 file changed, 2 deletions(-) -- 2.13.0

[PATCH 1/1] mac80211: ieee80211_rx_napi: remove warning

fb ff ff [ 27.439114] ---[ end trace 89f286e9814e824a ]--- Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- net/mac80211/rx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 1f75280ba26c..2ec54232817d 100644 --- a/net/mac8021

[RFC 4/9] ath10k: add start_once support

to rerun the BMI phase (fw upload) without power-cycling the device. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 19 +++ drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wireless/ath/ath10k/hw.h | 6 +++

[RFC 0/9] ath10k high latency

836095] ---[ end trace 887d2ccc4510936b ]--- Erik Stromdahl (9): ath10k: high_latency detection ath10k: htt: RX ring config HL support ath10k: per target configurablity of various items ath10k: add start_once support ath10k: htt: High latency TX support ath10k: htt: High latency RX s

[RFC 3/9] ath10k: per target configurablity of various items

device in order to prevent the target fw to crash after HTT RX ring cfg is issued. Apparently, the QCA9377 HL device does not seem to handle the same amount of peers as the LL devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c

[RFC 7/9] ath10k: dma fixes for high latency devices

Several DMA related functions (such as the dma_map_xxx functions) are not used with high latency devices and don't need to be invoked in this case. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htc.c| 13 - drivers/net/wirele

[RFC 6/9] ath10k: htt: High latency RX support

me control field. The chipset seems to do hw decryption but the frame_control protected bit is still set. This is necessary for mac80211 not to drop the frame. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c| 38 - drivers/

[RFC 2/9] ath10k: htt: RX ring config HL support

Special HTT RX ring config message used by high latency devices. The main difference between HL and LL is that HL devices do not use shared memory between device and host and thus, no host paddr's are added to the RX config message. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.

[RFC 5/9] ath10k: htt: High latency TX support

Add HTT TX function for HL interfaces. Intended for SDIO and USB. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h| 9 ++-- drivers/net/wireless/ath/ath10k/htt_tx.c | 72 +++- drivers/net/wireless/ath/ath10k

[RFC 1/9] ath10k: high_latency detection

The setup of high latency chips (USB and SDIO) is sometimes different than for chips using low latency interfaces. The bus type is used to determine if the interface is a high latency interface. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/

[RFC 8/9] ath10k: add QCA9377 usb hw_param item

Hardware parameters for QCA9377 usb devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 23 +++ drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/net/wirele

[RFC 9/9] ath10k: add QCA9377 sdio hw_param item

Hardware parameters for QCA9377 sdio devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 25 + drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/net/wi

[RFC v2 0/3] ath10k usb support

was actually thinking about squashing all the patches into one, but decided not to do so since I wanted usb.h, usb.c and the update Kconfig + Makefile in one separate patch. Perhaps patch 1 and 2 should be squashed? Erik Stromdahl (3): ath10k: various usb related definitions ath10k: different fw

[RFC v2 2/3] ath10k: different fw file names for usb

USB firmware will be named in the same way as SDIO files, i.e, the bus type will be added to the firmware file name. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wirele

[RFC v2 3/3] ath10k: add initial USB support

. For that reason we print during initialisation: WARNING: ath10k USB support is incomplete, don't expect anything to work! Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/Kconfig |7 + drivers/net/wireless/ath/ath10k/Makefile |3 + drive

[RFC v2 1/3] ath10k: various usb related definitions

Definitions for USB based chipsets Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.h | 3 +++ drivers/net/wireless/ath/ath10k/debug.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drive

Re: [PATCH v7 00/10] ath10k: sdio support

On 2017-04-13 10:28, Kalle Valo wrote: More changes to Erik's SDIO patches. The biggest change in this round is refactoring of the ugly ath10k_sdio_io() function. Only compile tested, I don't have any SDIO boards at the moment. I have tested the patches and they are working as expected...

Re: [PATCH 0/7] ath10k: remove ath10k_sdio_io()

I have made some basic testing (AP scanning) with this patchset and as far as I can see they haven't broken anything. I have not exercised all code (like error interrupt handling etc.) so those patches might contain bugs (I noticed a FIXME comment in one of them). I will review those patches

Re: [PATCH 0/7] ath10k: remove ath10k_sdio_io()

On 2017-04-05 18:53, Kalle Valo wrote: Erik Stromdahl <erik.stromd...@gmail.com> writes: I can't find patch 1/7... Odd, apparently it didn't get delivered to ath10k list but did get to linux-wireless. You can find the patch from linux-wireless patchwork: https://patchwork.kernel.org

Re: [PATCH 0/7] ath10k: remove ath10k_sdio_io()

I can't find patch 1/7... On 2017-04-05 09:06, Kalle Valo wrote: Using ath10k_sdio_io() and ath10k_sdio_read_write_sync() are just confusing. Refactor the code by following the plan outlined below. I'm planning to fold all these seven patches into Erik's patch adding sdio.c[1] so I didn't

Re: [PATCH v6 00/10] ath10k: sdio support

Please let me know if there is anything I can help with... I will test the patches as soon as v7 is submitted. On 2017-03-28 13:53, Kalle Valo wrote: Kalle Valo writes: I did some changes while reviewing Erik's SDIO patches. Only compile tested, I don't have any

Re: [RFC v4 06/21] ath10k: sdio support

On 2017-03-16 10:33, Kalle Valo wrote: Erik Stromdahl <erik.stromd...@gmail.com> writes: There seems to be same pattern for reading four bytes, what if we should add a helper for that? Something like ath10k_sdio_read32()? It could handle the kmalloc and switch endianess also. But

Re: [PATCH v6 03/10] ath10k: htc: move htc ctrl ep connect to htc_init

On 2017-03-16 02:06, Ryan Hsu wrote: On 03/15/2017 08:45 AM, Kalle Valo wrote: From: Erik Stromdahl <erik.stromd...@gmail.com> This patch moves the HTC ctrl service connect from htc_wait_target to htc_init. This is done in order to make sure the htc ctrl service is setup properly

Re: [RFC v4 06/21] ath10k: sdio support

On 2017-03-15 13:09, Kalle Valo wrote: Erik Stromdahl <erik.stromd...@gmail.com> writes: On 2017-03-10 13:43, Valo, Kalle wrote: "Valo, Kalle" <kv...@qca.qualcomm.com> writes: Erik Stromdahl <erik.stromd...@gmail.com> writes: sdio/mailbox HIF implemen

Re: [RFC v4 06/21] ath10k: sdio support

On 2017-03-11 16:04, Kalle Valo wrote: Erik Stromdahl <erik.stromd...@gmail.com> writes: You are right, there is definitely a memory leak (and there are similar problems in a couple of other functions as well as you have pointed out). This was introduced in version 3 of the RFC

Re: [RFC v4 06/21] ath10k: sdio support

On 2017-03-10 17:29, Erik Stromdahl wrote: On 2017-03-10 13:43, Valo, Kalle wrote: "Valo, Kalle" <kv...@qca.qualcomm.com> writes: Erik Stromdahl <erik.stromd...@gmail.com> writes: sdio/mailbox HIF implementation. Signed-off-by: Erik Stromdahl <erik.stromd...

Re: [RFC v4 06/21] ath10k: sdio support

On 2017-03-10 13:43, Valo, Kalle wrote: "Valo, Kalle" <kv...@qca.qualcomm.com> writes: Erik Stromdahl <erik.stromd...@gmail.com> writes: sdio/mailbox HIF implementation. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> I'm looking at this mo

[RFC v4 15/21] ath10k: per target configurablity of various items

device in order to prevent the target fw to crash after HTT RX ring cfg is issued. Apparently, the QCA9377 HL device does not seem to handle the same amount of peers as the LL devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c

[RFC v4 11/21] ath10k: usb support

usb HIF implementation Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/Kconfig |6 + drivers/net/wireless/ath/ath10k/Makefile |3 + drivers/net/wireless/ath/ath10k/usb.c| 1125 ++ drivers/net/wirele

[RFC v4 08/21] ath10k: sdio get target info

Special BMI get target info function for SDIO. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/bmi.c | 70 ++ drivers/net/wireless/ath/ath10k/bmi.h | 2 + drivers/net/wireless/ath/ath10k/core.c | 5 ++- 3

[RFC v4 17/21] ath10k: htt: High latency TX support

Add HTT TX function for HL interfaces. Intended for SDIO and USB. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htt.h| 9 ++-- drivers/net/wireless/ath/ath10k/htt_tx.c | 72 +++- drivers/net/wireless/ath/ath10k

[RFC v4 18/21] ath10k: htt: High latency RX support

me control field. The chipset seems to do hw decryption but the frame_control protected bit is still set. This is necessary for mac80211 not to drop the frame. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c| 38 - drivers/

[RFC v4 20/21] ath10k: add QCA9377 sdio hw_param item

Hardware parameters for QCA9377 sdio devices. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 25 + drivers/net/wireless/ath/ath10k/hw.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/net/wi

[RFC v4 07/21] ath10k: add sdio extra initializations

Extra initializations needed by all sdio boards. Derived from qcacld. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/cor

[RFC v4 10/21] ath10k: various usb related definitions

Definitions for USB based chipsets Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.h | 3 +++ drivers/net/wireless/ath/ath10k/debug.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drive

[RFC v4 21/21] ath10k: dma fixes for high latency devices

Several DMA related functions (such as the dma_map_xxx functions) are not used with high latency devices and don't need to be invoked in this case. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/htc.c| 13 - drivers/net/wirele

[RFC v4 12/21] ath10k: high_latency detection

The setup of high latency chips (USB and SDIO) is sometimes different than for chips using low latency interfaces. The bus type is used to determine if the interface is a high latency interface. Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/

[RFC v4 13/21] ath10k: different fw file names for usb and sdio

Signed-off-by: Erik Stromdahl <erik.stromd...@gmail.com> --- drivers/net/wireless/ath/ath10k/core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 39c407e..9d60f4b 100644 --- a/d

  1   2   >