Re: [PATCH 00/27] mtd: rawnand: Improve compile-test coverage

2018-07-05 Thread Geert Uytterhoeven
mbined with COMPILE_TEST, do you plan to do something similar with > HAS_IOMEM? No plans for that. NO_IOMEM is Richard's itch, now s390 has gained PCI support. NO_DMA matters for UML and Sun-3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -

Re: [PATCH 00/16] remove eight obsolete architectures

2018-03-15 Thread Geert Uytterhoeven
Hi David, On Thu, Mar 15, 2018 at 10:42 AM, David Howells <dhowe...@redhat.com> wrote: > Do we have anything left that still implements NOMMU? Sure: arm, c6x, m68k, microblaze, and sh. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux be

[PATCH trivial resend^2] net: Spelling s/stucture/structure/

2018-03-02 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/ethernet/ti/tlan.c | 2 +- drivers/net/wireless/atmel/atmel.c | 2 +- include/net/iw_handler.h | 2 +- net/socket.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff

Re: Build regressions/improvements in v4.15-rc1

2017-11-27 Thread Geert Uytterhoeven
On Mon, Nov 27, 2017 at 11:01 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > Below is the list of build error/warning regressions/improvements in > v4.15-rc1[1] compared to v4.14[2]. > > Summarized: > - build errors: +2/-5 > [1] > http://kisskb

Re: ath10k: ret used but uninitialized

2017-07-07 Thread Geert Uytterhoeven
h the style of initialising ret to zero, >> it tends to hide things. Instead my preference is something like below >> where the error handling is more explicit and easier to find where it's >> exactly failing. But that's just an example how I would try to solve it, >> it still lacks t

ath10k: ret used but uninitialized (was: Re: ath10k: add initial SDIO support)

2017-07-06 Thread Geert Uytterhoeven
re(jiffies, timeout) && !done) { > + ret = ath10k_sdio_mbox_proc_pending_irqs(ar, ); > + if (ret) > + break; > + } > + > + sdio_claim_host(ar_sdio->func); > + > + wake_up(_sdio->irq_wq); > + >

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Geert Uytterhoeven
build-testing is really all you need. Any > problems caused by adding 'const' to a definition will be seen by build > errors or warnings. Unfortunately in this particular case they could lead to failures that can only be detected at runtime, when failing o write to a read-only piece of m

[PATCH] drivers: misc: ti-st: Use int instead of fuzzy char for callback status

2016-06-06 Thread Geert Uytterhoeven
is used to pass a (negative) error code, it should always be signed. 2. EINPROGRESS is 150 on mips, 245 on parisc. Hence -EINPROGRESS doesn't fit in a signed 8-bit number. Change the callback status from "char" to "int" to fix these. Signed-off-by: Geert Uytterhoeven <g

[PATCH v2] NFC: fdp: Detect errors from fdp_nci_create_conn()

2016-06-05 Thread Geert Uytterhoeven
of data type fdp_nci_create_conn() may return a negative error code, which is silently ignored by assigning it to a u8. Change conn_id from u8 to int to fix this. Fixes: a06347c04c13e380 ("NFC: Add Intel Fields Peak NFC solution driver") Signed-off-by: Geert Uytterhoeven <ge...@l

[PATCH 33/54] MAINTAINERS: Add file patterns for wireless device tree bindings

2016-05-22 Thread Geert Uytterhoeven
Submitters of device tree binding documentation may forget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Cc: Kalle Valo <kv...@codeaurora.org> Cc: linux-wireless@vger.kernel.org --- Please apply this patch directly

[PATCH trivial] mwifiex: Spelling s/minmum/minimum/, s/bandwidth/bandwith/

2016-03-14 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> --- drivers/net/wireless/marvell/mwifiex/tdls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c index 9275f9c3f8

Re: pull-request: wireless-drivers 2016-02-18

2016-02-29 Thread Geert Uytterhoeven
LESS_MODE_AC_5G || wireless_mode == WIRELESS_MODE_AC_24G || wireless_mode == WIRELESS_MODE_AC_ONLY)) rate->flags |= IEEE80211_TX_RC_VHT_MCS; u8 wireless_mode = 0; enum wireless_mode { ... WIRELESS_MODE_AC_ONLY = 0x100, How is tha

[PATCH] NFC: nci: Fix error check of nci_hci_create_pipe() result

2015-11-06 Thread Geert Uytterhoeven
-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- net/nfc/nci/hci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c index 2aedac15cb592353..a0ab26d535dca749 100644 --- a/net/nfc/nci/hci.c +++ b/net/nfc/nci/hci.c @@ -676,7 +676,7

[PATCH] NFC: fdp: Detect errors from fdp_nci_patch_otp()

2015-11-06 Thread Geert Uytterhoeven
of data type fdp_nci_patch_otp() may return a negative error, which is silently ignored by assigning it to a u8. Change conn_id from u8 to int to fix this. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> --- fdp_nci_patch_otp() and fdp_nci_patch_ram() are almost identical. Please merg