Re: [PATCH 05/16] staging: wilc1000: change the type of wilc1000_initialized

On Wed, Oct 14, 2015 at 08:46:33PM +0900, Tony Cho wrote: > This patch changes the type of wilc1000_initialized in the struct wilc from > int to bool and renames it to the initialized. In addition, the unncessary > wilc1000_initialized codes are removed in this patch. because I didn't take the

Re: [PATCH 01/13] staging: wilc1000: add wilc to netdev private data structure

On Fri, Oct 16, 2015 at 06:22:57PM +0900, Tony Cho wrote: > From: Glen Lee > > This patch adds struct wilc to struct perInterface_wlan_t which is netdev > private data to access wilc via netdev_priv function and assigns wilc to > nic->wilc. The global variable wl will be

Re: [PATCH] staging: wilc1000: remove WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

On Sat, Oct 10, 2015 at 03:41:54PM +0300, Stanislav Kholmanskikh wrote: > The config option in the subject may be removed, because, > indeed, it only serves as the 'n' value for > CONFIG_WILC1000_PREALLOCATE_AT_LOADING_DRIVER > > Signed-off-by: Stanislav Kholmanskikh

Re: [PATCH 01/14] staging: wilc1000: remove typedef from tstrWILC_UsrScanReq

On Thu, Oct 08, 2015 at 10:49:08AM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes typedef from the struct tstrWILC_UsrScanReq with > related comments and renames it to user_scan_req. > > Signed-off-by: Leo Kim > Signed-off-by: Tony Cho

Re: [PATCH 01/10] staging: wilc1000: remove typedef from tstrWID

On Tue, Oct 06, 2015 at 06:42:12PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes typedef from the struct tstrWID and > rename it to wid. > > Signed-off-by: Leo Kim > Signed-off-by: Tony Cho > --- >

Re: [PATCH 01/11] staging: wilc1000: replace drvHandler and hWFIDrv with hif_drv

On Thu, Oct 08, 2015 at 06:10:46PM +0900, Tony Cho wrote: > This patch replaces the variable names of struct host_if_drv used as the > functions' input parameter, drvHandler and hWFIDrv with hif_drv. In > addition, the local variable declared in many functions, pstrWFIDrv is > removed and hif_drv

Re: [PATCH 1/6] staging: wilc1000: remove typedef from tstrWILC_WFIDrv

On Mon, Oct 05, 2015 at 07:28:09PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes typedef from the struct tstrWILC_WFIDrv and > rename it to host_if_drv. > This patch includes the removal of the comment for tstrWILC_WFIDrv as well. > > Signed-off-by: Leo Kim

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote: > Hi! > > I noticed that drivers/staging/wilc1000/Kconfic defines: > > config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY > bool "Dynamically allocate memory in real time" > ---help--- > This choice

Re: [PATCH 06/10] staging: wilc1000: rename hWFIDrv of host_int_set_mac_chnl_num

On Fri, Oct 02, 2015 at 09:44:52PM +0900, Chaehyun Lim wrote: > This patch replaces hWFIDrv with wfi_drv that is first argument of > host_int_set_mac_chnl_num to avoid camelcase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/host_interface.c | 6 +++---

Re: [PATCH 04/10] staging: wilc1000: replace PRINT_ER with pr_err

On Fri, Oct 02, 2015 at 09:44:50PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_ER with pr_err. > It would be better to use netdev_err, but it cannot use it in this > function, so just use pr_err. > > Signed-off-by: Chaehyun Lim > --- >

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

On Sun, Oct 04, 2015 at 12:16:31PM +0300, Dan Carpenter wrote: > On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: > > Aren't you now leaking memory as you aren't freeing pstrMessage and the > > buffer on the "normal" return path? > > It's supposed to. It's

Re: [PATCH 09/10] staging: wilc1000: use pr_err in host_int_wait_msg_queue_idle

On Fri, Oct 02, 2015 at 09:44:55PM +0900, Chaehyun Lim wrote: > This patch changes PRINT_ER by pr_err. > It would be better to use netdev_err, but it cannot use it in this > function, so just use pr_err. > > Signed-off-by: Chaehyun Lim > --- >

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: > The spin_lock_irqsave is moved to just beginning of critical section. > This change moves a couple of return statements out of the lock. > > Signed-off-by: Chandra S Gorentla > --- >

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote: > - kfree is being called for the members of the queue without >de-queuing them; they are just inserted within this function; >they are supposed to be de-queued and freed in a function >for receiving the queue items >

Re: [PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote: > The kbuild test robot reports the following build error for > openrisc-allmodconfig. > > >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit > >> declaration of function 'memset' > > The error occurs due to missing a

Re: [PATCH 5/6] staging: wilc1000: remove wilc_platform include file

On Wed, Sep 23, 2015 at 06:03:49PM +0900, Chaehyun Lim wrote: > This patch removes wilc_platform.h include file in wilc_oswrapper.h > Because wilc_platform.h have several standard header files so that some > header file should be included .c file to avoid compilation errors. > > Signed-off-by:

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > - The message queue is replaced with standard Linux linked list > - kmem_cache is used for list members Why? > - A check for return value of receive method is added > - GFP_ATOMIC is changed to GFP_KERNEL Why? Are you

Re: [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove code that no effect

On Tue, Sep 29, 2015 at 12:07:43AM +0530, Chandra Gorentla wrote: > Please do not review this. This is duplicate to - > [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove ineffective > code I don't understand, you sent 2 2/2 patches, which one do I look at? Please just resend the

Re: [PATCH] Removed extra spaces, and error from checkpatch.pl

On Sun, Sep 27, 2015 at 01:59:17PM +0530, Pinkesh Jain wrote: > There were many warnings and error given by checkpatch.pl and most of them > were > almost of the same type so i believed a single patch is enough to do the > cleanup. > > 1. Remove errors of the struct declaration (foo*bar to foo

Re: [PATCH 1/2] staging: wilc1000: replace s32Error with result

On Mon, Sep 21, 2015 at 09:25:31AM +0900, Chaehyun Lim wrote: > Most of functions use s32Error variable to check error and return its value. > This patch replaces s32Error with result to avoid CamelCase. > > Signed-off-by: Chaehyun Lim This doesn't apply at all anymore.

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote: > > > On 2015년 09월 21일 11:01, Greg KH wrote: > >On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > >>This patch removes function declaration of WILC_WFI_frame_register in > >

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Mon, Sep 21, 2015 at 03:20:12PM +0900, Tony Cho wrote: > > > On 2015년 09월 21일 15:07, Greg KH wrote: > >On Mon, Sep 21, 2015 at 02:54:28PM +0900, Tony Cho wrote: > >> > >>On 2015년 09월 21일 11:01, Greg KH wrote: > >>>On Sun, Sep 20, 2015 at 03:51:15P

Re: [PATCH 10/18] staging: wilc1000: rename WILC_WFI_set_power_mgmt

On Sun, Sep 20, 2015 at 03:51:17PM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_set_power_mgmt with set_power_mgmt to avoid > CamelCase. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 > 1 file changed,

Re: [PATCH 07/18] staging: wilc1000: replaces PRINT_D with netdev_err

On Sun, Sep 20, 2015 at 03:51:14PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_D with netdev_err which is used at error > checking. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++--- > 1 file changed, 3

Re: [PATCH 06/18] staging: wilc1000: replace PRINT_D with netdev_info

On Sun, Sep 20, 2015 at 03:51:13PM +0900, Chaehyun Lim wrote: > This patch replaces PRINT_D with netdev_info in wilc_free_wiphy function. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 08/18] staging: wilc1000: remove declaration of WILC_WFI_frame_register

On Sun, Sep 20, 2015 at 03:51:15PM +0900, Chaehyun Lim wrote: > This patch removes function declaration of WILC_WFI_frame_register in > linux_wlan.c file, then adds it in wilc_wfi_cfgoperations.h file. > > The compilation warning occurs because it is assigned to incorrect > pointer type of second

Re: [PATCH v2 02/34] staging: wilc1000: remove typedef from the struct

On Mon, Sep 21, 2015 at 12:16:31PM +0900, Tony Cho wrote: > The Linux kernel coding style does not recommend to use typedef for the > structure. This patch removes typedef from the host_if_msg structure. > > Signed-off-by: Tony Cho > Signed-off-by: Greg Kroah-Hartman

Re: [PATCH v2 01/34] staging: wilc1000: rename tstrHostIFmsg

On Mon, Sep 21, 2015 at 12:16:30PM +0900, Tony Cho wrote: > This patch changes the name, tstrHostIFmsg to host_if_msg not to use > camelcase notation in the Linux. > > Signed-off-by: Tony Cho > Signed-off-by: Greg Kroah-Hartman Is this already in

Re: [PATCH v2 2/4] staging: wilc1000: remove warnings on the multiple blank lines uses

On Thu, Sep 17, 2015 at 07:02:18PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes the warnings reported by checkpatch.pl > for using multiple blank lines. > > Signed-off-by: Leo Kim > Signed-off-by: Tony Cho > --- >

Re: [PATCH v2 1/4] staging: wilc1000: fix null check routine

On Thu, Sep 17, 2015 at 07:02:17PM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes the potential faults which may happen when unexpectedly > getting access to invalid pointer. The pointer of pstrWFIDrv is unlikely > to be invalid. However, it is safer to return

Re: [PATCH V2 3/8] staging: wilc1000: replace int8_t with int

On Thu, Sep 17, 2015 at 09:03:14PM +0900, Chaehyun Lim wrote: > On Thu, Sep 17, 2015 at 7:34 PM, Sudip Mukherjee > wrote: > > On Thu, Sep 17, 2015 at 04:48:44PM +0900, Chaehyun Lim wrote: > >> This patch replaces int8_t with int. just use return type as int. > >> > >>

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Sep 17, 2015 at 07:13:39AM +0530, Ronit Halder wrote: > Why not the second one? Second what? > None of the line edited in first patch haven't changed after that. I don't understand what

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > Sorry for the ambiguity. > I am talking about my second patch in the series. > https://lkml.org/lkml/2015/9/15/293 > > > > None of the line edited in first patch haven't changed after that. > > You applied the version 1 of the first patch

Re: [PATCH 03/10] staging: wilc1000: remove INLINE macro

On Wed, Sep 16, 2015 at 08:11:28PM +0900, Chaehyun Lim wrote: > This patch removes INLINE macro that is used anymore. > > Signed-off-by: Chaehyun Lim > --- > drivers/staging/wilc1000/coreconfigurator.c | 1 - > drivers/staging/wilc1000/wilc_wlan.c| 1 - > 2 files

Re: [PATCH] staging: wilc1000: Added spaces

On Thu, Sep 17, 2015 at 12:12:50AM +0530, Aparna Karuthodi wrote: > Added spaces around '=' to remove coding style errors detected by > checkpatch.The errors are given below: > drivers/staging/wilc1000/host_interface.c:7951: ERROR: spaces required > around that '=' (ctx:VxV) >

Re: [PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK

On Tue, Sep 15, 2015 at 11:53:36AM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes the definition WILC_NULLCHECK which is not used anymore. No, it is used, you just remove all usages of it in this patch as well :) Also, your fixes are not correct, you are not

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote: > > > On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: > >>From: Glen Lee > >> > >>g_num_total_switches is never used so just delete it. > >> >

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: > This patch fixes the warning generated by sparse > "Using plain integer as NULL pointer" by using NULL > instead of zero. > > Signed-off-by: Ronit halder > --- > > v2: added a new patch in this patch series to

Re: [PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

On Tue, Sep 15, 2015 at 10:17:41AM +0900, Tony Cho wrote: > Hi Greg, > > I am sorry but please ignore this patch in this time. It's already in my tree, right? I can revert it if you want me to, but I can't ignore it anymore, sorry. greg k-h -- To unsubscribe from this list: send the line

Re: [PATCH V3 29/31] staging: wilc1000: rename WILC_WFI_frame_register

On Mon, Sep 14, 2015 at 12:24:29PM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_frame_register with mgmt_frame_register to > avoid CamelCase. > > Signed-off-by: Chaehyun Lim > --- > V3: remove "wilc_" prefix > > drivers/staging/wilc1000/linux_wlan.c

Re: [PATCH v2 1/2] staging: wilc1000: remove unused enum

On Mon, Sep 14, 2015 at 10:29:26AM +0900, Tony Cho wrote: > > > On 2015년 09월 12일 11:35, Greg KH wrote: > >On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote: > >>From: Glen Lee <glen@atmel.com> > >> > >>This patch removes a unused enum

Re: [PATCH] staging: wilc1000: Added a new line

On Sun, Sep 13, 2015 at 04:31:33PM +0530, Aparna Karuthodi wrote: > Added a new line after declaration to remove a coding style warning > detected by checkpatch. The warning is given below > WARNING: Missing a blank line after declarations > > Signed-off-by: Aparna Karuthodi

Re: [PATCH V2 01/31] staging: wilc1000: rename WILC_WFI_CfgSetChannel

On Fri, Sep 11, 2015 at 04:14:00AM +0900, Chaehyun Lim wrote: > This patch replaces WILC_WFI_CfgSetChannel with > wilc_set_channel to avoid CamelCase. > > Signed-off-by: Chaehyun Lim > --- > V2: to make function name simple > >

Re: [PATCH v2 1/2] staging: wilc1000: remove unused enum

On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote: > From: Glen Lee > > This patch removes a unused enum tenuFrameClass. > > Signed-off-by: Glen Lee > Signed-off-by: Tony Cho > --- >

Re: [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h

On Thu, Sep 10, 2015 at 11:08:25AM +0900, Tony Cho wrote: > Hi Greg, > > I want to make sure one thing before moving further. Are you saying > the errorsupport.h file as the os wrapper remaining in the oswrapper.h > file? If not, can you let me know what you point out as remaining os > wrapper

Re: [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper

On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote: > From: Glen Lee > > Call kmalloc directly. No need to wrap kmalloc. > Only one function, wilc_mq_send which use WILC_MALLOC, can be running in > interrupt context or process context. In this case, We call in_interrupt

Re: [PATCH 1/5] staging: wilc1000: define undefined operation mode

On Tue, Sep 08, 2015 at 05:07:59PM +0900, Tony Cho wrote: > From: Johnny Kim > > This patch adds new define, IDLE_MODE to change comparison statement which > is wrong due to typecasting to null. > > Signed-off-by: Johnny Kim > Signed-off-by: Tony Cho

Re: [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h

On Wed, Sep 09, 2015 at 04:08:12PM +0900, Tony Cho wrote: > From: Glen Lee > > wilc1000 driver runs on Linux. No need to have oswrapper or platform > dependent files. > Before delete two header files, move two structures in wilc_platform.h to > wilc_msgqueue.h where it is

Re: [PATCH 4/5] staging: wilc1000: wilc_msgqueue.c: use kmalloc with GFP_ATOMIC

On Tue, Sep 08, 2015 at 11:23:07AM +0900, Tony Cho wrote: > > > On 2015년 09월 08일 00:36, Chaehyun Lim wrote: > >This patch use kmalloc with GFP_ATOMIC instead of WILC_MALLOC. > >It is inside the spin lock region. > > > >Signed-off-by: Chaehyun Lim > >--- > >

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

On Fri, Sep 04, 2015 at 03:01:55PM +0900, johnny.kim wrote: > > > On 2015년 09월 04일 12:51, Greg KH wrote: > >On Fri, Sep 04, 2015 at 12:24:29PM +0900, johnny.kim wrote: > >> > >>On 2015년 09월 04일 00:47, Greg KH wrote: > >>>On Thu, Sep 03, 2015 at 04

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote: > Hello Greg. > > On 2015년 09월 03일 10:33, Greg KH wrote: > >On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote: > >>From: Johnny Kim <johnny@atmel.com> > >> > >>The driv

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

On Fri, Sep 04, 2015 at 12:24:29PM +0900, johnny.kim wrote: > > > On 2015년 09월 04일 00:47, Greg KH wrote: > >On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote: > >>Hello Greg. > >> > >>On 2015년 09월 03일 10:33, Greg KH wrote: > >>>On

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote: > From: Johnny Kim > > The driver communicates with the chipset via the address of handlers > to distinguish async data frame. The SendConfigPkt function gets the > pointer address indicating the handlers as the last

Re: [PATCH] staging: wilc1000: Set all options in region debugfs file

On Wed, Aug 19, 2015 at 06:00:12PM +0530, Chandra Gorentla wrote: On Tue, Aug 18, 2015 at 08:01:00PM -0700, Greg KH wrote: On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote: This patch allows setting all options in the module's debug region options file 'wilc_debug_region

Re: [PATCH] staging: wilc1000: Set all options in region debugfs file

On Tue, Aug 18, 2015 at 10:32:17PM +0530, Chandra S Gorentla wrote: This patch allows setting all options in the module's debug region options file 'wilc_debug_region'. This functionality allows the user to enable logging from all regions (initialization, locks, firmware etc.) of the driver.

Re: [PATCH 1/4] staging: wilc1000: delete wilc_log.h

On Mon, Aug 17, 2015 at 10:44:28PM +0900, Chaehyun Lim wrote: The macros in wilc_log.h are not referenced anywhere, so just delete it. Oops, I just did this same thing before I saw your email, sorry about that. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-wireless

Re: [PATCH 4/4] staging: wilc1000: return -EINVAL for invalid argument checking

On Mon, Aug 17, 2015 at 10:44:31PM +0900, Chaehyun Lim wrote: This patch uses -EINVAL for invalid argument checking instead of using WILC_ERRORREPORT with WILC_INVALID_ARGUMENT. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 ++-- 1

Re: [PATCH v2] staging: wilc1000: Process WARN, INFO options of debug levels from user

On Fri, Aug 14, 2015 at 10:50:07PM +0530, Chandra S Gorentla wrote: This patch enables setting the module's debug options WARN and INFO in the debugfs file 'wilc_debug_level'. This enables the user to enable logging of warning and other information. Before this change writes to this debugfs

Re: [PATCH 2/5] staging: wilc1000: change void pointer type to real type

On Fri, Aug 14, 2015 at 11:56:13AM +0530, Sudip Mukherjee wrote: On Thu, Aug 13, 2015 at 01:41:20PM +0900, Tony Cho wrote: From: Johnny Kim johnny@atmel.com This patch changes the void pointer member of the tstrHostIFmsg to the real data type because the void pointer type is

Re: [PATCH v3 2/3] drivers: staging: wilc1000: move { to previous line

On Thu, Aug 06, 2015 at 09:29:44PM +0530, Chandra Gorentla wrote: On Wed, Aug 05, 2015 at 10:11:56PM +0530, Chandra S Gorentla wrote: Moved the opening brace of code blocks to the previous lines. This fixes the checkpatch.pl error - that open brace { should be on the previous line.

Re: [PATCH v2 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions

On Wed, Aug 05, 2015 at 09:43:00PM +0530, Chandra S Gorentla wrote: Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - Bad function definition 'function()' should probably be function(void).

Re: [PATCH 1/3] drivers: staging: wilc1000: use 'void' for no arguments functions

On Sun, Aug 02, 2015 at 09:23:51PM +0530, Chandra S Gorentla wrote: Added 'void' keyword in the paranthesis of function definitions, when there are no arguments to the functions. This fixes the checkpatch.pl error - Bad function definition 'function()' should probably be function(void).

Re: [PATCH] staging: rtl8723au: fix coding style warnings reported by checkpatch.pl.

On Sun, Aug 02, 2015 at 01:00:58PM +0800, Ting-Chih Hsiao wrote: From 8c86ae927a38693f587826f51fca5d374e756768 Mon Sep 17 00:00:00 2001 From: Ting-Chih Hsiao s894...@hotmail.com Date: Sun, 2 Aug 2015 12:32:19 +0800 Why is this information in the body of your email? And please use

Re: [PATCH 01/28] staging: wilc1000: change type of driver handler in host interface msg

On Fri, Jul 31, 2015 at 04:38:09PM +0900, Tony Cho wrote: From: glen lee glen@atmel.com This patch changes void pointer type of drvHandler with WILC_WFIDrvHandle type variable since the structure member drvHandler in tstrHostIFmsg is explicitly used to pass driver pointer as handler.

Re: [PATCH 24/28] staging: wilc1000: fix cast from pointer to integer warning

On Fri, Jul 31, 2015 at 04:38:32PM +0900, Tony Cho wrote: From: glen lee glen@atmel.com To use a pointer as as integer in arithmetic operation, cast type to uintptr_t as the data type. This patch changes casting (unsigned int) with (uintptr_t) to do arithmetic operation Here is

Re: [PATCH 02/28] staging: wilc1000: change void type of argument with WILC_WFIDrvHandle

On Fri, Jul 31, 2015 at 04:38:10PM +0900, Tony Cho wrote: From: glen lee glen@atmel.com This should probably be Glen Lee, right? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 28/28] staging: wilc1000: change data type of variable

On Fri, Jul 31, 2015 at 04:38:36PM +0900, Tony Cho wrote: From: glen lee glen@atmel.com drvHandler of u32 type is used to handle integer type pointer operation which cause build warnings. To use integer type varialbe as pointer, drvHandler data type need to be changed with uintptr_t

Re: [PATCH 25/28] staging: wilc1000: change cast type from pointer to uintptr_t

On Fri, Jul 31, 2015 at 04:38:33PM +0900, Tony Cho wrote: From: glen lee glen@atmel.com To use drvHandler as integer operation, cast type to uintptr_t. Here is the build warning. drivers/staging/wilc1000/wilc_wlan.c:1871:23: warning: cast from pointer to integer of different size

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

On Fri, Jul 31, 2015 at 12:27:04PM +0900, tony.cho wrote: On 2015년 07월 30일 20:56, Sudip Mukherjee wrote: On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling

Re: [PATCH 0/5] 2nd patch for illegal coding style

On Thu, Jul 30, 2015 at 06:10:09PM +0900, Tony Cho wrote: This patch V2 includes only patches rejected. The rejected patch for the following, #ifdef conditionals cover entire functions, introduced new error on required space before the open parenthesis '('. This is my mistake while rewriting

Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

On Thu, Jul 30, 2015 at 12:14:08AM +0300, Dan Carpenter wrote: On Wed, Jul 29, 2015 at 01:54:54PM -0700, Greg KH wrote: On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote: /** * Disable power sequencer **/ - if (!sdio_read_reg(WILC_MISC, reg

Re: [PATCH V2 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC

On Fri, Jul 24, 2015 at 08:55:53AM +0900, Chaehyun Lim wrote: Use kmalloc and kmalloc_array instead of WILC_MALLOC. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- V2: Use GFP_KERNEL flag instead of GFP_ATOMIC Please answer Dan's question for the next time you resend this series, I

Re: [PATCH 21/21] staging: wilc1000: update TODO list of WILC1000

On Tue, Jul 28, 2015 at 05:47:40PM +0900, Tony Cho wrote: The TODO list is updated for the WILC1000 kernel driver. The TODO list contains many items listed in time sequence. I don't understand what you mean by in time sequence Signed-off-by: Tony Cho tony@atmel.com Reviewed-by: Dan

Re: [PATCH 09/21] staging: wilc1000: #ifdef conditionals cover entire functions

On Tue, Jul 28, 2015 at 05:47:28PM +0900, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions of functions or expressions becausue doing so

Re: [PATCH 06/21] staging: wilc1000: remove the warnings on unnecessary braces

On Tue, Jul 28, 2015 at 05:47:25PM +0900, Tony Cho wrote: This patch removes the warnings reported by checkpatch.pl on {} not necessary for the single statement blocks. Signed-off-by: Tony Cho tony@atmel.com Reviewed-by: Dan Carpenter dan.carpen...@oracle.com ---

Re: [PATCH] staging: wilc1000: host_interface.c: Fix build warning

On Wed, Jul 29, 2015 at 07:36:59PM +0530, Chandra S Gorentla wrote: Fixed - warning: ‘*((void *)strHostIFmsg+4).pu8Head’ may be used uninitialized The warning is incorrect, look at the code, I don't see anything wrong with it. I suggest upgrading to a newer version of gcc that doesn't report

Re: [PATCH 1/3] staging: wilc1000: coreconfigurator.c: remove WILC_MALLOC

On Thu, Jul 23, 2015 at 08:19:17PM +0900, Chaehyun Lim wrote: Use kmalloc and kmalloc_array instead of WILC_MALLOC. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/coreconfigurator.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

Re: [PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

On Fri, Jul 10, 2015 at 02:55:56PM +0900, Johnny Kim wrote: Last argument of wilc_wlan_cfg_get function is actually structure's address. This should be changed to be compatible with 64bit machine. Because wilc_wlan_cfg_get function is mapped by function pointer later,

Re: [PATCH 2/2] staging: wilc1000: fix memory allocation error check

On Tue, Jul 14, 2015 at 10:48:41AM +0900, Chaehyun Lim wrote: Remove WILC_ERRORREPORT macro. If memory allocation is failed, jump to a label to return this function with WILC_NO_MEM. Signed-off-by: Chaehyun Lim chaehyun@gmail.com --- drivers/staging/wilc1000/host_interface.c | 7

Re: [PATCH 2/2] staging: wilc1000: fix memory allocation error check

On Wed, Jul 15, 2015 at 08:14:08AM +0900, Chaehyun Lim wrote: On Wed, Jul 15, 2015 at 6:16 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jul 14, 2015 at 10:48:41AM +0900, Chaehyun Lim wrote: Remove WILC_ERRORREPORT macro. If memory allocation is failed, jump to a label to return

Re: [PATCH 1/3] staging: vt6655: Fix missing power saving support

On Sun, Jun 21, 2015 at 11:05:53AM +0100, Malcolm Priestley wrote: Add IEEE80211_HW_SUPPORTS_PS to ieee80211_hw flags enabling this feature. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- drivers/staging/vt6655/device_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH 2/4 v2] staging: vt6655: Fix missing power saving support

On Thu, Jul 09, 2015 at 05:01:25PM +0100, Malcolm Priestley wrote: Add IEEE80211_HW_SUPPORTS_PS to ieee80211_hw flags enabling this feature. Signed-off-by: Malcolm Priestley tvbox...@gmail.com --- v2 rebased for 4.2 Ah, nevermind, you did this already, now applied. Sorry for the noise,

Re: [PATCH 2/6] staging: wilc1000: delete 'WILC_WFIDrvHandle' structure

On Tue, Jun 30, 2015 at 05:34:34PM +0900, Dean Lee wrote: delete odd structure and rework it. what do you mean by rework it? It looks like you just made it a void * everywhere, which is what I explicitly said to not do. sorry, can't take this. greg k-h -- To unsubscribe from this list: send

Re: [PATCH 1/6] staging: wilc1000: modify build error

On Tue, Jun 30, 2015 at 05:34:33PM +0900, Dean Lee wrote: this function needs more arguments. The subject doesn't make sense. And this sentance doesn't make sense, please describe _why_ you are doing this, not what you are doing. greg k-h -- To unsubscribe from this list: send the line

Re: [PATCH 4/6] staging: wilc1000: rework address value.

On Tue, Jun 30, 2015 at 05:34:36PM +0900, Dean Lee wrote: change type to pointer. that describes _what_ you did, which is obvious from the patch, but not _why_ you did it. You need to describe this much better before I can take it. One comment on the code: Signed-off-by: Dean Lee

Re: [PATCH 4/5] staging: wilc1000: remove prohibited spaces.

On Thu, Jun 18, 2015 at 01:51:15PM +0900, 조성훈 wrote: Hi Greg, I want to make sure one thing before going further. I cloned the staging-testing and then made the first patch. There was no problem when I sent the first path to you. Afterwards, I also pulled the repository to update my local

Re: [PATCH 2/5] staging: wilc1000: remove the warnings on multiple blank line uses.

On Wed, Jun 17, 2015 at 04:28:52PM +0900, Sunghoon Cho wrote: This patch removes the warnings reported by checkpatch.pl regarding the multiple blank line. Signed-off-by: Sunghoon Cho ywhsbl...@gmail.com --- drivers/staging/wilc1000/wilc_wlan_if.h | 12 1 file changed, 12

Re: [PATCH 1/5] staging: wilc1000: change commenting styles.

On Wed, Jun 17, 2015 at 04:28:51PM +0900, Sunghoon Cho wrote: This patch changes commenting style to Linux preferred C89 style. Signed-off-by: Sunghoon Cho ywhsbl...@gmail.com --- drivers/staging/wilc1000/wilc_wlan_if.h | 721 ++-- 1 file changed, 397

Re: [PATCH 4/5] staging: wilc1000: remove prohibited spaces.

On Wed, Jun 17, 2015 at 02:42:35PM +0900, Sunghoon Cho wrote: This patch removes the warnings on the prohibited spaces between function name and open parenthesis. Signed-off-by: Sunghoon Cho ywhsbl...@gmail.com --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 4 ++-- 1 file changed, 2

Re: [PATCH 1/2] staging: wilc1000: modify type casting warning

On Tue, Jun 16, 2015 at 04:11:24PM +0900, Dean Lee wrote: modify message warning: cast from pointer to integer of different size. add type cast 'uintptr_t'. Signed-off-by: Dean Lee dean@atmel.com --- Change Log: add Signed-off-by line drivers/staging/wilc1000/host_interface.c

Re: [PATCH 2/2] staging: wilc1000: modify uninitialized warning

On Tue, Jun 16, 2015 at 04:11:25PM +0900, Dean Lee wrote: initialize it. Signed-off-by: Dean Lee dean@atmel.com --- drivers/staging/wilc1000/host_interface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c

Re: [PATCH 1/3] staging: wilc1000: rework include wilc_oswrapper.h

On Tue, Jun 16, 2015 at 02:38:20PM +0900, Dean Lee wrote: rework line '#include wilc_oswrapper.h' it does not require after change own data type to common data type. Signed-off-by: Dean Lee dean@atmel.com These are nice, but why isn't anyone sending me patches to fix the build warnings

Re: [PATCH] staging: wilc1000: change WILC_Char to s8

On Mon, Jun 15, 2015 at 09:47:04AM +0900, Dean.lee wrote: On 2015년 06월 13일 00:28, Greg KH wrote: On Fri, Jun 12, 2015 at 02:39:08PM +0900, Dean Lee wrote: change own data type(WILC_Char) to common data type(s8) Why not just 'char'? And you are using these in strings, so why not u8

Re: [PATCH v3] staging: wilc1000: remove oswrapper type file

On Fri, Jun 12, 2015 at 07:21:11PM +0900, Dean Lee wrote: remove OS Wrapper function(wilc_oswrapper.h) is in our plan. i removed OS Wrapper function and it's done. and i found wilc_type.h file is does not used it. so i deleted them and modify #include line in another file. You are also doing

Re: [PATCH] staging: wilc1000: change WILC_Char to s8

On Fri, Jun 12, 2015 at 02:39:08PM +0900, Dean Lee wrote: change own data type(WILC_Char) to common data type(s8) Why not just 'char'? And you are using these in strings, so why not u8? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of

Re: [PATCH] staging: wilc1000: update TODO list

On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote: remove complete OS wrapper functions. Signed-off-by: Dean Lee dean@atmel.com --- drivers/staging/wilc1000/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO

Re: [PATCH] staging: wilc1000: remove warnings reported by checkpatch.pl.

On Fri, Jun 12, 2015 at 06:51:56PM +0900, Dean Lee wrote: Remove the following warnings in the wilc_log.h: - unnecessary whitespace before a quoted newline - line over 80 characters - single statement macros should not use a do {} while (0) loop. Those are different things, so this should be

Re: [PATCH] staging: wilc1000: modify odd print message

On Thu, Jun 11, 2015 at 01:52:28PM +0900, Dean.lee wrote: On 2015년 06월 11일 12:50, Greg KH wrote: On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote: This driver has odd message in print string. So this patch removes the data type. Signed-off-by: Dean Lee dean@atmel.com

Re: [PATCH 1/4] staging: wilc1000: modify data type

On Thu, Jun 11, 2015 at 02:33:39PM +0900, Johnny Kim wrote: On 2015년 06월 11일 09:40, Greg KH wrote: On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote: -static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler) +static int wilc_wlan_cfg_commit(int type, size_t drvHandler

Re: [PATCH 2/4] staging: wilc1000: add syntax for 64-bit machine

On Wed, Jun 10, 2015 at 05:06:45PM +0900, Johnny Kim wrote: The driver take pointer value to integer value for message packet. So, The driver was fixed to save and load the address on 64-bit machine. Signed-off-by: Johnny Kim johnny@atmel.com ---

<    1   2   3   4   >