Re: iwlwifi firmware load broken in current -git

2017-09-16 Thread Jens Axboe
On 09/15/2017 09:03 PM, Bjorn Helgaas wrote: > On Fri, Sep 15, 2017 at 01:55:57PM -0600, Jens Axboe wrote: >> On 09/15/2017 01:51 PM, Luca Coelho wrote: >>> On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: >>>> On 09/15/2017 01:38 PM, Linus Torvalds wrote: >&

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
d I'll get a pull request. Hopefully soon, so that > it makes rc. That was my hope, and why I emailed again today on the topic. > Jens, you were actually cc'd on that revert according to the email > headers, so check your spam-box. Yeah, Luca says so too. Which is making me a little worried on behalf of my email, since it's not sitting in spam. -- Jens Axboe

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/15/2017 01:51 PM, Luca Coelho wrote: > On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: >> On 09/15/2017 01:38 PM, Linus Torvalds wrote: >>> On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: >>>>> >>>>> In any case, your patch introdu

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/15/2017 01:38 PM, Linus Torvalds wrote: > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: >>> >>> In any case, your patch introduces a regression on systems. Please get >>> it reverted now, and then you can come up with a new approach to fix the >>&g

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/15/2017 01:36 PM, Luca Coelho wrote: > On Fri, 2017-09-15 at 13:32 -0600, Jens Axboe wrote: >> On 09/14/2017 02:36 PM, Jens Axboe wrote: >>> On 09/14/2017 02:04 PM, Srinath Mannam wrote: >>>> Hi Jens Axboe, >>>> >>>> >>>> O

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Jens Axboe
On 09/14/2017 02:36 PM, Jens Axboe wrote: > On 09/14/2017 02:04 PM, Srinath Mannam wrote: >> Hi Jens Axboe, >> >> >> On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: >>> On 09/14/2017 11:35 AM, Jens Axboe wrote: >>>> On 09/14/2017 11:28 AM, Srin

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 02:04 PM, Srinath Mannam wrote: > Hi Jens Axboe, > > > On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: >> On 09/14/2017 11:35 AM, Jens Axboe wrote: >>> On 09/14/2017 11:28 AM, Srinath Mannam wrote: >>>> Hi Bjorn, >>>> >&

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:44 AM, Srinath Mannam wrote: > Hi Jens Axboe, > > On Thu, Sep 14, 2017 at 11:05 PM, Jens Axboe wrote: >> On 09/14/2017 11:28 AM, Srinath Mannam wrote: >>> Hi Bjorn, >>> >>> On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: >>>

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:35 AM, Jens Axboe wrote: > On 09/14/2017 11:28 AM, Srinath Mannam wrote: >> Hi Bjorn, >> >> On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: >>> >>> On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: >>>> [+cc linux-pci] >>&g

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:28 AM, Srinath Mannam wrote: > Hi Bjorn, > > On Thu, Sep 14, 2017 at 10:52 PM, Jens Axboe wrote: >> >> On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: >>> [+cc linux-pci] >>> >>> On Thu, Sep 14, 2017 at 12:00 PM, Jens Axboe wrote:

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/14/2017 11:11 AM, Bjorn Helgaas wrote: > [+cc linux-pci] > > On Thu, Sep 14, 2017 at 12:00 PM, Jens Axboe wrote: >> On 09/12/2017 02:04 PM, Johannes Berg wrote: >>> On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: >>> >>>> CC'in

Re: iwlwifi firmware load broken in current -git

2017-09-14 Thread Jens Axboe
On 09/12/2017 02:04 PM, Johannes Berg wrote: > On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: > >> CC'ing the guilty part and Bjorn. I'm assuming it's the >> pci_is_enabled() check, since the rest of the patch shouldn't have >> functional changes.

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
On 09/12/2017 10:36 AM, Luca Coelho wrote: > On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: >> Hi Jens, >> >> On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: >>> Hi, >>> >>> I have no wifi in current git (8fac2f96ab8), it simply fa

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
On 09/12/2017 10:36 AM, Luca Coelho wrote: > On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: >> Hi Jens, >> >> On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: >>> Hi, >>> >>> I have no wifi in current git (8fac2f96ab8), it simply fa

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
On 09/12/2017 10:11 AM, Coelho, Luciano wrote: > Hi Jens, > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: >> Hi, >> >> I have no wifi in current git (8fac2f96ab8), it simply fails with: >> >> [4.363481] iwlwifi :04:00.0: Direct firmware loa

iwlwifi firmware load broken in current -git

2017-09-12 Thread Jens Axboe
4.13-rc7+, which was the last kernel I ran on my laptop. -- Jens Axboe

Re: [PATCH 13/31] timer: Remove meaningless .data/.function assignments

2017-09-01 Thread Jens Axboe
On 08/31/2017 05:29 PM, Kees Cook wrote: > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. For amiflop: Acked-by: Jens Axboe

Re: WARNING: CPU: 2 PID: 682 at net/wireless/util.c:1236

2017-05-04 Thread Jens Axboe
On 05/04/2017 09:27 AM, Jens Axboe wrote: > On 05/04/2017 09:25 AM, David Miller wrote: >> From: Jens Axboe >> Date: Thu, 4 May 2017 09:23:36 -0600 >> >>> Running current -git on my laptop, and I see this spew every once >>> in a while. This is new, haven&

Re: WARNING: CPU: 2 PID: 682 at net/wireless/util.c:1236

2017-05-04 Thread Jens Axboe
On 05/04/2017 09:25 AM, David Miller wrote: > From: Jens Axboe > Date: Thu, 4 May 2017 09:23:36 -0600 > >> Running current -git on my laptop, and I see this spew every once >> in a while. This is new, haven't seen it in 4.11 or previously. Driver >> is iwl

WARNING: CPU: 2 PID: 682 at net/wireless/util.c:1236

2017-05-04 Thread Jens Axboe
c R15: 01ffc570 [ 3285.978664] Code: d0 f7 e1 d1 ea 8d 14 92 01 d2 81 c2 50 c3 00 00 b9 c5 5a 7c 0a 5d c1 ea 05 89 d0 f7 e1 89 d0 c1 e8 07 c3 31 c0 40 80 fe 02 74 b6 <0f> ff 31 c0 eb b0 8d 14 52 01 d2 e9 41 ff ff ff 0f ff 31 c0 5d [ 3285.978693] ---[ end trace ae08dfa326cc120a ]--- -- Jens Axboe

Re: [PATCH] iwlwifi: mvm: cleanup pending frames in DQA mode

2017-03-13 Thread Jens Axboe
r frame is received, mac80211 tells the driver to send > frames from the queues using release_buffered_frames. > The driver will tell the fw to let frames out even if the station > is asleep. This is done by iwl_mvm_sta_modify_sleep_tx_count. It fixes the warning for me. Tested-by: Jens Axboe -- Jens Axboe

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-03-13 Thread Jens Axboe
On 03/13/2017 07:00 AM, Luca Coelho wrote: > On Fri, 2017-03-10 at 08:41 -0700, Jens Axboe wrote: >> On 03/10/2017 08:36 AM, Luca Coelho wrote: >>> On Fri, 2017-03-10 at 08:23 -0700, Jens Axboe wrote: >>>> On 03/10/2017 05:01 AM, Luca Coelho wrote: >>>>&g

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-03-10 Thread Jens Axboe
On 03/10/2017 08:36 AM, Luca Coelho wrote: > On Fri, 2017-03-10 at 08:23 -0700, Jens Axboe wrote: >> On 03/10/2017 05:01 AM, Luca Coelho wrote: >>> Hi Jens, >>> >>> On Thu, 2017-03-09 at 21:41 -0700, Jens Axboe wrote: >>>> On 03/01/2017 09:10 PM

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-03-10 Thread Jens Axboe
On 03/10/2017 05:01 AM, Luca Coelho wrote: > Hi Jens, > > On Thu, 2017-03-09 at 21:41 -0700, Jens Axboe wrote: >> On 03/01/2017 09:10 PM, Jens Axboe wrote: >>> On 03/01/2017 08:33 PM, Luca Coelho wrote: >>>> Hi Jens, >>>> >>>> On Mar 1,

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-03-09 Thread Jens Axboe
On 03/01/2017 09:10 PM, Jens Axboe wrote: > On 03/01/2017 08:33 PM, Luca Coelho wrote: >> Hi Jens, >> >> On Mar 1, 2017 20:25, Jens Axboe wrote: >> >> Not that folks have been jumping all over this, but in case someone is >> curious, it triggered twi

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-03-01 Thread Jens Axboe
On 03/01/2017 08:33 PM, Luca Coelho wrote: > Hi Jens, > > On Mar 1, 2017 20:25, Jens Axboe wrote: > > Not that folks have been jumping all over this, but in case someone is > curious, it triggered twice here today. For those two times, the value > of mvm->pe

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-03-01 Thread Jens Axboe
On 02/28/2017 01:41 PM, Jens Axboe wrote: > On 02/28/2017 11:02 AM, Jens Axboe wrote: >> Hi, >> >> I'm hitting this one a lot with current -git, which is this one: >> >> if (iwl_mvm_is_dqa_supported(mvm)) { >>

WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-02-28 Thread Jens Axboe
thor: Sara Sharon Date: Wed Dec 7 15:04:37 2016 +0200 iwlwifi: mvm: fix pending frame counter calculation but the pestering is new. -- Jens Axboe

Re: WARNING: CPU: 1 PID: 23668 at drivers/net/wireless/intel/iwlwifi/mvm/sta.c:1539 iwl_mvm_rm_sta+0x3ce/0x450

2017-02-28 Thread Jens Axboe
On 02/28/2017 11:02 AM, Jens Axboe wrote: > Hi, > > I'm hitting this one a lot with current -git, which is this one: > > if (iwl_mvm_is_dqa_supported(mvm)) { > iwl_mvm_disable_sta_q

Re: iwlwifi: fix kernel crash when unregistering thermal zone

2017-01-27 Thread Jens Axboe
On 01/27/2017 12:54 PM, Kalle Valo wrote: > Jens Axboe writes: > >> On 01/21/2017 05:59 AM, Kalle Valo wrote: >>> Jens Axboe wrote: >>>> A recent firmware change seems to have enabled thermal zones on the >>>> iwlwifi driver. Unfortunately, my device

Re: iwlwifi: fix kernel crash when unregistering thermal zone

2017-01-27 Thread Jens Axboe
On 01/21/2017 05:59 AM, Kalle Valo wrote: > Jens Axboe wrote: >> A recent firmware change seems to have enabled thermal zones on the >> iwlwifi driver. Unfortunately, my device fails when registering the >> thermal zone. This doesn't stop the driver from attempting to

iwlwifi: fix kernel crash when unregistering thermal zone

2017-01-17 Thread Jens Axboe
f the thermal_zone_device_unregister() path. Don't unregister if name is NULL, for that case we failed registering. Do the same for the cooling zone. Signed-off-by: Jens Axboe --- Would be great if this could go into the current series, as sometimes I have to reload the driver. Right n