Hi Arend,
On Wed, May 30, 2018 at 8:05 PM Arend van Spriel <
arend.vanspr...@broadcom.com> wrote:
> On 5/27/2018 7:34 AM, Julian Calaby wrote:
> > Hi Arend,
> > On Fri, May 25, 2018 at 12:38 PM Arend van Spriel <
> > arend.vanspr...@broadcom.com> wrote:
>
han happy to pass some
flag through telling us/you that it's unofficial firmware and has probably
broken the hardware, etc.)
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
cannot register a second one. so a independend led driver is a
>>> >>requirement for direct control
>>> >If the limitation indeed exists, please fix the limitation rather than
>>> >working around it in each and every driver.
>>> see ath9k. its exact the sam
quot;But what about backporting?" if this code is backported, it'll most
likely be through the backports project and will be handled using this
script:
https://git.kernel.org/pub/scm/linux/kernel/git/backports/backports.git/tree/patches/0002-gpio-parent.cocci
)
Removing these blocks will make the kbuild bot happy. Also,
checkpatch.pl should have complained about this.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
E5 */ >,
> + <0 136 0 /* CE6 */ >,
> + <0 137 0 /* CE7 */ >,
> + <0 138 0 /* CE8 */ >,
> + <0 139 0 /* CE9 */ >,
> + <0 140 0 /* CE10 */ >,
> + <0 141 0 /* CE11 */ >;
> + vdd-0.8-cx-mx-supply = <_l5>;
You've omitted the "qcom," you specify above.
> + qcom,vdd-0.8-cx-mx-config = <80 80 2400 1000>;
> +};
> --
> 1.9.1
>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
)
Alternatively, would it waste too much RAM to just set this to the
maximum size and have done?
I feel that allowing the user to set it will be problematic.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
23] iwlwifi :01:00.0: RF_KILL bit toggled to enable radio.
> [20168.544328] iwlwifi :01:00.0: reporting RF_KILL (radio enabled)
This is perfectly normal, what is the purpose of this email?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
se an array of u32s instead?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
ds they are on, your
question appears to be WiFi related, so you'll be more likely to get a
useful answer on the linux-wireless list, which I've added to CC.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
# AP netdevice name (without 'a
utex_unlock(>mutex);
>
> - if (ret < 0) {
> - wl1271_warning("couldn't prepare device to suspend");
"couldn't enable power saving"?
> - return ret;
> - }
> + if (ret < 0)
> + goto report_prepa
tter
> reused at the end of this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
However,
> ---
> drivers/net/wireless/ti/w
iled at the beginning.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
_off(wl);
> + goto out_free_nvs;
Why not put this in front of the out_free_nvs label? It looks weird here.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
y without the specification of useful actions between.
> Thus remove such unnecessary source code at the end of this function.
>
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
Looks good to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
--
Julia
t, this command can be used to subscribe
> to mgmt frames when wireless device is up and running in AP or STA mode.
> That can be convenient for monitor and debug purposes. There is a
> limitation though: currently cfg80211 core allows only one subscriber
> for each particular frame/pa
Hi Ian,
On Wed, Aug 23, 2017 at 10:27 PM, Ian Molton <i...@mnementh.co.uk> wrote:
> On 23/08/17 11:09, Julian Calaby wrote:
>> I don't think I explained my point well.
>>
>> The description of this patch implies that this method
>> brcmf_sdiod_ramrw(), now relies
Hi Arend,
On Wed, Aug 23, 2017 at 5:38 AM, Arend van Spriel
<arend.vanspr...@broadcom.com> wrote:
> On 22-08-17 14:50, Julian Calaby wrote:
>>
>> Hi Ian,
>>
>> On Tue, Aug 22, 2017 at 9:25 PM, Ian Molton <i...@mnementh.co.uk> wrote:
>>>
>>
odev, sdiodev->sbwad))
> - brcmf_err("FAILED to set window back to 0x%x\n",
> - sdiodev->sbwad);
> -
> sdio_release_host(sdiodev->func[1]);
>
> return err;
> --
> 2.11.0
>
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
>> Well clearly at least this one does not have any valid hardware
>> mac address, the hardware mac address is broken with all zeroes.
>>
>
> Looks like it is not really all zeros but rather 00:00:00:00:00:01.
> I wonder if it is just a one board issue or not...
It's 0
"be removed as a default mac address is "
> + "stored internally.\n");
> +
> + /* Use TI oui and a random nic */
> + oui = 0x080028;
Is there (or should there be) a constant for this?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
*hw)
> pr_err("Failed to init power on!\n");
> return err;
> }
> - if (!wmm_enable) {
> boundary = TX_PAGE_BOUNDARY;
Firstly this isn't indented properly.
Secondly, can this be moved up to where boundary is
> + struct brcmf_usbdev_info *devinfo = bus->bus_priv.usb->devinfo;;
>
> if (ret)
> goto error;
Completely unrelated to this specific patch, I just want to point out
that this construct looks _really_ weird.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
t; case.
>
> I was interested in supporting ASUS RT-AC87U and maybe Netgear R7500.
>
> According to the https://wikidevi.com/wiki/ASUS_RT-AC87U ASUS indeed
> uses some RGMII interface, I'll need to look for more details first.
> Thanks for looking at this.
There's a number of "qtn" strings in the Broadcom boot log listed at
that URL, so it looks like there's some non-network communication
between the "main" SoC and the Quantenna one.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
Hi All,
On Fri, Mar 3, 2017 at 2:38 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote:
> Removed unnecessary 'if' statement and integrated the condition to the
> previous 'if' statement.
>
> Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Reviewed-by: J
Hi All,
On Fri, Mar 3, 2017 at 2:37 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote:
> Fixed alignment to match open parenthesis.
>
> Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> -
Hi All,
On Fri, Mar 3, 2017 at 3:41 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote:
> Modified comment style to preferred kernel comment style.
>
> Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> -
Hi All,
On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote:
> Modified the 'if-else' statement to make it more readable.
>
> Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Again, I'm dubious if this is needed or helpful, but
Revie
Hi All,
On Fri, Mar 3, 2017 at 4:07 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote:
> Added blank line after function and modified comment style.
>
> Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Hi All,
On Fri, Mar 3, 2017 at 4:06 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote:
> Fixed spelling error. 'unkmown' to 'unknown'.
>
> Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
> dr
Hi All,
On Fri, Mar 3, 2017 at 4:05 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote:
> Fixed alignment to match parenthesis.
>
> Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
> driver
; Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 14 ++
> 1 file changed, 6 insertions(+), 8 deletions(-)
--
Julian Calaby
Email: julian.cal...@gmail.com
Profil
}
> - size = (1 << (size + 1));
> -
> - return size;
> + return (1 << (size + 1));
Is the size variable used elsewhere? If not, it's declaration should
probably be removed.
Also, there should be a blank line before the return statement.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
- rt2x00_set_field32(, MAX_LEN_CFG_MAX_PSDU, 1);
> + rt2x00_set_field32(, MAX_LEN_CFG_MAX_PSDU, 3;
You're missing a closing parenthesis, so it isn't going to work unless
it's added back in.
> rt2x00_set_field32(, MAX_LEN_CFG_MIN_PSDU, 0);
> rt2x00_set_field32(, MAX_LEN_CFG_MIN_MPDU, 0);
> rt2800_register_write(rt2x00dev, MAX_LEN_CFG, reg);
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
s = kzalloc(sizeof(*cmd_channels), GFP_KERNEL);
> if (!cmd_channels) {
> ret = -ENOMEM;
> - goto out;
> + goto err_cmd_free;
> }
>
> /* configure channels */
> @@ -296,6 +295,7 @@ int wl18xx_scan_sched_scan_config(struct wl1271 *wl,
>
> out:
> kfree(cmd_channels);
> +err_cmd_free:
Same question here.
> kfree(cmd);
> return ret;
> }
> --
> 1.9.1
>
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
nter dereference.
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
ally need to split this up
into several patches, e.g.
1. Fix the spelling mistakes
2. Add the new debug messages
etc. etc. etc.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
T <christophe.jail...@wanadoo.fr>
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
ertions(+), 5 deletions(-)
Where's the patch?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
hes <j...@perches.com>
This all looks correct to me. I wish you'd put the code changes in a
separate patch, however it's all noted in the commit log, so...
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
Hi All,
On Sun, Aug 28, 2016 at 9:28 PM, Colin King <colin.k...@canonical.com> wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Revie
Hi All,
On Sun, Sep 4, 2016 at 2:43 AM, Colin King <colin.k...@canonical.com> wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> Trivial fix to spelling mistakes in dev_dbg message.
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Revie
Hi All,
On Sat, Aug 27, 2016 at 4:08 AM, Colin King <colin.k...@canonical.com> wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> Trivial fix to spelling mistake in ath10k_warn message.
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Revie
right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
goto out;
> - } else if (ap_ioctl)
> + else if (ap_ioctl)
> ret = 0;
> }
>
> - out:
Does this change make any difference to the compiled code?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
Hi All,
On Thu, Aug 4, 2016 at 4:43 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> It looks like this code is correct, but it just needs to be indented a
> bit.
>
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Looks right to me.
Reviewed-by: J
micro-optimisation: kfree(NULL) is perfectly valid
and buff is either malloc'd memory or NULL when it's called.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubs
Hi Bob,
On Fri, Jul 22, 2016 at 8:38 PM, Bob Copeland <m...@bobcopeland.com> wrote:
> On Fri, Jul 22, 2016 at 07:53:35PM +1000, Julian Calaby wrote:
>> Hi Bob,
>
> Hi!
>
>> > --- a/interface.c
>> > +++ b/interface.c
>> > @@ -295,6 +295,10
z";
> default:
> return "unknown";
> }
Judging by the previous two entries, it looks like the case statements
are sorted, so should these ones therefore be at the top of the list?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Hi All,
On Fri, Jul 22, 2016 at 2:31 AM, Bob Copeland <m...@bobcopeland.com> wrote:
> Fixes smatch warning:
>
> ath9k_vif_iter_set_beacon() warn if statement not indented
>
> Signed-off-by: Bob Copeland <m...@bobcopeland.com>
Looks right to me.
Reviewed-by
ostap/hostap_ioctl.c:3044:9-16: WARNING
> opportunity for memdup_user
> drivers/net/wireless/intersil/hostap/hostap_ioctl.c:3806:9-16: WARNING
> opportunity for memdup_user
>
> Signed-off-by: Rajan Vaja <rajan.v...@gmail.com>
Looks right to me.
Reviewed-by: Julian Calaby <j
why the condition would be compile-time constant as it
>> can be called from outside nl80211.c.
>
> what has that to do with it. No matter who calls it, the point is to ensure
> that it is called for new/del interface. And if a caller uses it for
> something else, then it should
+654,8 @@ struct ath10k_fw_file {
>
> const void *codeswap_data;
> size_t codeswap_len;
> + /* FIXME: add a comment */
> + struct ath10k_swap_code_seg_info *firmware_swap_code_seg_info;
Why not just add a comment? Adding FIXMEs makes the patch look incomplete to me.
Th
ssumes only one of the counters
> would wraparound at anytime. Fix this by moving 'else' part to
> another 'if'.
>
> Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for
> QCA4019")
> Signed-off-by: Vasanthakumar Thiagarajan <vthia...@qti.qualcomm.com>
> interface")
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Looks correct to me as Dan Carpenter submitted the same fix.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://
sely
Patches that you send must be signed off by you, not ack'd by you.
I.e.
From: Random Developer <random.develo...@company.com>
.
Signed-off-by: Random Developer <random.develo...@company.com>
Signed-off-by: Patch Sender <patch.sen...@company.com>
Thanks,
--
Hi All,
On Wed, Jun 29, 2016 at 1:37 PM, Masanari Iida <standby2...@gmail.com> wrote:
> This patch fix spelling typos found in drivers/net/wireless/realtek.
>
> Signed-off-by: Masanari Iida <standby2...@gmail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.c
k: The GPIO mask
> +- qca,gpio-val: The GPIO value
> +- qca,led-pin: The GPIO number to which the LED is connected
> +- qca,led-active-high: The LED is active when the GPIO is HIGH
> +- qca,clk-25mhz: Defines that at 25MHz clock is used
> +- qca,no-eeprom: Indicates that there is on phy
ail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless&
s right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a m
right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message
Hi Luis,
On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt
<lui...@osg.samsung.com> wrote:
> On 24/06/16 00:15, Julian Calaby wrote:
>> Hi Joe,
>>
>> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches <j...@perches.com> wrote:
>>> On Thu, 2016-06-23
Maybe I should send a hit to the
>> kernelnewbies mailing list :)
>
> Or not.
>
> really_long_identifiers™ makes using 80 columns silly.
>
> The hungarian could probably be converted though.
The main developers of this driver are slowly working through the
driver's style issu
Hi All,
On Fri, Jun 17, 2016 at 2:58 AM, Eduardo Abinader
<eduardo.abina...@riverbed.com> wrote:
> Just setting the proper return for reading beyond the eeprom data.
>
> Signed-off-by: Eduardo Abinader <eduardo.abina...@riverbed.com>
This makes sense to me.
Revie
uld be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
The return value of wlan_initialize_threads() is only checked to be
non-zero, so this looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
--
Julian Calaby
returning -EINVAL instead of -1 is more
> appropriate.
These two changes could be argued to be separate changes deserving of
their own patches.
> Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com>
However if everyone else is ok with that, this is:
Reviewed-by: Julian Calaby <
Hi All,
On Wed, Jun 22, 2016 at 11:34 PM, Eduardo Abinader
<eduardo.abina...@riverbed.com> wrote:
> just to comply to coding style.
>
> Signed-off-by: Eduardo Abinader <eduardo.abina...@riverbed.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.c
Hi Jouni,
On Tue, Jun 21, 2016 at 7:41 PM, Jouni Malinen <j...@w1.fi> wrote:
> On Tue, Jun 21, 2016 at 11:02:20AM +1000, Julian Calaby wrote:
>> I've only done this work as I hate to see people's efforts go to
>> waste and I feel that there's enough roadblocks in the way
om>
[Hide this support behind a Kconfig option]
Signed-off-by: Julian Calaby <julian.cal...@gmail.com>
---
drivers/net/wireless/ath/ath9k/Kconfig | 19 +++
drivers/net/wireless/ath/ath9k/ath9k.h | 2 +-
drivers/net/wireless/ath/ath9k/
to
> DFS channels, tx power, and such, but maybe having driver support is
> considered to make it
> too easy for users to hack around restrictions?
Maybe hide this behind CFG80211_CERTIFICATION_ONUS or equivalent?
(Maybe a new symbol CFG80211_LICENSE_REQUIRED with big scary
feds-will-come-knocking w
xists, has that number, takes arguments
in that format and works?
Thanks,
Julian Calaby
> On Wed, Jun 8, 2016 at 8:16 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote:
>> Prasun Maiti <prasunmait...@gmail.com> writes:
>>
>>> No. I did not any test for that cas
queuing based drivers
> achieve better performance by utilizing airtime
> more efficiently with big aggregates.
>
> Signed-off-by: Michal Kazior <michal.kaz...@tieto.com>
As this patch is passing through your hands, you need to add your
Signed-off-by too.
Thanks,
--
Julian Calaby
Hugh Sipiere <hgsipi...@gmail.com>
You should separate the changes into two patches, one to change
"unsigned" to "unsigned int" and one to fix the comments.
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
Hi Javier,
On Wed, Jun 1, 2016 at 11:51 PM, Javier Martinez Canillas
<jav...@osg.samsung.com> wrote:
> Hello Julian,
>
> Thanks a lot for your feedback and reviews.
>
> On 06/01/2016 12:20 AM, Julian Calaby wrote:
>> Hi All,
>>
>> On Sat, May 28, 2016 at 12:
ppropriate one.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
>
> ---
>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
> 1 file changed, 2 insertions(+)
the property being missed shouldn't be treated as an error.
Have you checked whether it is truly optional? I.e. nothing else
breaks if this property isn't set?
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Other than that, this looks sensible to me.
Reviewed-by: Juli
av...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.c
t;
> This also has the nice side effect that the cleanup operations are made
> in the inverse order of their counterparts, which was not the case for
> the mwifiex_add_card() error path.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sens
the first function that failed.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 8
> 1 file changed,
Hi All,
On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas
<jav...@osg.samsung.com> wrote:
> It's better to have the device name prefixed in the error message.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks right to me.
Revie
actually failed.
>
> Since the driver/device core prints the value returned by .probe in its
> error message propagate what was returned by sdio_enable_func() at fail.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Ju
c2:0001:1: sdio platform data not available
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
This looks sensible to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> drivers/net/wireless/marvell/mwifiex/sdio.c | 6 +++---
> 1 file changed, 3 inserti
Hi All,
On Fri, May 27, 2016 at 9:25 PM, Eduardo Abinader <eabina...@ocedo.com> wrote:
> Just small adjustment.
>
> Signed-off-by: Eduardo Abinader <eduardo.abina...@riverbed.com>
This looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
>
ted patch.
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> ---
> net/wireless/ap.c | 1 -
> net/wireless/chan.c| 3 ---
> net/wireless/core.h| 2 --
>
d-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
With Kirtika's explanation, this is:
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 103
> ++---
> 1 file cha
his patch also contains two hunks to fix
> 'line over 80 characters',
> that are spacing related". This is the second hunk, the first being
> the comments in the nl80211_fam
> definition. Should I resend with these two hunks omitted, or fix my wording?
That explains it, I m
> command failed: Too many open files in system (-23)
>
> Signed-off-by: Rafal Milecki <zaj...@gmail.com>
> [ar...@broadcom.com: reduce error prints upon iface creation]
> Signed-off-by: Arend van Spriel <ar...@broadcom.com>
FWIW, this is:
Reviewed-by: Julian Calaby &
>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 46757af..2964406
Hi All,
On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani
<kirtika.ruchand...@gmail.com> wrote:
> This patch fixes the checkpatch.pl warning "foo * bar should be
> foo *bar"
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
Looks right
Hi All,
On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani
<kirtika.ruchand...@gmail.com> wrote:
> Fix 'implementation' spelling, reported by checkpatch.pl
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
Looks right to me.
Reviewed-by: Juli
m not sure I agree with checkpatch here, but this looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/wireless/nl80211.c b
>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 945405d.
ail.com>
Looks right to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 23 +++
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wirel
right to me, but doesn't ether_addr_copy() have alignment
requirements? Could someone more familiar with that review these
changes to ensure they're met?
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/net/wi
nd the whole patch-set or just patch 3/3 in
> this one as a separate set?
Re-send the entire set, make sure you mark it as v2, include a
changelog in the cover letter or below the "---" in the patches
themselves, and don't forget to include the reviewed-bys for any
unchanged patches.
Th
kas <auri...@google.com>
Other than that, it looks good to me.
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
One final note, any patch you send to linux-wireless gets entered into
patchwork, so there's no need to keep asking for a review, people are
busy and will get to i
ement
Multiple assignments:
> - multiple assignments should be avoided
ether_addr_copy:
> - prefer ether_addr_copy over memcpy
Spelling:
> - correct spelling - 'implementation'
NULL comparisons:
> - comparison to NULL could be written as !foo
kcalloc vs kzalloc:
> - prefer kcalloc over
after declarations
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
Looks sensible to me
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 22 ++
> 1 file changed, 10
'*/' on a separate line
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchand...@gmail.com>
The change and logic behind it are sound, so it gets my:
Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
however I'm concerned that this file is a deliberate exception to the
se NL80211_IFTYPE_UNSPECIFIED:
> default:
> return ERR_PTR(-EINVAL);
> }
> +
> + if (IS_ERR(wdev))
> + brcmf_err("add iface %s type %d failed: err=%d\n",
> + name, type, PTR_ERR(wdev));
> +
Hi,
On Wed, May 18, 2016 at 11:14 AM, Dan Lenski <dlen...@gmail.com> wrote:
> This patch makes RTL8XXXU_FIRMWARE_POLL_MAX into a configurable module
> parameter, firmware_poll_max.
>
> Signed-off-by: Dan Lenski <dlen...@gmail.com>
This looks good to me.
Reviewed-by: J
1 - 100 of 296 matches
Mail list logo
