Re: [PATCH] mac80211: minstrel: Enable STBC and LDPC for VHT Rates

On Mon, Jun 27, 2016 at 9:53 AM, Chaitanya TK wrote: > From: Chaitanya T K > > If peer support reception of STBC and LDPC, enable them for better > performance. > > Signed-off-by: Chaitanya TK > --- >

Re: [PATCH v6] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

Hi, On Fri, Nov 14, 2014 at 06:43:28PM +0200, Jouni Malinen wrote: On Tue, Oct 21, 2014 at 10:38:38AM +0200, Karl Beldan wrote: When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'), there is no behavioral change including in sampling and MCS_GROUP_RATES remains 8

Re: [PATCH v6] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

On Fri, Nov 14, 2014 at 07:36:48PM +0200, Jouni Malinen wrote: On Fri, Nov 14, 2014 at 06:18:32PM +0100, Karl Beldan wrote: Yes, only with iw and nothing fancy, I also have had it running on some boards for some weeks as is and with rfc version for more than a year at work (minstrel

Re: [PATCH v6] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

Hi, On Tue, Oct 21, 2014 at 10:38:38AM +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com @@ -1026,13 +1184,47 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband, sta-bandwidth IEEE80211_STA_RX_BW_40

[PATCH] mac80211: minstrel_ht: do not always skip ht rates vht_only is true

From: Karl Beldan karl.bel...@rivierawaves.com When CONFIG_MAC80211_RC_MINSTREL_VHT is set, the module param minstrel_vht_only tells minstrel_ht whether to allow the mix of ht rates with vht rates. ATM, minstrel_ht skips ht rates when minstrel_vht_only is true, but it does that even if vht

Re: [PATCH] mac80211: minstrel_ht: do not always skip ht rates vht_only is true

On Fri, Oct 24, 2014 at 02:34:49PM +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com When CONFIG_MAC80211_RC_MINSTREL_VHT is set, the module param minstrel_vht_only tells minstrel_ht whether to allow the mix of ht rates with vht rates. ATM, minstrel_ht skips ht rates

Re: [PATCH v3 0/4] add VHT support to minstrel_ht

On Sat, Oct 18, 2014 at 11:11:48PM +0530, Krishna Chaitanya wrote: On Sat, Oct 18, 2014 at 10:43 PM, Karl Beldan karl.bel...@gmail.com wrote: From: Karl Beldan karl.bel...@rivierawaves.com Karl Beldan (4): mac80211: minstrel_ht: Increase the range of handled rate indexes

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote: On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: I still don't know why I don't see the smatch array warnings here, I guess I'll live with that for now. I'm hoping Dan will eventually pick up on it ;-) smatch is good

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

On Wed, Oct 22, 2014 at 04:07:31PM +0200, Johannes Berg wrote: On Wed, 2014-10-22 at 15:54 +0200, Karl Beldan wrote: On Tue, Oct 21, 2014 at 08:47:26PM +0200, Johannes Berg wrote: On Tue, 2014-10-21 at 17:26 +0200, Karl Beldan wrote: I still don't know why I don't see the smatch

[PATCH] mac80211: minstrel_ht: use group flags instead of index to display rates

From: Karl Beldan karl.bel...@rivierawaves.com When displaying a rate through debugfs minstrel_ht guesses its flags comparing group indexes. Since 3ec373c421b6 (mac80211: minstrel_ht: include type (cck/ht) in rates flag), the rate flags of interest are present in the mcs_group-s, so use

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

On Mon, Oct 20, 2014 at 09:33:17PM +0200, Johannes Berg wrote: On Mon, 2014-10-20 at 17:34 +0200, Karl Beldan wrote: Indeed, will resending only 4/4 do ? Sure. CHECK /home/johannes/sys/wireless/net/mac80211/rc80211_minstrel_ht_debugfs.c /home/johannes/sys/wireless/net

[PATCH v2] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

From: Karl Beldan karl.bel...@rivierawaves.com ATM an HT rc_stats line is 106 chars. Times 8(MCS_GROUP_RATES)*3(SS)*2(GI)*2(BW) + CCK(4), i.e. x100, this is well above the current 8192 - sizeof(*ms) currently allocated. Fix this by squeezing the output as follows (not that we're short on memory

[PATCH v4 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag

From: Karl Beldan karl.bel...@rivierawaves.com ATM, we grep cck rates idx with idx / MCS_GROUP_RATES == MINSTREL_CCK_GROUP. Matching neither-cck-non-ht rates could be done by replacing '==' with '', however it would be less versatile or explicit. This will allow to match VHT rates

Re: [PATCH v4 0/4] add VHT support to minstrel_ht

Felix, I added your Acks in the patches but git-send-email did not send them to the Acked-by addresses. Karl On Mon, Oct 20, 2014 at 10:55:38AM +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Hi, This is just a respin rebased on v2 of mac80211: minstrels: fix

Re: [PATCH v4 0/4] add VHT support to minstrel_ht

Hi Varka Bhadram, On Mon, Oct 20, 2014 at 02:31:31PM +0530, Varka Bhadram wrote: Hi Karl Beldan, On 10/20/2014 02:25 PM, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Hi, This is just a respin rebased on v2 of mac80211: minstrels: fix buffer overflow in HT debugfs

[PATCH v5 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs

From: Karl Beldan karl.bel...@rivierawaves.com No functional change. Signed-off-by: Karl Beldan karl.bel...@rivierawaves.com Cc: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 51 +++--- net/mac80211/rc80211_minstrel_ht.h | 15

[PATCH v5 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes

From: Karl Beldan karl.bel...@rivierawaves.com Since 5935839ad735 (mac80211: improve minstrel_ht rate sorting by throughput probability), the rate indexes are manipulated via u8's and hence allow for a maximum of 256 mcs_group entries in minstrel_mcs_groups. ATM, minstrel_ht advertizes support

[PATCH v5 0/4] add VHT support to minstrel_ht

From: Karl Beldan karl.bel...@rivierawaves.com Hi, Varka Bhadram reported checkpatch is noisy on this series. I made another pass which affects [2/4](trivially) and [4/4]. This could have been a patch on top of what Felix acked, I hope you won't bother too much. Thanks for reviewing, Karl

[PATCH v5 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag

From: Karl Beldan karl.bel...@rivierawaves.com ATM, we grep cck rates idx with idx / MCS_GROUP_RATES == MINSTREL_CCK_GROUP. Matching neither-cck-non-ht rates could be done by replacing '==' with '', however it would be less versatile or explicit. This will allow to match VHT rates

[PATCH v5 4/4] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

From: Karl Beldan karl.bel...@rivierawaves.com When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'), there is no behavioral change including in sampling and MCS_GROUP_RATES remains 8. Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only* (default 'true'), restricts

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

On Mon, Oct 20, 2014 at 04:49:06PM +0200, Johannes Berg wrote: On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Hi, Varka Bhadram reported checkpatch is noisy on this series. I made another pass which affects [2/4](trivially

Re: [PATCH v5 0/4] add VHT support to minstrel_ht

On Mon, Oct 20, 2014 at 05:13:02PM +0200, Karl Beldan wrote: On Mon, Oct 20, 2014 at 04:49:06PM +0200, Johannes Berg wrote: On Mon, 2014-10-20 at 15:45 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Hi, Varka Bhadram reported checkpatch is noisy

Re: [PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

Hi, If that's not too late I'd like to fix some coding style, replace: On Fri, Oct 17, 2014 at 08:34:00PM +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com @@ -102,6 +102,8 @@ minstrel_stats_open(struct inode *inode, struct file *file) mi

Re: [RESEND PATCH v2 4/4] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

In v3 the moduleparam minstrel_vht_only should go under CONFIG_MAC80211_RC_MINSTREL_VHT. On Fri, Oct 17, 2014 at 09:50:59PM +0200, Karl Beldan wrote: @@ -91,6 +124,10 @@ } \ } +static bool minstrel_vht_only = true; +module_param

[PATCH v3 0/4] add VHT support to minstrel_ht

From: Karl Beldan karl.bel...@rivierawaves.com Karl Beldan (4): mac80211: minstrel_ht: Increase the range of handled rate indexes mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs mac80211: minstrel_ht: include type (cck/ht) in rates flag mac80211: minstrel_ht: add basic

[PATCH v3 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag

From: Karl Beldan karl.bel...@rivierawaves.com ATM, we grep cck rates idx with idx / MCS_GROUP_RATES == MINSTREL_CCK_GROUP. Matching neither-cck-non-ht rates could be done by replacing '==' with '', however it would be less versatile or explicit. This will allow to match VHT rates

[PATCH v3 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes

From: Karl Beldan karl.bel...@rivierawaves.com Since 5935839ad735 (mac80211: improve minstrel_ht rate sorting by throughput probability), the rate indexes are manipulated via u8's and hence allow for a maximum of 256 mcs_group entries in minstrel_mcs_groups. ATM, minstrel_ht advertizes support

[PATCH v3 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs

From: Karl Beldan karl.bel...@rivierawaves.com No functional change. Signed-off-by: Karl Beldan karl.bel...@rivierawaves.com Cc: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 51 +++--- net/mac80211/rc80211_minstrel_ht.h | 14

Re: [PATCH v3 0/4] add VHT support to minstrel_ht

On Sat, Oct 18, 2014 at 11:11:48PM +0530, Krishna Chaitanya wrote: On Sat, Oct 18, 2014 at 10:43 PM, Karl Beldan karl.bel...@gmail.com wrote: From: Karl Beldan karl.bel...@rivierawaves.com Karl Beldan (4): mac80211: minstrel_ht: Increase the range of handled rate indexes

[PATCH] mac80211: minstrels: fix buffer overflow in HT debugfs rc_stats

From: Karl Beldan karl.bel...@rivierawaves.com ATM an HT rc_stats line is 106 chars. Times 8(MCS_GROUP_RATES)*3(SS)*2(GI)*2(BW) + CCK(4), i.e. x100, this is well above the current 8192 - sizeof(*ms) currently allocated. Fix this by squeezing the output as follows (not that we're short on memory

[PATCH v2 0/4] add VHT support to minstrel_ht

From: Karl Beldan karl.bel...@rivierawaves.com Hi, This is a split version of the VHT support addition to minstrel. Thanks for reviewing, Karl Beldan (4): mac80211: minstrel_ht: Increase the range of handled rate indexes mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs

[PATCH v2 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes

From: Karl Beldan karl.bel...@rivierawaves.com Since 5935839ad735 (mac80211: improve minstrel_ht rate sorting by throughput probability), the rate indexes are manipulated via u8's and hence allow for a maximum of 256 mcs_group entries in minstrel_mcs_groups. ATM, minstrel_ht advertizes support

[RESEND PATCH v2 3/4] mac80211: minstrel_ht: include type (cck/ht) in rates flag

From: Karl Beldan karl.bel...@rivierawaves.com ATM, we grep cck rates idx with idx / MCS_GROUP_RATES == MINSTREL_CCK_GROUP. Matching neither-cck-non-ht rates could be done by replacing '==' with '', however it would be less versatile or explicit. This will allow to match VHT rates

[RESEND PATCH v2 1/4] mac80211: minstrel_ht: Increase the range of handled rate indexes

From: Karl Beldan karl.bel...@rivierawaves.com Since 5935839ad735 (mac80211: improve minstrel_ht rate sorting by throughput probability), the rate indexes are manipulated via u8's and hence allow for a maximum of 256 mcs_group entries in minstrel_mcs_groups. ATM, minstrel_ht advertizes support

[RESEND PATCH v2 4/4] mac80211: minstrel_ht: add basic support for VHT rates = 3SS@80MHz

From: Karl Beldan karl.bel...@rivierawaves.com When the new CONFIG_MAC80211_RC_MINSTREL_VHT is not set (default 'N'), there is no behavioral change including in sampling and MCS_GROUP_RATES remains 8. Otherwise MCS_GROUP_RATES is 10, and a module parameter *vht_only* (default 'true'), restricts

[RESEND PATCH v2 2/4] mac80211: minstrel_ht: macros adjustments for future VHT_GROUPs

From: Karl Beldan karl.bel...@rivierawaves.com No functional change. Signed-off-by: Karl Beldan karl.bel...@rivierawaves.com Cc: Felix Fietkau n...@openwrt.org --- net/mac80211/rc80211_minstrel_ht.c | 51 +++--- net/mac80211/rc80211_minstrel_ht.h | 14

[PATCH v2] mac80211: fix typo in starting baserate for rts_cts_rate_idx

From: Karl Beldan karl.bel...@rivierawaves.com It affects non-(V)HT rates and can lead to selecting an rts_cts rate that is not a basic rate or way superior to the reference rate (ATM rates[0] used for the 1st attempt of the protected frame data). E.g, assuming drivers register growing (bitrate

Re: [PATCH] cfg80211: set the rates mask in connection probes over specified freq

On Thu, Oct 09, 2014 at 11:32:57AM +0200, Johannes Berg wrote: On Tue, 2014-10-07 at 11:42 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com ATM, specifying the frequency when connecting sends a void 'supported rates' EID. Seems like this should be a stable fix

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote: On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com Is that really trivial? It seems to have some impact on the code, but I can't right now say exactly what the impact is. Can you

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

On Thu, Oct 09, 2014 at 04:15:03PM +0200, Johannes Berg wrote: On Thu, 2014-10-09 at 16:06 +0200, Karl Beldan wrote: On Thu, Oct 09, 2014 at 11:06:26AM +0200, Johannes Berg wrote: On Tue, 2014-10-07 at 15:53 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com

Re: [PATCH] cfg80211: set the rates mask in connection probes over specified freq

On Thu, Oct 09, 2014 at 03:26:02PM +0200, Johannes Berg wrote: On Thu, 2014-10-09 at 15:00 +0200, Karl Beldan wrote: On Thu, Oct 09, 2014 at 11:32:57AM +0200, Johannes Berg wrote: On Tue, 2014-10-07 at 11:42 +0200, Karl Beldan wrote: From: Karl Beldan karl.bel...@rivierawaves.com

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

On Thu, Oct 09, 2014 at 05:22:21PM +0200, Johannes Berg wrote: On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote: The typo is clearly showing but the faulty behavior clearly demands more detail indeed. It affects non-(V)HT rates and can lead to selecting an rts_cts rate

Re: [PATCH] cfg80211: set the rates mask in connection probes over specified freq

On Thu, Oct 09, 2014 at 08:36:33PM +0200, Johannes Berg wrote: Heh, so I guess this goes way back ... what does it actually affect really though? only connections with iw, which should really not be done that much? potentially wpa_s with wext, though I'm not even sure that works? For wext I

Re: [PATCH] mac80211/trivial: fix typo in starting baserate for rts_cts_rate_idx

On Thu, Oct 09, 2014 at 05:22:21PM +0200, Johannes Berg wrote: On Thu, 2014-10-09 at 16:45 +0200, Karl Beldan wrote: The typo is clearly showing but the faulty behavior clearly demands more detail indeed. It affects non-(V)HT rates and can lead to selecting an rts_cts rate

Re: [PATCH] mac80211: minstrel_ht: add basic support for VHT rates = 80MHz@NSS2

Unless I can spare some space in rc_stats, v2 will need an increase in minstrel_debugfs_info buffer (ATM 1 line is 100 chars). Karl -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 2/2] mac80211: improve minstrel_ht rate sorting by throughput probability

On Tue, Sep 09, 2014 at 11:22:14PM +0200, Thomas Huehn wrote: This patch improves the way minstrel_ht sorts rates according to throughput and success probability. 3 FOR-loops across the entire rate and mcs group set in function minstrel_ht_update_stats() which where used to determine the

[PATCH] mac80211: minstrel_ht: fix MCS_GROUP_RATES usage

From: Karl Beldan karl.bel...@rivierawaves.com Commit 4441e8e9 (mac80211: improve minstrel_ht rate sorting by throughput probability) replaced the constant 8 with MCS_GROUP_RATES when getting the number of streams of an HT MCS. See commit 7a5e3fa2 (mac80211: minstrel_ht: replace some occurences