[PATCH 14/18] iwlwifi: acpi: move function to get mcc into acpi code

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The iwl_get_bios_mcc() function was in the iwl-nvm-parse.c file, but it has nothing to do with the NVM. Move it to fw/acpi.c and rename it to iwl_acpi_get_mcc(). Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wi

[PATCH 15/18] iwlwifi: fix indentation in a000 family configuration

2017-09-29 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> Fix the double indentation in the configuration structs for a000 family devices. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwif

[PATCH 17/18] iwlwifi: mvm: warn on invalid statistics size

2017-09-29 Thread Luca Coelho
s Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rx.c b/drivers/net/wireless/intel/iwlw

[PATCH 11/18] iwlwifi: acpi: use iwl_acpi_get_wifi_pkg when reading reading SPLC

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Instead of finding the wifi package with its own code, we can reuse the new iwl_acpi_get_wifi_pkg() function when reading the default power limit from SPLC. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/i

[PATCH 13/18] iwlwifi: acpi: remove a couple of unnecessary ifdefs

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Some of the #ifdef CONFIG_ACPI are not needed anymore, so they can be removed. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 -- drivers/net/wireless/intel/iwlwifi/pcie/drv.c |

[PATCH 16/18] iwlwifi: acpi: move code that reads SPLC to acpi

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Move most of the set_dflt_pwr_limit() function to acpi.c and make it return the pwr_limit value instead of setting directly. Also rename it to iwl_acpi_get_pwr_limit(). Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/

[PATCH 02/18] iwlwifi: fw: api: remove excess enum value documentation

2017-09-29 Thread Luca Coelho
From: Johannes Berg <johannes.b...@intel.com> These enum values don't exist, so remove their documentation as well. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/sta.

[PATCH 07/18] iwlwifi: acpi: add common code to read from ACPI

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There are many places where the same process of invoking a method from ACPI is used, causing a lot of duplicate code. To improve this, introduce a new function to get an ACPI object by invoking an ACPI method that can be reused. Additionally,

[PATCH 09/18] iwlwifi: acpi: move ACPI-related definitions to acpi.h

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The ACPI table size definitions were spread around the different files that used them. Move them all to a common place. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/acpi

[PATCH 03/18] iwlwifi: mvm: add marker cmd response struct.

2017-09-29 Thread Luca Coelho
From: Mordechay Goodstein <mordechay.goodst...@intel.com> This helps for documentation and clarifies the code by defining the exact response struct for the marker command. Signed-off-by: Mordechay Goodstein <mordechay.goodst...@intel.com> Signed-off-by: Luca Coelho <luciano.c

[PATCH 01/18] iwlwifi: mvm: don't send identical PHY_CTXT_CMD

2017-09-29 Thread Luca Coelho
ed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 14 ++ drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 ++ drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt

[PATCH 06/18] iwlwifi: mvm: change warning to warn_once()

2017-09-29 Thread Luca Coelho
From: Sara Sharon <sara.sha...@intel.com> In case there is a FW bug where the BAID value in the metadata is not properly initialized we hit the warning for every RX packet. Change it to warn once and add elaborate message. Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-

[PATCH 4/5] iwlwifi: nvm-parse: unify channel flags printing

2017-09-29 Thread Luca Coelho
ertain channels with certain flag combinations. Signed-off-by: Johannes Berg <johannes.b...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 98 +- 1 file changed, 39 insertions(+), 59 deleti

[PATCH 2/5] iwlwifi: stop dbgc recording before stopping DMA

2017-09-29 Thread Luca Coelho
golan.ben@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 7 ++- drivers/net/wireless/intel/iwlwifi/fw/dbg.h | 15 +++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireles

[PATCH 5/5] iwlwifi: nvm: set the correct offsets to 3168 series

2017-09-29 Thread Luca Coelho
Fixes: c4836b056d83 ("iwlwifi: Add PCI IDs for the new 3168 series") Signed-off-by: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/7000.c | 1 + drivers/net/wireless/intel/

[PATCH 3/5] iwlwifi: mvm: return -ENODATA when reading the temperature with the FW down

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> It seems that libsensors treats -EIO as a special non-recoverable failure when it tries to read the temperature while the firmware is not running. To solve that, change the error code to a milder -ENODATA. This fixes https://bugzilla.kern

[PATCH 0/5] iwlwifi: fixes intended for 4.14 2017-09-29

2017-09-29 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Another batch of fixes intended for 4.14. This one is a bit smaller than the previous one. These are the fixes: * Fix support for 3168 device series; * Fix a potential crash when using FW debugging recording; * Improve channel flags p

[PATCH 1/5] iwlwifi: mvm: do not print security error in monitor mode

2017-09-29 Thread Luca Coelho
Signed-off-by: Shaul Triebitz <shaul.trieb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 7 +++ drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 3 +++ drivers/net/wireless/intel/iwlwifi/mvm/rx.c

Re: [PATCH 09/10] mac80211_hwsim: Add command to control rx status RSSI

2017-09-29 Thread Luca Coelho
On Wed, 2017-09-06 at 12:33 +0200, Johannes Berg wrote: > On Sat, 2017-08-05 at 11:44 +0300, Luca Coelho wrote: > > > > +static int hwsim_fops_rx_rssi_write(void *dat, u64 val) > > +{ > > + struct mac80211_hwsim_data *data = dat; > > + int rssi = (int)val; >

[PATCH v2] ieee80211: Add WFA TPC report element OUI type

2017-09-29 Thread Luca Coelho
From: Avraham Stern <avraham.st...@intel.com> Add Transmit Power Control OUI type definition for WLAN_OUI_MICROSOFT. Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/linux/ieee80211.h | 1 + 1 file ch

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote: > On 09/15/2017 01:38 PM, Linus Torvalds wrote: > > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > > > > > > > In any case, your patch introduces a regression on systems. Please get > > > > it reverted now, and then

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 12:38 -0700, Linus Torvalds wrote: > On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe wrote: > > > > > > In any case, your patch introduces a regression on systems. Please get > > > it reverted now, and then you can come up with a new approach to fix the > > >

Re: iwlwifi firmware load broken in current -git

2017-09-15 Thread Luca Coelho
On Fri, 2017-09-15 at 13:32 -0600, Jens Axboe wrote: > On 09/14/2017 02:36 PM, Jens Axboe wrote: > > On 09/14/2017 02:04 PM, Srinath Mannam wrote: > > > Hi Jens Axboe, > > > > > > > > > On Thu, Sep 14, 2017 at 11:14 PM, Jens Axboe wrote: > > > > On 09/14/2017 11:35 AM, Jens

[PATCH 03/10] iwlwifi: fix wrong struct for a000 device

2017-09-15 Thread Luca Coelho
From: Oren Givon <oren.gi...@intel.com> The PCI ID (0x2720, 0x0070) was set with the config struct iwla000_2ax_cfg_hr instead of iwla000_2ac_cfg_hr_cdb. Fixes: 175b87c69253 ("iwlwifi: add the new a000_2ax series") Signed-off-by: Oren Givon <oren.gi...@intel.com> Sign

[PATCH 00/10] iwlwifi: updates intended for v4.15 2017-09-15

2017-09-15 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here's my first set of patches intended for 4.15. Nothing major here, these are the changes: * Cleanups: - remove an unused value that we read from the NVM; - remove link quality measurement code that was never used; * One FW c

[PATCH 08/10] iwlwifi: Add few debug prints to the WRT dump flow

2017-09-15 Thread Luca Coelho
From: Ilan Peer <ilan.p...@intel.com> This would enable to better catch timing issues with cases that WRT dump takes too much time. Signed-off-by: Ilan Peer <ilan.p...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwl

[PATCH 10/10] iwlwifi: remove redundant reading from NVM file

2017-09-15 Thread Luca Coelho
From: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> The driver reads xtal_calib from NVM file, but actually never uses it. This is only used in dvm driver. Signed-off-by: Chaya Rachel Ivgi <chaya.rachel.i...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

[PATCH 07/10] iwlwifi: mvm: support firmware debug trigger on frame reorder timeout

2017-09-15 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> The trigger that collects data when a frame is released because of the timer of the reordering buffer was not implemented for 9000 devices. Fix this. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

[PATCH 09/10] iwlwifi: pcie: dynamic Tx command queue size

2017-09-15 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/a000.c | 3 ++- drivers/net/wireless/intel/iwlwifi/iwl-config.h| 3 +++ .../net/wireless/intel/iwlwifi/pcie/ctxt-info.c| 2 +- drivers/net/wireless/intel/iwlwifi/pc

[PATCH 05/10] iwlwifi: mvm: Add new quota command API

2017-09-15 Thread Luca Coelho
From: David Spinadel <david.spina...@intel.com> New quota command adds a field indicating low latency direction per quota. A TLV API bit was added to indicate the new API. Signed-off-by: David Spinadel <david.spina...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.co

[PATCH 06/10] iwlwifi: mvm: remove support for Link Quality Measurements

2017-09-15 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> This was never used by any product. Remove it. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/fw/api

[PATCH 04/10] iwlwifi: add a new a000 device

2017-09-15 Thread Luca Coelho
From: Oren Givon <oren.gi...@intel.com> Add a new a000 device with PCI ID (0x2720, 0x0030). Signed-off-by: Oren Givon <oren.gi...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 + 1 file changed, 1 insert

[PATCH 02/10] iwlwifi: trans: move ref/unref code to the common part of the transport

2017-09-15 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> De-inline iwl_trans_ref/unref and move it to common transport code in preparation for more common code to come to these functions. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-

[PATCH 01/10] iwlwifi: mvm: add dbgfs entry for fw info

2017-09-15 Thread Luca Coelho
From: Liad Kaufman <liad.kauf...@intel.com> Add a dbgfs entry for an easy way during runtime to check what FW file was loaded, and get some general FW-related data. Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com>

pull-request: iwlwifi 2017-09-15

2017-09-15 Thread Luca Coelho
on the probe queue iwlwifi: mvm: wake the correct mac80211 queue David Spinadel (1): iwlwifi: mvm: Flush non STA TX queues Luca Coelho (4): iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast addresses iwlwifi: mvm

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Luca Coelho
On Tue, 2017-09-12 at 13:43 -0600, Jens Axboe wrote: > On 09/12/2017 10:36 AM, Luca Coelho wrote: > > On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: > > > Hi Jens, > > > > > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > > > >

Re: iwlwifi firmware load broken in current -git

2017-09-12 Thread Luca Coelho
On Tue, 2017-09-12 at 16:11 +, Coelho, Luciano wrote: > Hi Jens, > > On Tue, 2017-09-12 at 09:48 -0600, Jens Axboe wrote: > > Hi, > > > > I have no wifi in current git (8fac2f96ab8), it simply fails with: > > > > [4.363481] iwlwifi :04:00.0: Direct firmware load for > >

[PATCH 09/10] iwlwifi: mvm: set status before calling iwl_mvm_send_cmd_status()

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always must set the status to what we consider success before calling iwl_mvm_send_cmd_status() (also iwl_mvm_send_cmd_pdu_status() which calls it). Fix a few places where initialization is missing. Signed-off-by: Luca Coelho <lu

[PATCH 04/10] iwlwifi: mvm: change state when queueing agg start work

2017-09-08 Thread Luca Coelho
se criteria of a BA session") Signed-off-by: Naftali Goldstein <naftali.goldst...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 3 ++- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 6 -- drivers/net/wireless

[PATCH 10/10] iwlwifi: mvm: fix reorder buffer for 9000 devices

2017-09-08 Thread Luca Coelho
elease packets out of order in some scenarios. Fixes: b915c10174fb ("iwlwifi: mvm: add reorder buffer per queue") Signed-off-by: Sara Sharon <sara.sha...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c |

[PATCH 08/10] iwlwifi: mvm: initialize status in iwl_mvm_add_int_sta_common()

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always need to initialize the status argument to the success case before calling iwl_mvm_send_cmd_status() or iwl_mvm_send_cmd_pdu_status() (which calls the former) otherwise we may get an uninitialized value back. In this case,

[PATCH 07/10] iwlwifi: mvm: handle FIF_ALLMULTI when setting multicast addresses

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We were ignoring the FIF_ALLMULTI flag when setting the multicast addresses with MCAST_FILTER_CMD. Check if this flag is set and enable pass_all accordingly. We also need to set the count to 0 if pass_all is enable so we don't pass add

[PATCH 06/10] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The MCAST_FILTER_CMD can get quite large when we have many mcast addresses to set (we support up to 255). So the command should be send as NOCOPY to prevent a warning caused by too-long commands: WARNING: CPU: 0 PID: 9700 at /root/iwlwifi/sta

[PATCH 03/10] iwlwifi: mvm: send all non-bufferable frames on the probe queue

2017-09-08 Thread Luca Coelho
y: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wir

[PATCH 02/10] iwlwifi: mvm: Flush non STA TX queues

2017-09-08 Thread Luca Coelho
ed-off-by: David Spinadel <david.spina...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 44 ++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi

[PATCH 05/10] iwlwifi: mvm: wake the correct mac80211 queue

2017-09-08 Thread Luca Coelho
are purged") Signed-off-by: Avraham Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/m

[PATCH 01/10] iwlwifi: mvm: fix wowlan resume failed to load INIT ucode

2017-09-08 Thread Luca Coelho
: Matt Chen <matt.c...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlw

[PATCH 00/10] iwlwifi: fixes intended for 4.14 2017-09-08

2017-09-08 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here is my first batch of fixes intended for 4.14. Since it is very early in the release process, I was a bit liberal with the fixes I'm sending, but they all fix real issues. These are the fixes: * A couple of bugzilla bugs r

[PATCH] iwlwifi: mvm: only send LEDS_CMD when the FW supports it

2017-09-07 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The LEDS_CMD command is only supported in some newer FW versions (e.g. iwlwifi-8000C-31.ucode), so we can't send it to older versions (such as iwlwifi-8000C-27.ucode). To fix this, check for a new bit in the FW capabilities TLV that tell

Re: [GIT] Networking

2017-09-06 Thread Luca Coelho
re it still works with version 27. Okay, I found the offending patch: commit 7089ae634c50544b29b31faf1a751e8765c8de3b Author: Johannes Berg <johannes.b...@intel.com> AuthorDate: Wed Jun 28 16:19:49 2017 +0200 Commit: Luca Coelho <luciano.coe...@intel.com> CommitDate: Wed Aug 9

Re: Bug Report for iwlwifi kernel module

2017-09-05 Thread Luca Coelho
On Tue, 2017-09-05 at 09:51 -0700, Carl Myers wrote: > Hi Luca, > > On Mon, Sep 04, 2017 at 10:34:37AM +0300, Luca Coelho wrote: > > Date: Mon, 04 Sep 2017 10:34:37 +0300 > > From: Luca Coelho <l...@coelho.fi> > > To: Carl Myers <cmy...@cmyers.org>, linux-

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-09-04 Thread Luca Coelho
On Mon, 2017-09-04 at 13:43 +0200, Jiri Kosina wrote: > On Thu, 24 Aug 2017, Luca Coelho wrote: > > > > looks like a correct fix to me, so feel free to add > > > > > > Acked-by: Jiri Kosina <jkos...@suse.cz> > > > > > > I'll be

Re: Bug Report for iwlwifi kernel module

2017-09-04 Thread Luca Coelho
Hi Carl, On Sun, 2017-09-03 at 12:15 -0700, Carl Myers wrote: > Greetings all, > > Apologies if any of this is wrong, this is my first attempt to report a bug in > the linux kernel =) > > I got here by running the get_maintainer script on the iwlwifi directory of a > linux kernel checkout. > >

[PATCH] iwlwifi: mvm: initialize status in iwl_mvm_add_int_sta_common()

2017-09-02 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always need to initialize the status argument to the success case before calling iwl_mvm_send_cmd_status() or iwl_mvm_send_cmd_pdu_status() (which calls the former) otherwise we may get an uninitialized value back. In this case,

Re: [PATCH 1/2] iwlwifi: fix long debug print

2017-08-31 Thread Luca Coelho
On Thu, 2017-08-31 at 14:57 -0700, Joe Perches wrote: > On Fri, 2017-08-25 at 11:27 +0300, Luca Coelho wrote: > > From: Liad Kaufman <liad.kauf...@intel.com> > > > > There is a debug print that sometimes reaches over > > 110 chars, thus generating a warnin

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-31 Thread Luca Coelho
On Wed, 2017-08-30 at 17:57 +0300, David Weinehall wrote: > On Tue, Aug 22, 2017 at 10:37:29AM +0300, Luca Coelho wrote: > > From: Luca Coelho <luciano.coe...@intel.com> > > > > Work queues cannot be allocated when a mutex is held because the mutex > > may be in

pull-request: iwlwifi-next 2017-08-30

2017-08-30 Thread Luca Coelho
Hi Kalle, Here's my fourth and final pull-request intended for v4.14.  It contains just a couple of small fixes and a FW API number bump.  More details in the tag description. I have fixed the subject of one of the patches for the typo you reported during review. I have sent this out before,

[PATCH] iwlwifi: mvm: bump API to 34 for 8000 and up

2017-08-30 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> These devices support -34.ucode, so load it. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/8000.c | 4

Re: [PATCH 2/2] iwlwifi: mvm: Avoid deffering non bufferable frames

2017-08-30 Thread Luca Coelho
On Tue, 2017-08-29 at 11:22 +0300, Kalle Valo wrote: > Luca Coelho <l...@coelho.fi> writes: > > > From: David Spinadel <david.spina...@intel.com> > > > > Use bcast station for all non bufferable frames on AP and AD-HOC. > > > > The host is no

[PATCH 0/2] iwlwifi: updates intended for v4.14 2017-08-25

2017-08-25 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, A very tiny set of patches for v4.14. :) Nothing is backlogged in our internal tree anymore and this has been a very slow week due to vacations in our team. These are the changes: * Fix a queue hang problem due to 11w behavior * Fix a w

[PATCH 2/2] iwlwifi: mvm: Avoid deffering non bufferable frames

2017-08-25 Thread Luca Coelho
Fixes: 3e56eadfb6a1 ("iwlwifi: mvm: implement AP/GO uAPSD support") Signed-off-by: David Spinadel <david.spina...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 9 + 1 file changed, 5 insertions(+)

[PATCH 1/2] iwlwifi: fix long debug print

2017-08-25 Thread Luca Coelho
ags require it") Signed-off-by: Liad Kaufman <liad.kauf...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwif

[PATCH] mac80211: Complete ampdu work schedule during session tear down

2017-08-25 Thread Luca Coelho
r the BA session cancellation and properly clean the session. Fixes: 7a7c0a6438b8 ("mac80211: fix TX aggregation start/stop callback race") Signed-off-by: Ilan Peer <ilan.p...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/mac80211/ht.c | 15

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-24 Thread Luca Coelho
On Thu, 2017-08-24 at 21:56 +0200, Jiri Kosina wrote: > On Thu, 24 Aug 2017, Luca Coelho wrote: > > > > Work queues cannot be allocated when a mutex is held because the mutex > > > may be in use and that would make it sleep. Doing so generates the > &g

Re: [PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-24 Thread Luca Coelho
On Tue, 2017-08-22 at 10:37 +0300, Luca Coelho wrote: > From: Luca Coelho <luciano.coe...@intel.com> > > Work queues cannot be allocated when a mutex is held because the mutex > may be in use and that would make it sleep. Doing so generates the > following splat with 4.13

[PATCH v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-22 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Work queues cannot be allocated when a mutex is held because the mutex may be in use and that would make it sleep. Doing so generates the following splat with 4.13+: [ 19.513298] == [ 19.

[PATCH] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

2017-08-22 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Work queues cannot be allocated in when a mutex is held because the mutex may be in use and that would make it sleep. Doing so generates the following splat with 4.13+: [ 19.

pull-request: iwlwifi-next 2017-08-18

2017-08-19 Thread Luca Coelho
mvm: Fix channel switch in case of count <= 1 João Paulo Rechi Vita (1): iwlwifi: Demote messages about fw flags size to info Luca Coelho (12): iwlwifi: mvm: consider RFKILL during INIT as success iwlwifi: call iwl_remove_notification from iwl_wait_notification

Re: Cisco's Wi-Fi Direct Client Policy and iwlwifi (8260)

2017-08-18 Thread Luca Coelho
On Fri, 2017-08-18 at 20:16 +0300, Luca Coelho wrote: > Hi Dariusz, > > On Fri, 2017-08-18 at 14:48 +0200, Dariusz Gadomski wrote: > > Hi, > > > > There is a “Wi-Fi Direct Client Policy” setting in some Cisco AP hardware > > [1]. > > I am unaware how that

Re: Cisco's Wi-Fi Direct Client Policy and iwlwifi (8260)

2017-08-18 Thread Luca Coelho
Hi Dariusz, On Fri, 2017-08-18 at 14:48 +0200, Dariusz Gadomski wrote: > Hi, > > There is a “Wi-Fi Direct Client Policy” setting in some Cisco AP hardware [1]. > I am unaware how that works exactly behind the scenes (except for some hints > at > [2]), but I have noticed that with that setting

[PATCH 22/24] iwlwifi: mvm: remove useless argument in iwl_nvm_init()

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We always call iwl_nvm_init() with read_nvm_from_nic == true, so this argument is useless. Remove it. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 5 +- drivers/net/wireless/i

[PATCH 20/24] iwlwifi: add workaround to disable wide channels in 5GHz

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The OTP in some SKUs have erroneously allowed 40MHz and 80MHz channels in the 5.2GHz band. The firmware has been modified to not allow this in those SKUs, so the driver needs to do the same otherwise the firmware will assert when we try to use i

[PATCH 11/24] iwlwifi: mvm: remove session protection to allow channel switch

2017-08-18 Thread Luca Coelho
Stern <avraham.st...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 3 +- .../net/wireless/intel/iwlwifi/mvm/time-event.c| 34 -- 2 files changed, 33 insertions(+), 4 deletions(-) diff -

[PATCH 23/24] iwlwifi: mvm: remove useless check for mvm->cfg in iwl_parse_nvm_section()

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> At this point we have already copied the cfg pointer to mvm and we have been dereferencing this pointer many times before, so it will never be NULL or we would have crashed. Remove the useless check. Signed-off-by: Luca Coelho <lu

[PATCH 18/24] iwlwifi: update channel flags parser

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There are some new flags in the channel flags that we don't know about. Also, the "WIDE" flag is very confusing, because it actually means 20MHz bandwidth, which is not very wide. Add the new flags and rename the confusing one. Sig

[PATCH 19/24] iwlwifi: mvm: change open and close criteria of a BA session

2017-08-18 Thread Luca Coelho
ter-op issues with some APs. We'll not close a BA session until we receive an explicit del BA from the peer. Signed-off-by: Gregory Greenman <gregory.green...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/constants.h | 1 + dr

[PATCH 24/24] iwlwifi: use big-endian for the hw section of the nvm

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Unlike the other sections of the NVM, the hw section is in big-endian. To read a value from it, we had to cast it to __be16. Fix that by using __be16 * for the entire section. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

[PATCH 13/24] iwlwifi: move BT_MBOX_PRINT macro to common header

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Move the BT_MBOX_PRINT() macro from mvm/debugfs.c to fw/api/coex.h so it can be reused and remove duplicate definition of BT_MBOX_MSG(), keeping only the one already in coex.h. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> ---

[PATCH 21/24] iwlwifi: fw: fix lar_enabled endian problem in iwl_fw_get_nvm

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We read the regulatory.lar_enabled field in iwl_fw_get_nvm() and store it in nvm->lar_enabled, taking care of endianness. But then later we read it again to pass the value to iwl_init_sbands() without handling endianness. To solve this, sim

[PATCH 16/24] iwlwifi: distinguish different RF modules in A000 devices

2017-08-18 Thread Luca Coelho
rmware. Signed-off-by: Tzipi Peres <tzipi.pe...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/cfg/a000.c | 34 ++--- drivers/net/wireless/intel/iwlwifi/iwl-config.h | 4 ++- drivers/net/wireless/intel

[PATCH 15/24] iwlwifi: mvm: Fix channel switch in case of count <= 1

2017-08-18 Thread Luca Coelho
ime after the reception the frame, and for counter == 1 the switch would happens before the next TBTT, schedule the time event immediately. Signed-off-by: Ilan Peer <ilan.p...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

[PATCH 17/24] iwlwifi: pci: add new PCI ID for 7265D

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We have a new PCI subsystem ID for 7265D. Add it to the list. Cc: sta...@vger.kernel.org Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 + 1 file changed, 1 insertion(+)

[PATCH 14/24] iwlwifi: Demote messages about fw flags size to info

2017-08-18 Thread Luca Coelho
ooting the kernel with "quiet". Demoting it to the warn level helps having a clean boot process. Signed-off-by: João Paulo Rechi Vita <jprv...@endlessm.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 12 +++

[PATCH 12/24] iwlwifi: mvm: don't send BAR on flushed frames

2017-08-18 Thread Luca Coelho
<emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi

[PATCH 10/24] iwlwifi: mvm: update the firmware API in TX

2017-08-18 Thread Luca Coelho
mapped reasons. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/tx.h | 9 +++-- drivers/net/wireless/intel/iwlwifi/mvm/tx.c| 2 +- 2 files changed, 4 insertions(+), 7

[PATCH 07/24] iwlwifi: mvm: include more debug data when we get an unexpected baid

2017-08-18 Thread Luca Coelho
manuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c b/drivers/

[PATCH 02/24] iwlwifi: mvm: consider RFKILL during INIT as success

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> There's no need to differentiate an INIT that ended early because of RFKILL from one that succeded. Additionally, if INIT fails later, during calibration, due to RFKILL, we can just return success and continue as if we were already in RFKILL to

[PATCH 05/24] iwlwifi: pcie: support short Tx queues for A000 device family

2017-08-18 Thread Luca Coelho
Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- .../net/wireless/intel/iwlwifi/pcie/ctxt-info.c| 2 +- drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 13 +++ drivers/net/wireless/intel/iwlwifi/pc

[PATCH 06/24] iwlwifi: mvm: add command name for FRAME_RELEASE

2017-08-18 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> This name was missing in the list. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 + 1 file ch

[PATCH 04/24] iwlwifi: mvm: support new Coex firmware API

2017-08-18 Thread Luca Coelho
From: Emmanuel Grumbach <emmanuel.grumb...@intel.com> The firmware now adds more information about time sharing with the Bluetooth core. Adapt the API structures and add the new fields in the debugfs hooks. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

[PATCH 08/24] iwlwifi: mvm: group all dummy SAR function declarations together

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We have some of the SAR dummy functions when ACPI is not set declared in mvm.h and some declared in fw.c. Group them all together in fw.c for consistency and to avoid static/non-static issues. Signed-off-by: Luca Coelho <luciano.coe...@

[PATCH 09/24] iwlwifi: mvm: use mvmsta consistently in rs.c

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> We use mvmsta for the sta->drv_priv in mvm, but in rs.c we have a bunch of instances using sta_priv, which is probably due to it being copied from dvm. Change all occurrences to mvmsta for consistency with the rest of the driver Signed-off

[PATCH 00/24] iwlwifi: updates intended for v4.14 2017-08-18

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Hi, Here's one more set of patches for v4.14. These are the changes: * Work for the upcoming A000 device family continues; * Improvements in debugging; * A couple of improvements in block-ack sessions; * Some fixes for channel switch; * A work

[PATCH 01/24] iwlwifi: mvm: remove the corunning support

2017-08-18 Thread Luca Coelho
er has always been blank. Remove all that code. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- drivers/net/wireless/intel/iwlwifi/fw/api/coex.h | 13 - .../net/wireless/intel/iwlwifi/fw/api/commands.h | 12 - dr

[PATCH 03/24] iwlwifi: call iwl_remove_notification from iwl_wait_notification

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> The iwl_wait_notification() function removes the wait entry from the list. To make it clearer that it's doing the same thing as iwl_remove_notification(), call the latter instead of having duplicate code. Signed-off-by: Luca Coelho <lu

[PATCH 1/2] mac80211: add documentation to ieee80211_rx_ba_offl()

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Add documentation to ieee80211_rx_ba_offl() function and, while at it, rename the bit argument to tid, for consistency. Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- include/net/mac80211.h | 8 +++- net/mac80211/agg-rx.c

[PATCH 2/2] mac80211: flush hw_roc_start work before cancelling the ROC

2017-08-18 Thread Luca Coelho
intel.com> Signed-off-by: Luca Coelho <luciano.coe...@intel.com> --- net/mac80211/offchannel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/mac80211/offchannel.c b/net/mac80211/offchannel.c index f8e7a8bbc618..faf4f6055000 100644 --- a/net/mac80211/offchannel.c +++ b/net/mac

[PATCH 0/2] mac80211 patches from our internal tree 2017-08-18

2017-08-18 Thread Luca Coelho
From: Luca Coelho <luciano.coe...@intel.com> Here are two pending mac80211 patches from our internal tree. Please review. Cheers, Luca. Avraham Stern (1): mac80211: flush hw_roc_start work before cancelling the ROC Luca Coelho (1): mac80211: add documentation to ieee80211_rx_b

[PATCH v4 12/19] nl80211: add an option to allow MFP without requiring it

2017-08-18 Thread Luca Coelho
hether to use it or not. Include a feature bit to advertise support for NL80211_MFP_OPTIONAL. This allows new user space to run on old kernels and know that it cannot use the new attribute if it isn't supported. Signed-off-by: Emmanuel Grumbach <emmanuel.grumb...@intel.com> Signed-off-by:

pull-request: iwlwifi-next 2017-08-11

2017-08-11 Thread Luca Coelho
ode iwlwifi: mvm: use firmware LED command where applicable Liad Kaufman (1): iwlwifi: fix a000 RF_ID define Luca Coelho (2): iwlwifi: fix a few instances of misaligned kerneldoc parameters iwlwifi: remove references to unsupported HW Matt Chen (1): iwlwifi: mvm: don't send C

<    3   4   5   6   7   8   9   10   11   12   >