[PATCH v2] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

the following warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13: error: explicitly assigning value of variable of type 'u32' (aka 'unsigned int') to itself [-Werror,-Wself-assign] writeVal = writeVal; Delete the branch with the self-assignment. Signed-off-by: Matthias Kaehlcke

Re: [PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

El Wed, Feb 07, 2018 at 02:35:59PM -0600 Larry Finger ha dit: > On 02/07/2018 02:26 PM, Matthias Kaehlcke wrote: > > In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal > > is assigned to itself in an if ... else statement, apparently only to > > doc

[PATCH] rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c

the 'handling' of the branch condition. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c b/drivers/net/wi

[PATCH] nl80211: Fix enum type of variable in nl80211_put_sta_rate()

rate_flg is of type 'enum nl80211_attrs', however it is assigned with 'enum nl80211_rate_info' values. Change the type of rate_flg accordingly. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] mac80211: ibss: Fix channel type enum in ieee80211_sta_join_ibss()

) of the channel type enum. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- net/mac80211/ibss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c index 98999d3d5262..e957351976a2 100644 --- a/net/mac80211/ibss.c +++ b/net/mac80211/

[PATCH v2] cfg80211: Fix array-bounds warning in fragment copy

after consume. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Note: Resent to include linux-wireless in cc net/wireless/util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/util.c b/net/wireless/util.c index 68e5f2ecee1a..52795ae5337f

Re: [PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

Hi Joe, El Thu, Apr 06, 2017 at 02:29:20PM -0700 Joe Perches ha dit: > On Thu, 2017-04-06 at 14:21 -0700, Matthias Kaehlcke wrote: > > The macro results are assigned to u8 variables/fields. Adding the cast > > fixes plenty of clang warnings about "implicit conversion f

[PATCH v2] mac80211: Fix clang warning about constant operand in logical operation

builtin strlen function is used. Change the condition to check for strlen() > 0 to make the constant operand boolean and thus avoid the warning. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v2: - Changed expression to strlen() > 0 to make constant operand boole

Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation

El Thu, Apr 06, 2017 at 11:12:25PM +0200 Johannes Berg ha dit: > On Thu, 2017-04-06 at 12:24 -0700, Matthias Kaehlcke wrote: > > > I agree that the code looks worse :( I hoped to find a fix using a > > preprocessor condition but wasn't successful. > > It's act

[PATCH] ath9k: Add cast to u8 to FREQ2FBIN macro

The macro results are assigned to u8 variables/fields. Adding the cast fixes plenty of clang warnings about "implicit conversion from 'int' to 'u8'". Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/net/wireless/ath/ath9k/eeprom.h | 2 +- 1 file changed, 1

Re: [PATCH] mac80211: Fix clang warning about constant operand in logical operation

Hi Johannes, thanks for your comments El Thu, Apr 06, 2017 at 09:11:18PM +0200 Johannes Berg ha dit: > On Thu, 2017-04-06 at 11:56 -0700, Matthias Kaehlcke wrote: > > Clang raises a warning about the expression 'strlen(CONFIG_XXX)' > > being > > used in a logical opera

[PATCH] mac80211: Fix clang warning about constant operand in logical operation

using the const expression in a logical operation. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- net/mac80211/rate.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c index 206698bc93f4..68ff202d6380 100644 ---