[PATCH v3 2/2] ath10k: fix CCK h/w rates for QCA99X0 and newer chipsets

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> CCK hardware table mapping from QCA99X0 onwards got revised. The CCK hardware rate values are in a proper order wrt. to rate and preamble as below ATH10K_HW_RATE_REV2_CCK_LP_1M = 1, ATH10K_HW_RATE_REV2_CCK_LP_

[PATCH v2 2/2] ath10k: fix CCK h/w rates for QCA99X0 and newer chipsets

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> CCK hardware table mapping from QCA99X0 onwards got revised. The CCK hardware rate values are in a proper order wrt. to rate and preamble as below ATH10K_HW_RATE_REV2_CCK_LP_1M = 1, ATH10K_HW_RATE_REV2_CCK_LP_

[PATCH v2 1/2] ath10k: remove duplicate and unused rx rate flags

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> All these flags are not used and their use is completely covered by 'ath10k_hw_rate_ofdm', 'ath10k_hw_rate_cck', and RX_PPDU_START_RATE_FLAG Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Patchwork-Id: 91

[PATCH v3] ath10k: Fix 10.4 extended peer stats update

2016-06-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration f

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-06-01 Thread Mohammed Shafi Shajakhan
On Wed, Jun 01, 2016 at 01:00:40PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan <moham...@codeaurora.org> writes: > > > Hello, > > > > On Tue, May 31, 2016 at 06:57:52PM +, Valo, Kalle wrote: > >> Mohammed Shafi Shajakhan <moham...@cod

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-06-01 Thread Mohammed Shafi Shajakhan
Hello, On Tue, May 31, 2016 at 06:57:52PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan <moham...@codeaurora.org> writes: > > >> > +void ath10k_sta_update_rx_duration(struct ath10k *ar, > >> > +

Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Mohammed Shafi Shajakhan
Hi Kalle, thanks for the review On Tue, May 31, 2016 at 12:18:49PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> writes: > > > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > > 10.4 'extended peer stats'

Re: [PATCH v4] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-05-31 Thread Mohammed Shafi Shajakhan
On Tue, May 31, 2016 at 11:41:08AM +0200, Johannes Berg wrote: > On Thu, 2016-04-07 at 20:00 +0530, Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > > Add support for new netlink attribute 'N

Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-31 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Tue, May 31, 2016 at 11:09:38AM +, Valo, Kalle wrote: > "Shajakhan, Mohammed Shafi (Mohammed Shafi)" > writes: > > seems the change got merged in pending branch > >

Re: [PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-27 Thread Mohammed Shafi Shajakhan
On Fri, May 27, 2016 at 10:12:45AM +0200, Sven Eckelmann wrote: > On Wednesday 11 May 2016 11:54:30 Mohammed Shafi Shajakhan wrote: > > #else > > -static inline void ath10k_sta_update_rx_duration(struct ath10k *ar, > > -s

[PATCH v2] ath10k: Fix 10.4 extended peer stats update

2016-05-27 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration f

[PATCH] ath10k: Fix error while writing 'simulate_fw_crash' debugfs

2016-05-26 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Fix invalid argument error while writing 'simulate_fw_crash', though the funcionality is working fine we get an error 'invalid argument' because 'count' value is not returned properly (no reason to reduce the count value for re

Re: [PATCH 1/2] ath10k: add QCA9887 chipset support

2016-05-23 Thread Mohammed Shafi Shajakhan
On Mon, May 23, 2016 at 11:52:11AM +0530, Mohammed Shafi Shajakhan wrote: > Hi Sven, > > On Fri, May 20, 2016 at 04:41:11PM +0200, Sven Eckelmann wrote: > > Add the hardware name, revision, firmware names and update the pci_id > > table. > > > > QA9887 HW1.0 is

Re: [PATCH 1/2] ath10k: add QCA9887 chipset support

2016-05-23 Thread Mohammed Shafi Shajakhan
Hi Sven, On Fri, May 20, 2016 at 04:41:11PM +0200, Sven Eckelmann wrote: > Add the hardware name, revision, firmware names and update the pci_id > table. > > QA9887 HW1.0 is supposed to be similar to QCA988X HW2.0 . Details about > he firmware interface are currently unknown. > > Signed-off-by:

[PATCH 1/2] ath10k: Remove duplicate and unused rx rate flags

2016-05-20 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> All these flags are not used and their use is completely covered by 'ath10k_hw_rate_ofdm', 'ath10k_hw_rate_cck', and RX_PPDU_START_RATE_FLAG Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- [thanks

[PATCH 2/2] ath10k: Fix CCK h/w rates for QCA99X0 and newer chipsets

2016-05-20 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> CCK hardware table mapping from QCA99X0 onwards got revised. The CCK hardware rate values are in a proper order wrt. to rate and preamble as below ATH10K_HW_RATE_REV2_CCK_LP_1M = 1, ATH10K_HW_RATE_REV2_CCK_LP_

[PATCH] ath10k: Fix legacy rate packet debug messages

2016-05-17 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Legacy rate packets may not necessarily be having a rx status flag of '0' always, for example management frame have flags like RX_FLAG_ONLY_MONITOR / RX_FLAG_MACTIME_END also set Just check 'VHT' and 'HT' flags are not set , and

Re: [PATCH v3 RESEND 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-05-17 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Fri, May 13, 2016 at 03:13:36PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> writes: > > > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > > Enable support for 'drv_sta_statistics' call

[PATCH v1] ath10k: Fix 10.4 extended peer stats update

2016-05-11 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration f

Re: [PATCH] ath10k: Fix 10.4 extended peer stats update

2016-05-10 Thread Mohammed Shafi Shajakhan
On Tue, May 10, 2016 at 09:34:55AM -0700, Ben Greear wrote: > On 05/10/2016 09:27 AM, Mohammed Shafi Shajakhan wrote: > >From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > >10.4 'extended peer stats' will be not be appended with normal peer stats >

Re: [PATCH v2 3/5] ath10k: Add WARN_ON if we over-write peer-map pointer.

2016-05-10 Thread Mohammed Shafi Shajakhan
On Tue, May 10, 2016 at 07:41:44AM -0700, Ben Greear wrote: > > > On 05/10/2016 12:12 AM, Mohammed Shafi Shajakhan wrote: > >Hi Ben, > > > >On Fri, Apr 01, 2016 at 02:12:10PM -0700, gree...@candelatech.com wrote: > >>From: Ben Greear <gree...@candelatech

Re: [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

2016-05-10 Thread Mohammed Shafi Shajakhan
> > > >On Fri, Apr 01, 2016 at 02:12:08PM -0700, gree...@candelatech.com wrote: > >>From: Ben Greear > >> > >>Otherwise, the txrx-compl-task may access some bad memory? > > > >good to mention when this happens, will be helpful ifsome one recreates > >the issue and matches

[PATCH] ath10k: Fix 10.4 extended peer stats update

2016-05-10 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> 10.4 'extended peer stats' will be not be appended with normal peer stats data and they shall be coming in separate chunks. Fix this by maintaining a separate linked list 'extender peer stats' for 10.4 and update rx_duration f

[PATCH] ath10k: Reduce warning messages during rx without proper channel context

2016-05-10 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> WARN_ON_ONCE when we receive packets for self peer when mac80211 had not assigned a proper channel context. This scenario happens in QCA4019 when we start the AP via hostapd in background and start it once again in the background w

Re: [PATCH 15/21] ath10k: support CT firmware flag.

2016-05-10 Thread Mohammed Shafi Shajakhan
Hi Ben, On Mon, May 09, 2016 at 04:11:09PM -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Add placeholder so CT firmware can more easily co-exist with upstream > kernel. [shafi] nitpick: good to provide an expansion in commit log as well, so that if we

Re: [PATCH v2 3/5] ath10k: Add WARN_ON if we over-write peer-map pointer.

2016-05-10 Thread Mohammed Shafi Shajakhan
Hi Ben, On Fri, Apr 01, 2016 at 02:12:10PM -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Not sure this can happen, but seems like a reasonable sanity > check. [shafi] possibly if the peer is removed and the bit is not cleared in the driver ? when the new

Re: [PATCH v2 1/5] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

2016-05-10 Thread Mohammed Shafi Shajakhan
Hi Ben, On Fri, Apr 01, 2016 at 02:12:08PM -0700, gree...@candelatech.com wrote: > From: Ben Greear > > Otherwise, the txrx-compl-task may access some bad memory? good to mention when this happens, will be helpful ifsome one recreates the issue and matches your call

[PATCH v3 RESEND 2/2] ath10k: Remove debugfs support for Per STA total rx duration

2016-05-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> cfg80211/nl80211 interface changes for per STA total rx-duration and very basic 'ath10k_sta_statistics' mac80211 callback is implemented to extend support for per station statistics from the driver. Also provision in 'iw dev

[PATCH v3 RESEND 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-05-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for 'drv_sta_statistics' callback. Export rx_duration support if available to cfg80211/nl80211 This can also act as a placeholder for any new per STA stats support Signed-off-by: Mohammed Shafi Shajakhan

[PATCH] ath10k: Move spectral related structures under ath10k debugfs

2016-04-26 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Spectral related structures are accessed / modified only if ath10k debugfs is enabled, so it makes more sense to move them under ATH10K_DEBUGFS Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- [co

[PATCH] ath10k: fix a typo in ath10k_start()

2016-04-22 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> fix a typo (spelling mistake) in 'ath10k_start' Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH v4] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-04-18 Thread Mohammed Shafi Shajakhan
On Thu, Apr 14, 2016 at 10:59:36AM +0200, Johannes Berg wrote: > On Thu, 2016-04-07 at 19:59 +0530, Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > > Add support for new netlink attribute 'N

[PATCH v4] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-04-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'. 'NL80211_STA_INFO_RX_DURATION' accounts for aggregate PPDU duration in microseconds for all the frames from a peer. Drivers can fill 'rx_duration' field a

[PATCH v4] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-04-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION'. 'NL80211_STA_INFO_RX_DURATION' accounts for aggregate PPDU duration in microseconds for all the frames from a peer. Drivers can fill 'rx_duration' field a

Re: [PATCH] ath10k: Fix return value for btcoex and peer stats debugfs

2016-04-06 Thread Mohammed Shafi Shajakhan
Hello Joe, On Tue, Apr 05, 2016 at 10:28:56AM -0700, Joe Perches wrote: > On Tue, 2016-04-05 at 20:58 +0530, Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > > Return value is incorrect for btcoex and peer stats

[PATCH] ath10k: Fix return value for btcoex and peer stats debugfs

2016-04-05 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Return value is incorrect for btcoex and peer stats debugfs 'write' entries if the user provides a value that matches with the already available debugfs entry, this results in the debugfs entry getting stuck and the operati

Re: [PATCH v3] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-04-05 Thread Mohammed Shafi Shajakhan
Hi Johannes, On Tue, Apr 05, 2016 at 12:04:10PM +0200, Johannes Berg wrote: > Hi, > > The implementation seems fine now, but I think the commit log needs some work. [shafi] thanks for reviewing. > > > Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' > > I think it'd be

[PATCH v3 2/2] ath10k: Remove debugfs support for Per STA total rx duration

2016-03-29 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> cfg80211/nl80211 interface changes for per STA total rx-duration and very basic 'ath10k_sta_statistics' mac80211 callback is implemented to extend support for per station statistics from the driver. Also provision in 'iw dev

[PATCH v3 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-29 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for 'drv_sta_statistics' callback. Export rx_duration support if available to cfg80211/nl80211 This can also act as a placeholder for any new per STA stats support Signed-off-by: Mohammed Shafi Shajakhan

Re: [RFCv2 2/3] ath10k: report per-station tx/rate rates to mac80211

2016-03-24 Thread Mohammed Shafi Shajakhan
On Thu, Mar 24, 2016 at 08:49:12AM +0100, Michal Kazior wrote: > On 24 March 2016 at 08:19, Mohammed Shafi Shajakhan > <moham...@codeaurora.org> wrote: > > Hi Michal, > > > > On Wed, Mar 16, 2016 at 11:17:57AM +0100, Michal Kazior wrote: > >> The rate c

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-24 Thread Mohammed Shafi Shajakhan
Hi Michal / Kalle, > > On Thu, Mar 17, 2016 at 12:35:00PM +0100, Michal Kazior wrote: > > On 17 March 2016 at 12:20, Mohammed Shafi Shajakhan > > <moham...@codeaurora.org> wrote: > > > Hi Michal, > > > > > > On Thu, Mar 17, 2016 at 12:12:31PM

Re: [RFCv2 2/3] ath10k: report per-station tx/rate rates to mac80211

2016-03-24 Thread Mohammed Shafi Shajakhan
Hi Michal, On Wed, Mar 16, 2016 at 11:17:57AM +0100, Michal Kazior wrote: > The rate control is offloaded by firmware so it's > challanging to provide expected throughput value > for given station. > > This approach is naive as it reports last tx rate > used for given station as provided by

Re: [PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4

2016-03-24 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Thu, Mar 24, 2016 at 06:51:18AM +, Valo, Kalle wrote: > "Shajakhan, Mohammed Shafi (Mohammed Shafi)" > writes: > > I will make sure, I will run sparse before sending it for review > >

Re: [PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4

2016-03-23 Thread Mohammed Shafi Shajakhan
Hi Kalle, On Wed, Mar 23, 2016 at 01:00:01PM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> writes: > > > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > > Rx duration support for per station is part of exten

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-19 Thread Mohammed Shafi Shajakhan
Hi Michal, On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote: > On 17 March 2016 at 11:48, Mohammed Shafi Shajakhan > <moham...@qti.qualcomm.com> wrote: > [...] > > +void ath10k_sta_statistics(struct ieee80211_hw *hw, struct ie

[PATCH v1 2/3] ath10k: Introduce Extended Resource Config support for 10.4

2016-03-19 Thread Mohammed Shafi Shajakhan
. Also for clarity send default host platform type as 'WMI_HOST_PLATFORM_HIGH_PERF', though this should not make any difference in functionality Signed-off-by: Raja Mani <rm...@qti.qualcomm.com> Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- drivers/net/wirel

[PATCH] mac80211: Remove unused variable in per STA debugfs struct

2016-03-19 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Remove unused variable in per STA debugfs structure, 'commit 34e895075e21 ("mac80211: allow station add/remove to sleep")' removed the only user of 'add_has_run'. Signed-off-by: Mohammed Shafi Shajakhan <moham.

[PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-19 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for 'drv_sta_statistics' callback. Export rx_duration support if available to cfg80211/nl80211 This can also act as a placeholder for any new per STA stats support Signed-off-by: Mohammed Shafi Shajakhan

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-19 Thread Mohammed Shafi Shajakhan
Hi Michal, thanks for the comments .. On Thu, Mar 17, 2016 at 12:35:00PM +0100, Michal Kazior wrote: > On 17 March 2016 at 12:20, Mohammed Shafi Shajakhan > <moham...@codeaurora.org> wrote: > > Hi Michal, > > > > On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal

[PATCH v1 1/3] ath10k: Enable debugfs provision to enable Peer Stats feature

2016-03-19 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Provide a debugfs entry to enable/ disable Peer Stats feature. Peer Stats feature is for developers/users who are more interested in studying in Rx/Tx stats with multiple clients connected, hence disable this by default. En

Re: [PATCH 2/2] ath10k: Enable parsing per station rx duration for 10.4

2016-03-19 Thread Mohammed Shafi Shajakhan
On Wed, Mar 16, 2016 at 10:22:22AM +, Valo, Kalle wrote: > Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> writes: > > > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > > > Rx duration support for per station is part of extended peer

[PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4

2016-03-18 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Rx duration support for per station is part of extended peer stats, enable provision to parse the same and provide backward compatibility based on the 'stats_id' event Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qua

[PATCH v2 2/2] ath10k: Remove debugfs support for Per STA total rx duration

2016-03-18 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> cfg80211/nl80211 interface changes for per STA total rx-duration and very basic 'ath10k_sta_statistics' mac80211 callback is implemented to extend support for per station statistics from the driver. Also provision in 'iw dev

Re: [PATCH v5] ath10k: Enable debugfs provision to enable Peer Stats feature

2016-03-18 Thread Mohammed Shafi Shajakhan
parsing per station rx duration for 10.4 Please let me know if there are any issues. thanks, shafi On Fri, Feb 26, 2016 at 09:19:30PM +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > Provide a debugfs entry to enable/ dis

[PATCH 0/2] Parsing per station rx duration for 10.4

2016-03-15 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Peer Stats for 10.4 is enabled by Extended Resource Configuration API (based on one of the earlier patch from Raja Mani), and parsing of the same is based also 'stats_id' which also provides backward compatibility with old

[PATCH 1/2] ath10k: Introduce Extended Resource Config support for 10.4

2016-03-15 Thread Mohammed Shafi Shajakhan
. Also for clarity send default host platform type as 'WMI_HOST_PLATFORM_HIGH_PERF', though this should not make any difference in functionality Signed-off-by: Raja Mani <rm...@qti.qualcomm.com> Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- drivers/net/wirel

[PATCH 2/2] ath10k: Enable parsing per station rx duration for 10.4

2016-03-15 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Rx duration support for per station is part of extended peer stats, enable provision to parse the same and provide backward compatibility based on the 'stats_id' event Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qua

Re: [RFC v1] mac80211: Add support for per station rx stats histogram

2016-03-09 Thread Mohammed Shafi Shajakhan
On Wed, Mar 09, 2016 at 06:27:48PM +0100, Johannes Berg wrote: > On Wed, 2016-03-09 at 22:00 +0530, Mohammed Shafi Shajakhan wrote: > >  > > I had started studying(understand) your patch. Please > > let me know if you have already added support for the same > > in usersp

Re: [PATCH v1 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-09 Thread Mohammed Shafi Shajakhan
to v4.5-rc7] > > [if your patch is applied to the wrong git tree, please drop us a note to > > help improving the system] > > > > url: > > https://github.com/0day-ci/linux/commits/Mohammed-Shafi-Shajakhan/ath10k-Add-support-for-ath10k_sta_statistics-support/20160309

Re: [RFC v1] mac80211: Add support for per station rx stats histogram

2016-03-09 Thread Mohammed Shafi Shajakhan
as well, we like to use your changes and possibly add any changes that addresses rx_stats histogram as well I will keep you posted for any other queries/ clarification, thanks ! -shafi On Tue, Mar 08, 2016 at 03:12:50PM +0530, Mohammed Shafi Shajakhan wrote: > Hi Johannes, > > On Tue, Mar

[PATCH v3] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-09 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' This flag will be set when drivers can fill rx_duration (aggregate PPDU duration(usecs) for all the frames from a peer) via 'drv_sta_statistics' callback Als

[PATCH v3] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-03-09 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for parsing per station rx-duration (usecs) via adding support for new netlink attribute NL80211_STA_INFO_RX_DURATION rx_duration is aggregate PPDU duration(usecs) for all the frames frames from a peer . This wi

[PATCH v2] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-03-09 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for parsing per station rx-duration (usecs) via adding support for new netlink attribute NL80211_STA_INFO_RX_DURATION rx_duration is aggregate PPDU duration(usecs) for all the frames frames from a peer . This wi

[PATCH v2] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-09 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' This flag will be set when drivers can fill rx_duration (aggregate PPDU duration(usecs) for all the frames from a peer) via 'drv_sta_statistics' callback Als

Re: [PATCH v2] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-09 Thread Mohammed Shafi Shajakhan
On Wed, Mar 09, 2016 at 12:18:25PM +0100, Johannes Berg wrote: > On Wed, 2016-03-09 at 16:22 +0530, Mohammed Shafi Shajakhan wrote: > >  > > [shafi] ath10k implementation is based on PPDU duration calculation > > and it does not includes any IFS duration. > >

Re: [PATCH v2] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-09 Thread Mohammed Shafi Shajakhan
Hi Johannes, On Wed, Mar 09, 2016 at 10:58:08AM +0100, Johannes Berg wrote: > On Wed, 2016-03-09 at 15:08 +0530, Mohammed Shafi Shajakhan wrote: > > > [shafi] Please suggest if this is ok ? I will be thankful > > if you can suggest a better one if this is not ok >

Re: [PATCH v2] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-09 Thread Mohammed Shafi Shajakhan
On Wed, Mar 09, 2016 at 10:30:03AM +0100, Johannes Berg wrote: > On Wed, 2016-03-09 at 12:50 +0530, Mohammed Shafi Shajakhan wrote: > >  > > + * @rx_duration: approximate total air time(usecs) for all the > > frames from a > > + * connected client > > I don't

[PATCH v2] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-03-08 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for parsing per station rx-duration (usecs) via adding support for new netlink attribute NL80211_STA_INFO_RX_DURATION rx_duration is an approximate total air time(usecs) for all the frames frames from a connected

[PATCH v2] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-08 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' This flag will be set when drivers can fill rx_duration (approximate total air time(usecs) for all the frames from a connected client) via 'drv_sta_statistics' ca

Re: [PATCH v1] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-08 Thread Mohammed Shafi Shajakhan
On Wed, Mar 09, 2016 at 12:09:15PM +0530, Mohammed Shafi Shajakhan wrote: > Hi Johannes, > > On Tue, Mar 08, 2016 at 05:52:23PM +0100, Johannes Berg wrote: > > On Mon, 2016-03-07 at 16:33 +0530, Mohammed Shafi Shajakhan wrote: > > > From: Mohammed Shafi Shajakhan &l

Re: [RFC v1] mac80211: Add support for per station rx stats histogram

2016-03-08 Thread Mohammed Shafi Shajakhan
Hi Johannes, On Tue, Mar 08, 2016 at 09:07:31AM +0100, Johannes Berg wrote: > On Mon, 2016-03-07 at 21:53 +0530, Mohammed Shafi Shajakhan wrote: > >  > > +#define IEEE80211_HT_MCS_NUM 32 > > +#define IEEE80211_VHT_MCS_NUM 10 > > +#define I

Re: [RFC v1] mac80211: Add support for per station rx stats histogram

2016-03-07 Thread Mohammed Shafi Shajakhan
in Openwrt distribution regards, shafi On Mon, Mar 07, 2016 at 09:53:29PM +0530, Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> > > Enable a provision in mac80211 'MAC80211_DEBUG_PER_STA_RX_STATS' > to keep track and dump per station stats.

[RFC] mac80211: Add support for per station rx stats histogram

2016-03-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable a provision in mac80211 'MAC80211_DEBUG_PER_STA_RX_STATS' to keep track and dump per station stats. Dump rx pkts / bytes per {MCS, BW, NSS, GI} per station in histogram format. Rx stats provides a history of the receive

[RFC v1] mac80211: Add support for per station rx stats histogram

2016-03-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable a provision in mac80211 'MAC80211_DEBUG_PER_STA_RX_STATS' to keep track and dump per station stats. Dump rx pkts / bytes per {MCS, BW, NSS, GI} per station in histogram format. Rx stats provides a history of the receive

[PATCH v1] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' This flag will be set when drivers can fill rx_duration (vendor specific total air time(usecs) for data/management frames from the connected clien

[PATCH v1] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-03-07 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for parsing per station rx-duration (usecs) via adding support for new netlink attribute NL80211_STA_INFO_RX_DURATION rx_duration is vendor specific total air time(usecs) for data/management frames from the con

Re: [PATCH] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-05 Thread Mohammed Shafi Shajakhan
+0530, Mohammed Shafi Shajakhan wrote: > Hi johannes, > > On Thu, Mar 03, 2016 at 05:07:51PM +0100, Johannes Berg wrote: > > On Thu, 2016-03-03 at 21:30 +0530, Mohammed Shafi Shajakhan wrote: > > > > > [shafi] This is part of the Per Station statistics requirement, &g

Re: [PATCH] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-03 Thread Mohammed Shafi Shajakhan
Hi johannes, On Thu, Mar 03, 2016 at 05:07:51PM +0100, Johannes Berg wrote: > On Thu, 2016-03-03 at 21:30 +0530, Mohammed Shafi Shajakhan wrote: > > > [shafi] This is part of the Per Station statistics requirement, > > Heh. Whose requirements? :) [shafi] We have this as part

[PATCH 2/2] ath10k: Remove debugfs support for Per STA total rx duration

2016-03-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> cfg80211/nl80211 interface changes for per STA total rx-duration and very basic 'ath10k_sta_statistics' mac80211 callback is implemented to extend support for per station statistics from the driver. Also provision in 'iw dev

[PATCH 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for 'drv_sta_statistics' callback. Export rx_duration support if available to cfg80211/nl80211 This can also act as a placeholder for any new per STA stats support Signed-off-by: Mohammed Shafi Shajakhan

[PATCH] iw: Add support for NL80211_STA_INFO_RX_DURATION netlink attribute

2016-03-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable support for parsing per station rx-duration (usecs) via adding support for new netlink attribute NL80211_STA_INFO_RX_DURATION rx_duration is total air time(usecs) for unicast data/management frames from the connected

[PATCH] cfg80211/nl80211: Add support for NL80211_STA_INFO_RX_DURATION

2016-03-02 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Add support for new netlink attribute 'NL80211_STA_INFO_RX_DURATION' This flag will be set when drivers can fill rx_duration ( approximate total air time(usecs) for unicast data/management frames from the connected clien

[PATCH v5] ath10k: Enable debugfs provision to enable Peer Stats feature

2016-02-26 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Provide a debugfs entry to enable/ disable Peer Stats feature. Peer Stats feature is for developers/users who are more interested in studying in Rx/Tx stats with multiple clients connected, hence disable this by default. En

[PATCH] ath10k: Fix sanity check on enabling btcoex via debugfs

2016-02-22 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> First check for the device state before enabling / disabling btcoex, also return a proper error value. Enabling / disabling btcoex ideally does a f/w + ath10k_core_restart so the checks that are applicable for 'simulate_fw_crash'

[PATCH 1/2] ath10k: Fix updating peer stats rx duration

2016-02-03 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> We are not updating peer stats rx_duration periodically unless the user one polls for fw_stats, this is because we discard the update event since pdev list is empty. Fix this by updating rx duration periodically irrepective of

[PATCH] ath10k: Remove unnecessary amsdu/ampdu assignment in debugfs

2015-11-30 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> The default values of max_num_amsdu / max_num_amdpu is assigned a default value as part of 'ath10k_core_init_firmware_features' Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- drivers/net/wireles

[PATCH v2] ath10k: Fix write permission on few debugfs files

2015-11-24 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Fix write permission for few of the debugfs entries which support write file operations as well. Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/debug.c | 12 ++--

[PATCH] ath10k: Enable AP + STA interface combination support for 10.x

2015-11-21 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Enable AP + STA interface combination support for 10.x and this enables Repeater mode testing (with WDS Repeater combinations as well). Fix indentation as well. Based on the suggestions from Michal and Yanbo Li, thanks to them

Re: [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode

2015-11-20 Thread Mohammed Shafi Shajakhan
Hi Kalle\Yanbo, On Mon, Nov 16, 2015 at 10:57:44PM +0200, Kalle Valo wrote: > "Li, Yanbo" writes: > > >> > +/* The padding bytes's location is different on various > >> > chips */ > >> > +enum ath10k_loc_4addr_pad loc_4addr_pad; > >> >

[PATCH] ath10k: Fix cleanup in ath10k_thermal_unregister

2015-10-08 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> First remove the 'cooling_device#n' syslink created for ath10k and then unregsiter from the thermal subsystem(cooling) Signed-off-by: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> --- drivers/net/wireless/ath/ath1

[PATCH] mac80211: Fix hwflags debugfs file format

2015-10-08 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <moham...@qti.qualcomm.com> Commit 30686bf7f5b3 ("mac80211: convert HW flags to unsigned long bitmap") accidentally removed the newline delimiter from the hwflags debugfs file. Fix this by adding back the newline between the HW flags. Signed-off-by

<    1   2