Re: rtl8821ae dbi read question

On 11/06/2017 08:52 AM, Larry Finger wrote: Your results seem to indicate that aspm, which is support_aspm internally, is not being set to zero. The first executable statement in enable_aspm is     if (!ppsc->support_aspm)     return; That statement should disable the enti

Re: rtl8821ae dbi read question

On 11/05/2017 09:09 PM, Larry Finger wrote: Disabling all of _rtl8821ae_enable_aspm_back_door() may not be wise. We tried that patch as part of debugging. That routine consists of two mdio r/w sequences, and 3 dbi r/w sequences. The third one of the latter is only used for RTL8812AE, thus it

Re: rtl8821ae dbi read question

I also want to note that adding rtl8821ae.aspm=0 to my grub kernel boot command doesn't fix my problem. (I'm building this driver into the kernel, not as a module). My connection dropping problem is fixed only if I comment out the aspm init code in the driver, per this patch: https://patchwor

Re: rtl8821ae dbi read question

On 11/05/2017 11:50 AM, Larry Finger wrote: If you read the commit message for commit b8b8b16352cd, you will find that we do not understand why using a byte read causes failure, but reverting the change so that it is a word read made it function again. The "fix" was found by a user doing bise

rtl8821ae dbi read question

In drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c, we have this function: static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr) { u16 read_addr = addr & 0xfffc; u8 tmp = 0, count = 0, ret = 0; rtl_write_word(rtlpriv, REG_DBI_ADDR, read_addr); rtl_write_byt

[PATCH] rtlwifi: rtl8821ae: Fix typo in variable name

In _rtl8821ae_dbi_write(), wrtie_addr should be write_addr. Signed-off-by: Nik Nyby --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless

[PATCH] b43: Fix typo in function name

This fixes a typo in the "b43_lo_g_maintenance_work" function name. Signed-off-by: Nik Nyby --- drivers/net/wireless/b43/lo.c| 4 ++-- drivers/net/wireless/b43/lo.h| 2 +- drivers/net/wireless/b43/phy_g.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/d

[PATCH] rtlwifi: Trivial: fix typo in comments

This fixes a typo in two comments: "paht" -> "path". Signed-off-by: Nik Nyby --- drivers/net/wireless/rtlwifi/rtl8192de/phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/

[PATCH v2] ath6kl: Trivial: spell "distribution" correctly in a comment.

This fixes two misspellings of "distribution" in a comment. Signed-off-by: Nik Nyby --- drivers/net/wireless/ath/ath6kl/htc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/htc.h b/drivers/net/wireless/ath/ath6kl/htc.h index 14cab1

[PATCH] Trivial: spell "distribution" correctly in a comment.

Signed-off-by: Nik Nyby --- drivers/net/wireless/ath/ath6kl/htc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/htc.h b/drivers/net/wireless/ath/ath6kl/htc.h index 14cab14..112d8a9 100644 --- a/drivers/net/wireless/ath/ath6kl/htc.h +++ b