> Is a new version of this patch hinging only on this? We'd love to have a
> fixed-
> up one :-)
The new version covers the use cases mentioned by Jouni as the OUIs of the
vendor commands
has the format of OUI + type + subtype. For other format of vendor commands,
they will be treated
as
> On Tue, Nov 14, 2017 at 02:39:31PM +0000, Peng Xu wrote:
> > > I'm not even sure why this is necessary anyway though, do we really
> > > think vendors will expect to be able to put vendor IEs inside the
> > > subelements and override the ones outside?
>
>
> Right, not really.
>
> I'm not even sure why this is necessary anyway though, do we really think
> vendors will expect to be able to put vendor IEs inside the subelements and
> override the ones outside?
>
> Is there even any point for the WFA ones? It seems WMM really ought to be
> the
> >
> > It is OUI + type + subTye.
>
> Ah, right, type/subtype.
>
> Still, this is problematic, because there's nothing that says that the vendor
> IE
> must have OUI + type + subtype, the spec only says OUI + vendor specific
> data.
>
> This may be right for the WFA/Microsoft OUI, but not
>
> > + if (tmp_old[0] == WLAN_EID_VENDOR_SPECIFIC) {
> > + if (!memcmp(tmp_old + 2, tmp + 2, 5)) {
> > + /* same vendor ie, copy from new ie
> */
> > + memcpy(pos, tmp, tmp[1] + 2);
>
