Re: [PATCH] ath6kl: mark expected switch fall-throughs

Hello! On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++--- 1 file

Re: [PATCH 08/18] carl9170: prevent bounds-check bypass via speculative execution

Hello! On 1/6/2018 4:10 AM, Dan Williams wrote: Static analysis reports that 'queue' may be a user controlled value that is used as a data dependency to read from the 'ar9170_qmap' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction

Re: [PATCH 09/18] p54: prevent bounds-check bypass via speculative execution

On 1/6/2018 4:10 AM, Dan Williams wrote: Static analysis reports that 'queue' may be a user controlled value that is used as a data dependency to read from the 'priv->qos_params' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction

Re: [PATCH 2/7] ath9k: ahb: Add OF support

Hello! On 3/14/2017 12:05 AM, Alban wrote: Allow registering ath9k AHB devices defined in DT. This just add the compatible strings to allow matching the driver and setting the proper device ID. Signed-off-by: Alban --- drivers/net/wireless/ath/ath9k/ahb.c | 47

Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes

Hello. On 9/30/2016 3:11 PM, Johannes Thumshirn wrote: The call to krealloc() in wsm_buf_reserve() directly assigns the newly returned memory to buf->begin. This is all fine except when krealloc() failes we loose the ability to free the old memory pointed to by Fails. buf->begin. If we

Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template

Hello. On 7/13/2016 2:45 PM, Yaniv Machani wrote: The HT capab info field inside the HT capab IE of the mesh beacon is incorrect (in the case of 20MHz channel width). To fix this driver will check configuration from cfg and will build it accordingly. Signed-off-by: Meirav Kama

Re: [PATCH 1/2] ath10k: remove unused

Hello. On 6/21/2016 2:45 PM, Chaehyun Lim wrote: is not used anymore, so just remove it. s/it/#include/? Signed-off-by: Chaehyun Lim [...] diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h index cc82718..0c55cd9

Re: [PATCH v2 10/15] wcn36xx: Copy all members in config_sta v1 conversion

On 4/4/2016 1:16 AM, Bjorn Andersson wrote: From: Pontus Fuchs When converting to version 1 of the config_sta struct not all members where copied. This fixes the problem of multicast frames Were. not being delivered on an encrypted network. Signed-off-by:

Re: [PATCH v2 09/15] wcn36xx: Parse trigger_ba response properly

Hello. On 4/4/2016 1:16 AM, Bjorn Andersson wrote: From: Pontus Fuchs This message does not follow the canonical format and needs it's own parser. Signed-off-by: Pontus Fuchs Signed-off-by: Bjorn Andersson ---

Re: [PATCH 15/16] wcn36xx: don't pad beacons for mesh

Hello. On 3/29/2016 9:06 AM, Bjorn Andersson wrote: From: Jason Mobarak Patch "wcn36xx: Pad TIM PVM if needed" has caused a regression in mesh scripts/checkpatch.pl now enforces the specific commit citing format, i.e. <12-digit SHA1> (""). beaconing. The field

Re: [PATCH] mac80211: fix memory leak

Hello. On 2/1/2016 12:28 PM, Kalle Valo wrote: On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: Hi Sudip, On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee wrote: On error we jumped to the error label and returned the error code but we missed

Re: [PATCH 2/3] net-iwlegacy: One check less in il_eeprom_init() after error detection

Hello. On 1/1/2016 11:31 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 1 Jan 2016 21:12:29 +0100 This issue was detected by using the Coccinelle software. Adjust a jump target to avoid a check repetition before the function call

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

Hello On 1/2/2016 12:33 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 1 Jan 2016 22:27:20 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "err"

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

Hello. On 12/1/2015 8:41 AM, Brent Taylor wrote: Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, The scripts/checkpatch.pl now enforces certain format of the commit citing. ar->fw is expected to be pointing to memory allocated by vmalloc. If the api1 method (via

Re: [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret

On 10/28/2015 4:35 PM, Sergei Shtylyov wrote: This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly ins

Re: [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret

Hello. On 10/27/2015 10:02 PM, Punit Vara wrote: This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return

Re: [PATCH] net: tso: add support for IPv6

Hello. On 10/25/2015 10:58 PM, Emmanuel Grumbach wrote: Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach

Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

Hello. On 10/22/2015 09:26 PM, Punit Vara wrote: This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Also removed empty line suggested by Sergei

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

On 10/22/2015 09:47 PM, Punit Vara wrote: Remove black line suggested by Sergei Such kind of comments should be under the --- tear line. This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded

Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

On 10/21/2015 10:07 PM, Punit Vara wrote: Remove int ret suggested by kbuild test robot This patch is to the wlcore/acx.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more

Re: [PATCH] net: wireless: rt2x00: statics code style

Hello. On 10/17/2015 11:25 PM, Paul McQuade wrote: Do not initialise statics to 0 or NULL Also use tabs where possible Signed-off-by: Paul McQuade --- drivers/net/wireless/rt2x00/rt61pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

Hello. On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote: This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all the segments will have a truesize of 704 (skb itself) and

Re: [RFC v2 3/3] iwlwifi: mvm: transfer the truesize to the last TSO segment

On 08/19/2015 10:12 PM, Grumbach, Emmanuel wrote: This allows to release the backpressure on the socket only when the last segment is released. Now the truesize looks like this: if the truesize of the original skb is 65420, all the segments will have a truesize of 704 (skb itself) and the last

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

Hello. On 8/5/2015 4:39 PM, Heikki Krogerus wrote: Helper for finding the type based on name. Useful if the type needs to be determined based on device property. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com --- include/linux/rfkill.h | 15 +

Re: [PATCH 2/2] ath10k: core: harmonize error case handling in ath10k_core_start

Hello. On 03/14/2015 11:55 AM, Nicholas Mc Guire wrote: All of the bringup/init functions called in ath10k_core_start return 0 on success and != 0 on failure - ath10k_wmi_wait_for_service_ready and ath10k_wmi_wait_for_unified_ready were adjusted to fit this model and the call sites here fixed

Re: [PATCH v2 1/7] rtlwifi: Remove unused defines from rtl8192cu driver

Hello. You didn't sign off on the patches, so they can't be applied. WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel ar...@broadcom.com Acked-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Acked-by: Kalle Valo kv...@codeaurora.org Signed-off

Re: [PATCH 5/7] net: wireless: wcn36xx: swallow two wcn3620 IND messages

Hello. On 1/18/2015 8:11 AM, Andy Green wrote: WCN3620 can asynchronously send two new kinds of indication message, since we can't handle them just accept them quietly. Signed-off-by: Andy Green andy.gr...@linaro.org --- drivers/net/wireless/ath/wcn36xx/smd.c |6 ++ 1 file

Re: [PATCH] net: wireless: atmel: Remove open-coded and wrong strcasecmp

Hello. On 01/16/2015 04:28 PM, Rasmus Villemoes wrote: The kernel's string library does in fact have strcasecmp, at least since ded220bd8f08. Moreover, this open-coded version is in fact Please also specify that commit's summary line in parens. wrong: If the strings only differ in their

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

Hello. On 1/12/2015 9:41 AM, Fu, Zhonghui wrote: From 8685c3c2746b4275fc808d9db23c364b2f54b52a Mon Sep 17 00:00:00 2001 From: Zhonghui Fu zhonghui...@linux.intel.com Date: Mon, 12 Jan 2015 14:25:46 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation The lines above

Re: [PATCH net-next] mac80211: silent build warnings

Hello. On 1/8/2015 10:04 AM, Ying Xue wrote: Silent the following build warnings: net/mac80211/mlme.c: In function ‘ieee80211_rx_mgmt_beacon’: net/mac80211/mlme.c:1348:3: warning: ‘pwr_level_cisco’ may be used uninitialized in this function [-Wuninitialized] net/mac80211/mlme.c:1315:6:

Re: [PATCH 02/11] rtlwifi: rtl8723be: Improve modinfo output

Hello. On 1/2/2015 7:58 PM, Larry Finger wrote: The description of the power-save variables for this driver is not as clear as for the others. The wording is changed to match the others. Signed-off-by: Larry Finger larry.fin...@lwfinger.net --- drivers/net/wireless/rtlwifi/rtl8723be/sw.c

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

Hello. On 12/31/2014 11:20 AM, Fu, Zhonghui wrote: From e34419970a07bfcd365f9c66bdfa552188a0cd26 Mon Sep 17 00:00:00 2001 From: Zhonghui Fu zhonghui...@linux.intel.com Date: Mon, 29 Dec 2014 21:25:31 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation WiFi chip has 2

Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up

Hello. On 12/30/2014 03:20 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout does not return negative values so the tests for = 0 are not needed and the case differentiation in the error handling path unnecessary. I decided to verify your statement and I saw that it seems wrong.

Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up

On 12/30/2014 09:28 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout does not return negative values so the tests for = 0 are not needed and the case differentiation in the error handling path unnecessary. I decided to verify your statement and I saw that it seems wrong.