Re: [PATCH] mac80211: allow hardware scan to fall back to software

2018-11-09 Thread Siva Rebbagondla
On Fri, Nov 9, 2018 at 4:49 PM Johannes Berg wrote: > > On Fri, 2018-11-09 at 11:48 +0530, Siva Rebbagondla wrote: > > Hi, > > Gentle Remainder..!!!. > > Any update required for this patch?. If not, When can i expect this > > patch to be available in wireless-n

Re: [PATCH] mac80211: allow hardware scan to fall back to software

2018-11-08 Thread Siva Rebbagondla
Hi, Gentle Remainder..!!!. Any update required for this patch?. If not, When can i expect this patch to be available in wireless-next?. Thank you, Siva Rebbagondla On Thu, Oct 18, 2018 at 5:21 PM Siva Rebbagondla wrote: > > On Thu, Oct 18, 2018 at 2:06 PM Johannes Berg > wrote: >

Re: [PATCH] mac80211: allow hardware scan to fall back to software

2018-10-18 Thread Siva Rebbagondla
y letting them fall back to software > scan by returning the special value 1 from the hardware scan method. > Acked-and-Tested-by: Siva Rebbagondla

Re: [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM

2018-09-21 Thread Siva Rebbagondla
On Tue, Sep 11, 2018 at 6:50 PM Siva Rebbagondla wrote: > > On Tue, Sep 11, 2018 at 5:55 PM Johannes Berg > wrote: > > > > [re-adding the previous thread] > > > > > As discussed earlier, please find attached tar ball for driver logs, > > > traces a

Re: [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM

2018-09-11 Thread Siva Rebbagondla
scan we report 4 SSIDs, low prio scan, AP scan, random > scan, minimal scan content ... these are OK, but if there are ever > features that mac80211 *doesn't* support, we'll be in trouble if > somebody tries to use them. > > Hope this helps. If my patch actually works (I obviously haven't tested) > then I can send it to the list with signed-off-by and all. > > johannes Hi Johannes, Thanks for the brief explanation and As you mentioned above, we made the changes w.r.t our module. We will understand, what we missed here and will test with your patch and update you. Regards, Siva Rebbagondla.

Re: [PATCH v3 1/2] mac80211: invoke sw_scan if hw_scan returns EPERM

2018-08-31 Thread Siva Rebbagondla
know why this happens, and that's why you set the > cancel bit? Sure Johannes. I will provide event trace or function graph details for this and send you the updatd patch. Is that fine?. > > So I think the clearer thing to do would be to have a separate bit for > this and check it in the right place. > > johannes Thanks Siva Rebbagondla

Re: [PATCH] Bluetooth: btrsi: fix bt tx timeout issue

2018-08-31 Thread Siva Rebbagondla
On Wed, Aug 29, 2018 at 2:24 PM Siva Rebbagondla wrote: > > From: Sanjay Kumar Konduri > > observed sometimes data is coming with unaligned address from kernel > BT stack. If unaligned address is passed, some data in payload is > stripped when packet is loading to firmware an

[PATCH] Bluetooth: btrsi: fix bt tx timeout issue

2018-08-29 Thread Siva Rebbagondla
device hci0: hci0 command 0x0c03 tx timeout Fixed this by moving the data to aligned address. Signed-off-by: Sanjay Kumar Konduri Signed-off-by: Siva Rebbagondla --- drivers/bluetooth/btrsi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth

[PATCH 2/2] rsi: improve kernel thread handling to fix kernel panic

2018-08-27 Thread Siva Rebbagondla
From: Siva Rebbagondla While running regressions, observed below kernel panic when sdio disconnect called. This is because of, kthread_stop() is taking care of wait_for_completion() by default. When wait_for_completion triggered in kthread_stop and as it was done already, giving kernel panic

[PATCH 1/2] rsi: fix memory alignment issue in ARM32 platforms

2018-08-27 Thread Siva Rebbagondla
From: Siva Rebbagondla During testing in ARM32 platforms, observed below kernel panic, as driver accessing data beyond the allocated memory while submitting URB to USB. Fix: Resolved this by specifying correct length by considering 64 bit alignment. so that, USB bus driver will access only

[PATCH 1/6] rsi: remove redundant device ids

2018-07-16 Thread Siva Rebbagondla
From: Siva Rebbagondla Removing redundant device id's from both usb and sdio idtables, as rsi driver currently supporting only one module(RS9113). Also, replaced ids with specific defines. Signed-off-by: Siva Rebbagondla --- drivers/net/wireless/rsi/rsi_91x_sdio.c | 5 + drivers/net

[PATCH 4/6] rsi: Correct RSI_NEEDED_HEADROOM in mac80211_attach.

2018-07-16 Thread Siva Rebbagondla
Signed-off-by: Siva Rebbagondla --- drivers/net/wireless/rsi/rsi_mgmt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_mgmt.h b/drivers/net/wireless/rsi/rsi_mgmt.h index 1462093..359fbdf 100644 --- a/drivers/net/wireless/rsi/rsi_mgmt.h +++ b/drivers

[PATCH 6/6] rsi: move init_done flag to end of rsi_91x_init().

2018-07-16 Thread Siva Rebbagondla
From: Amol Hanwate common->init_done flag should set after basic initialization. Hence, moving init_done flag at end of rsi_91x_init(). Signed-off-by: Amol Hanwate Signed-off-by: Siva Rebbagondla --- drivers/net/wireless/rsi/rsi_91x_main.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 2/6] rsi: remove redundant flash_content variable

2018-07-16 Thread Siva Rebbagondla
From: Siva Rebbagondla while cleaning up the driver, observed that flash_content pointer is not necessary in rsi_load_firmware(). Instead of this, driver can use 'fw_entry->data' directly.Hence, removed redundant flash_content pointer. Signed-off-by: Siva Rebbagondla --- drivers/net/wirel

[PATCH 0/6] rsi: miscellaneous driver cleanups

2018-07-16 Thread Siva Rebbagondla
From: Siva Rebbagondla This patch set consists some miscellaneous driver cleanups for Redpine wlan driver. Amol Hanwate (3): rsi: Correct RSI_NEEDED_HEADROOM in mac80211_attach. rsi: fill rx_params only once. rsi: move init_done flag to end of rsi_91x_init(). Siva Rebbagondla (3): rsi

[PATCH 3/6] rsi: add firmware support for AP+BT dual mode

2018-07-16 Thread Siva Rebbagondla
From: Siva Rebbagondla Currently, AP mode will work on only WLAN alone firmware. To give support for AP and BT dual mode, adding firmware entry in 'struct ta_metadata'. The firmware entry is based on what coex_mode is used in driver and coex mode '4' for all AP+BT related functionalities. Hence

[PATCH 5/6] rsi: fill rx_params only once.

2018-07-16 Thread Siva Rebbagondla
From: Amol Hanwate rx_params are getting updated two times in driver, which is not required. Hence, removing duplicate updation of rx_params from rsi_prepare_skb(). Signed-off-by: Amol Hanwate Signed-off-by: Siva Rebbagondla --- drivers/net/wireless/rsi/rsi_91x_main.c | 5 - 1 file

[v2 7/7] rsi: advertise 5GHz support based on device capability

2018-04-10 Thread Siva Rebbagondla
From: Amitkumar Karwar <amit.kar...@redpinesignals.com> Currently 5GHz gets advertised even for the device which supports only 2.4Ghz band. This patch fixes the issue Signed-off-by: Amitkumar Karwar <amit.kar...@redpinesignals.com> Signed-off-by: Siva Rebbagondla &l

[v2 5/7] rsi: parse TID from data frame correctly

2018-04-10 Thread Siva Rebbagondla
gnals.com> Signed-off-by: Siva Rebbagondla <siva.rebbagon...@redpinesignals.com> --- drivers/net/wireless/rsi/rsi_91x_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_core.c b/drivers/net/wireless/rsi/rsi_91x_core.c index 3ca468

[v2 6/7] rsi: enable power save by default for coex

2018-04-10 Thread Siva Rebbagondla
From: Amitkumar Karwar <amit.kar...@redpinesignals.com> Power save is by default enabled for WLAN and BT coex mode. Signed-off-by: Amitkumar Karwar <amit.kar...@redpinesignals.com> Signed-off-by: Siva Rebbagondla <siva.rebbagon...@redpinesignals.com> --- driver

[v2 4/7] rsi: increase max supported aggregation subframes

2018-04-10 Thread Siva Rebbagondla
From: Amitkumar Karwar <amit.kar...@redpinesignals.com> Maximum number of supported aggregation subframes has been increased to 8. This is the optimal number for the driver. Signed-off-by: Amitkumar Karwar <amit.kar...@redpinesignals.com> Signed-off-by: Siva Rebbagondla &l

[v2 3/7] rsi: use appropriate interface for power save configuration

2018-04-10 Thread Siva Rebbagondla
;amit.kar...@redpinesignals.com> Signed-off-by: Siva Rebbagondla <siva.rebbagon...@redpinesignals.com> --- drivers/net/wireless/rsi/rsi_91x_mac80211.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/driver

[v2 2/7] rsi: device bootup parameter configuration

2018-04-10 Thread Siva Rebbagondla
From: Amitkumar Karwar <amit.kar...@redpinesignals.com> Some device configuration flags need to be enabled while sending 'bootup params' internal frame to firmware. This patch takes care of it. Signed-off-by: Amitkumar Karwar <amit.kar...@redpinesignals.com> Signed-off-by: Siva

[v2 1/7] rsi: disable fw watchdog timer during reset

2018-04-10 Thread Siva Rebbagondla
From: Amitkumar Karwar <amit.kar...@redpinesignals.com> Firmware's watchdog timer should be disabled as a part of reset sequence. This change fixes a firmware hang issue observed during stress tests. Signed-off-by: Amitkumar Karwar <amit.kar...@redpinesignals.com> Signed-off-by: Siva

[v2 0/7] rsi driver improvements

2018-04-10 Thread Siva Rebbagondla
From: Siva Rebbagondla <siva.rebbagon...@redpinesignals.com> This patch series brings in some improvements in power save, Tx data path etc. Changes in v2: Below patches are split and created smaller incremental patches[Kalle] [08/10] rsi: device disconnect changes

Re: [PATCH] Added wait event for power save request till confirm form firmware is received

2018-04-06 Thread Siva Rebbagondla
On Fri, Apr 6, 2018 at 5:11 PM, Siva Rebbagondla <siva8...@gmail.com> wrote: > From: Sanjay Kumar Konduri <sanjay.kond...@redpinesignals.com> > > Signed-off-by: Sanjay Kumar Konduri <sanjay.kond...@redpinesignals.com> > --- > ubuntu/rsi/rsi_91x_main.c | 1 +

[PATCH] Added wait event for power save request till confirm form firmware is received

2018-04-06 Thread Siva Rebbagondla
From: Sanjay Kumar Konduri Signed-off-by: Sanjay Kumar Konduri --- ubuntu/rsi/rsi_91x_main.c | 1 + ubuntu/rsi/rsi_91x_mgmt.c | 5 + ubuntu/rsi/rsi_main.h | 1 + 3 files changed, 7 insertions(+) diff --git