Re: [v2] rsi: sdio suspend and resume support

2017-09-21 Thread Souptick Joarder
On Thu, Sep 21, 2017 at 6:21 PM, Amitkumar Karwar wrote: > From: Karun Eagalapati > > SDIO suspend and resume handlers are implemented and verified > that device works after suspend/resume cycle. > > Signed-off-by: Karun Eagalapati >

Re: [PATCH] mwifiex: add device specific ioctl handler

2017-09-20 Thread Souptick Joarder
On Wed, Sep 20, 2017 at 12:14 PM, Xinming Hu wrote: > From: Xinming Hu > > Add net_dev ndo_do_ioctl handler, which could be used for > downloading host command by utility in manufactory test > > Signed-off-by: Xinming Hu >

Re: [PATCH v5] rtlwifi: Replace hardcode value with macro

2017-08-03 Thread Souptick Joarder
On Thu, Aug 3, 2017 at 3:48 PM, Kalle Valo <kv...@codeaurora.org> wrote: > Larry Finger <larry.fin...@lwfinger.net> writes: > >> On 08/02/2017 07:29 AM, Souptick Joarder wrote: >>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >>>

[PATCH v5] rtlwifi: Replace hardcode value with macro

2017-08-02 Thread Souptick Joarder
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++--- drivers/net/wireless/realtek/rt

Re: [PATCH v5] rtlwifi: Replace hardcode value with macro

2017-08-02 Thread Souptick Joarder
Please ignore this patch. On Wed, Aug 2, 2017 at 5:50 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval > and hw->max_rate_tries are replaced by macro and removed the comment. > > Signed-off-by: S

[PATCH v5] rtlwifi: Replace hardcode value with macro

2017-08-02 Thread Souptick Joarder
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++--- drivers/net/wireless/realtek/rt

[PATCH v4] rtlwifi: Replace hardcode value with macro

2017-08-02 Thread Souptick Joarder
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++--- drivers/net/wireless/realtek/rt

Re: [PATCH v4] rtlwifi: Replace hardcode value with macro

2017-08-02 Thread Souptick Joarder
Hi Kalle, On Wed, Aug 2, 2017 at 2:51 PM, Kalle Valo <kv...@codeaurora.org> wrote: > Larry Finger <larry.fin...@lwfinger.net> writes: > >> On 07/31/2017 06:14 AM, Souptick Joarder wrote: >>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen

[PATCH v4] rtlwifi: Replace hardcode value with macro

2017-07-31 Thread Souptick Joarder
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/

[PATCH v2] rtlwifi: Fix memory leak when firmware request fails

2017-07-05 Thread Souptick Joarder
This patch will fix memory leak when firmware request fails Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- v2: - Modified patch title drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c | 2 ++ drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 2 ++ drivers/net/wi

Re: [PATCH] rtlwifi: Handle memory free

2017-07-05 Thread Souptick Joarder
On Wed, Jul 5, 2017 at 1:53 AM, Larry Finger <larry.fin...@lwfinger.net> wrote: > On 07/04/2017 02:21 AM, Souptick Joarder wrote: >> >> This patch will fix memory leak when firmware load fails >> >> Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> >

[PATCH] rtlwifi: Fix memory leak when firmware request fails

2017-07-05 Thread Souptick Joarder
This patch will fix memory leak when firmware request fails Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c | 2 ++ drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 2 ++ drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw

Re: [PATCH] rtlwifi: Remove unused dummy function

2017-07-04 Thread Souptick Joarder
Any Comment for this patch ? On Wed, Jun 28, 2017 at 6:02 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > Removing unused dummy function > > Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2

Re: [PATCH] rtlwifi: remove dummy function call

2017-07-04 Thread Souptick Joarder
Hi Larry, On Wed, Jun 28, 2017 at 1:27 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > _rtl92cu_init_usb_aggregation() can be removed as it is dummy one > > Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192

[PATCH] rtlwifi: Handle memory free

2017-07-04 Thread Souptick Joarder
This patch will fix memory leak when firmware load fails Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c | 2 ++ drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 2 ++ drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw

[PATCH v3] rtlwifi: Replace hardcode value with macro

2017-06-30 Thread Souptick Joarder
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++--- drivers/net/wireless/realtek/rtlwifi/base.h | 2

Re: [PATCH v2] rtlwifi: Replace hardcode value with macro

2017-06-28 Thread Souptick Joarder
Hi Kalle, On Wed, Jun 28, 2017 at 9:47 PM, Kalle Valo <kv...@codeaurora.org> wrote: > Souptick Joarder <jrdr.li...@gmail.com> writes: > >> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >> and hw->max_rate_tries are replaced by macro. &

[PATCH] rtlwifi: Remove unused dummy function

2017-06-28 Thread Souptick Joarder
Removing unused dummy function Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 12 drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 3 --- 3

[PATCH] rtlwifi: remove dummy function call

2017-06-28 Thread Souptick Joarder
_rtl92cu_init_usb_aggregation() can be removed as it is dummy one Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c b/d

Re: [PATCH v2] rtlwifi: Replace hardcode value with macro

2017-06-27 Thread Souptick Joarder
Hi Larry, On Thu, Jun 22, 2017 at 7:05 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: > On 06/22/2017 07:00 AM, Souptick Joarder wrote: >> >> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >> and hw->max_rate_tries are replaced by mac

[PATCH v2] rtlwifi: Remove unnecessary conditions

2017-06-22 Thread Souptick Joarder
As wmm_enable is initialized to false, hence the else condition never execute and boundary is assigned with TX_PAGE_BOUNDARY. So the if-else condition can be removed and boundary will be assigned with TX_PAGE_BOUNDARY. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- Changes

Re: [PATCH] rtlwifi: Remove unnecessary conditions

2017-06-22 Thread Souptick Joarder
Hi Julian, On Thu, Jun 22, 2017 at 6:03 PM, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Souptick, > > On Thu, Jun 22, 2017 at 9:16 PM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> As wmm_enable is initialized to false, hence the else condition

[PATCH v2] rtlwifi: Replace hardcode value with macro

2017-06-22 Thread Souptick Joarder
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- Changes in v2: - Signed-off was missing in previous one. drivers/net/wireless/realtek/rtlwif

[PATCH] rtlwifi: Remove unnecessary conditions

2017-06-22 Thread Souptick Joarder
As wmm_enable is initialized to false, hence the else condition never execute and boundary is assigned with TX_PAGE_BOUNDARY. So the if-else condition can be removed and boundary will be assigned with TX_PAGE_BOUNDARY. Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> --- drive

[PATCH] rtlwifi: Replace hardcode value with macro

2017-06-21 Thread Souptick Joarder
In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro. --- drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++--- drivers/net/wireless/realtek/rtlwifi/base.h | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: rtl8712: Free memory and return failure when kmalloc fails

2016-10-20 Thread Souptick Joarder
This patch is added to free memory and return failure when kmalloc fails Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> --- drivers/staging/rtl8712/os_intfs.c | 3 ++- drivers/staging/rtl8712/rtl871x_cmd.c | 5 - drivers/staging/rtl8712/rtl871x_xmit.c | 5 - 3 files c

Re: [PATCH] wl18xx: Handle kfree() in better way when kzalloc fails

2016-10-07 Thread souptick joarder
On Fri, Oct 7, 2016 at 12:36 PM, Johannes Berg <johan...@sipsolutions.net> wrote: > > On Fri, 2016-10-07 at 12:19 +0530, Souptick Joarder wrote: > > This patch is added to handle kfree and return error in a better way > > What's "better" about this? > >

[PATCH] wl18xx: Handle kfree() in better way when kzalloc fails

2016-10-07 Thread Souptick Joarder
This patch is added to handle kfree and return error in a better way if kzalloc fails in wl18xx_scan_send() and wl18xx_scan_sched_scan_config(). Signed-off-by: Souptick joarder <jrdr.li...@gmail.com> --- drivers/net/wireless/ti/wl18xx/scan.c | 20 ++-- 1 file chang

Re: [PATCH] [wl18xx] Fix memory leakage if kzalloc fails

2016-10-06 Thread Souptick Joarder
Hi Julian, On Thu, Oct 6, 2016 at 3:05 PM, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi, > > On Wed, Oct 5, 2016 at 10:50 PM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> This patch is added to properly handle memory leak if kzallo

[PATCH] [wl18xx] Fix memory leakage if kzalloc fails

2016-10-05 Thread Souptick Joarder
This patch is added to properly handle memory leak if kzalloc fails in wl18xx_scan_send() and wl18xx_scan_sched_scan_config() Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> Signed-off-by: Rameshwar Sahu <sahu.rameshwa...@gmail.com> --- drivers/net/wireless/ti/wl18xx

Test mail please ignore

2016-10-05 Thread Souptick Joarder

test mail please ignore

2016-10-05 Thread Souptick Joarder

[PATCH] [wl18xx] Fix memory leakage if kzalloc fails

2016-10-05 Thread Souptick Joarder
This patch is added to properly handle memory leak if kzalloc fails in wl18xx_scan_send() and wl18xx_scan_sched_scan_config() Signed-off-by: Souptick Joarder <jrdr.li...@gmail.com> Signed-off-by: Rameshwar Sahu <sahu.rameshwa...@gmail.com> --- drivers/net/wireless/ti/wl18xx

Re: [PATCH] rt2x00: unterminated strlen of user data

2016-02-17 Thread Souptick Joarder
On Thu, Feb 18, 2016 at 5:49 AM, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Souptick, > > On Thu, Feb 18, 2016 at 12:49 AM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> Hi Julian, >> >> On Wed, Feb 17, 2016 at 5:38 AM, Julian Calaby &

Re: [PATCH] rt2x00: unterminated strlen of user data

2016-02-17 Thread Souptick Joarder
Hi Julian, On Wed, Feb 17, 2016 at 5:38 AM, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Souptick, > > On Tue, Feb 16, 2016 at 5:36 PM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> On Tue, Feb 16, 2016 at 12:34 AM, Alan <gno...@lxorguk.ukuu.or

Re: [PATCH] rt2x00: unterminated strlen of user data

2016-02-15 Thread Souptick Joarder
On Tue, Feb 16, 2016 at 12:34 AM, Alan wrote: > The buffer needs to be zero terminated in case the user data is not. > Otherwise we run off the end of the buffer. > > Signed-off-by: Alan Cox > --- >

Re: [PATCH] rtlwifi: Change long delays to sleeps

2016-02-15 Thread Souptick Joarder
On Tue, Feb 16, 2016 at 3:42 AM, Larry Finger wrote: > Routine rtl_addr_delay() uses delay statements in code that can > sleep. To improve system responsiveness, the various delay statements > are changed. > > In addition, routines rtl_rfreg_delay() and rtl_bb_delay()

Re: [PATCH 3/3] mwifiex: Added missing spaces around brackets

2016-02-15 Thread Souptick Joarder
Looks fine. On Thu, Feb 11, 2016 at 12:17 PM, Ujjal Roy wrote: > This patch fixes the missing spaces issue in coding style. > > Signed-off-by: Ujjal Roy > --- > drivers/net/wireless/marvell/mwifiex/usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Souptick Joarder
On Wed, Dec 30, 2015 at 10:35 PM, Bjorn Andersson <bj...@kryo.se> wrote: > On Wed, Dec 30, 2015 at 8:47 AM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> >> HI Bjorn, >> >> On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson <bj...@kryo.

Re: [PATCH] mac80211: Make addr const in SET_IEEE80211_PERM_ADDR()

2015-12-30 Thread Souptick Joarder
HI Bjorn, On Thu, Dec 24, 2015 at 2:03 PM, Bjorn Andersson wrote: > Make the addr parameter const in SET_IEEE80211_PERM_ADDR() to save > clients from having to cast away a const qualifier. > > Signed-off-by: Bjorn Andersson > --- >

Re: [PATCH v2 1/2] staging: wilc1000: fix always return 0 error

2015-12-30 Thread Souptick Joarder
HI Glen, On Thu, Dec 24, 2015 at 11:32 AM, Glen Lee wrote: > This patch fixes a bug that return always 0 so it fails every time. > > Fixes: c1af9db78950 ("staging: wilc1000: call linux_sdio_init instead of > io_init") > Signed-off-by: Glen Lee > --- >

Re: [PATCH 17/20] staging: wilc1000: fix return type of host_int_get_ipaddress

2015-12-30 Thread Souptick Joarder
Hi Lim, On Wed, Dec 30, 2015 at 5:45 PM, Chaehyun Lim wrote: > This patch changes return type of host_int_get_ipaddress from s32 to > int. The result variable gets return value from wilc_mq_send that has > data type of int. It should be changed return type of this

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-29 Thread Souptick Joarder
Brent, On Tue, Dec 22, 2015 at 2:42 PM, Kalle Valo <kv...@qca.qualcomm.com> wrote: > Souptick Joarder <jrdr.li...@gmail.com> writes: > >> Hi Brent, >> >> On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor <moto...@gmail.com> wrote: >>> On Mon,

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-22 Thread Souptick Joarder
Hi Brent, On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor <moto...@gmail.com> wrote: > On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder <jrdr.li...@gmail.com> > wrote: >> Hi Brent, >> >> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor <mot

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Souptick Joarder
Hi Brent, On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: > Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to > be pointing to memory allocated by vmalloc. If the api1 method (via > ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw,

Re: [RFC/RFT 2/2] ath9k: request aligned skb

2015-12-21 Thread Souptick Joarder
On Thu, Dec 17, 2015 at 2:50 PM, Janusz Dziedzic wrote: > > Set NEEDS_ALIGNED4_SKB hw flag. > This allow driver to save CPU and remove two memmove > from tx path. > > Signed-off-by: Janusz Dziedzic > --- >

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Souptick Joarder
On Mon, Dec 21, 2015 at 10:17 PM, Nicholas Mc Guire wrote: > This is an API consolidation only. The use of kmalloc + memset to 0 > is equivalent to kzalloc. > > Signed-off-by: Nicholas Mc Guire > --- > > Found by coccinelle script (relaxed version of >