[PATCH v2] rsi: Remove stack VLA usage

(and re-initialization) so this overhead should not degrade performance. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- This applies onto tip of wireless-drivers next, commit (28bf8312a983 mwifiex: get_channel from firmware v2: - Use k

Re: [RESEND] rsi: Remove stack VLA usage

On Wed, Mar 14, 2018 at 11:19:53AM +0200, Kalle Valo wrote: > "Tobin C. Harding" <m...@tobin.cc> writes: > > > Added Konstantin in case he is in charge of administering > > patchwork.kernel.org? > > > > On Tue, Mar 13, 2018 at 07:53:34PM -0700, Kees

Re: [RESEND] rsi: Remove stack VLA usage

Added Konstantin in case he is in charge of administering patchwork.kernel.org? On Tue, Mar 13, 2018 at 07:53:34PM -0700, Kees Cook wrote: > On Tue, Mar 13, 2018 at 7:11 PM, Tobin C. Harding <m...@tobin.cc> wrote: > > On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wro

Re: [RESEND] rsi: Remove stack VLA usage

On Tue, Mar 13, 2018 at 11:00:47PM +0200, Andy Shevchenko wrote: > On Tue, Mar 13, 2018 at 10:17 PM, tcharding wrote: > > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: > >> tcharding wrote: > > I'm pretty much sure it depends on the original email

Re: [RESEND PATCH] rsi: Remove stack VLA usage

On Sun, Mar 11, 2018 at 09:06:10PM -0500, Larry Finger wrote: > On 03/11/2018 08:43 PM, Tobin C. Harding wrote: > >The kernel would like to have all stack VLA usage removed[1]. rsi uses > >a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > >is defined

[RESEND PATCH] rsi: Remove stack VLA usage

the array in case of programmer error. [1]: https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- RESEND: add wireless mailing list to CC's (requested by Kalle) drivers/net/wireless/rsi/rsi_91x_hal.c | 13 +++-- drivers/net/wireless/rsi/rsi_91x_sdio.

Re: [PATCH 00/18] use ARRAY_SIZE macro

On Sun, Oct 01, 2017 at 03:30:38PM -0400, Jérémy Lefaure wrote: > Hi everyone, > Using ARRAY_SIZE improves the code readability. I used coccinelle (I > made a change to the array_size.cocci file [1]) to find several places > where ARRAY_SIZE could be used instead of other macros or sizeof >

Re: cfg80211_ops

On Wed, Jun 21, 2017 at 05:53:13PM -0700, Igor Mitsyanko wrote: > On 06/21/2017 05:03 PM, Tobin C. Harding wrote: > > > >Hi, > > > >Is some one able to please confirm for me that the following > >cfg80211_ops callbacks are enough to implement a minimal fu

cfg80211_ops

Hi, Is some one able to please confirm for me that the following cfg80211_ops callbacks are enough to implement a minimal functioning Wi-Fi driver. Assume that a virtual interface is added during driver initialization. scan add_key get_key del_key sat_default_key connect disconnect

Re: ks7010 firmware upload fail

On Mon, Jun 05, 2017 at 08:07:40PM -0400, Brian Masney wrote: > On Mon, Jun 05, 2017 at 08:24:44PM +1000, Tobin C. Harding wrote: > > On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote: > > > Tobin, > > > > > > > My question is should I be diggin

Re: ks7010 firmware upload fail

On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote: > Tobin, > > > My question is should I be digging further into the MMC code or be doing > > something else with the driver code? > > So, you haven't found any branch that worked? No plain v4.9 or the > gen3-sdio branch from my tree?

ks7010 firmware upload fail

Hi, I am attempting to test the ks7010 SIDO Wi-Fi driver (drivers/staging/ks7010/). Currently probing the driver fails because of a firmware upload error. I am seeking ideas on where to continue troubleshooting this issue. Test setup: - Spectec SDW-823 WIFI card (micro SD). - Raspberry Pi B 1

Re: [RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

On Thu, Jun 01, 2017 at 12:46:30PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:08PM +1000, Tobin C. Harding wrote: > > Driver ks7010 does not currently have a maintainer. > > > > Add maintainers entry for ks7010. > > > > Signed-off-by

Re: [RFC 1/3] staging: ks7010: move WEXT files to sub directory

On Thu, Jun 01, 2017 at 12:45:37PM +0900, Greg KH wrote: > On Thu, Jun 01, 2017 at 01:27:06PM +1000, Tobin C. Harding wrote: > > Current driver implements the WEXT interface. WEXT is in maintenance > > mode, we need to re-write the driver using cfg80211. The current >

[RFC 0/3] staging: ks7010: cfg80211 conversion, add FIL

for taking the time to read this and thank you in advance for any time that you spend on this RFC. All feedback very much appreciated. Regards, Tobin. Tobin C. Harding (3): staging: ks7010: move WEXT files to sub directory staging: ks7010: Add cfg80211 files MAINTAINERS: add maintainer entry

[RFC 3/3] MAINTAINERS: add maintainer entry for ks7010

Driver ks7010 does not currently have a maintainer. Add maintainers entry for ks7010. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e98464..75250ee 100644 --- a/MAINTAINERS

[RFC 2/3] staging: ks7010: add cfg80211 files

for most of the rest of the driver at the same time. Add cfg80211 driver skeleton. Implement FIL. Signed-off-by: Tobin C. Harding <m...@tobin.cc> --- drivers/staging/ks7010/Makefile|6 + drivers/staging/ks7010/README.rst | 73 ++ drivers/staging/ks7010/TODO.rst| 17 + d

Re: WPA and WPA2

On Thu, May 25, 2017 at 12:45:53PM -0500, Dan Williams wrote: > On Thu, 2017-05-25 at 08:40 +1000, Tobin C. Harding wrote: > > On Wed, May 24, 2017 at 08:06:40PM +0200, Johannes Berg wrote: > > > Just a small correction: > > > > > > On Wed, 2017-05-2

drivers/staging/ks7010 hardware test

Hi Wolfram, I began testing the card you sent today. I'm getting a firmware load error like you mentioned. I checked out code from when you originally merged into staging, however I built the module in a 4.9 kernel. To help me track down the issue could you please tell me what testing you

Re: WPA and WPA2

On Wed, May 24, 2017 at 11:44:00AM -0500, Dan Williams wrote: > On Wed, 2017-05-24 at 17:34 +1000, Tobin C. Harding wrote: > > On Wed, May 24, 2017 at 05:27:50PM +1000, Tobin C. Harding wrote: > > > Hi, > > > > > > I am attempting to rewrite the ks7010 WEXT

Re: WPA and WPA2

On Wed, May 24, 2017 at 08:06:40PM +0200, Johannes Berg wrote: > Just a small correction: > > On Wed, 2017-05-24 at 11:44 -0500, Dan Williams wrote: > > > > For RSN, they are 1 = PMK, 2 = GMK, 3 = GMK2, 4 seems unused. > > PTK and GTK, and in theory you could have more than two GTKs but that's

Re: WPA and WPA2

On Wed, May 24, 2017 at 09:40:51AM +0200, Johannes Berg wrote: > On Wed, 2017-05-24 at 17:27 +1000, Tobin C. Harding wrote: > > > I am attempting to rewrite the ks7010 WEXT driver > > (drivers/staging/ks7010) to use the CFG80211 API. > > Heh, I wasn't even aware of

Re: WPA and WPA2

On Wed, May 24, 2017 at 05:27:50PM +1000, Tobin C. Harding wrote: > Hi, > > I am attempting to rewrite the ks7010 WEXT driver (drivers/staging/ks7010) > to use the CFG80211 API. > > I am reading 802.11 Wireless Networks - Matthew S. Gast for reference. > > I have some

WPA and WPA2

Hi, I am attempting to rewrite the ks7010 WEXT driver (drivers/staging/ks7010) to use the CFG80211 API. I am reading 802.11 Wireless Networks - Matthew S. Gast for reference. I have some confusion regarding WEP/WPA/WPA2/RSN, ciphers, keys and ie's? As I understand, first there was WEP. Next we

Re: ks7010 endianness question

On Wed, Apr 19, 2017 at 01:34:46PM +1000, Tobin C. Harding wrote: > Hi Wolfram, > > May I please ask you with an ks7010 driver endianness question? > > Comments on the hostif_hdr data structure (ks_hostif.h) state that the > target uses little endian byte order. > > /

ks7010 endianness question

Hi Wolfram, May I please ask you with an ks7010 driver endianness question? Comments on the hostif_hdr data structure (ks_hostif.h) state that the target uses little endian byte order. /* * HOST-MAC I/F data structure * Byte alignmet Little Endian */ struct hostif_hdr { u16 size;

Re: [PATCH RFC] remove custom Michael MIC implementation

On Tue, Apr 04, 2017 at 11:31:14PM +0200, Arend Van Spriel wrote: > >> On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > >>> "Tobin C. Harding" <m...@tobin.cc> writes: > >>> > >>>> Except one: do you know off the top of your hea

Re: [PATCH RFC] remove custom Michael MIC implementation

On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: > seems we are missing out again? Sorry, I don't understand what this comment means? > On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > > "Tobin C. Harding" <m...@tobin.cc> writes: > > > &

Re: [PATCH RFC] remove custom Michael MIC implementation

On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote: > + linux-wireless > > "Tobin C. Harding" <m...@tobin.cc> writes: > > > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > >> > >> > The code is untested, I have ha