Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-05-24 Thread Chris Bainbridge
On Mon, May 23, 2016 at 04:42:16PM +0200, Lukas Wunner wrote: > > The reason why my previous patches didn't work on your machine is > because you're using grub, and grub contains a patch by Matthew > Garrett which puts the wireless card into power state D3hot. The > card's mmio space isn't accessi

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-05-23 Thread Lukas Wunner
Hi Andrew, On Sun, Apr 24, 2016 at 07:04:23PM +0200, Lukas Wunner wrote: > On Thu, Apr 14, 2016 at 06:42:50AM +1000, Andrew Worsley wrote: > > The only time I am getting the IRQ 17 nobody cared message is on > > suspend / resume. A fresh boot always had below the 100k interrupt > > threshold level

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-24 Thread Lukas Wunner
Hi Andrew, On Thu, Apr 14, 2016 at 06:42:50AM +1000, Andrew Worsley wrote: > The only time I am getting the IRQ 17 nobody cared message is on > suspend / resume. A fresh boot always had below the 100k interrupt > threshold level. > > I tried your new patch and the number is even lower < 30,000 ov

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-24 Thread Lukas Wunner
Hi, On Sat, Apr 09, 2016 at 01:00:55PM +0100, Matt Fleming wrote: > On Wed, 06 Apr, at 11:30:29PM, Lukas Wunner wrote: > > (2) Find out exactly which EFI boot services area is used for DMA and > > amend arch/x86/platform/efi/quirks.c:efi_apply_memmap_quirks() to > > assign that area a diff

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-13 Thread Andrew Worsley
Thank-you very much for your comments in your reply. Actually the patch did work - I confirmed it was run and the iomap call was successful by adding a pr_info() after the pci_iomap() success branch. The only time I am getting the IRQ 17 nobody cared message is on suspend / resume. A fresh boot a

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-12 Thread Lukas Wunner
wireless card, so theoretically yes, but the right place to fix this is in the kernel since not everyone is using grub. Best regards, Lukas -- >8 -- Subject: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm on b

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-10 Thread Andrew Worsley
Further testing Broadcom 4331 reset quirk to prevent IRQ storm patch testing reveals that: 1. quirk is run on initial boot up and this time appears to have vastly reduced the interrupts (only 81 this time): cat /proc/interrupts| grep 17 17: 81 0 0 0 0

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-09 Thread Matt Fleming
On Wed, 06 Apr, at 11:30:29PM, Lukas Wunner wrote: > > More specifically, arch/x86/platform/efi/quirks.c:efi_free_boot_services() > makes EFI boot services memory available to the page allocator and this > is called near the end of init/main.c:start_kernel(). *Afterwards*, the > initcalls are exec

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-07 Thread Andrew Worsley
Sorry but testing the patch shows no difference. I have just compiled debian jessie kernel 3.16.7-ckt25 and booted it and hibernated it twice, then did the same with your patch applied. There appeared to be no difference On first boot I didn't get the nobody card disabling problem but after each

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-06 Thread Matthew Garrett
On Wed, Apr 06, 2016 at 11:30:29PM +0200, Lukas Wunner wrote: > Matthew's grub patch puts the wireless card into D3hot, which does not > stop the interrupts. I have tested this. (It may stop the DMA, I cannot > verify that as it doesn't occur on my machine for lack of an access point.) Ah, intere

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-06 Thread Lukas Wunner
Hi, On Wed, Apr 06, 2016 at 05:17:24PM +0200, Michael Büsch wrote: > On Wed, 6 Apr 2016 08:31:51 -0500 Bjorn Helgaas wrote: > > > Even for interrupts, it's only a 90% solution because we do still get > > a few interrupts before the quirk runs. There may not be enough to > > trigger the "IRQ nobo

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-06 Thread Lukas Wunner
[+cc Matt Fleming, linux-efi] Hi Bjorn, On Tue, Apr 05, 2016 at 02:40:15PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 29, 2016 at 08:20:30PM +0200, Lukas Wunner wrote: > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > > on boot until they are reset, causing spurious int

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-06 Thread Michael Büsch
On Wed, 6 Apr 2016 08:31:51 -0500 Bjorn Helgaas wrote: > Even for interrupts, it's only a 90% solution because we do still get > a few interrupts before the quirk runs. There may not be enough to > trigger the "IRQ nobody cared" check, If no driver requested the shared interrupt yet, it should

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-06 Thread Bjorn Helgaas
On Tue, Apr 05, 2016 at 09:49:45PM +0200, Michael Büsch wrote: > On Tue, 5 Apr 2016 14:40:15 -0500 > Bjorn Helgaas wrote: > > > [+cc Matthew] > > > > Hi Lukas, > > > > On Tue, Mar 29, 2016 at 08:20:30PM +0200, Lukas Wunner wrote: > > > Broadcom 4331 wireless cards built into Apple Macs unleash

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-06 Thread Andrew Worsley
That patch appears to be the grub 1 equivalent to grub2 git://git.savannah.gnu.org/grub.git rev 9d34bb8 which puts the network device into D3 power state. I am running grub2 with that patch and it doesn't fix my irq 17 problem. Can we not fix this in grub2 via something like Lukas original patc

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-05 Thread Matthew Garrett
On Tue, Apr 05, 2016 at 02:40:15PM -0500, Bjorn Helgaas wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=111781 and > https://mjg59.dreamwidth.org/11235.html describe a sort of similar > issue, but with DMA. An interrupt from the device is probably to > signal a DMA completion, but these prob

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-05 Thread Michael Büsch
On Tue, 5 Apr 2016 14:40:15 -0500 Bjorn Helgaas wrote: > [+cc Matthew] > > Hi Lukas, > > On Tue, Mar 29, 2016 at 08:20:30PM +0200, Lukas Wunner wrote: > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > > on boot until they are reset, causing spurious interrupts if the

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-05 Thread Bjorn Helgaas
[+cc Matthew] Hi Lukas, On Tue, Mar 29, 2016 at 08:20:30PM +0200, Lukas Wunner wrote: > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > on boot until they are reset, causing spurious interrupts if the IRQ is > shared. Apparently the EFI bootloader enables the device and

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-03 Thread Lukas Wunner
Hi Andrew, On Sat, Apr 02, 2016 at 10:40:41PM +1100, Andrew Worsley wrote: > On 30 March 2016 at 04:41, Lukas Wunner wrote: > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > > on boot until they are reset, causing spurious interrupts if the IRQ is > > shared. Apparentl

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-02 Thread Michael Büsch
On Sat, 2 Apr 2016 00:46:46 +0200 Lukas Wunner wrote: > Hi Chris, > > On Fri, Apr 01, 2016 at 12:13:46AM +0100, Chris Bainbridge wrote: > > On Tue, Mar 29, 2016 at 07:41:30PM +0200, Lukas Wunner wrote: > > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > > > on boot

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-04-01 Thread Lukas Wunner
Hi Chris, On Fri, Apr 01, 2016 at 12:13:46AM +0100, Chris Bainbridge wrote: > On Tue, Mar 29, 2016 at 07:41:30PM +0200, Lukas Wunner wrote: > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > > on boot until they are reset, causing spurious interrupts if the IRQ is > > sh

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-31 Thread Michael Büsch
On Fri, 1 Apr 2016 00:13:46 +0100 Chris Bainbridge wrote: > Should also fix https://bugzilla.kernel.org/show_bug.cgi?id=111781 ? > Given that this is a serious bug that can corrupt filesystems it would > be good to see the fix in stable too. Wow, this is horrible. This patch should help a bit.

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-31 Thread Chris Bainbridge
On Tue, Mar 29, 2016 at 07:41:30PM +0200, Lukas Wunner wrote: > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > on boot until they are reset, causing spurious interrupts if the IRQ is > shared. Apparently the EFI bootloader enables the device and does not > disable it befo

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-31 Thread Michael Büsch
On Tue, 29 Mar 2016 19:41:30 +0200 Lukas Wunner wrote: > +static void quirk_apple_b43_reset(struct pci_dev *dev) > +{ > + void __iomem *mmio; > + > + if (!dmi_match(DMI_BOARD_VENDOR, "Apple Inc.") || !dev->bus->self || > + pci_pcie_type(dev->bus->self) != PCI_EXP_TYPE_ROOT_PORT) >

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-31 Thread Rafał Miłecki
On 29 March 2016 at 20:20, Lukas Wunner wrote: > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > on boot until they are reset, causing spurious interrupts if the IRQ is > shared. Apparently the EFI bootloader enables the device and does not > disable it before passing con

[PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-29 Thread Lukas Wunner
Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm on boot until they are reset, causing spurious interrupts if the IRQ is shared. Apparently the EFI bootloader enables the device and does not disable it before passing control to the OS. The bootloader contains a driver for the

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

2016-03-29 Thread Lukas Wunner
Dear bcma maintainers, I'm moving BCMA_CORE_SIZE from drivers/bcma/bcma_private.h to include/linux/bcma/bcma.h in the patch included below to be able to use it in drivers/pci/quirks.c. If you are okay with this change and have no other objections then please kindly ack the patch for merging via t