Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-27 Thread Kalle Valo
Steve deRosier writes: > It's useful to permit the customization of the debug uart baud rate. Enable > this and send down the value to the chip if we're enabling debug. > > Signed-off-by: Steve deRosier Applied, thanks. -- Kalle Valo -- To

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-19 Thread Valo, Kalle
Steve deRosier writes: > On Sun, Apr 17, 2016 at 5:07 PM, Julian Calaby > wrote: >> Hi Steve, >> >> This looks like it's using standard serial rates. Does it accept >> non-standard rates? If not, should this be checked before being passed >> to the

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-18 Thread Julian Calaby
Hi Steve, On Tue, Apr 19, 2016 at 1:06 PM, Steve deRosier wrote: > Hi Julian, > > First off, let me say I do appreciate your comments and I do > understand your perspective. I also generally prefer not to let users > shoot-themselves in the foot if it's avoidable. > > In this

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-18 Thread Steve deRosier
Hi Julian, First off, let me say I do appreciate your comments and I do understand your perspective. I also generally prefer not to let users shoot-themselves in the foot if it's avoidable. In this case, however, I don't happen to agree with you. For one specific reason: I don't want to say what

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-18 Thread Julian Calaby
Hi Steve, On Tue, Apr 19, 2016 at 4:12 AM, Steve deRosier wrote: > Hi Julian, > > Thanks for looking at the patch. > > On Sun, Apr 17, 2016 at 5:07 PM, Julian Calaby > wrote: >> Hi Steve, >> >> This looks like it's using standard serial rates. Does

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-18 Thread Steve deRosier
Hi Julian, Thanks for looking at the patch. On Sun, Apr 17, 2016 at 5:07 PM, Julian Calaby wrote: > Hi Steve, > > This looks like it's using standard serial rates. Does it accept > non-standard rates? If not, should this be checked before being passed > to the hardware?

Re: [PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-17 Thread Julian Calaby
Hi Steve, On Sat, Apr 16, 2016 at 10:19 AM, Steve deRosier wrote: > It's useful to permit the customization of the debug uart baud rate. Enable > this and send down the value to the chip if we're enabling debug. > > Signed-off-by: Steve deRosier

[PATCH] ath6kl: Add ability to set debug uart baud rate

2016-04-15 Thread Steve deRosier
It's useful to permit the customization of the debug uart baud rate. Enable this and send down the value to the chip if we're enabling debug. Signed-off-by: Steve deRosier --- drivers/net/wireless/ath/ath6kl/core.c | 3 +++ drivers/net/wireless/ath/ath6kl/core.h |