Re: Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-15 Thread Simon Wunderlich
Hey Kalle, On Thursday 15 January 2015 16:30:51 Kalle Valo wrote: > Simon Wunderlich writes: > >> I did not dig how the hw->conf.radar_enabled flag is set in monitor mode, > >> but if it is same as for master (i.e. set for DFS channels), then it > >> would > >> be a better approach to prevent cal

Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-15 Thread Kalle Valo
Simon Wunderlich writes: >> I did not dig how the hw->conf.radar_enabled flag is set in monitor mode, >> but if it is same as for master (i.e. set for DFS channels), then it would >> be a better approach to prevent calling ath9k_dfs_process_phyerr() >> altogether from ath9k_rx_skb_preprocess() if

Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-13 Thread Zefir Kurtisi
On 01/13/2015 12:04 PM, Simon Wunderlich wrote: > On Tuesday 13 January 2015 11:16:02 Zefir Kurtisi wrote: >> [...] >> >> I did not dig how the hw->conf.radar_enabled flag is set in monitor mode, >> but if it is same as for master (i.e. set for DFS channels), then it would >> be a better approach t

Re: Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-13 Thread Simon Wunderlich
On Tuesday 13 January 2015 11:16:02 Zefir Kurtisi wrote: > On 01/10/2015 05:26 PM, Simon Wunderlich wrote: > > On Friday 09 January 2015 19:57:37 Arend van Spriel wrote: > >> On 01/09/15 17:54, Simon Wunderlich wrote: > >>> Performing spectral scans on 5 GHz channels may result in PHY errors > >>>

Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-13 Thread Zefir Kurtisi
On 01/10/2015 05:26 PM, Simon Wunderlich wrote: > On Friday 09 January 2015 19:57:37 Arend van Spriel wrote: >> On 01/09/15 17:54, Simon Wunderlich wrote: >>> Performing spectral scans on 5 GHz channels may result in PHY errors >>> sent by the hardware, even if DFS support is not enabled in the dri

Re: Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-10 Thread Simon Wunderlich
On Friday 09 January 2015 19:57:37 Arend van Spriel wrote: > On 01/09/15 17:54, Simon Wunderlich wrote: > > Performing spectral scans on 5 GHz channels may result in PHY errors > > sent by the hardware, even if DFS support is not enabled in the driver > > (e.g. channel scanning or passive monitorin

Re: [PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-09 Thread Arend van Spriel
On 01/09/15 17:54, Simon Wunderlich wrote: Performing spectral scans on 5 GHz channels may result in PHY errors sent by the hardware, even if DFS support is not enabled in the driver (e.g. channel scanning or passive monitoring). In that case channels may falsely get marked as 'unusable'. To fix

[PATCH] ath9k: ignore radar PHY errors when DFS is not enabled

2015-01-09 Thread Simon Wunderlich
Performing spectral scans on 5 GHz channels may result in PHY errors sent by the hardware, even if DFS support is not enabled in the driver (e.g. channel scanning or passive monitoring). In that case channels may falsely get marked as 'unusable'. To fix that, only process radar PHY errors when rada