Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Larry Finger
On 11/29/2014 12:09 PM, nick wrote: Sorry about that, next time I will be more careful. One other thing would be to change the initial part of the subject. Yes, the device is in drivers/net/wireless/, but it is much more common to not include those in patches that are sent to Linville. I woul

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 09:56, Michael Büsch wrote: > On Fri, 28 Nov 2014 22:32:30 -0500 > nick wrote: > >> I don't have hardware for this driver on me, so I didn't test it. However >> this seems to >> be correct from my reading of the code around this function and other >> locking related >> to

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Michael Büsch
On Fri, 28 Nov 2014 22:32:30 -0500 nick wrote: > I don't have hardware for this driver on me, so I didn't test it. However > this seems to > be correct from my reading of the code around this function and other locking > related > to this driver. From the current docs: > * @set_tim: Set TIM

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 04:32, nick wrote: > I don't have hardware for this driver on me, so I didn't test it. However > this seems to > be correct from my reading of the code around this function and other locking > related > to this driver. So do you say it's not executed in an atomic? >From

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-28 Thread Michael Büsch
On Fri, 28 Nov 2014 23:40:46 +0100 Rafał Miłecki wrote: > > @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw > > *hw, > > { > > struct b43_wl *wl = hw_to_b43_wl(hw); > > > > - /* FIXME: add locking */ > > + mutex_lock(&wl->mutex); > > b43_up

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-28 Thread Rafał Miłecki
On 28 November 2014 at 23:16, Nicholas Krause wrote: > Adds needed mutex lockng of wl->mutex in order to prevent issues with > separate threads executing on > the b43_update_templates function call in the function, > b43_op_beacon_set_time at the same time. For all kind of kernel documentation