Re: [PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-08-02 Thread Johannes Berg
On Wed, 2016-07-13 at 16:04 +0900, Masashi Honma wrote: > The mesh STA sends QoS frame with EOSP (end of service period) > subfiled=1 to end the MPSP(mesh peer service period). Previously, if > the frame was not acked by peer, the mesh STA did not end the MPSP. > This patch ends the MPSP even if

Re: [PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-08-02 Thread Masashi Honma
On 2016年08月02日 16:47, Johannes Berg wrote: Can you elaborate why? Does it fix anything? Please resend the patch with that (and perhaps the "subfield" typo fixed above). I see. Masashi Honma. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message

Re: [PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-07-20 Thread Bob Copeland
On Wed, Jul 20, 2016 at 04:11:33PM +0900, Masashi Honma wrote: > On 2016年07月19日 19:40, Bob Copeland wrote: > > > >OK, do we need to also clear WLAN_STA_PS_STA flag for the peer in > >ieee80211_mps_sta_status_update(), or does the node completely repeer? > > > >ISTR running into a problem where

Re: [PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-07-20 Thread Masashi Honma
On 2016年07月19日 19:40, Bob Copeland wrote: OK, do we need to also clear WLAN_STA_PS_STA flag for the peer in ieee80211_mps_sta_status_update(), or does the node completely repeer? ISTR running into a problem where rebooted peer (previously in power-save) would send popen but we would buffer the

Re: [PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-07-19 Thread Bob Copeland
On Tue, Jul 19, 2016 at 11:16:24AM +0900, Masashi Honma wrote: > This patch does not fix starting MPSP, this patch fixes ending of MPSP. > Without this patch, local peer continues MPSP even if we lost opposite peer > accidentally. OK, do we need to also clear WLAN_STA_PS_STA flag for the peer in

Re: [PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-07-18 Thread Masashi Honma
On 2016年07月13日 22:50, Bob Copeland wrote: Hmm, my recollection on this stuff is a little fuzzy. So we only get here if the peer sta is in doze state, but it shouldn't do that if we are in an MPSP. Yes. In the MPSP, local peer only transmits frame when opposite peer is in AWAKE. This patch

Re: [PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-07-13 Thread Bob Copeland
On Wed, Jul 13, 2016 at 04:04:35PM +0900, Masashi Honma wrote: > The mesh STA sends QoS frame with EOSP (end of service period) > subfiled=1 to end the MPSP(mesh peer service period). Previously, if > the frame was not acked by peer, the mesh STA did not end the MPSP. > This patch ends the MPSP

[PATCH] mac80211: End the MPSP even if EOSP frame was not received

2016-07-13 Thread Masashi Honma
The mesh STA sends QoS frame with EOSP (end of service period) subfiled=1 to end the MPSP(mesh peer service period). Previously, if the frame was not acked by peer, the mesh STA did not end the MPSP. This patch ends the MPSP even if the QoS frame was no acked. Signed-off-by: Masashi Honma