Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-04 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Wed, 2018-07-04 at 09:26 +0200, Toke Høiland-Jørgensen wrote: >> Johannes Berg writes: >> >> > I see no evidence of ath9k doing this correctly, so this might fix a >> > bug there, but I may have missed it. >> >> ath9k does check for this, in ath_tx_sched_aggr() and i

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-04 Thread Johannes Berg
On Wed, 2018-07-04 at 09:26 +0200, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > I see no evidence of ath9k doing this correctly, so this might fix a > > bug there, but I may have missed it. > > ath9k does check for this, in ath_tx_sched_aggr() and in > ath_tx_form_aggr(); it'll ch

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-04 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > I see no evidence of ath9k doing this correctly, so this might fix a > bug there, but I may have missed it. ath9k does check for this, in ath_tx_sched_aggr() and in ath_tx_form_aggr(); it'll check for the IEEE80211_TX_CTL_AMPDU flag, and stop building the current aggregat

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-04 Thread Johannes Berg
On Tue, 2018-07-03 at 21:24 -0700, Ben Greear wrote: > > ath10k appears to not do aggregation in the host, and I guess the data > > isn't split over multiple queues so the firmware has to determine/buffer > > it some other way. No idea how that would work. > > This is my current understanding of

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Ben Greear
On 07/03/2018 04:48 PM, Johannes Berg wrote: On Tue, 2018-07-03 at 13:40 -0700, Peter Oh wrote: On 07/03/2018 05:47 AM, Johannes Berg wrote: From: Johannes Berg Since (QoS) NDP frames shouldn't be put into aggregation nor are assigned real sequence numbers, etc. it's better to treat them

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Johannes Berg
On Tue, 2018-07-03 at 13:40 -0700, Peter Oh wrote: > > On 07/03/2018 05:47 AM, Johannes Berg wrote: > > From: Johannes Berg > > > > Since (QoS) NDP frames shouldn't be put into aggregation nor are > > assigned real sequence numbers, etc. it's better to treat them as > > non-data packets and not

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Peter Oh
On 07/03/2018 05:47 AM, Johannes Berg wrote: From: Johannes Berg Since (QoS) NDP frames shouldn't be put into aggregation nor are assigned real sequence numbers, etc. it's better to treat them as non-data packets and not put them on the normal TXQs, for example when building A-MPDUs they nee

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > On Tue, 2018-07-03 at 16:31 +0200, Toke Høiland-Jørgensen wrote: >> Johannes Berg writes: >> >> > From: Johannes Berg >> > >> > Since (QoS) NDP frames shouldn't be put into aggregation nor are >> > assigned real sequence numbers, etc. it's better to treat them as >> >

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Johannes Berg
On Tue, 2018-07-03 at 16:31 +0200, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > From: Johannes Berg > > > > Since (QoS) NDP frames shouldn't be put into aggregation nor are > > assigned real sequence numbers, etc. it's better to treat them as > > non-data packets and not put them

Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Toke Høiland-Jørgensen
Johannes Berg writes: > From: Johannes Berg > > Since (QoS) NDP frames shouldn't be put into aggregation nor are > assigned real sequence numbers, etc. it's better to treat them as > non-data packets and not put them on the normal TXQs, for example > when building A-MPDUs they need to be treated

[PATCH] mac80211: don't put null-data frames on the normal TXQ

2018-07-03 Thread Johannes Berg
From: Johannes Berg Since (QoS) NDP frames shouldn't be put into aggregation nor are assigned real sequence numbers, etc. it's better to treat them as non-data packets and not put them on the normal TXQs, for example when building A-MPDUs they need to be treated specially, and they are more used