Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

2017-04-27 Thread Larry Finger
On 04/27/2017 11:35 AM, Ian W MORRISON wrote: On 28 April 2017 at 01:58, Larry Finger wrote: On 04/27/2017 09:41 AM, Ian W MORRISON wrote: Here's hoping this is what you want. If not let me know what info you'd like me to provide. For this info I just built the

Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

2017-04-27 Thread Ian W MORRISON
On 28 April 2017 at 01:58, Larry Finger wrote: > On 04/27/2017 09:41 AM, Ian W MORRISON wrote: >> >> Here's hoping this is what you want. If not let me know what info you'd >> like me >> to provide. For this info I just built the r8723bs.ko module from >> linux-next >>

Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

2017-04-27 Thread Larry Finger
On 04/27/2017 09:41 AM, Ian W MORRISON wrote: Here's hoping this is what you want. If not let me know what info you'd like me to provide. For this info I just built the r8723bs.ko module from linux-next commit 6557ddf. Commit trace from 'git log --oneline --follow drivers/staging/rtl8723bs':

Fwd: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

2017-04-27 Thread Ian W MORRISON
This is a resend of earlier emails in plain text mode. Apologies for the repeat and for the initial mistake. -- Forwarded message -- From: Ian W MORRISON <ianwmorri...@gmail.com> Date: 28 April 2017 at 00:41 Subject: Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachabl

Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

2017-04-27 Thread Bastien Nocera
On Fri, 2017-04-28 at 00:00 +1000, Ian W MORRISON wrote: > With the current code from linux-next an 'insmod r8723bs.ko' > immediately results in segmentation fault. What's the error trace you get? > If I apply my 'patch' the insmod works and wifi is perfect. I didn't > try removing the kfree()

Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

2017-04-27 Thread Greg KH
On Thu, Apr 27, 2017 at 11:42:38PM +1000, Ian W MORRISON wrote: > Hi, html email is rejected by vger, also please always cc: the driverdev mailing list for staging patches. And finally, I need all patches in a format that I can apply them in (i.e. not as attachments.) Can you fix that up and

Re: [PATCH] staging: rtl8723bs: Revert ignoring_unreachable_code kfree

2017-04-27 Thread Bastien Nocera
On Thu, 2017-04-27 at 23:44 +1000, Ian W MORRISON wrote: > I tried building the RTL8723BS SDIO wifi driver which has just been > incorporated in staging for linux-next as an external module and > found that it fails with 'Segmentation Fault'. I've tracked this down > to commit