Re: [PATCH] wireless: nl80211: Broadcast CMD_NEW_INTERFACE and CMD_DEL_INTERFACE

2014-10-30 Thread Johannes Berg
On Thu, 2014-10-30 at 11:14 +0200, Tomasz Bursztyka wrote: Hi Johannes, It really bloats the*arguments* more than anything, no way to change that, say by sending the delete message before the wdev is destroyed? You mean building the nlmsg before? (sending it would be wrong if the

Re: [PATCH] wireless: nl80211: Broadcast CMD_NEW_INTERFACE and CMD_DEL_INTERFACE

2014-10-29 Thread Johannes Berg
On Mon, 2014-10-27 at 14:43 +0200, Tomasz Bursztyka wrote: Let the other listeners being notified when a new or del interface command has been issued, thus reducing later necessary request to be in sync with current context. I see no reason to list wireless: in the subject - please just use

Re: [PATCH] wireless: nl80211: Broadcast CMD_NEW_INTERFACE and CMD_DEL_INTERFACE

2014-10-29 Thread Johannes Berg
On Wed, 2014-10-29 at 16:44 +0100, Johannes Berg wrote: + nl80211_notify_iface(rdev, NULL, iftype, id, address, dev, +0, NULL, false, info-snd_portid); I'm not sure why this needs to be so late in the command, if you put it first you don't have the whole argument