Re: [PATCH 02/19] wilc: add coreconfigurator.c

2018-10-09 Thread Johannes Berg
On Tue, 2018-10-09 at 15:12 +0530, Ajay Singh wrote: > > > +static inline enum sub_frame_type get_sub_type(u8 *header) > > > +{ > > > + return ((enum sub_frame_type)(header[0] & 0xFC)); > > > +} > > > > remove, use include/linux/ieee80211.h. > > > > Did you mean to use '& IEEE80211_FCTL_STYPE'

Re: [PATCH 02/19] wilc: add coreconfigurator.c

2018-10-09 Thread Ajay Singh
Hi, Firstly, thanks alot for taking out time and reviewing our driver. I will work on review comment and submit the updated code changes. On 10/8/2018 7:46 PM, Johannes Berg wrote: >> +static inline u16 get_beacon_period(u8 *data) >> +{ >> +u16 bcn_per; >> + >> +bcn_per = data[0]; >> +

Re: [PATCH 02/19] wilc: add coreconfigurator.c

2018-10-08 Thread Johannes Berg
> +static inline u16 get_beacon_period(u8 *data) > +{ > + u16 bcn_per; > + > + bcn_per = data[0]; > + bcn_per |= (data[1] << 8); > + > + return bcn_per; > +} Remove and use get_unaligned_le16(). > +static inline u32 get_beacon_timestamp_lo(u8 *data) > +{ > + u32 time_stamp

[PATCH 02/19] wilc: add coreconfigurator.c

2018-09-26 Thread Ajay Singh
Moved '/driver/staging/wilc1000/coreconfigurator.c' to 'drivers/net/wireless/microchip/wilc/'. Signed-off-by: Ajay Singh --- .../net/wireless/microchip/wilc/coreconfigurator.c | 287 + 1 file changed, 287 insertions(+) create mode 100644