Re: [PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

2018-08-24 Thread Claudiu Beznea
On 23.08.2018 12:43, Ajay Singh wrote: > The idea was to keep private data related to 'wiphy priv' > in 'wilc_priv' struct and 'netdev priv' related data in 'wilc_vif' > struct. OK, I see, agree!

Re: [PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

2018-08-23 Thread Ajay Singh
On Thu, 23 Aug 2018 11:09:42 +0300 Claudiu Beznea wrote: > On 14.08.2018 09:49, Ajay Singh wrote: > > Move global variable 'wilc_during_ip_timer' and 'wilc_optaining_ip' > > to 'wilc_vif' structure. > > > > Rename these variables like below > > > > wilc_during_ip_timer -> during_ip_timer > > wi

Re: [PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

2018-08-23 Thread Claudiu Beznea
On 14.08.2018 09:49, Ajay Singh wrote: > Move global variable 'wilc_during_ip_timer' and 'wilc_optaining_ip' to > 'wilc_vif' structure. > > Rename these variables like below > > wilc_during_ip_timer -> during_ip_timer > wilc_optaining_ip -> obtaining_ip. Is there any reason you choose to have

[PATCH 06/24] staging: wilc1000: move during_ip_timer & wilc_optaining_ip to 'wilc_vif' struct

2018-08-13 Thread Ajay Singh
Move global variable 'wilc_during_ip_timer' and 'wilc_optaining_ip' to 'wilc_vif' structure. Rename these variables like below wilc_during_ip_timer -> during_ip_timer wilc_optaining_ip -> obtaining_ip. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 15 +++