Re: [PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

2014-10-16 Thread Fabian Frederick
On 14 October 2014 at 20:08 Bjørn Mork bj...@mork.no wrote: Joe Perches j...@perches.com writes: And does this really need to be alloc'd? Yes, it does. It is used as a transfer_buffer in usb_fill_bulk_urb() and must be suitable for DMA.  From include/linux/usb.h: /**   * struct urb -

[PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

2014-10-14 Thread Fabian Frederick
Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/net/wireless/zd1201.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c index 6f5c793..4630b26 100644 --- a/drivers/net/wireless/zd1201.c +++

Re: [PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

2014-10-14 Thread Joe Perches
On Tue, 2014-10-14 at 18:40 +0200, Fabian Frederick wrote: Signed-off-by: Fabian Frederick f...@skynet.be It might be clearer to use a structure for this 16 byte thing. There's a comment bit in the code: /* cmdreq message: u32 type u16 cmd u16 parm0 u16 parm1