Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-10-10 Thread Stanislaw Gruszka
On Wed, Oct 10, 2018 at 12:14:28AM +0200, Tom Psyborg wrote: > On 09/10/2018, Stanislaw Gruszka wrote: > > Patches 3-5 looks ok to me, I'll rebase and resend them. > > > > Thanks > > Stanislaw > > > > and what about patches 1-2 ? did you find any regression? I don't think they are correct nor

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-10-09 Thread Tom Psyborg
On 09/10/2018, Stanislaw Gruszka wrote: > Patches 3-5 looks ok to me, I'll rebase and resend them. > > Thanks > Stanislaw > and what about patches 1-2 ? did you find any regression?

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-10-09 Thread Stanislaw Gruszka
Patches 3-5 looks ok to me, I'll rebase and resend them. Thanks Stanislaw

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-09-29 Thread Tom Psyborg
On 19/09/2018, Stanislaw Gruszka wrote: > On Wed, Sep 19, 2018 at 02:47:18PM +0200, Stanislaw Gruszka wrote: >> > Can you show us how will the problem trigger on dual band devices? >> >> When you switch from some 2.4GHz channel to 5GHz channel (or vice versa) >> ->curr_band will point to old band

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-09-19 Thread Stanislaw Gruszka
On Wed, Sep 19, 2018 at 02:47:18PM +0200, Stanislaw Gruszka wrote: > > Can you show us how will the problem trigger on dual band devices? > > When you switch from some 2.4GHz channel to 5GHz channel (or vice versa) > ->curr_band will point to old band not the new one. To fix that you > have to

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-09-19 Thread Stanislaw Gruszka
On Wed, Sep 19, 2018 at 02:17:30PM +0200, Tomislav Požega wrote: > On Wed, 19 Sep 2018 13:05:41 +0200, Stanislaw Gruszka wrote: > > >Driver should provide on what channels are supported to mac80211, but > >user space decide what channel to use and that imply band 2.4GHz or > >5GHz. ->curr_band is

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-09-19 Thread Tomislav Požega
On Wed, 19 Sep 2018 13:05:41 +0200, Stanislaw Gruszka wrote: >Driver should provide on what channels are supported to mac80211, but >user space decide what channel to use and that imply band 2.4GHz or >5GHz. ->curr_band is just shortcut for band of current channel. Is set >in rt2x00lib_config()

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-09-19 Thread Stanislaw Gruszka
On Tue, Sep 18, 2018 at 04:14:33PM +0200, Tomislav Požega wrote: > On Tue, 18 Sep 2018 14:20:16 +0200, Stanislaw Gruszka wrote: > > >On Mon, Sep 17, 2018 at 06:32:51PM +0200, Tomislav Požega wrote: > >> Use curr_band instead of rf->channel among various subroutines - > >> mostly for 2.4GHz band

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-09-18 Thread Tomislav Požega
On Tue, 18 Sep 2018 14:20:16 +0200, Stanislaw Gruszka wrote: >On Mon, Sep 17, 2018 at 06:32:51PM +0200, Tomislav Požega wrote: >> Use curr_band instead of rf->channel among various subroutines - >> mostly for 2.4GHz band but in some circumstances for 5GHz band too. > >What is the reason for that

Re: [PATCH 1/5] rt2x00: set registers based on current band

2018-09-18 Thread Stanislaw Gruszka
On Mon, Sep 17, 2018 at 06:32:51PM +0200, Tomislav Požega wrote: > Use curr_band instead of rf->channel among various subroutines - > mostly for 2.4GHz band but in some circumstances for 5GHz band too. What is the reason for that change ? > @@ -9265,8 +9278,9 @@ static int

[PATCH 1/5] rt2x00: set registers based on current band

2018-09-17 Thread Tomislav Požega
Use curr_band instead of rf->channel among various subroutines - mostly for 2.4GHz band but in some circumstances for 5GHz band too. Signed-off-by: Tomislav Požega --- drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 130 +--- 1 files changed, 72 insertions(+), 58