Re: [PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings

2018-09-04 Thread Johannes Berg
On Tue, 2018-09-04 at 13:43 +0300, Luca Coelho wrote: > On Mon, 2018-09-03 at 10:56 +0200, Johannes Berg wrote: > > On Fri, 2018-08-31 at 11:31 +0300, Luca Coelho wrote: > > > > > > + cap = cfg80211_find_ext_ie(WLAN_EID_EXT_HE_CAPABILITY, ies, > > > ies_len); > > > + if (cap && cap[1] >=

Re: [PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings

2018-09-04 Thread Luca Coelho
On Mon, 2018-09-03 at 10:56 +0200, Johannes Berg wrote: > On Fri, 2018-08-31 at 11:31 +0300, Luca Coelho wrote: > > > > + cap = cfg80211_find_ext_ie(WLAN_EID_EXT_HE_CAPABILITY, ies, > > ies_len); > > + if (cap && cap[1] >= sizeof(*params->he_cap) + 1) > > + params->he_cap = (void

Re: [PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings

2018-09-03 Thread Johannes Berg
On Fri, 2018-08-31 at 11:31 +0300, Luca Coelho wrote: > > + cap = cfg80211_find_ext_ie(WLAN_EID_EXT_HE_CAPABILITY, ies, ies_len); > + if (cap && cap[1] >= sizeof(*params->he_cap) + 1) > + params->he_cap = (void *)(cap + 3); I think this should validate that the element is

[PATCH 12/28] cfg80211: add he_capabilities (ext) IE to AP settings

2018-08-31 Thread Luca Coelho
From: Shaul Triebitz Same as for HT and VHT. This helps the lower level to know whether the AP supports HE. Signed-off-by: Shaul Triebitz Signed-off-by: Luca Coelho --- include/net/cfg80211.h | 2 ++ net/wireless/nl80211.c | 3 +++ 2 files changed, 5 insertions(+) diff --git