Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

2016-01-26 Thread Bob Copeland
On Tue, Jan 19, 2016 at 09:04:32AM +0100, Henning Rogge wrote: > err = -ENXIO; > -enddel: > +enddelpath: Concur about it being better to leave this label alone, also the diff looks weird because it continues: > + mesh_paths_generation++; > + spin_unlock(&tbl->hashwlock[hash_idx]); >

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

2016-01-26 Thread Henning Rogge
On Tue, Jan 26, 2016 at 12:44 PM, Johannes Berg wrote: > On Tue, 2016-01-19 at 09:04 +0100, Henning Rogge wrote: > >> +++ b/net/mac80211/mesh_pathtbl.c >> @@ -929,12 +929,55 @@ int mesh_path_del(struct ieee80211_sub_if_data >> *sdata, const u8 *addr) >> if (mpath->sdata == sdata && >

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

2016-01-26 Thread Johannes Berg
On Tue, 2016-01-19 at 09:04 +0100, Henning Rogge wrote: > +++ b/net/mac80211/mesh_pathtbl.c > @@ -929,12 +929,55 @@ int mesh_path_del(struct ieee80211_sub_if_data > *sdata, const u8 *addr) >   if (mpath->sdata == sdata && >   ether_addr_equal(addr, mpath->dst)) { >  

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

2016-01-24 Thread Henning Rogge
On Sat, Jan 23, 2016 at 4:15 PM, Bob Copeland wrote: > On Sat, Jan 23, 2016 at 10:39:04AM +0100, Henning Rogge wrote: >> > FYI I have a patch set I'm testing which rewrites a big chunk of >> > the path table stuff. >> >> Does it include some cleanup paths for the MPP table? At the moment >> the "m

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

2016-01-23 Thread Bob Copeland
On Sat, Jan 23, 2016 at 10:39:04AM +0100, Henning Rogge wrote: > > FYI I have a patch set I'm testing which rewrites a big chunk of > > the path table stuff. > > Does it include some cleanup paths for the MPP table? At the moment > the "missing cleanup" still allows remote users to make the Linux

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

2016-01-23 Thread Henning Rogge
On Fri, Jan 22, 2016 at 9:30 PM, Bob Copeland wrote: > On Tue, Jan 19, 2016 at 09:04:32AM +0100, Henning Rogge wrote: >> Remember the last time when a mpp table entry is used for >> rx or tx and remove them after MESH_PATH_EXPIRE time. > > FYI I have a patch set I'm testing which rewrites a big ch

Re: [PATCH 2/2] mac80211: let unused MPP table entries timeout

2016-01-22 Thread Bob Copeland
On Tue, Jan 19, 2016 at 09:04:32AM +0100, Henning Rogge wrote: > Remember the last time when a mpp table entry is used for > rx or tx and remove them after MESH_PATH_EXPIRE time. FYI I have a patch set I'm testing which rewrites a big chunk of the path table stuff. As I haven't posted it yet, I g